Page MenuHomePhabricator
Feed All Stories

Dec 8 2018

Mengerian committed rABC255c0289cba0: Remove BTCForks Slack from CONTRIBUTING.md (authored by Mengerian).
Remove BTCForks Slack from CONTRIBUTING.md
Dec 8 2018, 19:16
Mengerian closed D2182: Remove BTCForks Slack from CONTRIBUTING.md.
Dec 8 2018, 19:15
teamcity added a comment to D2169: [secp256k1] Implement Schnorr signatures.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Dec 8 2018, 15:55
teamcity added a comment to D2169: [secp256k1] Implement Schnorr signatures.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Dec 8 2018, 15:47
deadalnix updated the diff for D2169: [secp256k1] Implement Schnorr signatures.

Fix mixture of tab and spaces

Dec 8 2018, 15:45
deadalnix requested changes to D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.

Back on your queue, this is apparently breaking many tests.

Dec 8 2018, 13:10
deadalnix accepted D2182: Remove BTCForks Slack from CONTRIBUTING.md.
Dec 8 2018, 13:08
teamcity added a comment to D2182: Remove BTCForks Slack from CONTRIBUTING.md.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Dec 8 2018, 03:34
teamcity added a comment to D2182: Remove BTCForks Slack from CONTRIBUTING.md.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Dec 8 2018, 03:26
Herald added a reviewer for D2182: Remove BTCForks Slack from CONTRIBUTING.md: Restricted Project.
Dec 8 2018, 03:24
deadalnix added a comment to D2169: [secp256k1] Implement Schnorr signatures.

@markblundeberg Both are necessary. one is a public API, one is a private one.

Dec 8 2018, 03:04
teamcity added a comment to D2169: [secp256k1] Implement Schnorr signatures.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Dec 8 2018, 02:00
teamcity added a comment to D2169: [secp256k1] Implement Schnorr signatures.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Dec 8 2018, 01:51
deadalnix updated the diff for D2169: [secp256k1] Implement Schnorr signatures.

reorder code so verify come before sign. This allows to change the signature code (for instance for multisig) without causing the verification code lost in the middle of the signature code.

Dec 8 2018, 01:49
teamcity added a comment to D2169: [secp256k1] Implement Schnorr signatures.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Dec 8 2018, 00:21
teamcity added a comment to D2169: [secp256k1] Implement Schnorr signatures.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Dec 8 2018, 00:11
deadalnix updated the diff for D2169: [secp256k1] Implement Schnorr signatures.

remove useless static

Dec 8 2018, 00:10

Dec 7 2018

markblundeberg added a comment to D2169: [secp256k1] Implement Schnorr signatures.

Just wondering, there are two implementations here, e.g., "secp256k1_schnorr_verify" and "secp256k1_schnorr_sig_verify". I understand one is from Amaury and one is from Pieter. What is the goal here, keep both or keep just one (and which?)?

Dec 7 2018, 23:08
Fabien requested changes to D2169: [secp256k1] Implement Schnorr signatures.
Dec 7 2018, 22:26
teamcity added a comment to D2169: [secp256k1] Implement Schnorr signatures.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Dec 7 2018, 21:57
teamcity added a comment to D2169: [secp256k1] Implement Schnorr signatures.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Dec 7 2018, 21:48
deadalnix updated the diff for D2169: [secp256k1] Implement Schnorr signatures.

Refactor the signing code.

  • Extract a function to generate a proper value for k
  • Use that fucntion in the signing code.
Dec 7 2018, 21:46
Fabien committed rABC7e1857a25075: [wallet] Remove Wallet dependencies from init.cpp (authored by John Newbery <john@johnnewbery.com>).
[wallet] Remove Wallet dependencies from init.cpp
Dec 7 2018, 21:02
Fabien closed D2181: [wallet] Remove Wallet dependencies from init.cpp.
Dec 7 2018, 21:01
deadalnix accepted D2181: [wallet] Remove Wallet dependencies from init.cpp.
Dec 7 2018, 20:59
deadalnix added inline comments to D2181: [wallet] Remove Wallet dependencies from init.cpp.
Dec 7 2018, 20:58
teamcity added a comment to D2181: [wallet] Remove Wallet dependencies from init.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Dec 7 2018, 20:54
Fabien committed rABCe90de6eb79bc: [wallet] Clarify wallet initialization / destruction interface (authored by John Newbery <john@johnnewbery.com>).
[wallet] Clarify wallet initialization / destruction interface
Dec 7 2018, 20:53
Fabien closed D2180: [wallet] Clarify wallet initialization / destruction interface.
Dec 7 2018, 20:52
Fabien committed rABC7cc44b87c1f3: Fix undefined behaviour errors due to long int overflow in Amount (authored by Fabien).
Fix undefined behaviour errors due to long int overflow in Amount
Dec 7 2018, 20:52
Fabien closed D2179: Fix undefined behaviour errors due to long int overflow in Amount.
Dec 7 2018, 20:51
teamcity added a comment to D2181: [wallet] Remove Wallet dependencies from init.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Dec 7 2018, 20:46
Fabien added inline comments to D2181: [wallet] Remove Wallet dependencies from init.cpp.
Dec 7 2018, 20:45
Fabien updated the diff for D2181: [wallet] Remove Wallet dependencies from init.cpp.

Fix comment layout

Dec 7 2018, 20:45
Mengerian committed rABC96ad4ca52218: Make links clickable in CONTRIBUTING.md (authored by Mengerian).
Make links clickable in CONTRIBUTING.md
Dec 7 2018, 20:24
Mengerian closed D2178: Make links clickable in CONTRIBUTING.md.
Dec 7 2018, 20:24
deadalnix requested changes to D2181: [wallet] Remove Wallet dependencies from init.cpp.

Some small nits, but overall it's good.

Dec 7 2018, 20:12
teamcity added a comment to D2169: [secp256k1] Implement Schnorr signatures.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Dec 7 2018, 20:08
deadalnix accepted D2180: [wallet] Clarify wallet initialization / destruction interface.
Dec 7 2018, 20:06
deadalnix accepted D2179: Fix undefined behaviour errors due to long int overflow in Amount.
Dec 7 2018, 20:00
teamcity added a comment to D2169: [secp256k1] Implement Schnorr signatures.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Dec 7 2018, 19:59
deadalnix accepted D2178: Make links clickable in CONTRIBUTING.md.
Dec 7 2018, 19:58
deadalnix updated the diff for D2169: [secp256k1] Implement Schnorr signatures.

Use R.x in part of the explaination where r is not defined

Dec 7 2018, 19:57
deadalnix added inline comments to D2169: [secp256k1] Implement Schnorr signatures.
Dec 7 2018, 19:54
teamcity added a comment to D2181: [wallet] Remove Wallet dependencies from init.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Dec 7 2018, 16:03
teamcity added a comment to D2181: [wallet] Remove Wallet dependencies from init.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Dec 7 2018, 15:55
Herald added a reviewer for D2181: [wallet] Remove Wallet dependencies from init.cpp: deadalnix.
Dec 7 2018, 15:52
teamcity added a comment to D2180: [wallet] Clarify wallet initialization / destruction interface.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Dec 7 2018, 15:25
teamcity added a comment to D2180: [wallet] Clarify wallet initialization / destruction interface.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Dec 7 2018, 15:17
Herald added a reviewer for D2180: [wallet] Clarify wallet initialization / destruction interface: deadalnix.
Dec 7 2018, 15:15
teamcity added a comment to D2179: Fix undefined behaviour errors due to long int overflow in Amount.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Dec 7 2018, 15:04
teamcity added a comment to D2179: Fix undefined behaviour errors due to long int overflow in Amount.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Dec 7 2018, 14:55
Herald added a reviewer for D2179: Fix undefined behaviour errors due to long int overflow in Amount: deadalnix.
Dec 7 2018, 14:53
teamcity added a comment to D2178: Make links clickable in CONTRIBUTING.md.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Dec 7 2018, 05:19
teamcity added a comment to D2178: Make links clickable in CONTRIBUTING.md.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Dec 7 2018, 05:10
Herald added a reviewer for D2178: Make links clickable in CONTRIBUTING.md: deadalnix.
Dec 7 2018, 05:08

Dec 6 2018

Fabien committed rABC3ceb48399f8c: Make bip68-112-113-p2p.py conform to magnetic anomaly (authored by Fabien).
Make bip68-112-113-p2p.py conform to magnetic anomaly
Dec 6 2018, 21:09
Fabien closed D2177: Make bip68-112-113-p2p.py conform to magnetic anomaly.
Dec 6 2018, 21:09
Fabien committed rABC002b8d9fbfff: Move OP_CSV from scriptSig to scriptPubKey in bip68-112-113-p2p (authored by Fabien).
Move OP_CSV from scriptSig to scriptPubKey in bip68-112-113-p2p
Dec 6 2018, 21:03
Fabien closed D2176: Move OP_CSV from scriptSig to scriptPubKey in bip68-112-113-p2p.
Dec 6 2018, 21:02
Fabien committed rABC0890051f4081: Add new test cases to abc-finalize-.py (authored by Fabien).
Add new test cases to abc-finalize-.py
Dec 6 2018, 20:29
Fabien closed D2162: Add new test cases to abc-finalize-.py.
Dec 6 2018, 20:28
teamcity added a comment to D2162: Add new test cases to abc-finalize-.py.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Dec 6 2018, 20:28
teamcity added a comment to D2162: Add new test cases to abc-finalize-.py.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Dec 6 2018, 20:19
Fabien updated the diff for D2162: Add new test cases to abc-finalize-.py.

Update assertion

Dec 6 2018, 20:17
deadalnix accepted D2162: Add new test cases to abc-finalize-.py.
Dec 6 2018, 20:03
teamcity added a comment to D2162: Add new test cases to abc-finalize-.py.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Dec 6 2018, 19:54
teamcity added a comment to D2162: Add new test cases to abc-finalize-.py.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Dec 6 2018, 19:45
Fabien updated the diff for D2162: Add new test cases to abc-finalize-.py.

Address feedbacks

Dec 6 2018, 19:43
Fabien added inline comments to D2162: Add new test cases to abc-finalize-.py.
Dec 6 2018, 19:37
deadalnix requested changes to D2162: Add new test cases to abc-finalize-.py.
Dec 6 2018, 18:06
Fabien requested changes to D1894: Added RPCCommand base classes in preparation for RPC migration.
Dec 6 2018, 18:00
Fabien added a comment to D1894: Added RPCCommand base classes in preparation for RPC migration.

One small change, looks good otherwise

Dec 6 2018, 17:59
Fabien requested changes to D2169: [secp256k1] Implement Schnorr signatures.
Dec 6 2018, 16:46
Fabien accepted D2166: Remove unused variables and/or function calls.
Dec 6 2018, 08:17
Fabien accepted D2151: Use sys.exit(...) instead of exit(...): exit(...) should not be used in programs.
Dec 6 2018, 07:32
jasonbcox accepted D2176: Move OP_CSV from scriptSig to scriptPubKey in bip68-112-113-p2p.
Dec 6 2018, 02:40
deadalnix requested changes to D1979: [qt] Multiwallet support for GUI (Core PR12610).
Dec 6 2018, 01:48
deadalnix accepted D2166: Remove unused variables and/or function calls.
Dec 6 2018, 01:42

Dec 5 2018

teamcity added a comment to D2176: Move OP_CSV from scriptSig to scriptPubKey in bip68-112-113-p2p.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Dec 5 2018, 20:20
teamcity added a comment to D2176: Move OP_CSV from scriptSig to scriptPubKey in bip68-112-113-p2p.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Dec 5 2018, 20:12
Fabien updated the diff for D2176: Move OP_CSV from scriptSig to scriptPubKey in bip68-112-113-p2p.

Update create_test_block_spend_utxos to make it less confusing regarding tip height

Dec 5 2018, 20:10
jasonbcox added inline comments to D2176: Move OP_CSV from scriptSig to scriptPubKey in bip68-112-113-p2p.
Dec 5 2018, 19:34
Fabien accepted D1979: [qt] Multiwallet support for GUI (Core PR12610).
Dec 5 2018, 16:44
schancel requested review of D2153: [qa] Make src_dir handling more robust.
Dec 5 2018, 05:29
schancel updated the summary of D2153: [qa] Make src_dir handling more robust.
Dec 5 2018, 05:28
teamcity added a comment to D2155: [qa] Switch to using multiprocessing instead of threading.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Dec 5 2018, 05:02
schancel planned changes to D2167: [qa] Switch to using a tagging model instead of 'extended'.
Dec 5 2018, 05:02
teamcity added a comment to D2155: [qa] Switch to using multiprocessing instead of threading.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Dec 5 2018, 04:53
teamcity added a comment to D1979: [qt] Multiwallet support for GUI (Core PR12610).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Dec 5 2018, 00:46
teamcity added a comment to D1979: [qt] Multiwallet support for GUI (Core PR12610).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Dec 5 2018, 00:38
jasonbcox updated the diff for D1979: [qt] Multiwallet support for GUI (Core PR12610).

Rebase

Dec 5 2018, 00:38
jasonbcox added inline comments to D1979: [qt] Multiwallet support for GUI (Core PR12610).
Dec 5 2018, 00:36
teamcity added a comment to D2150: Datadir option in linearize scripts.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Dec 5 2018, 00:34
D2166: Remove unused variables and/or function calls now requires review to proceed.
Dec 5 2018, 00:27
teamcity added a comment to D2150: Datadir option in linearize scripts.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Dec 5 2018, 00:26

Dec 4 2018

jasonbcox committed rABCc97320473fa4: Fix broken boost mirror for BSD and fix http -> https in some links (authored by rex4539).
Fix broken boost mirror for BSD and fix http -> https in some links
Dec 4 2018, 23:32
jasonbcox closed D2175: Fix broken boost mirror for BSD and fix http -> https in some links.
Dec 4 2018, 23:31
Fabien requested changes to D1979: [qt] Multiwallet support for GUI (Core PR12610).

Otherwise LGTM

Dec 4 2018, 22:05
Fabien requested changes to D2149: [Part 1] Core PR 11531: p2p-acceptblock improvements.
Dec 4 2018, 21:46