Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Feed All Stories
Feb 15 2019
Feb 15 2019
teamcity added a comment to D2556: Reset default -g -O2 flags when enable debug.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
teamcity added a comment to D2555: Update timing.json.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
teamcity added a comment to D2555: Update timing.json.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
teamcity added a comment to D2341: Enforce NULLDUMMY.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
teamcity added a comment to D2341: Enforce NULLDUMMY.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
dagurval updated the diff for D2341: Enforce NULLDUMMY.
New approach. Instead of modifing the existing nulldummy test, create a new test following deadalnix's test plan above.
markblundeberg closed T527: Add Schnorr support to OP_CHECKSIG and OP_CHECKDATASIG, a subtask of T526: Schnorr-ifying, as Resolved.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC6bb69585f326: Schnorr signature activation (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).
Schnorr signature activation
teamcity added a comment to D2483: Schnorr signature activation.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
teamcity added a comment to D2483: Schnorr signature activation.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
markblundeberg updated the diff for D2483: Schnorr signature activation.
- add extra node for doing actual ban-checking (whitelist was stopping this)
- include positive ban tests (for schnorr multisig)
- get rid of update_block
Feb 14 2019
Feb 14 2019
deadalnix requested changes to D2483: Schnorr signature activation.
Ok the general flow of the code and test looks good. However I'm not convinced that the check for banning actually checks anything. Can you remove the whitelist and then make sure to test manually that the node gets banned when sending a transaction that is actually invalid, for instance a schnorr multisig transaction?
deadalnix committed rABC0d4393e4b638: BIP32 extra test vector (authored by Pieter Wuille <pieter.wuille@gmail.com>).
BIP32 extra test vector
Format BIP32 test cases manually
teamcity added a comment to D2554: CONTRIBUTING.md : recommend ccache.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Yeah that was hideous before ... linters aren't always right. :-D
markblundeberg added a comment to D2554: CONTRIBUTING.md : recommend ccache.
Not 100% sure about the placement of this, but I think it does deserve to go *somewhere*.
teamcity added a comment to D2554: CONTRIBUTING.md : recommend ccache.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
teamcity added a comment to D2553: BIP32 extra test vector.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
teamcity added a comment to D2542: Format BIP32 test cases manually.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
teamcity added a comment to D2542: Format BIP32 test cases manually.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
teamcity added a comment to D2553: BIP32 extra test vector.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
teamcity added a comment to D2542: Format BIP32 test cases manually.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
deadalnix updated the diff for D2542: Format BIP32 test cases manually.
Remove test cases added by mistake
teamcity added a comment to D2542: Format BIP32 test cases manually.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
deadalnix committed rABCdaec76faa3e7: Check that key length is correct when deserializing CExtKey (authored by deadalnix).
Check that key length is correct when deserializing CExtKey
Various nit in pubkey.h
Various nits in key.{h|cpp}
jasonbcox committed rABC4a2ad75ca9c4: qt: Poll ShutdownTimer after init is done (authored by MarcoFalke <falke.marco@gmail.com>).
qt: Poll ShutdownTimer after init is done
teamcity added a comment to D2552: Check that key length is correct when deserializing CExtKey.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
teamcity added a comment to D2551: Various nits in key.{h|cpp}.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
teamcity added a comment to D2552: Check that key length is correct when deserializing CExtKey.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Herald added a reviewer for D2552: Check that key length is correct when deserializing CExtKey: Restricted Project.
teamcity added a comment to D2551: Various nits in key.{h|cpp}.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
teamcity added a comment to D2550: Various nit in pubkey.h.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
teamcity added a comment to D2550: Various nit in pubkey.h.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
teamcity added a comment to D2550: Various nit in pubkey.h.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
teamcity added a comment to D2550: Various nit in pubkey.h.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
sickpig committed rABC721e17485bde: Use the correct icon name in bitcoin-qt.desktop (authored by sickpig).
Use the correct icon name in bitcoin-qt.desktop
deadalnix added inline comments to D2534: [schnorr] Add features to combine public keys in order to do musig..
teamcity added a comment to D2549: Use the correct icon name in bitcoin-qt.desktop.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
teamcity added a comment to D2549: Use the correct icon name in bitcoin-qt.desktop.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
A nice simplification and improvement. Presumably there is no chance that StopHTTPServer will be called during StartHTTPServer execution, as they are only ever called from a particular thread?
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC011e6fe43a59: fix abc-parkedchain timeouts (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).
fix abc-parkedchain timeouts
teamcity added a comment to D2548: fix abc-parkedchain timeouts.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
teamcity added a comment to D2548: fix abc-parkedchain timeouts.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
markblundeberg updated the diff for D2548: fix abc-parkedchain timeouts.
use wait_for_tip instead of sync_blocks
jasonbcox requested changes to D2548: fix abc-parkedchain timeouts.
teamcity added a comment to D2548: fix abc-parkedchain timeouts.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
markblundeberg updated the summary of D2548: fix abc-parkedchain timeouts.
markblundeberg added a comment to D2548: fix abc-parkedchain timeouts.
Check out the debug logs.
Mengerian accepted D2461: Drop support for OpenBSD.
Given that you have asked around, and no-one seems to indicate usage of Bitcoin ABC on OpenBSD, I think it's fine to drop support for it.
teamcity added a comment to D2548: fix abc-parkedchain timeouts.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
teamcity added a comment to D2483: Schnorr signature activation.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
markblundeberg updated the test plan for D2483: Schnorr signature activation.
teamcity added a comment to D2483: Schnorr signature activation.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
markblundeberg updated the diff for D2483: Schnorr signature activation.
various:
teamcity added a comment to D2547: Merge #12366: http: Join worker threads before deleting work queue.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Fix regression in getrawtransaction
jasonbcox added a comment to D2499: refactor TxToJSON() and ScriptPubKeyToJSON().
For posterity, this backport was fubar'd. See D2546 for details.
teamcity added a comment to D2547: Merge #12366: http: Join worker threads before deleting work queue.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Herald added a reviewer for D2547: Merge #12366: http: Join worker threads before deleting work queue: Restricted Project.
You may want to report that the backport was fubared, so there is no need to do excavation to figure out what happened.
jasonbcox added a comment to D2544: Improve shutdown process.
@dagurval points out, maybe we want to go straight for https://github.com/bitcoin/bitcoin/pull/14670 ... sounds like this exits uncleanly in some cases?