Looks good to me.

Values check out against my local node on main net.

I checked the paramaters on my local node, they check out.

It looks fine to me.

Good idea to make sure the testnet block is common to regular testnet, as well as the upgrade testnet.

Good idea to add this

Hey @dagurval It seems this is now too late to include for "Great Wall" activation.

Given that you have asked around, and no-one seems to indicate usage of Bitcoin ABC on OpenBSD, I think it's fine to drop support for it.

Yeah, @dagurval you just need to rebase for the release notes, and then it should be ready to land

Looks fine to me.

Looks good to me

In D2483#57845, @markblundeberg wrote:

switch to generic flag-based activation that applies for all upgrades.

Sure, "signature scripts" works

Good catch! I indicated a minor suggested rewording

In D2487#57041, @markblundeberg wrote:

In D2487#57038, @Mengerian wrote:

Typo in title:
implemenation -> implementation

Wow took me two tries to fix that...

Typo in title:
implemenation -> implementation

Can the title of this be changed? I find it a bit difficult to parse.

OK, I put in the template to implement CheckTransactionSignatureEncoding and CheckTransactionECDSASignatureEncoding

Use template for CheckTransactionSignatureEncoding and
CheckTransactionECDSASignatureEncoding

rename IsValidECDSASignatureEncoding to IsValidDERSignatureEncoding

I combined the changes, this is now superseded by D2477

Combine D2478 in this Diff.
it's less confusing this way

I think I will combine D2478 with this Diff.

@markblundeberg Have a look at D2478. Does it make more sense with that one added after?

simplify refactor

Yup, I can confirm the it works for me also, after enabling Coin Control as Mark suggested.

Shouldn't we go straight to 0.19.0?

Checked the parameters on my 0.18.6 node, looks good.

@Fabien Yeah, that's strange, I have the same issue.

I double-checked the timestamps and everything looks good to me.

@markblundeberg Yeah, I think that's a bit too specific, as it assumes what system the person is running, and people might have all kinds of different configurations. We don't want to get into system configuration management in these docs.

Make link https

Question, regarding this To Do item: "test op_checkmultisig still accepts 64 byte ECDSA"

Remove some commands. The commands that I had added to generate seed
lists were too specific and may just add confusion if the lists
come from a long-running DNS seeder such as seed.bitcoinabc.org

edit title

Remove relative paths

Simplify wording further

Remove mention of NODE_BITCOIN_CASH, which should be deprecated
and is no longer relevant.

fix typo

Yes, good idea to add this

Move step to after release

rebase