Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABC622df4ff0609: Add virtualsize computation to mempool (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>).

Add virtualsize computation to mempool

Jan 18 2020, 07:16

Mark Lundeberg <markblundeberg@users.noreply.github.com> closed D4906: Add virtualsize computation to mempool.

Jan 18 2020, 07:15

Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABC387e98cfdff9: track descendant sigops count in mempool (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>).

track descendant sigops count in mempool

Jan 18 2020, 07:13

Mark Lundeberg <markblundeberg@users.noreply.github.com> closed D4905: track descendant sigops count in mempool.

Jan 18 2020, 07:13

Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABC638e4857a2c4: tweak auto-unparking message (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>).

tweak auto-unparking message

Jan 18 2020, 05:06

Mark Lundeberg <markblundeberg@users.noreply.github.com> closed D4937: tweak auto-unparking message.

Jan 18 2020, 05:06

Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABCbaa19d9fb063: [validation.cpp] parking-related comment tweaks (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>).

[validation.cpp] parking-related comment tweaks

Jan 18 2020, 05:05

Mark Lundeberg <markblundeberg@users.noreply.github.com> closed D4935: [validation.cpp] parking-related comment tweaks.

Jan 18 2020, 05:04

teamcity added a comment to D4834: add sigChecks value to script cache.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 18 2020, 05:03

markblundeberg abandoned D4897: Add virtualsize tracking to mempool.

Jan 18 2020, 04:50

teamcity added a comment to D4834: add sigChecks value to script cache.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 18 2020, 04:49

markblundeberg updated the diff for D4834: add sigChecks value to script cache.

rebase ; comments ; tweak to not use uint256

Jan 18 2020, 04:49

markblundeberg added inline comments to D4834: add sigChecks value to script cache.

Jan 18 2020, 04:48

markblundeberg abandoned D4716: do not accept anything into mempool before UAHF has activated.

Fabien added some comments to this effect in D4642.

Jan 18 2020, 04:38

markblundeberg abandoned D4902: change default -blockmintxfee to 0.

Going to drop this from my queue for now, but I still think it's worth considering in future.

Jan 18 2020, 04:37

markblundeberg added inline comments to D5013: CheckBlockIndex before unlocking cs_main.

Jan 18 2020, 04:33

markblundeberg requested review of D4941: track ScriptExecutionMetrics in CheckInputs.

Jan 18 2020, 04:05

markblundeberg added a comment to D5013: CheckBlockIndex before unlocking cs_main.

The remaining inconsistencies are probably related to this fix:

Jan 18 2020, 03:43

markblundeberg requested changes to D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.

Jan 18 2020, 03:32

markblundeberg added a comment to D5013: CheckBlockIndex before unlocking cs_main.

OK, just a few failures remaining now, so it's better with that parent but something still wrong...

Jan 18 2020, 03:26

Harbormaster failed remote builds in B9046: Diff 15640 for D5013: CheckBlockIndex before unlocking cs_main!

Jan 18 2020, 03:25

teamcity added a comment to D5013: CheckBlockIndex before unlocking cs_main.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Jan 18 2020, 03:25

markblundeberg updated the summary of D5013: CheckBlockIndex before unlocking cs_main.

Jan 18 2020, 03:23

teamcity added a comment to D5013: CheckBlockIndex before unlocking cs_main.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 18 2020, 03:22

markblundeberg updated the diff for D5013: CheckBlockIndex before unlocking cs_main.

rebase onto D4929

Jan 18 2020, 03:22

markblundeberg added a comment to D5013: CheckBlockIndex before unlocking cs_main.

Above failures on master, now will try rebased.

Jan 18 2020, 03:12

teamcity added a comment to D5013: CheckBlockIndex before unlocking cs_main.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Jan 18 2020, 03:11

Harbormaster failed remote builds in B9045: Diff 15639 for D5013: CheckBlockIndex before unlocking cs_main!

Jan 18 2020, 03:11

markblundeberg updated the summary of D5013: CheckBlockIndex before unlocking cs_main.

Jan 18 2020, 03:06

teamcity added a comment to D5013: CheckBlockIndex before unlocking cs_main.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 18 2020, 03:06

markblundeberg created D5013: CheckBlockIndex before unlocking cs_main.

Jan 18 2020, 03:06

markblundeberg added a comment to D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.

From what I can tell, this change is actually a bugfix and should have really been combined with D4802. Please get this landed soon.

Jan 18 2020, 02:47

teamcity added a comment to D5012: Merge #14494: Error if # is used in rpcpassword in conf.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 18 2020, 01:20

teamcity added a comment to D5012: Merge #14494: Error if # is used in rpcpassword in conf.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 18 2020, 01:15

jasonbcox created D5012: Merge #14494: Error if # is used in rpcpassword in conf.

Jan 18 2020, 01:15

teamcity added a comment to D5010: Merge #9963: util: Properly handle errors during log message formatting.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 18 2020, 01:05

teamcity added a comment to D5010: Merge #9963: util: Properly handle errors during log message formatting.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 18 2020, 01:03

teamcity added a comment to D5010: Merge #9963: util: Properly handle errors during log message formatting.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 18 2020, 00:58

nakihito updated the diff for D5010: Merge #9963: util: Properly handle errors during log message formatting.

Fixed comment formatting.

Jan 18 2020, 00:58

teamcity added a comment to D5011: Merge #14413: tests: Allow closed rpc handler in assert_start_raises_init_error.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 18 2020, 00:56

teamcity added a comment to D5011: Merge #14413: tests: Allow closed rpc handler in assert_start_raises_init_error.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 18 2020, 00:51

jasonbcox created D5011: Merge #14413: tests: Allow closed rpc handler in assert_start_raises_init_error.

Jan 18 2020, 00:51

teamcity added a comment to D5009: Merge #14105: util: Report parse errors in configuration file.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 18 2020, 00:47

teamcity added a comment to D5010: Merge #9963: util: Properly handle errors during log message formatting.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 18 2020, 00:46

nakihito created D5010: Merge #9963: util: Properly handle errors during log message formatting.

Jan 18 2020, 00:46

teamcity added a comment to D5009: Merge #14105: util: Report parse errors in configuration file.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 18 2020, 00:40

jasonbcox created D5009: Merge #14105: util: Report parse errors in configuration file.

Jan 18 2020, 00:40

Jan 17 2020

teamcity added a comment to D4807: Add instructions for verifying download integrity against release signer keys.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 23:48

teamcity added a comment to D4807: Add instructions for verifying download integrity against release signer keys.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 23:31

jasonbcox updated the diff for D4807: Add instructions for verifying download integrity against release signer keys.

Fixes according to feedback:

Merge common lines into a single step
Fix file verification step when the working directory isn't clean

Jan 17 2020, 23:31

teamcity added a comment to D5004: Merge #14146: wallet: Remove trailing separators from -walletdir arg.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 23:13

teamcity added a comment to D5004: Merge #14146: wallet: Remove trailing separators from -walletdir arg.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 22:53

jasonbcox updated the diff for D5004: Merge #14146: wallet: Remove trailing separators from -walletdir arg.

Rebase on D5008

Jan 17 2020, 22:46

jasonbcox added inline comments to D5004: Merge #14146: wallet: Remove trailing separators from -walletdir arg.

Jan 17 2020, 22:46

Fabien committed rABCabfdad009c9d: [CMAKE] Run wallet tests as part of the check-bitcoin target (authored by Fabien).

[CMAKE] Run wallet tests as part of the check-bitcoin target

Jan 17 2020, 22:37

Fabien closed D5008: [CMAKE] Run wallet tests as part of the check-bitcoin target.

Jan 17 2020, 22:37

Fabien added a comment to D5008: [CMAKE] Run wallet tests as part of the check-bitcoin target.

My bad, thanks @deadalnix for finding this: https://reviews.bitcoinabc.org/D5004#inline-30712.

Jan 17 2020, 22:35

teamcity added a comment to D5008: [CMAKE] Run wallet tests as part of the check-bitcoin target.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 22:34

jasonbcox committed rABC7f1f8a59cc69: Merge #13862: utils: drop boost::interprocess::file_lock (authored by Wladimir J. van der Laan <laanwj@gmail.com>).

Merge #13862: utils: drop boost::interprocess::file_lock

Jan 17 2020, 22:34

jasonbcox closed D5005: Merge #13862: utils: drop boost::interprocess::file_lock.

Jan 17 2020, 22:34

jasonbcox added inline comments to D5004: Merge #14146: wallet: Remove trailing separators from -walletdir arg.

Jan 17 2020, 22:33

jasonbcox accepted D5008: [CMAKE] Run wallet tests as part of the check-bitcoin target.

Beat me to it. For posterity, this was missed in D4698

Jan 17 2020, 22:32

teamcity added a comment to D5008: [CMAKE] Run wallet tests as part of the check-bitcoin target.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 22:30

Fabien created D5008: [CMAKE] Run wallet tests as part of the check-bitcoin target.

Jan 17 2020, 22:29

teamcity added a comment to D5005: Merge #13862: utils: drop boost::interprocess::file_lock.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 22:23

deadalnix accepted D5005: Merge #13862: utils: drop boost::interprocess::file_lock.

Jan 17 2020, 22:10

deadalnix requested changes to D5004: Merge #14146: wallet: Remove trailing separators from -walletdir arg.

Jan 17 2020, 22:09

teamcity added a comment to D5005: Merge #13862: utils: drop boost::interprocess::file_lock.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 22:06

jasonbcox updated the diff for D5005: Merge #13862: utils: drop boost::interprocess::file_lock.

Fix sloppy includes merge

Jan 17 2020, 22:05

jasonbcox accepted D4961: [CMAKE] Add a check_linker_flag function.

Jan 17 2020, 22:05

jasonbcox lowered the priority of T692: Fix apptests from Unbreak Now! to Low.

Jan 17 2020, 21:51

deadalnix requested changes to D5005: Merge #13862: utils: drop boost::interprocess::file_lock.

Jan 17 2020, 21:51

Fabien committed rABC0851d55b0ea3: [CMAKE] Fix getentropy detection on OSX (authored by Fabien).

[CMAKE] Fix getentropy detection on OSX

Jan 17 2020, 21:48

Fabien closed D5007: [CMAKE] Fix getentropy detection on OSX.

Jan 17 2020, 21:48

teamcity added a comment to D5007: [CMAKE] Fix getentropy detection on OSX.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing passed.

Jan 17 2020, 21:47

CCulianu added a comment to T285: daemon is deprecated on MAC OSX.

FWIW -- my two cents here is that I sort of doubt they will actually remove this... since it's been a BSD function for ~30 years. They just don't want people using daemon() or anything that forks because their Apple libs break when you fork. :/

Jan 17 2020, 21:45 · Bootcamp

jasonbcox accepted D5007: [CMAKE] Fix getentropy detection on OSX.

Jan 17 2020, 21:45

teamcity added a comment to D5007: [CMAKE] Fix getentropy detection on OSX.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 21:44

teamcity added a comment to D5007: [CMAKE] Fix getentropy detection on OSX.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing started.

Jan 17 2020, 21:43

deadalnix accepted D5007: [CMAKE] Fix getentropy detection on OSX.

Jan 17 2020, 21:40

teamcity added a comment to D5007: [CMAKE] Fix getentropy detection on OSX.