markblundeberg retitled D5019: CreateNewBlock: insert entries into block slightly earlier so that correct size is logged from CreateNewBlock: insert entries into block slightly earlier to CreateNewBlock: insert entries into block slightly earlier so that correct size is logged.

Jan 19 2020, 05:57

teamcity added a comment to D5022: CreateNewBlock: small tweaks.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 19 2020, 05:55

markblundeberg created D5022: CreateNewBlock: small tweaks.

Jan 19 2020, 05:55

teamcity added a comment to D5019: CreateNewBlock: insert entries into block slightly earlier so that correct size is logged.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 19 2020, 04:47

teamcity added a comment to D5019: CreateNewBlock: insert entries into block slightly earlier so that correct size is logged.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 19 2020, 04:42

markblundeberg updated the diff for D5019: CreateNewBlock: insert entries into block slightly earlier so that correct size is logged.

simplify changes to smallest possible (move-only on the for loop, and an extra update)

Jan 19 2020, 04:42

markblundeberg added inline comments to D5019: CreateNewBlock: insert entries into block slightly earlier so that correct size is logged.

Jan 19 2020, 04:37

deadalnix requested changes to D5019: CreateNewBlock: insert entries into block slightly earlier so that correct size is logged.

Requesting changes, but it's more like questions.

Jan 19 2020, 03:51

markblundeberg added a comment to D5019: CreateNewBlock: insert entries into block slightly earlier so that correct size is logged.

(For reference, this mechanism was introduced in D2047 which was basically a good fix.)

Jan 19 2020, 03:35

teamcity added a comment to D5017: [abc-wallet-standardness] do test the signing error code.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 19 2020, 02:36

teamcity added a comment to D5018: add input sigchecks limit to STANDARD_SCRIPT_VERIFY_FLAGS (but not mempool flags).

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 19 2020, 02:33

teamcity added a comment to D5018: add input sigchecks limit to STANDARD_SCRIPT_VERIFY_FLAGS (but not mempool flags).

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 19 2020, 02:28

teamcity added a comment to D5017: [abc-wallet-standardness] do test the signing error code.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 19 2020, 02:24

markblundeberg updated the diff for D5018: add input sigchecks limit to STANDARD_SCRIPT_VERIFY_FLAGS (but not mempool flags).

rebase

Jan 19 2020, 02:18

markblundeberg updated the diff for D5017: [abc-wallet-standardness] do test the signing error code.

rebase

Jan 19 2020, 02:17

markblundeberg planned changes to D5013: CheckBlockIndex before unlocking cs_main.

Jan 19 2020, 02:15

Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABC3e255713bfa6: simplify ATMP standard flag computation [2/2] - move computation to another… (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>).

simplify ATMP standard flag computation [2/2] - move computation to another…

Jan 19 2020, 02:12

Mark Lundeberg <markblundeberg@users.noreply.github.com> closed D5015: simplify ATMP standard flag computation [2/2] - move computation to another function.

Jan 19 2020, 02:12

Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABC2d1c6597e5ee: simplify ATMP standard flag computation [1/2] - remove CHECKDATASIG_SIGOPS (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>).

simplify ATMP standard flag computation [1/2] - remove CHECKDATASIG_SIGOPS

Jan 19 2020, 02:10

Mark Lundeberg <markblundeberg@users.noreply.github.com> closed D5014: simplify ATMP standard flag computation [1/2] - remove CHECKDATASIG_SIGOPS.

Jan 19 2020, 02:09

markblundeberg added inline comments to D4834: add sigChecks value to script cache.

Jan 19 2020, 00:43

Jan 18 2020

deadalnix requested changes to D4834: add sigChecks value to script cache.

From what I gather, it is fairly obvious that you actually don't want a but are trying to make things work as a pod. The problem when you distribute responsibilities is that you always end up with something inconsistent down the road or a huge pile of spaghetti because various pieces of code needs to be kept in sync.

Jan 18 2020, 23:51

deadalnix accepted D5010: Merge #9963: util: Properly handle errors during log message formatting.

Jan 18 2020, 23:39

deadalnix accepted D5015: simplify ATMP standard flag computation [2/2] - move computation to another function.

Jan 18 2020, 23:33

deadalnix accepted D5014: simplify ATMP standard flag computation [1/2] - remove CHECKDATASIG_SIGOPS.

Jan 18 2020, 23:30

teamcity added a comment to D5021: [cmake] Do not generate git_ignored_files.txt.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 18 2020, 23:27

teamcity added a comment to D5021: [cmake] Do not generate git_ignored_files.txt.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 18 2020, 23:22

deadalnix created D5021: [cmake] Do not generate git_ignored_files.txt.

Jan 18 2020, 23:22

teamcity added a comment to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 18 2020, 19:15

teamcity added a comment to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 18 2020, 19:07

tobias_ruck updated the diff for D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Fixed the, and I quote, quibble, which has been pointed out by @markblundeberg

Jan 18 2020, 19:07

deadalnix committed rABCfaf086373ffc: [cmake] Only set the native build marker once (authored by deadalnix).

[cmake] Only set the native build marker once

Jan 18 2020, 18:07

deadalnix closed D5020: [cmake] Only set the native build marker once.

Jan 18 2020, 18:07

jasonbcox accepted D5020: [cmake] Only set the native build marker once.

Jan 18 2020, 18:06

teamcity added a comment to D5020: [cmake] Only set the native build marker once.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 18 2020, 17:53

teamcity added a comment to D5020: [cmake] Only set the native build marker once.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 18 2020, 17:48

deadalnix created D5020: [cmake] Only set the native build marker once.

Jan 18 2020, 17:48

markblundeberg added inline comments to D5019: CreateNewBlock: insert entries into block slightly earlier so that correct size is logged.

Jan 18 2020, 17:17

teamcity added a comment to D5019: CreateNewBlock: insert entries into block slightly earlier so that correct size is logged.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 18 2020, 17:16

teamcity added a comment to D5019: CreateNewBlock: insert entries into block slightly earlier so that correct size is logged.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 18 2020, 17:12

markblundeberg created D5019: CreateNewBlock: insert entries into block slightly earlier so that correct size is logged.

Jan 18 2020, 17:12

teamcity added a comment to D4917: more optimal virtualsize accounting with increments.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 18 2020, 16:34

markblundeberg added a comment to D4903: Use virtualsize for mining/mempool priority.

A note for curiosity: I tried to make the same kind of test using fundrawtransaction / signrawtransactionwithwallet RPC, however it took about 100 ms per tx. So with 500 txes, that made a 50 second long test, yuck! This test runs in 2 seconds.

Jan 18 2020, 16:31

teamcity added a comment to D4903: Use virtualsize for mining/mempool priority.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 18 2020, 16:29

teamcity added a comment to D4917: more optimal virtualsize accounting with increments.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 18 2020, 16:29

markblundeberg updated the diff for D4917: more optimal virtualsize accounting with increments.

simplify API ; rebase

Jan 18 2020, 16:29

markblundeberg added inline comments to D4917: more optimal virtualsize accounting with increments.

Jan 18 2020, 16:26