Jan 19 2020
A few minor improvement, but it's getting there. You should consider starting to work on activation logic and tests.
Requesting change, but most of it are actually questions. The only thing I'm really suspicious of is the block template thing.
Rebase on top of D5024 in order for the gitian build to succeed.
simplify changes to smallest possible (move-only on the for loop, and an extra update)
Requesting changes, but it's more like questions.
(For reference, this mechanism was introduced in D2047 which was basically a good fix.)
Jan 18 2020
From what I gather, it is fairly obvious that you actually don't want a but are trying to make things work as a pod. The problem when you distribute responsibilities is that you always end up with something inconsistent down the road or a huge pile of spaghetti because various pieces of code needs to be kept in sync.
Fixed the, and I quote, quibble, which has been pointed out by @markblundeberg
A note for curiosity: I tried to make the same kind of test using fundrawtransaction / signrawtransactionwithwallet RPC, however it took about 100 ms per tx. So with 500 txes, that made a 50 second long test, yuck! This test runs in 2 seconds.
simplify API ; rebase