Feed Advanced Search

Advanced Search
Use Results
Edit Query
Hide Query

Apr 28 2020

jasonbcox requested review of D5808: [land-bot] Bail early if there's nothing to land.

Apr 28 2020, 21:16

jasonbcox committed rABCc9574f16e779: Bump tool_wallet timeout (authored by jasonbcox).

Bump tool_wallet timeout

Apr 28 2020, 16:13

jasonbcox closed D5865: Bump tool_wallet timeout.

Apr 28 2020, 16:13

jasonbcox created D5865: Bump tool_wallet timeout.

Apr 28 2020, 00:06

jasonbcox accepted D5861: Reorder various univalue include orders.

Apr 28 2020, 00:02

jasonbcox committed rABC6f2ca9ddb3b4: Make sure we're using the same version of clang tools for everything (authored by jasonbcox).

Make sure we're using the same version of clang tools for everything

Apr 28 2020, 00:01

jasonbcox closed D5836: Make sure we're using the same version of clang tools for everything.

Apr 28 2020, 00:00

Apr 27 2020

jasonbcox committed rABCa2715122edec: Merge #15947: Install bitcoin-wallet manpage (authored by Wladimir J. van der Laan <laanwj@gmail.com>).

Merge #15947: Install bitcoin-wallet manpage

Apr 27 2020, 22:32

jasonbcox closed D5856: Merge #15947: Install bitcoin-wallet manpage.

Apr 27 2020, 22:32

jasonbcox committed rABCeef109b8e565: Merge #15354: doc: Add missing bitcoin-wallet tool manpages (authored by jasonbcox).

Merge #15354: doc: Add missing bitcoin-wallet tool manpages

Apr 27 2020, 22:31

jasonbcox closed D5855: Merge #15354: doc: Add missing bitcoin-wallet tool manpages.

Apr 27 2020, 22:31

jasonbcox accepted D5859: [CI] Cross build and run tests for Linux 64 bits.

Apr 27 2020, 21:23

jasonbcox accepted D5837: [CI] Cross build for OSX.

Apr 27 2020, 18:44

jasonbcox requested changes to D5837: [CI] Cross build for OSX.

Apr 27 2020, 18:38

jasonbcox committed rABC151039ebdaa1: Remove unnecessary --force-yes from installation script (authored by jasonbcox).

Remove unnecessary --force-yes from installation script

Apr 27 2020, 16:50

jasonbcox closed D5835: Remove unnecessary --force-yes from installation script.

Apr 27 2020, 16:50

jasonbcox created D5856: Merge #15947: Install bitcoin-wallet manpage.

Apr 27 2020, 16:50

jasonbcox created D5855: Merge #15354: doc: Add missing bitcoin-wallet tool manpages.

Apr 27 2020, 16:20

jasonbcox accepted D5853: [CI] Cross build for Linux ARM and AArch64.

Apr 27 2020, 15:49

jasonbcox updated the diff for D5836: Make sure we're using the same version of clang tools for everything.

Rebase

Apr 27 2020, 15:47

jasonbcox updated the diff for D5835: Remove unnecessary --force-yes from installation script.

Rebase

Apr 27 2020, 15:45

Apr 25 2020

jasonbcox updated the test plan for D5836: Make sure we're using the same version of clang tools for everything.

Apr 25 2020, 00:23

jasonbcox requested review of D5836: Make sure we're using the same version of clang tools for everything.

Apr 25 2020, 00:22

jasonbcox planned changes to D5836: Make sure we're using the same version of clang tools for everything.

Apr 25 2020, 00:08

jasonbcox updated the diff for D5836: Make sure we're using the same version of clang tools for everything.

Add missing clang++

Apr 25 2020, 00:08

jasonbcox planned changes to D5836: Make sure we're using the same version of clang tools for everything.

Apr 25 2020, 00:05

jasonbcox updated the diff for D5836: Make sure we're using the same version of clang tools for everything.

Simplify

Apr 25 2020, 00:05

jasonbcox planned changes to D5836: Make sure we're using the same version of clang tools for everything.

Apr 25 2020, 00:01

jasonbcox updated the diff for D5836: Make sure we're using the same version of clang tools for everything.

Fix alternatives

Apr 25 2020, 00:01

Apr 24 2020

jasonbcox requested review of D5835: Remove unnecessary --force-yes from installation script.

Apr 24 2020, 23:59

jasonbcox planned changes to D5836: Make sure we're using the same version of clang tools for everything.

Apr 24 2020, 23:47

jasonbcox created D5836: Make sure we're using the same version of clang tools for everything.

Apr 24 2020, 23:47

jasonbcox updated the summary of D5835: Remove unnecessary --force-yes from installation script.

Apr 24 2020, 23:43

jasonbcox planned changes to D5835: Remove unnecessary --force-yes from installation script.

Apr 24 2020, 23:42

jasonbcox created D5835: Remove unnecessary --force-yes from installation script.

Apr 24 2020, 23:42

jasonbcox accepted D5825: scripted-diff: Replace CCriticalSection with RecursiveMutex.

Apr 24 2020, 23:33

jasonbcox accepted D5832: [CI] Build for windows 64 and run some unit tests.

Apr 24 2020, 23:28

jasonbcox requested changes to D5834: Pass more informaion from the seeder DB to CSeederNode.

Apr 24 2020, 23:23

jasonbcox requested changes to D5833: Have the seeder database track and relay additional information.

The title and summary are incredibly vague. Why is this information useful? What is the goal here?

Apr 24 2020, 23:23

jasonbcox added inline comments to D5832: [CI] Build for windows 64 and run some unit tests.

Apr 24 2020, 23:18

jasonbcox requested changes to D5832: [CI] Build for windows 64 and run some unit tests.

Apr 24 2020, 23:16

jasonbcox committed rABCbffbe939ca08: Merge #15069: test: Fix rpc_net.py "pong" race condition (authored by MarcoFalke <falke.marco@gmail.com>).

Merge #15069: test: Fix rpc_net.py "pong" race condition

Apr 24 2020, 22:33

jasonbcox closed D5829: Merge #15069: test: Fix rpc_net.py "pong" race condition.

Apr 24 2020, 22:33

jasonbcox committed rABC64c0efc5696c: Merge #15013: test: Avoid race in p2p_timeouts (authored by MarcoFalke <falke.marco@gmail.com>).

Merge #15013: test: Avoid race in p2p_timeouts

Apr 24 2020, 22:31

jasonbcox closed D5828: Merge #15013: test: Avoid race in p2p_timeouts.

Apr 24 2020, 22:31

jasonbcox committed rABC94cd1f0f2b55: Merge #14733: P2P: Make peer timeout configurable, speed up very slow test and… (authored by Wladimir J. van der Laan <laanwj@gmail.com>).

Merge #14733: P2P: Make peer timeout configurable, speed up very slow test and…

Apr 24 2020, 20:55

jasonbcox closed D5827: Merge #14733: P2P: Make peer timeout configurable, speed up very slow test and ensure correct code path tested..

Apr 24 2020, 20:55

jasonbcox accepted D5830: Rename IsGood() to IsReliable().

Apr 24 2020, 19:31

jasonbcox created D5829: Merge #15069: test: Fix rpc_net.py "pong" race condition.

Apr 24 2020, 18:07

jasonbcox created D5828: Merge #15013: test: Avoid race in p2p_timeouts.

Apr 24 2020, 17:59

jasonbcox created D5827: Merge #14733: P2P: Make peer timeout configurable, speed up very slow test and ensure correct code path tested..

Apr 24 2020, 17:42

jasonbcox requested changes to D5686: Implement banning logic for Seeder for nodes on the wrong chain.

We discussed unit tests. Where are they?

Apr 24 2020, 17:00

jasonbcox committed rABC18d9600f4e5d: Merge #14456: test: forward timeouts properly in send_blocks_and_test (authored by MarcoFalke <falke.marco@gmail.com>).

Merge #14456: test: forward timeouts properly in send_blocks_and_test

Apr 24 2020, 15:24

jasonbcox closed D5821: Merge #14456: test: forward timeouts properly in send_blocks_and_test.

Apr 24 2020, 15:23

jasonbcox created D5821: Merge #14456: test: forward timeouts properly in send_blocks_and_test.

Apr 24 2020, 00:45

Apr 23 2020

jasonbcox requested changes to D5819: [backport#15288] Remove use of IsRBFOptIn in wallet code.

Why add an include if it's not needed?

Apr 23 2020, 21:12

jasonbcox committed rABC474bab14434f: Finish up release notes (authored by jasonbcox).

Finish up release notes

Apr 23 2020, 18:23

jasonbcox closed D5817: Finish up release notes.

Apr 23 2020, 18:23

jasonbcox accepted D5380: [seeder] Require good seeds to have latest checkpoint.

Apr 23 2020, 18:22

jasonbcox created D5817: Finish up release notes.

Apr 23 2020, 17:42

jasonbcox committed rABC72fbc5d5ef66: Add default THREADS to build_autotools.sh (authored by jasonbcox).

Add default THREADS to build_autotools.sh

Apr 23 2020, 15:50

jasonbcox closed D5814: Add default THREADS to build_autotools.sh.

Apr 23 2020, 15:50

jasonbcox committed rABCf153f5ac6cdc: Make sure build_* devtools scripts' default build directories always exist (authored by jasonbcox).

Make sure build_* devtools scripts' default build directories always exist

Apr 23 2020, 15:49

jasonbcox closed D5813: Make sure build_* devtools scripts' default build directories always exist.

Apr 23 2020, 15:49

jasonbcox requested review of D5801: Add a land bot script for running smoke tests before landing patches.

Added the full workflow to the summary. Hopefully it's more clear now.

Apr 23 2020, 15:49

jasonbcox updated the summary of D5801: Add a land bot script for running smoke tests before landing patches.

Apr 23 2020, 15:47

jasonbcox requested changes to D5686: Implement banning logic for Seeder for nodes on the wrong chain.

Apr 23 2020, 00:37

jasonbcox requested changes to D5380: [seeder] Require good seeds to have latest checkpoint.

Tests still need a little work + some other nits

Apr 23 2020, 00:16

jasonbcox created D5814: Add default THREADS to build_autotools.sh.

Apr 23 2020, 00:02

jasonbcox updated the test plan for D5813: Make sure build_* devtools scripts' default build directories always exist.

Apr 23 2020, 00:00

jasonbcox created D5813: Make sure build_* devtools scripts' default build directories always exist.

Apr 23 2020, 00:00

Apr 22 2020

jasonbcox accepted D5800: Remove TestNode().

Apr 22 2020, 21:38

jasonbcox committed rABCd61d1020d2fc: [build-configurations] Add build-without-cli (authored by jasonbcox).

[build-configurations] Add build-without-cli

Apr 22 2020, 21:15

jasonbcox closed D5784: [build-configurations] Add build-without-cli.

Apr 22 2020, 21:14

jasonbcox committed rABCe895e15b9a2b: Merge #17497: test: skip tests when utils haven't been compiled (authored by MarcoFalke <falke.marco@gmail.com>).

Merge #17497: test: skip tests when utils haven't been compiled

Apr 22 2020, 21:14

jasonbcox closed D5789: Merge #17497: test: skip tests when utils haven't been compiled.

Apr 22 2020, 21:14

jasonbcox requested changes to D5800: Remove TestNode().

It looks like the old code was trying to keep a separation between the DB results and the seeder implementation. Your patch now entangles the two. Neither approach appears to be correct, so that begs the question: Why does TestNode() exist outside of main.cpp? or why does it exist at all when it's only call site is ThreadCrawler?

Apr 22 2020, 20:54

jasonbcox created D5808: [land-bot] Bail early if there's nothing to land.

Apr 22 2020, 19:42

jasonbcox updated the diff for D5784: [build-configurations] Add build-without-cli.

Rebase

Apr 22 2020, 19:03

jasonbcox retitled D5789: Merge #17497: test: skip tests when utils haven't been compiled from test: skip bitcoin_cli test when the cli isn't compiled to Merge #17497: test: skip tests when utils haven't been compiled.

Apr 22 2020, 19:02

jasonbcox updated the diff for D5789: Merge #17497: test: skip tests when utils haven't been compiled.

Added remainder of the backport

Apr 22 2020, 19:00

jasonbcox added a comment to D5789: Merge #17497: test: skip tests when utils haven't been compiled.

In D5789#141660, @deadalnix wrote:

Why not backport the whole PR?

Apr 22 2020, 18:50

jasonbcox added inline comments to D5801: Add a land bot script for running smoke tests before landing patches.

Apr 22 2020, 18:37

jasonbcox accepted D5806: refactor: test/bench: dedup Build{Crediting,Spending}Transaction().

Apr 22 2020, 18:35

jasonbcox accepted D5802: Update the PPA to support Ubuntu 20.04, drop 16.04.

Apr 22 2020, 18:23

jasonbcox accepted D5805: [BENCH] Add an option to output the result as a Junit report.

Apr 22 2020, 18:21

jasonbcox accepted D5803: Build the deb package with cmake.

Please be sure to migrate the PPA dependencies to the ABC PPA before we release on Tuesday.

Apr 22 2020, 18:14

jasonbcox requested changes to D5802: Update the PPA to support Ubuntu 20.04, drop 16.04.

Apr 22 2020, 18:05

jasonbcox committed rABC7c83d810c5dc: Merge #14298: [REST] improve performance for JSON calls (authored by MarcoFalke <falke.marco@gmail.com>).

Merge #14298: [REST] improve performance for JSON calls

Apr 22 2020, 17:58

jasonbcox closed D5783: Merge #14298: [REST] improve performance for JSON calls.

Apr 22 2020, 17:58

jasonbcox abandoned D4195: Added a land bot script.

Abandoning in favor of D5801

Apr 22 2020, 01:42

jasonbcox created D5801: Add a land bot script for running smoke tests before landing patches.

Apr 22 2020, 01:40

jasonbcox committed rABC382f0b28914b: Merge #14097: validation: Log FormatStateMessage on ConnectBlock error in… (authored by Wladimir J. van der Laan <laanwj@gmail.com>).

Merge #14097: validation: Log FormatStateMessage on ConnectBlock error in…

Apr 22 2020, 01:22

jasonbcox closed D5780: Merge #14097: validation: Log FormatStateMessage on ConnectBlock error in ConnectTip.

Apr 22 2020, 01:22

Apr 21 2020

jasonbcox accepted D5798: gui: Stop translating PACKAGE_NAME.

Apr 21 2020, 16:46

jasonbcox committed rABCb66f14b8c6da: [autopatch] Do not create a new git branch when fetching upstream (authored by jasonbcox).

[autopatch] Do not create a new git branch when fetching upstream

Apr 21 2020, 16:32

jasonbcox closed D5786: [autopatch] Do not create a new git branch when fetching upstream.

Apr 21 2020, 16:32

jasonbcox committed rABC48cb6ae0ba83: core -> ABC in extract_strings_qt.py (authored by jasonbcox).

core -> ABC in extract_strings_qt.py

Apr 21 2020, 16:29

jasonbcox closed D5790: core -> ABC in extract_strings_qt.py.

Apr 21 2020, 16:29

jasonbcox committed rABC1bccab0c3e44: Fix @generated marking in Phab for generate-seeds.py (authored by jasonbcox).

Fix @generated marking in Phab for generate-seeds.py

Apr 21 2020, 16:28