Page MenuHomePhabricator
Feed Advanced Search

May 13 2020

jasonbcox updated the summary of D6036: Bump misbehaving factor for unexpected version message behavior.
May 13 2020, 16:49
jasonbcox planned changes to D6057: Cleanup useless dependency in setup-debian-buster.sh.
May 13 2020, 16:42
jasonbcox requested review of D6057: Cleanup useless dependency in setup-debian-buster.sh.
May 13 2020, 16:42

May 12 2020

jasonbcox planned changes to D6016: Test patch; please do NOT review.
May 12 2020, 22:45
jasonbcox updated the diff for D6016: Test patch; please do NOT review.

Rebase

May 12 2020, 22:45
jasonbcox committed rSTAGING702095f647a4: [land-bot] Ensure changes to the land bot script do not modify its execution in… (authored by jasonbcox).
[land-bot] Ensure changes to the land bot script do not modify its execution in…
May 12 2020, 22:40
jasonbcox committed rSTAGING2696cfecd29b: [land-bot] Only operate on trusted patches (authored by jasonbcox).
[land-bot] Only operate on trusted patches
May 12 2020, 22:40
jasonbcox committed rABC702095f647a4: [land-bot] Ensure changes to the land bot script do not modify its execution in… (authored by jasonbcox).
[land-bot] Ensure changes to the land bot script do not modify its execution in…
May 12 2020, 22:38
jasonbcox closed D6018: [land-bot] Ensure changes to the land bot script do not modify its execution in-flight.
May 12 2020, 22:38
jasonbcox committed rABC2696cfecd29b: [land-bot] Only operate on trusted patches (authored by jasonbcox).
[land-bot] Only operate on trusted patches
May 12 2020, 22:37
jasonbcox closed D6017: [land-bot] Only operate on trusted patches.
May 12 2020, 22:37
jasonbcox updated the diff for D6041: [tests] Give a useful error message when assert_debug_log is called with empty expected messages.

Fixed two assert_debug_log usages that "depend" on the old behavior, but don't need to.

May 12 2020, 18:11
jasonbcox added a comment to D6041: [tests] Give a useful error message when assert_debug_log is called with empty expected messages.

This is causing a large number of tests to fail

May 12 2020, 18:10
jasonbcox committed rSTAGING4fe73eeecdc9: Use HTTPS for LLVM repository (authored by jasonbcox).
Use HTTPS for LLVM repository
May 12 2020, 16:00
jasonbcox committed rABC4fe73eeecdc9: Use HTTPS for LLVM repository (authored by jasonbcox).
Use HTTPS for LLVM repository
May 12 2020, 15:57
jasonbcox closed D6039: Use HTTPS for LLVM repository.
May 12 2020, 15:57
jasonbcox committed rSTAGING886aa257ad5d: Add missing cs_main lock (authored by jasonbcox).
Add missing cs_main lock
May 12 2020, 01:15
jasonbcox committed rABC886aa257ad5d: Add missing cs_main lock (authored by jasonbcox).
Add missing cs_main lock
May 12 2020, 01:11
jasonbcox closed D6040: Add missing cs_main lock.
May 12 2020, 01:10
jasonbcox requested review of D6041: [tests] Give a useful error message when assert_debug_log is called with empty expected messages.
May 12 2020, 01:06
jasonbcox requested review of D6040: Add missing cs_main lock.
May 12 2020, 00:32
jasonbcox committed rSTAGING016abbe42e83: [net] Ignore unlikely timestamps in version messages (authored by jasonbcox).
[net] Ignore unlikely timestamps in version messages
May 12 2020, 00:20
jasonbcox committed rSTAGING59dff0e81865: Fix potential timedata overflow (authored by jasonbcox).
Fix potential timedata overflow
May 12 2020, 00:20
jasonbcox abandoned D5988: Fallback on buster-backports if LLVM packages are not available.

After some discussion with Fabien, it's clear this solution is not robust enough in the short term to warrant a bandaid that is not scalable in the long-term.

May 12 2020, 00:18
jasonbcox committed rABC016abbe42e83: [net] Ignore unlikely timestamps in version messages (authored by jasonbcox).
[net] Ignore unlikely timestamps in version messages
May 12 2020, 00:16
jasonbcox closed D6024: [net] Ignore unlikely timestamps in version messages.
May 12 2020, 00:16
jasonbcox committed rABC59dff0e81865: Fix potential timedata overflow (authored by jasonbcox).
Fix potential timedata overflow
May 12 2020, 00:14
jasonbcox closed D6025: Fix potential timedata overflow.
May 12 2020, 00:14

May 11 2020

jasonbcox requested review of D6039: Use HTTPS for LLVM repository.
May 11 2020, 23:40
jasonbcox committed rSTAGING360ada969b27: [tests] Remove ctime() call which may be unreliable on some systems (authored by jasonbcox).
[tests] Remove ctime() call which may be unreliable on some systems
May 11 2020, 22:25
jasonbcox committed rABC360ada969b27: [tests] Remove ctime() call which may be unreliable on some systems (authored by jasonbcox).
[tests] Remove ctime() call which may be unreliable on some systems
May 11 2020, 22:23
jasonbcox closed D6023: [tests] Remove ctime() call which may be unreliable on some systems.
May 11 2020, 22:23
jasonbcox updated the diff for D6017: [land-bot] Only operate on trusted patches.

Fix comment

May 11 2020, 21:13
jasonbcox updated the diff for D6017: [land-bot] Only operate on trusted patches.

Make the review checking more similar to arc land's implementation so
as not to have to check for the ABC reviewer group specifically.

May 11 2020, 21:11
jasonbcox planned changes to D6036: Bump misbehaving factor for unexpected version message behavior.
May 11 2020, 20:34
jasonbcox requested review of D6036: Bump misbehaving factor for unexpected version message behavior.
May 11 2020, 20:34
jasonbcox updated the diff for D6024: [net] Ignore unlikely timestamps in version messages.

Rebase on the right stack so tests pass

May 11 2020, 19:29
jasonbcox added inline comments to D6024: [net] Ignore unlikely timestamps in version messages.
May 11 2020, 19:18
jasonbcox updated the diff for D6024: [net] Ignore unlikely timestamps in version messages.

Bump misbehaving factor to 20

May 11 2020, 18:56
jasonbcox updated the diff for D6025: Fix potential timedata overflow.

Fix median calculation when both elements are odd

May 11 2020, 18:30
jasonbcox committed rSTAGING1a3b614d3952: Bump version to 0.21.7 (authored by jasonbcox).
Bump version to 0.21.7
May 11 2020, 18:15
jasonbcox committed rABC1a3b614d3952: Bump version to 0.21.7 (authored by jasonbcox).
Bump version to 0.21.7
May 11 2020, 18:14
jasonbcox closed D6033: Bump version to 0.21.7.
May 11 2020, 18:14
jasonbcox requested review of D6033: Bump version to 0.21.7.
May 11 2020, 17:43
jasonbcox added a comment to D6017: [land-bot] Only operate on trusted patches.

I don't understand why you need to do the check in this script. Isn't it already checked by arc land ?

May 11 2020, 17:21
jasonbcox updated the diff for D6024: [net] Ignore unlikely timestamps in version messages.
  • Use genesis time from chainparams
  • Use Misbehaving() instead of just logging
May 11 2020, 17:17
jasonbcox committed rSTAGING6bd6615b8135: Restrict setmocktime to non-negative integers (authored by jasonbcox).
Restrict setmocktime to non-negative integers
May 11 2020, 17:05
jasonbcox committed rABC6bd6615b8135: Restrict setmocktime to non-negative integers (authored by jasonbcox).
Restrict setmocktime to non-negative integers
May 11 2020, 17:03
jasonbcox closed D6022: Restrict setmocktime to non-negative integers.
May 11 2020, 17:03
jasonbcox retitled D6023: [tests] Remove ctime() call which may be unreliable on some systems from [tests] Limit timestamps passed to ctime() which may be unreliable on some systems to [tests] Remove ctime() call which may be unreliable on some systems.
May 11 2020, 16:59
jasonbcox updated the diff for D6023: [tests] Remove ctime() call which may be unreliable on some systems.

Just remove the pretty printing entirely

May 11 2020, 16:58
jasonbcox added inline comments to D6023: [tests] Remove ctime() call which may be unreliable on some systems.
May 11 2020, 16:57
jasonbcox updated the diff for D6022: Restrict setmocktime to non-negative integers.

Tweaked error message text

May 11 2020, 16:53
jasonbcox added inline comments to D6024: [net] Ignore unlikely timestamps in version messages.
May 11 2020, 16:48
jasonbcox requested review of D6025: Fix potential timedata overflow.
May 11 2020, 16:23
jasonbcox added a comment to D6018: [land-bot] Ensure changes to the land bot script do not modify its execution in-flight.

I have no problem with this per se now that it is done, but you got to wonder how that became a problem worth fixing in the first place. Why not run these scripts from master to begin with instead of using the version of the patch?

May 11 2020, 15:35
jasonbcox requested review of D6025: Fix potential timedata overflow.
May 11 2020, 03:04
jasonbcox requested review of D6024: [net] Ignore unlikely timestamps in version messages.
May 11 2020, 02:52

May 10 2020

jasonbcox requested review of D6023: [tests] Remove ctime() call which may be unreliable on some systems.
May 10 2020, 21:50
jasonbcox requested review of D6022: Restrict setmocktime to non-negative integers.
May 10 2020, 20:19
jasonbcox accepted D6020: Properly handle LONG_MIN in timedata.cpp.
May 10 2020, 17:58

May 8 2020

jasonbcox requested review of D6018: [land-bot] Ensure changes to the land bot script do not modify its execution in-flight.
May 8 2020, 23:48
jasonbcox updated the diff for D6017: [land-bot] Only operate on trusted patches.

Fix lint issue

May 8 2020, 23:16
jasonbcox requested review of D6017: [land-bot] Only operate on trusted patches.
May 8 2020, 23:13
jasonbcox planned changes to D6016: Test patch; please do NOT review.
May 8 2020, 23:09
jasonbcox requested review of D6016: Test patch; please do NOT review.
May 8 2020, 23:09
jasonbcox committed rSTAGING310321ec95c0: Merge #12764: doc: Remove field in getblocktemplate help that has never been… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #12764: doc: Remove field in getblocktemplate help that has never been…
May 8 2020, 22:05
jasonbcox committed rABC310321ec95c0: Merge #12764: doc: Remove field in getblocktemplate help that has never been… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #12764: doc: Remove field in getblocktemplate help that has never been…
May 8 2020, 22:05
jasonbcox closed D6015: Merge #12764: doc: Remove field in getblocktemplate help that has never been used..
May 8 2020, 22:04
jasonbcox requested review of D6015: Merge #12764: doc: Remove field in getblocktemplate help that has never been used..
May 8 2020, 21:46
jasonbcox closed T846: Build Bitcoin-ABC / Master / Bitcoin-ABC Master is broken. as Resolved.
May 8 2020, 18:25
jasonbcox reopened T846: Build Bitcoin-ABC / Master / Bitcoin-ABC Master is broken. as "Open".
May 8 2020, 18:24
jasonbcox abandoned D5975: [univalue] Add a path for ignoring duplicate key checks.
May 8 2020, 18:21
jasonbcox closed T846: Build Bitcoin-ABC / Master / Bitcoin-ABC Master is broken. as Resolved.
May 8 2020, 17:20
jasonbcox committed rSTAGINGe217d0e4cfbb: Merge #14984: rpc: Speedup getrawmempool when verbose=true (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14984: rpc: Speedup getrawmempool when verbose=true
May 8 2020, 14:50
jasonbcox committed rSTAGING54c6eab4e0b8: Merge #15463: rpc: Speedup getaddressesbylabel (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #15463: rpc: Speedup getaddressesbylabel
May 8 2020, 14:50
jasonbcox committed rABCe217d0e4cfbb: Merge #14984: rpc: Speedup getrawmempool when verbose=true (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14984: rpc: Speedup getrawmempool when verbose=true
May 8 2020, 14:49
jasonbcox closed D6007: Merge #14984: rpc: Speedup getrawmempool when verbose=true.
May 8 2020, 14:49
jasonbcox committed rABC54c6eab4e0b8: Merge #15463: rpc: Speedup getaddressesbylabel (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #15463: rpc: Speedup getaddressesbylabel
May 8 2020, 14:49
jasonbcox closed D6008: Merge #15463: rpc: Speedup getaddressesbylabel.
May 8 2020, 14:49
jasonbcox requested review of D6008: Merge #15463: rpc: Speedup getaddressesbylabel.
May 8 2020, 00:28
jasonbcox updated the test plan for D6007: Merge #14984: rpc: Speedup getrawmempool when verbose=true.
May 8 2020, 00:18
jasonbcox updated the test plan for D6007: Merge #14984: rpc: Speedup getrawmempool when verbose=true.
May 8 2020, 00:17
jasonbcox updated the test plan for D6007: Merge #14984: rpc: Speedup getrawmempool when verbose=true.
May 8 2020, 00:15
jasonbcox requested review of D6007: Merge #14984: rpc: Speedup getrawmempool when verbose=true.
May 8 2020, 00:14

May 7 2020

jasonbcox committed rSTAGING4f8d6e19114b: Added some release notes (authored by jasonbcox).
Added some release notes
May 7 2020, 20:15
jasonbcox committed rABC4f8d6e19114b: Added some release notes (authored by jasonbcox).
Added some release notes
May 7 2020, 20:10
jasonbcox closed D5998: Added some release notes.
May 7 2020, 20:10
jasonbcox updated the diff for D5998: Added some release notes.

Fix errant newlines

May 7 2020, 19:30
jasonbcox accepted D6002: refactoring: FlushStateToDisk -> CChainState.
May 7 2020, 19:27
jasonbcox accepted D6001: refactoring: introduce ChainstateActive().
May 7 2020, 19:13
jasonbcox added a comment to D5982: UniValue performance speedups for .write().

Submitted upstream: https://github.com/jgarzik/univalue/pull/70

May 7 2020, 19:00
jasonbcox committed rSTAGING4812274977f5: UniValue performance speedups for .write() (authored by jasonbcox).
UniValue performance speedups for .write()
May 7 2020, 18:40
jasonbcox requested review of D5998: Added some release notes.
May 7 2020, 18:36
jasonbcox committed rABC4812274977f5: UniValue performance speedups for .write() (authored by jasonbcox).
UniValue performance speedups for .write()
May 7 2020, 18:35
jasonbcox closed D5982: UniValue performance speedups for .write().
May 7 2020, 18:35
jasonbcox accepted D5996: move-only: make the CChainState interface public.
May 7 2020, 18:30
jasonbcox updated the test plan for D5982: UniValue performance speedups for .write().
May 7 2020, 17:38
jasonbcox updated the diff for D5982: UniValue performance speedups for .write().
  • UniValueStream -> UniValueStreamWriter
  • Use getter instead of direct access to str
May 7 2020, 17:37
jasonbcox accepted D5995: Move DisconnectResult in its own header and make it an enum class.

I assume this work is related to https://github.com/bitcoin/bitcoin/pull/15976/commits/d7c97edeea8cee10ad9da1f940d39d5073ac142d
We already own this part of the code due to D364 and that commit on Core appears to be shuffling DisconnectResult into validation.h which is not a good long-term solution.
This looks like the right approach, but the naming should change now that it sits on its own at the src level.

May 7 2020, 16:45