Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

May 18 2020

jasonbcox closed T896: Build Bitcoin ABC Diffs / Bitcoin-ABC Land Bot is broken. as Invalid.
May 18 2020, 20:36
jasonbcox accepted D6117: Fix Flake8 E741 errors.
May 18 2020, 18:56
jasonbcox planned changes to D5808: [land-bot] Bail early if there's nothing to land.
May 18 2020, 16:56
jasonbcox requested changes to D6115: [backport#15153] gui: Add Open Wallet menu.

Test plan doesn't test the GUI

May 18 2020, 16:55
jasonbcox accepted D6118: Lint everything.
May 18 2020, 16:53
jasonbcox accepted D6117: Fix Flake8 E741 errors.
May 18 2020, 16:51
jasonbcox accepted D6116: Fix dbcrash spurious failures.

Macro likestamp:

May 18 2020, 16:48
jasonbcox closed T858: Build Automated Deployments / Bitcoin ABC Automated Commits / Bitcoin-ABC Update Chainparams is broken. as Resolved.
May 18 2020, 15:42
jasonbcox closed T860: Build Automated Deployments / Bitcoin ABC Automated Commits / Bitcoin-ABC Update timings.json is broken. as Resolved.
May 18 2020, 15:41
jasonbcox closed T596: Backport Core PR 14350: Add WalletLocation class, a subtask of T595: Backport Core PR15639: bitcoin-wallet tool: Drop libbitcoin_server.a dependency, as Resolved.
May 18 2020, 15:27 · Restricted Project, Backport
jasonbcox closed T596: Backport Core PR 14350: Add WalletLocation class, a subtask of T600: Backport Core PR 14711: Refactor: Start to separate wallet from node, as Resolved.
May 18 2020, 15:27 · Restricted Project, Backport
jasonbcox closed T596: Backport Core PR 14350: Add WalletLocation class as Resolved.
May 18 2020, 15:27 · Restricted Project, Backport
jasonbcox closed T592: Backport Core PR 14437: Refactor: Start to separate wallet from node, a subtask of T596: Backport Core PR 14350: Add WalletLocation class, as Resolved.
May 18 2020, 15:27 · Restricted Project, Backport
jasonbcox closed T592: Backport Core PR 14437: Refactor: Start to separate wallet from node as Resolved.
May 18 2020, 15:26 · Backport, Restricted Project
jasonbcox closed T574: Backport Core PR 14708: unrecognized section names in the config should supply warnings in the logs as Resolved.
May 18 2020, 15:26 · Restricted Project, Bootcamp
jasonbcox closed T629: Backport Core PR 11372: Address encoding cleanup, a subtask of T590: Backport Core 14555: Move util files to new directory, as Resolved.
May 18 2020, 15:25 · Backport, Restricted Project
jasonbcox closed T629: Backport Core PR 11372: Address encoding cleanup as Resolved.
May 18 2020, 15:25 · Backport, Restricted Project
jasonbcox closed T590: Backport Core 14555: Move util files to new directory, a subtask of T574: Backport Core PR 14708: unrecognized section names in the config should supply warnings in the logs, as Resolved.
May 18 2020, 15:25 · Restricted Project, Bootcamp
jasonbcox closed T590: Backport Core 14555: Move util files to new directory, a subtask of T591: Backport Core 14494: Error if # is used in rpcpassword in conf, as Resolved.
May 18 2020, 15:25 · Backport, Restricted Project
jasonbcox closed T590: Backport Core 14555: Move util files to new directory as Resolved.
May 18 2020, 15:25 · Backport, Restricted Project
jasonbcox closed T590: Backport Core 14555: Move util files to new directory, a subtask of T592: Backport Core PR 14437: Refactor: Start to separate wallet from node, as Resolved.
May 18 2020, 15:25 · Backport, Restricted Project
jasonbcox committed rSTAGING90ee2a3fef5b: Cleanup useless dependency in setup-debian-buster.sh (authored by jasonbcox).
Cleanup useless dependency in setup-debian-buster.sh
May 18 2020, 15:25
jasonbcox closed T583: Backport Core PR 13190, a subtask of T582: Backport Core PR 13341, as Resolved.
May 18 2020, 15:25 · Backport, Bootcamp, Restricted Project
jasonbcox closed T583: Backport Core PR 13190, a subtask of T637: Backport Core PR 14168: Remove ENABLE_WALLET from libbitcoin_server.a, as Resolved.
May 18 2020, 15:25 · Backport, Restricted Project
jasonbcox closed T583: Backport Core PR 13190 as Resolved.
May 18 2020, 15:25 · Backport, Bootcamp, Restricted Project
jasonbcox closed T575: Backport Core PR 14532: reduce attack surface of RPC server as Resolved.
May 18 2020, 15:23 · Bootcamp, Restricted Project
jasonbcox committed rABC90ee2a3fef5b: Cleanup useless dependency in setup-debian-buster.sh (authored by jasonbcox).
Cleanup useless dependency in setup-debian-buster.sh
May 18 2020, 15:21
jasonbcox closed D6057: Cleanup useless dependency in setup-debian-buster.sh.
May 18 2020, 15:21
jasonbcox committed rSTAGING549166a5c7eb: Check for IBD completion based on existing log message instead of 100% progress (authored by jasonbcox).
Check for IBD completion based on existing log message instead of 100% progress
May 18 2020, 15:20
jasonbcox committed rABC549166a5c7eb: Check for IBD completion based on existing log message instead of 100% progress (authored by jasonbcox).
Check for IBD completion based on existing log message instead of 100% progress
May 18 2020, 15:20
jasonbcox closed D6100: Check for IBD completion based on existing log message instead of 100% progress.
May 18 2020, 15:20

May 16 2020

jasonbcox committed rSTAGING36804f1672e3: Fix typo related to ZMQ in build docs (authored by jasonbcox).
Fix typo related to ZMQ in build docs
May 16 2020, 00:30
jasonbcox committed rABC36804f1672e3: Fix typo related to ZMQ in build docs (authored by jasonbcox).
Fix typo related to ZMQ in build docs
May 16 2020, 00:27
jasonbcox closed D6099: Fix typo related to ZMQ in build docs.
May 16 2020, 00:27
jasonbcox requested review of D6100: Check for IBD completion based on existing log message instead of 100% progress.
May 16 2020, 00:18
jasonbcox requested review of D6099: Fix typo related to ZMQ in build docs.
May 16 2020, 00:02

May 15 2020

jasonbcox committed rSTAGINGef072c8c0526: Add OP_REVERSEBYTES test case (authored by jasonbcox).
Add OP_REVERSEBYTES test case
May 15 2020, 23:55
jasonbcox committed rABCef072c8c0526: Add OP_REVERSEBYTES test case (authored by jasonbcox).
Add OP_REVERSEBYTES test case
May 15 2020, 23:51
jasonbcox closed D6097: Add OP_REVERSEBYTES test case.
May 15 2020, 23:51
jasonbcox requested review of D6097: Add OP_REVERSEBYTES test case.
May 15 2020, 20:56
jasonbcox committed rSTAGING276077cdc648: Add release notes (authored by jasonbcox).
Add release notes
May 15 2020, 19:10
jasonbcox accepted D6093: Report updated sigops count in mining RPC.
May 15 2020, 19:07
jasonbcox committed rABC276077cdc648: Add release notes (authored by jasonbcox).
Add release notes
May 15 2020, 19:06
jasonbcox closed D6095: Add release notes.
May 15 2020, 19:06
jasonbcox requested review of D6095: Add release notes.
May 15 2020, 18:48
jasonbcox accepted D6094: Add checkpoints for phonon activation.
May 15 2020, 18:37
jasonbcox committed rSTAGINGec3450458c0f: Update chainparams to a post-upgrade block (authored by jasonbcox).
Update chainparams to a post-upgrade block
May 15 2020, 17:15
jasonbcox committed rABCec3450458c0f: Update chainparams to a post-upgrade block (authored by jasonbcox).
Update chainparams to a post-upgrade block
May 15 2020, 17:12
jasonbcox closed D6091: Update chainparams to a post-upgrade block.
May 15 2020, 17:12
jasonbcox updated the diff for D6091: Update chainparams to a post-upgrade block.

Remove testnet assume valid since no one is mining it right now

May 15 2020, 16:48
jasonbcox requested review of D6091: Update chainparams to a post-upgrade block.
May 15 2020, 13:40
jasonbcox committed rSTAGING3455faac52a9: Fix incorrect mocktime set in miner fund test (authored by jasonbcox).
Fix incorrect mocktime set in miner fund test
May 15 2020, 13:40
jasonbcox committed rABC3455faac52a9: Fix incorrect mocktime set in miner fund test (authored by jasonbcox).
Fix incorrect mocktime set in miner fund test
May 15 2020, 13:39
jasonbcox closed D6090: Fix incorrect mocktime set in miner fund test.
May 15 2020, 13:39
jasonbcox requested review of D6090: Fix incorrect mocktime set in miner fund test.
May 15 2020, 13:19
jasonbcox committed rSTAGING2e2726b672eb: Remove 0.20.x nodes from makeseeds (authored by jasonbcox).
Remove 0.20.x nodes from makeseeds
May 15 2020, 12:45
jasonbcox requested review of D6057: Cleanup useless dependency in setup-debian-buster.sh.
May 15 2020, 12:43
jasonbcox committed rABC2e2726b672eb: Remove 0.20.x nodes from makeseeds (authored by jasonbcox).
Remove 0.20.x nodes from makeseeds
May 15 2020, 12:41
jasonbcox closed D6085: Remove 0.20.x nodes from makeseeds.
May 15 2020, 12:41

May 14 2020

jasonbcox requested review of D6085: Remove 0.20.x nodes from makeseeds.
May 14 2020, 23:59
jasonbcox abandoned D5974: Tweak RPC mempool benchmark so that perf improvements are more noticeable.
May 14 2020, 23:30
jasonbcox accepted D6081: [tests] tidy up imports in wallet_importmulti.py.
May 14 2020, 23:19
jasonbcox accepted D6078: Remove white space between list in v0.21.5 release notes.

My bad on the first revision. I should have caught it sooner.

May 14 2020, 20:34
jasonbcox committed rSTAGING9b4b362ea132: Bump PORT_MIN in test framework to not collide with testnet (authored by jasonbcox).
Bump PORT_MIN in test framework to not collide with testnet
May 14 2020, 20:25
jasonbcox committed rABC9b4b362ea132: Bump PORT_MIN in test framework to not collide with testnet (authored by jasonbcox).
Bump PORT_MIN in test framework to not collide with testnet
May 14 2020, 20:22
jasonbcox closed D6076: Bump PORT_MIN in test framework to not collide with testnet.
May 14 2020, 20:22
jasonbcox committed rSTAGING573ecef355f4: Merge #16918: test: Make PORT_MIN in test runner configurable (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #16918: test: Make PORT_MIN in test runner configurable
May 14 2020, 19:55
jasonbcox updated the diff for D6076: Bump PORT_MIN in test framework to not collide with testnet.

Add comment per feedback

May 14 2020, 19:53
jasonbcox committed rABC573ecef355f4: Merge #16918: test: Make PORT_MIN in test runner configurable (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #16918: test: Make PORT_MIN in test runner configurable
May 14 2020, 19:51
jasonbcox closed D6075: Merge #16918: test: Make PORT_MIN in test runner configurable.
May 14 2020, 19:51
jasonbcox committed rSTAGINGaff6784475fb: Merge #18641: test: Create cached blocks not in the future (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #18641: test: Create cached blocks not in the future
May 14 2020, 19:45
jasonbcox committed rABCaff6784475fb: Merge #18641: test: Create cached blocks not in the future (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #18641: test: Create cached blocks not in the future
May 14 2020, 19:44
jasonbcox closed D6071: Merge #18641: test: Create cached blocks not in the future.
May 14 2020, 19:43
jasonbcox requested review of D6076: Bump PORT_MIN in test framework to not collide with testnet.
May 14 2020, 19:41
jasonbcox accepted D6074: Remove Core release note file, update previous release notes, and fix generate() deprecation message.
May 14 2020, 19:36
jasonbcox accepted D6074: Remove Core release note file, update previous release notes, and fix generate() deprecation message.
May 14 2020, 19:34
jasonbcox requested changes to D6074: Remove Core release note file, update previous release notes, and fix generate() deprecation message.

Good catch.

May 14 2020, 19:29
jasonbcox requested review of D6075: Merge #16918: test: Make PORT_MIN in test runner configurable.
May 14 2020, 19:23
jasonbcox requested review of D6071: Merge #18641: test: Create cached blocks not in the future.
May 14 2020, 17:04
jasonbcox committed rSTAGINGedbbd9315ad4: Reduce memory allocations in getblocktemplate (authored by jasonbcox).
Reduce memory allocations in getblocktemplate
May 14 2020, 01:40
jasonbcox committed rABCedbbd9315ad4: Reduce memory allocations in getblocktemplate (authored by jasonbcox).
Reduce memory allocations in getblocktemplate
May 14 2020, 01:37
jasonbcox closed D6065: Reduce memory allocations in getblocktemplate.
May 14 2020, 01:37

May 13 2020

jasonbcox committed rSTAGINGbbcc120d0745: Bump misbehaving factor for unexpected version message behavior (authored by jasonbcox).
Bump misbehaving factor for unexpected version message behavior
May 13 2020, 23:20
jasonbcox committed rSTAGING6e392928a605: Update univalue to 1.1.1 (authored by jasonbcox).
Update univalue to 1.1.1
May 13 2020, 23:20
jasonbcox committed rABCbbcc120d0745: Bump misbehaving factor for unexpected version message behavior (authored by jasonbcox).
Bump misbehaving factor for unexpected version message behavior
May 13 2020, 23:19
jasonbcox closed D6036: Bump misbehaving factor for unexpected version message behavior.
May 13 2020, 23:19
jasonbcox committed rABC6e392928a605: Update univalue to 1.1.1 (authored by jasonbcox).
Update univalue to 1.1.1
May 13 2020, 23:18
jasonbcox closed D6063: Update univalue to 1.1.1.
May 13 2020, 23:18
jasonbcox requested review of D6065: Reduce memory allocations in getblocktemplate.
May 13 2020, 23:14
jasonbcox requested review of D6063: Update univalue to 1.1.1.
May 13 2020, 22:47
jasonbcox committed rSTAGINGecf576938507: [tests] Give a useful error message when assert_debug_log is called with empty… (authored by jasonbcox).
[tests] Give a useful error message when assert_debug_log is called with empty…
May 13 2020, 21:10
jasonbcox committed rABCecf576938507: [tests] Give a useful error message when assert_debug_log is called with empty… (authored by jasonbcox).
[tests] Give a useful error message when assert_debug_log is called with empty…
May 13 2020, 21:07
jasonbcox closed D6041: [tests] Give a useful error message when assert_debug_log is called with empty expected messages.
May 13 2020, 21:07
jasonbcox updated the test plan for D6041: [tests] Give a useful error message when assert_debug_log is called with empty expected messages.
May 13 2020, 20:28
jasonbcox updated the diff for D6041: [tests] Give a useful error message when assert_debug_log is called with empty expected messages.

Discussed offline with Fabiento clarify why I believe this API is the correct one. I've distilled our conversation
into a comment for future reference.

May 13 2020, 20:27
jasonbcox abandoned D5968: [build-configurations] Add build and tests without wallet to build-diff.
May 13 2020, 18:28
jasonbcox requested changes to D6059: [backport#15159#15404] [RPC] Remove lookup to UTXO set from GetTransaction.

The diff title doesn't match the change. It looks like we're missing a backport or something? Check out https://github.com/bitcoin/bitcoin/pull/15159

May 13 2020, 18:13
jasonbcox accepted D6056: [DEPENDS] Remove the facilities for building win32.
May 13 2020, 18:01
jasonbcox accepted D6060: [doc] since D5764, regtest requires standard txns by default.

In the future, put D5764 in the summary so that it's automatically linked. It makes review easier :)

May 13 2020, 18:00
jasonbcox requested review of D6036: Bump misbehaving factor for unexpected version message behavior.
May 13 2020, 16:49
First
Prev
Next