Page MenuHomePhabricator
Feed Advanced Search

Jun 11 2020

jasonbcox updated the summary of D6506: Replace automatic bans with discouragement filter.
Jun 11 2020, 02:09
jasonbcox updated the summary of D6506: Replace automatic bans with discouragement filter.
Jun 11 2020, 02:08

Jun 10 2020

jasonbcox accepted D6512: [backport#17091] tests: Add test for loadblock option and linearize scripts.
Jun 10 2020, 23:02
jasonbcox accepted D6515: Use std::condition_variable and sync.h instead of boost in scheduler_tests.cpp.
Jun 10 2020, 22:56
jasonbcox requested review of D6516: Merge #15622: Remove global symbols: Avoid using the global namespace if possible.
Jun 10 2020, 22:51
jasonbcox requested review of D6514: Merge #16092: Don't use global (external) symbols for symbols that are used in only one translation unit.
Jun 10 2020, 22:34
jasonbcox requested review of D6513: Merge #12980: Allow quicker shutdowns during LoadBlockIndex().
Jun 10 2020, 22:17
jasonbcox requested changes to D6508: Move CustomArgumentsFixture to an apropriate place.
Jun 10 2020, 18:03
jasonbcox awarded D5999: Add a test for the mempool dynamic memory usage a Haypence token.
Jun 10 2020, 17:50
jasonbcox requested review of D6506: Replace automatic bans with discouragement filter.
Jun 10 2020, 17:18

Jun 9 2020

jasonbcox accepted D6461: Move SocketEvents logic to private method..
Jun 9 2020, 23:05
jasonbcox accepted D6460: Move GenerateSelectSet logic to private method..
Jun 9 2020, 23:02
jasonbcox accepted D6459: Introduce and use constant SELECT_TIMEOUT_MILLISECONDS..
Jun 9 2020, 22:57
jasonbcox accepted D6491: Merge #15597: net: Generate log entry when blocks messages are received unexpectedly.
Jun 9 2020, 22:54
jasonbcox accepted D6494: Merge #15718: docs: Improve netaddress comments.
Jun 9 2020, 22:45
jasonbcox accepted D6493: [backport#16898] test: Remove unused connect_nodes_bi.
Jun 9 2020, 22:41
jasonbcox accepted D6492: [backport#16898] scripted-diff: test: Replace connect_nodes_bi with connect_nodes.

As is, the change looks good. But please look into out-of-order backports in these files that will likely be a headache for others:

  • rpc_psbt.py
  • wallet_avoidreuse.py
  • wallet_keypool_topup.py
Jun 9 2020, 22:39
jasonbcox accepted D6490: [backport#16898] test: Use connect_nodes when connecting nodes in the test_framework.

Looks like other parts of the stack take care of it.

Jun 9 2020, 21:11
jasonbcox requested changes to D6490: [backport#16898] test: Use connect_nodes when connecting nodes in the test_framework.
Jun 9 2020, 20:55
jasonbcox requested changes to D6489: Merge #15486: [addrman, net] Ensure tried collisions resolve, and allow feeler connections to existing outbound netgroups.
Jun 9 2020, 19:38
jasonbcox committed rABC910e12658934: Merge #16073: refactor: Improve CRollingBloomFilter::reset by using std::fill (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #16073: refactor: Improve CRollingBloomFilter::reset by using std::fill
Jun 9 2020, 19:36
jasonbcox closed D6485: Merge #16073: refactor: Improve CRollingBloomFilter::reset by using std::fill.
Jun 9 2020, 19:36
jasonbcox accepted D6487: [backport#16239] docs: release note wording.
Jun 9 2020, 19:07
jasonbcox requested changes to D6487: [backport#16239] docs: release note wording.
Jun 9 2020, 18:53
jasonbcox accepted D6484: Remove upgrade notice.

In the future, we need to make this notice deactivate on its own once the date has past. That will decouple the code cleanup from requiring a new deployment to remove the notice.

Jun 9 2020, 18:48
jasonbcox requested review of D6485: Merge #16073: refactor: Improve CRollingBloomFilter::reset by using std::fill.
Jun 9 2020, 18:23
jasonbcox committed rABCWEB8862868761ff: Add .arcconfig (authored by jasonbcox).
Add .arcconfig
Jun 9 2020, 18:12
jasonbcox closed D6483: Add .arcconfig.
Jun 9 2020, 18:12
jasonbcox requested review of D6483: Add .arcconfig.
Jun 9 2020, 18:08

Jun 8 2020

jasonbcox committed rABC601266a81f92: Merge #17931: test: Fix p2p_invalid_messages failing in Python 3.8 because of… (authored by fanquake <fanquake@gmail.com>).
Merge #17931: test: Fix p2p_invalid_messages failing in Python 3.8 because of…
Jun 8 2020, 20:40
jasonbcox closed D6462: Merge #17931: test: Fix p2p_invalid_messages failing in Python 3.8 because of warning.
Jun 8 2020, 20:40
jasonbcox requested review of D6462: Merge #17931: test: Fix p2p_invalid_messages failing in Python 3.8 because of warning.
Jun 8 2020, 20:18
jasonbcox accepted D6384: [backport#18247] test: Wait for both veracks in add_p2p_connection.
Jun 8 2020, 17:00
jasonbcox accepted D6432: [backport#18247] test: Remove redundant sync_with_ping after add_p2p_connection.
Jun 8 2020, 16:58
jasonbcox committed rABC294237a627c8: Merge #15697: qa: Make swap_magic_bytes in p2p_invalid_messages atomic (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #15697: qa: Make swap_magic_bytes in p2p_invalid_messages atomic
Jun 8 2020, 16:53
jasonbcox closed D6396: Merge #15697: qa: Make swap_magic_bytes in p2p_invalid_messages atomic.
Jun 8 2020, 16:53
jasonbcox committed rABC76ebb03789ff: Merge #15330: test: Fix race in p2p_invalid_messages (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #15330: test: Fix race in p2p_invalid_messages
Jun 8 2020, 16:52
jasonbcox closed D6395: Merge #15330: test: Fix race in p2p_invalid_messages.
Jun 8 2020, 16:52
jasonbcox committed rABCbf2721f4c9ee: [land-bot] Point land bot at bitcoinabc.org (authored by jasonbcox).
[land-bot] Point land bot at bitcoinabc.org
Jun 8 2020, 16:48
jasonbcox closed D6397: [land-bot] Point land bot at bitcoinabc.org.
Jun 8 2020, 16:48

Jun 5 2020

jasonbcox requested review of D6397: [land-bot] Point land bot at bitcoinabc.org.
Jun 5 2020, 21:57
jasonbcox requested review of D6396: Merge #15697: qa: Make swap_magic_bytes in p2p_invalid_messages atomic.
Jun 5 2020, 21:45
jasonbcox requested review of D6395: Merge #15330: test: Fix race in p2p_invalid_messages.
Jun 5 2020, 21:41
jasonbcox committed rABC705b3c6c8cca: Merge #15246: qa: Add tests for invalid message headers (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #15246: qa: Add tests for invalid message headers
Jun 5 2020, 21:36
jasonbcox closed D6394: Merge #15246: qa: Add tests for invalid message headers.
Jun 5 2020, 21:36
jasonbcox committed rABC883815514dfe: Simplify install instructions for linter dependencies (authored by jasonbcox).
Simplify install instructions for linter dependencies
Jun 5 2020, 21:08
jasonbcox closed D6389: Simplify install instructions for linter dependencies.
Jun 5 2020, 21:07
jasonbcox committed rABC554d897104b2: Add remaining linter dependencies to CI base image (authored by jasonbcox).
Add remaining linter dependencies to CI base image
Jun 5 2020, 20:37
jasonbcox closed D6380: Add remaining linter dependencies to CI base image.
Jun 5 2020, 20:37
jasonbcox retitled D6380: Add remaining linter dependencies to CI base image from Add shellcheck to CI base image to Add remaining linter dependencies to CI base image.
Jun 5 2020, 20:30
jasonbcox committed rABC8227e3687e9b: [land-bot] Clarify review status error message (authored by jasonbcox).
[land-bot] Clarify review status error message
Jun 5 2020, 20:29
jasonbcox closed D6388: [land-bot] Clarify review status error message.
Jun 5 2020, 20:29
jasonbcox updated the diff for D6389: Simplify install instructions for linter dependencies.

clang-format -> clang-format-8

Jun 5 2020, 20:29
jasonbcox retitled D6389: Simplify install instructions for linter dependencies from Simply install instructions for linter dependencies to Simplify install instructions for linter dependencies.
Jun 5 2020, 20:28
jasonbcox added inline comments to D6394: Merge #15246: qa: Add tests for invalid message headers.
Jun 5 2020, 20:27
jasonbcox requested review of D6394: Merge #15246: qa: Add tests for invalid message headers.
Jun 5 2020, 20:26
jasonbcox retitled D6389: Simplify install instructions for linter dependencies from Simply install instructions for linter depenendencies to Simply install instructions for linter dependencies.
Jun 5 2020, 19:30
jasonbcox requested review of D6389: Simplify install instructions for linter dependencies.
Jun 5 2020, 18:49
jasonbcox updated the diff for D6380: Add remaining linter dependencies to CI base image.

Add missing php-codesniffer

Jun 5 2020, 18:44
jasonbcox requested review of D6388: [land-bot] Clarify review status error message.
Jun 5 2020, 18:07
jasonbcox requested changes to D6384: [backport#18247] test: Wait for both veracks in add_p2p_connection.

Missing backport of p2p_dos_header_tree.py

Jun 5 2020, 17:57
jasonbcox committed rABC95173738367c: [devtools] Use -daemon instead of backgrounding bitcoind (authored by jasonbcox).
[devtools] Use -daemon instead of backgrounding bitcoind
Jun 5 2020, 17:55
jasonbcox closed D6379: [devtools] Use -daemon instead of backgrounding bitcoind.
Jun 5 2020, 17:55

Jun 4 2020

jasonbcox committed rABCda311f5ed8fe: Fix UniValue .write() changes for C++98 (authored by jasonbcox).
Fix UniValue .write() changes for C++98
Jun 4 2020, 23:32
jasonbcox closed D6359: Fix UniValue .write() changes for C++98.
Jun 4 2020, 23:32
jasonbcox requested review of D6380: Add remaining linter dependencies to CI base image.
Jun 4 2020, 23:15
jasonbcox committed rABC3aa12ec3b525: [devtools] Use a trap to cleanup bitcoind instead of a background process (authored by jasonbcox).
[devtools] Use a trap to cleanup bitcoind instead of a background process
Jun 4 2020, 23:10
jasonbcox closed D6378: [devtools] Use a trap to cleanup bitcoind instead of a background process.
Jun 4 2020, 23:10
jasonbcox requested changes to D6375: [backport#16898] test: Remove connect_nodes_bi.

Figure out what's up with the build-without-wallet failure

Jun 4 2020, 23:08
jasonbcox accepted D6377: util: Add Join helper to join a list of strings.
Jun 4 2020, 23:05
jasonbcox accepted D6376: util: refactor upper/lowercase functions.
Jun 4 2020, 23:02
jasonbcox requested review of D6379: [devtools] Use -daemon instead of backgrounding bitcoind.
Jun 4 2020, 22:53
jasonbcox requested review of D6378: [devtools] Use a trap to cleanup bitcoind instead of a background process.
Jun 4 2020, 22:28
jasonbcox accepted D6374: [CI] Disable jemalloc for running the tests with wine.
Jun 4 2020, 21:33
jasonbcox accepted D6373: [CI] Let build_cmake.sh take a list of targets and use it.
Jun 4 2020, 21:15
jasonbcox updated the diff for D6359: Fix UniValue .write() changes for C++98.

size_t

Jun 4 2020, 20:13
jasonbcox updated the summary of D6359: Fix UniValue .write() changes for C++98.
Jun 4 2020, 20:12
jasonbcox updated the summary of D6359: Fix UniValue .write() changes for C++98.
Jun 4 2020, 18:30
jasonbcox added inline comments to D6373: [CI] Let build_cmake.sh take a list of targets and use it.
Jun 4 2020, 18:21
jasonbcox updated the diff for D6359: Fix UniValue .write() changes for C++98.

Use swap to emulate std::move for C++98

Jun 4 2020, 18:13
jasonbcox accepted D6350: [backport#15777] [docs] Add doxygen comment for CKeyPool.
Jun 4 2020, 18:04
jasonbcox updated the diff for D6359: Fix UniValue .write() changes for C++98.

Introduce preprocessor directive to allow compilation with std::move. This change differs from
the upstream PR for now, as a strategy for C++11 in UniValue will take more time.

Jun 4 2020, 17:35
jasonbcox committed rABC91184c7616fc: Merge #13047: [trivial] Tidy blocktools.py (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #13047: [trivial] Tidy blocktools.py
Jun 4 2020, 17:14
jasonbcox closed D6354: Merge #13047: [trivial] Tidy blocktools.py.
Jun 4 2020, 17:14
jasonbcox accepted D6346: init: Add CLI option to enable block filter index..
Jun 4 2020, 17:06
jasonbcox committed rABC53e142a7ed44: Merge #12856: Tests: Add Metaclass for BitcoinTestFramework (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #12856: Tests: Add Metaclass for BitcoinTestFramework
Jun 4 2020, 17:02
jasonbcox closed D6353: Merge #12856: Tests: Add Metaclass for BitcoinTestFramework.
Jun 4 2020, 17:02
jasonbcox requested changes to D6373: [CI] Let build_cmake.sh take a list of targets and use it.
Jun 4 2020, 17:01
jasonbcox accepted D6372: Update multiset hash benchmark to use get_iters.
Jun 4 2020, 16:43
jasonbcox accepted D6371: [CI] Disable jemalloc for running the JNI bindings tests.
Jun 4 2020, 16:24

Jun 3 2020

jasonbcox accepted D6355: Rename Seeder's CAddrInfo -> CSeederAddrInfo.

Since we own the seeder code now, consider new class names to not include the C... prefix. It's not useful.

Jun 3 2020, 23:56
jasonbcox accepted D6351: blockfilter: Update BIP 158 test vectors..
Jun 3 2020, 23:54
jasonbcox accepted D6349: rpc: Add getblockfilter RPC method..

Looks fine, but please investigate why the linter was not applied to the imports.

Jun 3 2020, 23:48
jasonbcox accepted D6358: test: Add RegTestingSetup to setup_common.
Jun 3 2020, 23:36
jasonbcox accepted D6356: test: move-only ComputeFilter to src/test/lib/blockfilter.
Jun 3 2020, 23:34
jasonbcox requested review of D6359: Fix UniValue .write() changes for C++98.
Jun 3 2020, 23:31
jasonbcox committed rABC6172b1663628: Add arcanist land bot workflow (authored by jasonbcox).
Add arcanist land bot workflow
Jun 3 2020, 22:30
jasonbcox closed D6264: Add arcanist land bot workflow.
Jun 3 2020, 22:30
jasonbcox requested review of D6354: Merge #13047: [trivial] Tidy blocktools.py.
Jun 3 2020, 22:02
jasonbcox requested changes to D6346: init: Add CLI option to enable block filter index..
Jun 3 2020, 21:53