Page MenuHomePhabricator
Feed Advanced Search

Jun 24 2020

jasonbcox updated the test plan for D6709: Merge #14658: qa: Add test to ensure node can generate all rpc help texts at runtime.
Jun 24 2020, 18:06
jasonbcox updated the summary of D6709: Merge #14658: qa: Add test to ensure node can generate all rpc help texts at runtime.
Jun 24 2020, 18:05
jasonbcox planned changes to D6709: Merge #14658: qa: Add test to ensure node can generate all rpc help texts at runtime.
Jun 24 2020, 18:05
jasonbcox requested review of D6709: Merge #14658: qa: Add test to ensure node can generate all rpc help texts at runtime.
Jun 24 2020, 18:04
jasonbcox requested review of D6692: [land-bot] Preserve committer name and email.
Jun 24 2020, 17:50
jasonbcox added a comment to D6692: [land-bot] Preserve committer name and email.

Why don't pull the change from the statging repo rather than doing this?

Jun 24 2020, 16:59
jasonbcox committed rABCef043c751567: [land-bot] Skip sanity check during arc patch (authored by jasonbcox).
[land-bot] Skip sanity check during arc patch
Jun 24 2020, 16:40
jasonbcox closed D6691: [land-bot] Skip sanity check during arc patch.
Jun 24 2020, 16:39
jasonbcox committed rABC32a6ebf19d61: Merge #18412: script: fix SCRIPT_ERR_SIG_PUSHONLY error string (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #18412: script: fix SCRIPT_ERR_SIG_PUSHONLY error string
Jun 24 2020, 16:38
jasonbcox closed D6696: Merge #18412: script: fix SCRIPT_ERR_SIG_PUSHONLY error string.
Jun 24 2020, 16:38
jasonbcox committed rABCc1f456c2efad: Merge #11418: Add error string for CLEANSTACK script violation (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Merge #11418: Add error string for CLEANSTACK script violation
Jun 24 2020, 16:38
jasonbcox closed D6697: Merge #11418: Add error string for CLEANSTACK script violation.
Jun 24 2020, 16:37
jasonbcox added a comment to D6692: [land-bot] Preserve committer name and email.

Can you explain how it works ? Are the exported variables interpreted by arc land (I don't see any reference in the doc) ?

Jun 24 2020, 16:27
jasonbcox updated the diff for D6691: [land-bot] Skip sanity check during arc patch.

Add comment

Jun 24 2020, 16:12
jasonbcox requested review of D6697: Merge #11418: Add error string for CLEANSTACK script violation.
Jun 24 2020, 00:51
jasonbcox requested review of D6696: Merge #18412: script: fix SCRIPT_ERR_SIG_PUSHONLY error string.
Jun 24 2020, 00:44
jasonbcox accepted D6693: Make sigcheck violation report invaid rather than non standard.
Jun 24 2020, 00:13
jasonbcox accepted D6694: Do not resuse state in checkpoints_tests.cpp.
Jun 24 2020, 00:06

Jun 23 2020

jasonbcox commandeered D6629: Merge #16152: Disable bloom filtering by default..
Jun 23 2020, 22:24
jasonbcox accepted D6690: [CI] Wrap build_depends.sh on ibd.sh into functions.
Jun 23 2020, 21:46
jasonbcox accepted D6689: [CI] Setup don't need to be a function.

Thank you. This is way less confusing.

Jun 23 2020, 21:45
jasonbcox requested review of D6692: [land-bot] Preserve committer name and email.
Jun 23 2020, 21:41
jasonbcox updated jasonbcox.
Jun 23 2020, 21:12
jasonbcox requested review of D6691: [land-bot] Skip sanity check during arc patch.
Jun 23 2020, 21:10

Jun 22 2020

jasonbcox accepted D6671: Merge #13457: tests: Drop variadic macro.
Jun 22 2020, 18:14
jasonbcox updated the summary of D6667: [DO NOT REVIEW] PATCH TEST 1.
Jun 22 2020, 17:34
jasonbcox planned changes to D6667: [DO NOT REVIEW] PATCH TEST 1.
Jun 22 2020, 17:33
jasonbcox updated the diff for D6667: [DO NOT REVIEW] PATCH TEST 1.

Rebase on D6669

Jun 22 2020, 17:33
jasonbcox updated the summary of D6669: Merge #14051: [Tests] Make combine_logs.py handle multi-line logs.
Jun 22 2020, 17:31
jasonbcox requested review of D6669: Merge #14051: [Tests] Make combine_logs.py handle multi-line logs.
Jun 22 2020, 17:30
jasonbcox planned changes to D6668: [DO NOT REVIEW] PATCH TEST 2.
Jun 22 2020, 16:55
jasonbcox requested review of D6668: [DO NOT REVIEW] PATCH TEST 2.
Jun 22 2020, 16:55
jasonbcox planned changes to D6667: [DO NOT REVIEW] PATCH TEST 1.
Jun 22 2020, 16:54
jasonbcox requested review of D6667: [DO NOT REVIEW] PATCH TEST 1.
Jun 22 2020, 16:54

Jun 20 2020

jasonbcox accepted D6658: [avalanche] Remove blocks not worth pollling from the vote reccords rather than just ignore them.
Jun 20 2020, 03:20

Jun 19 2020

jasonbcox updated the diff for D6653: Merge #18524: refactor: drop boost::signals2 in validationinterface.

Fixed braces

Jun 19 2020, 20:25
jasonbcox added a comment to D6652: Merge #16688: log: Add validation interface logging.

I don't see what is preventing the change to FormatStateMessage to be part of the backport ? AFAIK the massive stack you mention is a class rename but all the changes from the PR can be done now without conflict.

Jun 19 2020, 16:02
jasonbcox accepted D6639: [CI] Install the latest wine version from the winehq repository.
Jun 19 2020, 15:54
jasonbcox requested review of D6655: Merge #18563: test: Fix unregister_all_during_call cleanup.
Jun 19 2020, 01:26
jasonbcox requested review of D6654: Merge #18551: Do not clear validationinterface entries being executed.
Jun 19 2020, 01:24
jasonbcox requested review of D6653: Merge #18524: refactor: drop boost::signals2 in validationinterface.
Jun 19 2020, 01:04
jasonbcox requested review of D6652: Merge #16688: log: Add validation interface logging.
Jun 19 2020, 00:49

Jun 18 2020

jasonbcox committed rABC6f8ecc458ec3: Add cppcheck to base image setup (authored by jasonbcox).
Add cppcheck to base image setup
Jun 18 2020, 23:10
jasonbcox closed D6645: Add cppcheck to base image setup.
Jun 18 2020, 23:10
jasonbcox added a comment to D6644: Merge #18338: Fix wallet unload race condition.

@bot build-without-wallet gitian-linux

Jun 18 2020, 22:29
jasonbcox accepted D6632: Merge #12401: Reset pblocktree before deleting LevelDB file.
Jun 18 2020, 21:19
jasonbcox accepted D6646: Merge #13577: logging: avoid nStart may be used uninitialized in AppInitMain warning.
Jun 18 2020, 21:16
jasonbcox requested changes to D6629: Merge #16152: Disable bloom filtering by default..

I don't think we can make the same assumptions Core is making here. In ~5 months, no ABC nodes will be deployed with NODE_BLOOM unless explicitly set by the operator. This is likely to negatively impact SPV wallets, for which Bitcoin Cash has multiple.

Jun 18 2020, 21:13
jasonbcox accepted D6489: Merge #15486: [addrman, net] Ensure tried collisions resolve, and allow feeler connections to existing outbound netgroups.
Jun 18 2020, 21:07
jasonbcox updated the summary of D6645: Add cppcheck to base image setup.
Jun 18 2020, 19:49
jasonbcox requested review of D6645: Add cppcheck to base image setup.
Jun 18 2020, 19:45
jasonbcox added inline comments to D6549: [LINTER] Check for missing explicit.
Jun 18 2020, 19:44
jasonbcox requested review of D6644: Merge #18338: Fix wallet unload race condition.
Jun 18 2020, 19:43
jasonbcox accepted D6637: [WEB] Add a link to the new Bitcoin ABC Blog.
Jun 18 2020, 18:52
jasonbcox requested changes to D6637: [WEB] Add a link to the new Bitcoin ABC Blog.

Think about where the users eyes travel when they look at a webpage. Highest value content is always top-ish, front-and-center. Lower value is down and/or off to the sides.

Jun 18 2020, 17:56
jasonbcox accepted D6636: [WEB] Add a Developers menu with Contributing and Code coverage.
Jun 18 2020, 17:52
jasonbcox requested changes to D6639: [CI] Install the latest wine version from the winehq repository.
Jun 18 2020, 16:21
jasonbcox requested changes to D6639: [CI] Install the latest wine version from the winehq repository.
Jun 18 2020, 16:05
jasonbcox accepted D6635: [CI] Temporarly fix adoptopenjdk8 failure.
Jun 18 2020, 13:51

Jun 16 2020

jasonbcox requested changes to D6603: Use fewer blocks in abc-miner-fund.py.

This doesn't actually fix the test. From the PR you linked, it's pretty clear that block versioning is the issue, not the number of blocks.

Jun 16 2020, 16:24

Jun 15 2020

jasonbcox committed rABC2403f956bacf: [RPC docs] Fix build paths (authored by jasonbcox).
[RPC docs] Fix build paths
Jun 15 2020, 23:06
jasonbcox closed D6595: [RPC docs] Fix build paths.
Jun 15 2020, 23:06
jasonbcox planned changes to D6596: [RPC docs] Remove unused index files.

It was conflicting with local tests of using nginx to generate a quick index for us prior to having a nicely-formatted index. But you're right, there's probably value in having this if we can fix it up.

Jun 15 2020, 23:04
jasonbcox requested changes to D6597: Merge #15059: test: Add basic test for BIP34.
Jun 15 2020, 22:43
jasonbcox accepted D6576: Always enable sigcheck in the mempool admission.
Jun 15 2020, 21:44
jasonbcox requested review of D6596: [RPC docs] Remove unused index files.
Jun 15 2020, 21:42
jasonbcox requested review of D6595: [RPC docs] Fix build paths.
Jun 15 2020, 21:40
jasonbcox abandoned D6592: Backport doc-gen from bitcoincore.org.
Jun 15 2020, 21:09
jasonbcox committed rABCWEB91754eba80ae: Do not background the process while serving (authored by jasonbcox).
Do not background the process while serving
Jun 15 2020, 21:07
jasonbcox closed D6591: Do not background the process while serving.
Jun 15 2020, 21:07
jasonbcox closed D6589: Remove redundant configs.
Jun 15 2020, 21:06
jasonbcox committed rABCWEB097ee65c4cc1: Remove redundant configs (authored by jasonbcox).
Remove redundant configs
Jun 15 2020, 21:06
jasonbcox committed rABC1df8ec111651: Bump version to 0.21.10 (authored by jasonbcox).
Bump version to 0.21.10
Jun 15 2020, 20:18
jasonbcox closed D6582: Bump version to 0.21.10.
Jun 15 2020, 20:18
jasonbcox updated the diff for D6592: Backport doc-gen from bitcoincore.org.

Fix core -> ABC

Jun 15 2020, 20:17
jasonbcox requested review of D6592: Backport doc-gen from bitcoincore.org.
Jun 15 2020, 20:15
jasonbcox added a comment to D6571: [WIP] Test commit, don't review.

@bot build-without-wallet

Jun 15 2020, 19:46
jasonbcox requested review of D6591: Do not background the process while serving.
Jun 15 2020, 19:45
jasonbcox requested review of D6589: Remove redundant configs.
Jun 15 2020, 19:36
jasonbcox requested review of D6582: Bump version to 0.21.10.
Jun 15 2020, 17:22

Jun 12 2020

jasonbcox accepted D6551: [CI] Prevent ccache crosstalk by building in separate directories.
Jun 12 2020, 22:47
jasonbcox committed rABC4ec14900ef1b: Add a lock on cs_main while modifying the config in setexcessiveblock (authored by jasonbcox).
Add a lock on cs_main while modifying the config in setexcessiveblock
Jun 12 2020, 14:48
jasonbcox closed D6543: Add a lock on cs_main while modifying the config in setexcessiveblock.
Jun 12 2020, 14:48

Jun 11 2020

jasonbcox committed rABC62cc9f5b0bb2: Merge #16092: Don't use global (external) symbols for symbols that are used in… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #16092: Don't use global (external) symbols for symbols that are used in…
Jun 11 2020, 22:28
jasonbcox closed D6514: Merge #16092: Don't use global (external) symbols for symbols that are used in only one translation unit.
Jun 11 2020, 22:28
jasonbcox committed rABCdfd3616955ca: Merge #15622: Remove global symbols: Avoid using the global namespace if… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #15622: Remove global symbols: Avoid using the global namespace if…
Jun 11 2020, 22:21
jasonbcox closed D6516: Merge #15622: Remove global symbols: Avoid using the global namespace if possible.
Jun 11 2020, 22:21
jasonbcox committed rABC54554de6b6cb: Merge #12980: Allow quicker shutdowns during LoadBlockIndex() (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
Merge #12980: Allow quicker shutdowns during LoadBlockIndex()
Jun 11 2020, 22:13
jasonbcox closed D6513: Merge #12980: Allow quicker shutdowns during LoadBlockIndex().
Jun 11 2020, 22:13
jasonbcox requested review of D6543: Add a lock on cs_main while modifying the config in setexcessiveblock.
Jun 11 2020, 22:10
jasonbcox abandoned D6540: Disable DEBUG_LOCKORDER on TSAN builds.
Jun 11 2020, 21:39
jasonbcox committed rABCc5c01c8243f5: Replace automatic bans with discouragement filter (authored by Pieter Wuille <pieter@wuille.net>).
Replace automatic bans with discouragement filter
Jun 11 2020, 21:38
jasonbcox closed D6506: Replace automatic bans with discouragement filter.
Jun 11 2020, 21:38
jasonbcox committed rABCa0c05b6739fe: [CI] Do not enable debug for TSAN builds (authored by jasonbcox).
[CI] Do not enable debug for TSAN builds
Jun 11 2020, 21:36
jasonbcox closed D6541: [CI] Do not enable debug for TSAN builds.
Jun 11 2020, 21:36
jasonbcox updated the test plan for D6541: [CI] Do not enable debug for TSAN builds.
Jun 11 2020, 20:42
jasonbcox requested review of D6541: [CI] Do not enable debug for TSAN builds.
Jun 11 2020, 20:08
jasonbcox planned changes to D6540: Disable DEBUG_LOCKORDER on TSAN builds.
Jun 11 2020, 19:41
jasonbcox requested review of D6540: Disable DEBUG_LOCKORDER on TSAN builds.
Jun 11 2020, 19:41
jasonbcox updated the diff for D6506: Replace automatic bans with discouragement filter.

The original PR was refactored and split into two commits.
I've cut this diff down to just the first commit, as it
contains the behavior change and is easier to review alone.

Jun 11 2020, 02:10