Update Diff description
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Nov 25 2020
Nov 23 2020
Looks good to me as an MVP.
Tested locally, looks good
Nov 21 2020
Yes, this is a big improvement.
Built it locally and had a look, looks good to me
Nov 20 2020
OK, I think this is good as an initial MVP.
Could you put a link in the banner, so that people can navigate to it from the main site?
Oct 28 2020
Oct 27 2020
Oct 26 2020
Aug 24 2020
Aug 19 2020
Aug 18 2020
Aug 15 2020
Aug 11 2020
Aug 6 2020
Aug 5 2020
Jul 31 2020
Jul 30 2020
Jul 26 2020
Jul 24 2020
Jul 23 2020
Jul 22 2020
Jul 2 2020
For reference, same article is posted at
Jun 9 2020
May 20 2020
Although this is already landed, I had a 0.20.12 node synced to the non-upgraded chain, so I took the opportunity to test this Diff, and it behaved as expected.
Apr 7 2020
Mar 14 2020
Mar 13 2020
Checked out the new DNS seeder, seems good to me.
Just the list numbering fix, otherwise seems good to me.
Mar 3 2020
Feb 26 2020
Just a small comment/quibble: The name of the Diff seems misleading to me, it makes it sound like it's just adding a test, not changing behavior. But isn't it actually changing how the code work also?
Feb 15 2020
The Diff title seems to have a spurious "the":
Feb 12 2020
Looks good to me.
Feb 11 2020
Nit: Filename "abc-phonos-disconnectpool.py" should change phonos -> phonon
Feb 9 2020
Feb 8 2020
Feb 6 2020
Jan 20 2020
@tobias_ruck Could you change the name to OP_REVERSEBYTES in the Diff title?
Jan 11 2020
In D4871#117783, @tobias_ruck wrote:Renamed to OP_ENDIAN_REVERSE, reasons can be found in the PR:
In a previous proposal, this opcode has been named OP_REVERSE. After that, it has been renamed to OP_BSWAP, as that is a more technically accurate term, which is commonly used for reversing the byteorder of integers [14] [15]. However, after some more consideration, it has been renamed to OP_ENDIAN_REVERSE following Boost‘s nomenclature [16]. This is because OP_BSWAP is lexically very similar to the already existing OP_SWAP and would make Script harder to read. Also, while the technical term for the instruction is indeed bswap, it isn‘t well known for developers of higher level languages and could thus spark confusion that would be avoided by using the name OP_ENDIAN_REVERSE, which is more self-descriptive.
Also added tests for unexecuted branches, clarified tests for not yet activated case.
Merged D4859 into this diff.
Jan 8 2020
In D4871#117550, @tobias_ruck wrote:I‘ve left the SCRIPT_ENABLE_OP_BSWAP flag at bit 22, this should be coordinated with @markblundeberg
@tobias_ruck something is mangled with this Diff. Did you amend the previous Git commit? (You should amend) Or just add another commit?
Jan 7 2020
@Fabien Should Cmake build instructions be added to the secp256k1 readme at /src/secp256k1/README.md ?
It currently has the autotools build instructions