Page MenuHomePhabricator
Feed All Stories

Jan 15 2021

PiRK requested review of D8927: test: shift coverage from getunconfirmedbalance to getbalances.
Jan 15 2021, 09:48
teamcity awarded D8926: Remove useless calls to setexcessiveblock in extended tests a Haypence token.
Jan 15 2021, 09:06
Fabien added a comment to D8926: Remove useless calls to setexcessiveblock in extended tests.

@bot build-master

Jan 15 2021, 09:05
Fabien requested review of D8926: Remove useless calls to setexcessiveblock in extended tests.
Jan 15 2021, 09:05
PiRK updated the summary of D8925: test: add rpc_signrawtransaction logging.
Jan 15 2021, 08:56
PiRK published D8925: test: add rpc_signrawtransaction logging for review.
Jan 15 2021, 08:56
teamcity triaged T1438: Build Bitcoin-ABC / Master / Coverage is broken. as Unbreak Now! priority.
Jan 15 2021, 08:51
Fabien accepted D8922: test: Check that the version message does not leak the local address of the node.
Jan 15 2021, 08:34
teamcity updated the summary of D8924: doc: default minconf for getbalance should be 0.
Jan 15 2021, 08:34
PiRK requested review of D8924: doc: default minconf for getbalance should be 0.
Jan 15 2021, 08:33
Fabien requested changes to D8921: [backport#16380] Remove unused bits from the service flags enum.

You're missing the message.py declaration

Jan 15 2021, 08:32
teamcity updated the summary of D8923: test: Extend wallet_dump test to cover comments.
Jan 15 2021, 08:17
PiRK requested review of D8923: test: Extend wallet_dump test to cover comments.
Jan 15 2021, 08:17
Fabien accepted D8917: [consensus] MOVEONLY: Move single-sig checking EvalScript code to EvalChecksig.
Jan 15 2021, 08:16
Fabien closed D8918: Deprecate the `setexcessiveblock` RPC.
Jan 15 2021, 08:03
Fabien committed rABC953dbd5f2d1b: Deprecate the `setexcessiveblock` RPC (authored by Fabien).
Deprecate the `setexcessiveblock` RPC
Jan 15 2021, 08:03
teamcity updated the summary of D8922: test: Check that the version message does not leak the local address of the node.
Jan 15 2021, 06:56
PiRK requested review of D8922: test: Check that the version message does not leak the local address of the node.
Jan 15 2021, 06:56
PiRK closed D8920: test: Remove REJECT message code.
Jan 15 2021, 06:24
PiRK committed rABCb852a921a3d5: test: Remove REJECT message code (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
test: Remove REJECT message code
Jan 15 2021, 06:24
PiRK closed D8919: rpc: Remove deprecated migration code.
Jan 15 2021, 06:16
PiRK committed rABCfe5862ed7191: rpc: Remove deprecated migration code (authored by Vasil Dimov <vd@FreeBSD.org>).
rpc: Remove deprecated migration code
Jan 15 2021, 06:16

Jan 14 2021

bytesofman updated the diff for D8907: [Cashtab] parse sats from scanned qr code amount param.

New unit test & fix package-lock.json build

Jan 14 2021, 21:34
teamcity added a comment to D8907: [Cashtab] parse sats from scanned qr code amount param.
Jan 14 2021, 21:19
teamcity added a comment to D8907: [Cashtab] parse sats from scanned qr code amount param.
Jan 14 2021, 21:16
bytesofman updated the diff for D8907: [Cashtab] parse sats from scanned qr code amount param.

Add unit test for isToken()

Jan 14 2021, 21:16
bytesofman updated the diff for D8907: [Cashtab] parse sats from scanned qr code amount param.

Adding unit tests for new address methods

Jan 14 2021, 21:14
Fabien requested changes to D8907: [Cashtab] parse sats from scanned qr code amount param.

You have a rebase issue, this diff includes changes from D8905. Also the tests are still missing.

Jan 14 2021, 19:36
bytesofman updated the diff for D8907: [Cashtab] parse sats from scanned qr code amount param.

Bump extension version. Will submit this to Chrome store so extension can work with mercurymessenger.io.

Jan 14 2021, 19:15
majcosta accepted D8918: Deprecate the `setexcessiveblock` RPC.
Jan 14 2021, 17:43
teamcity updated the summary of D8921: [backport#16380] Remove unused bits from the service flags enum.
Jan 14 2021, 17:43
majcosta requested review of D8921: [backport#16380] Remove unused bits from the service flags enum.
Jan 14 2021, 17:42
bytesofman updated the diff for D8907: [Cashtab] parse sats from scanned qr code amount param.

Moving parsing logic to form level and not QR code to support copy pasted and scanned ecash addr and params.
Added validation to Send.js and SendToken.js address fields in line with new params and valid addresses.
Added warning notices to Send.js and SendToken.js on detection of address params.

Jan 14 2021, 17:30
majcosta accepted D8920: test: Remove REJECT message code.
Jan 14 2021, 17:15
majcosta accepted D8919: rpc: Remove deprecated migration code.
Jan 14 2021, 17:13
PiRK updated the test plan for D8920: test: Remove REJECT message code.
Jan 14 2021, 17:06
teamcity updated the summary of D8920: test: Remove REJECT message code.
Jan 14 2021, 17:05
PiRK requested review of D8920: test: Remove REJECT message code.
Jan 14 2021, 17:05
teamcity updated the summary of D8919: rpc: Remove deprecated migration code.
Jan 14 2021, 16:31
PiRK requested review of D8919: rpc: Remove deprecated migration code.
Jan 14 2021, 16:31
PiRK closed D8912: cli -getinfo: use getbalances instead of deprecated getwalletinfo balance.
Jan 14 2021, 16:25
PiRK committed rABCe5977fde2198: cli -getinfo: use getbalances instead of deprecated getwalletinfo balance (authored by Jon Atack <jon@atack.com>).
cli -getinfo: use getbalances instead of deprecated getwalletinfo balance
Jan 14 2021, 16:25
PiRK closed D8911: rpc: Make verifychain default values static, not depend on global args.
Jan 14 2021, 16:18
PiRK committed rABC6620ec6c59e6: rpc: Make verifychain default values static, not depend on global args (authored by MarcoFalke <falke.marco@gmail.com>).
rpc: Make verifychain default values static, not depend on global args
Jan 14 2021, 16:17
bytesofman added a comment to D8907: [Cashtab] parse sats from scanned qr code amount param.

Yes, good point. When I put this together yesterday, in my head I thought the copy-paste parse would need to be a separate diff and it was worth getting the QR scanner out first.

Jan 14 2021, 15:47
majcosta closed D8914: [backport#17453] gui: Fix intro dialog labels when the prune button is toggled.
Jan 14 2021, 15:38
majcosta committed rABCfbd564ae6a78: [backport#17453] gui: Fix intro dialog labels when the prune button is toggled (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
[backport#17453] gui: Fix intro dialog labels when the prune button is toggled
Jan 14 2021, 15:38
majcosta closed D8916: [backport#15874] Resolve the qt/guiutil <-> qt/optionsmodel CD.
Jan 14 2021, 15:38
majcosta committed rABCfc8c7fd5b1fa: [backport#15874] Resolve the qt/guiutil <-> qt/optionsmodel CD (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
[backport#15874] Resolve the qt/guiutil <-> qt/optionsmodel CD
Jan 14 2021, 15:38
Fabien requested changes to D8907: [Cashtab] parse sats from scanned qr code amount param.

More a question, but why limiting this parsing to QR code only ? Couldn't this be done at the lower level so the copying ecash:xxxx?amount=NNN into the address input field would behave the same ?

Jan 14 2021, 15:22
bytesofman updated the diff for D8907: [Cashtab] parse sats from scanned qr code amount param.

Rebase

Jan 14 2021, 15:14
Fabien requested review of D8918: Deprecate the `setexcessiveblock` RPC.
Jan 14 2021, 14:51
PiRK accepted D8914: [backport#17453] gui: Fix intro dialog labels when the prune button is toggled.
Jan 14 2021, 14:46
PiRK accepted D8916: [backport#15874] Resolve the qt/guiutil <-> qt/optionsmodel CD.
Jan 14 2021, 14:43
majcosta updated the diff for D8914: [backport#17453] gui: Fix intro dialog labels when the prune button is toggled.

rebase on top of D8916 which fixes the circular dependency h/t @PiRK

Jan 14 2021, 14:41
Fabien closed D8915: Add a test for the banscore deprecation.
Jan 14 2021, 14:40
Fabien committed rABCe811b1ca77f7: Add a test for the banscore deprecation (authored by Fabien).
Add a test for the banscore deprecation
Jan 14 2021, 14:40
majcosta closed D8913: [backport#17696] qt: Force set nPruneSize in QSettings after the intro dialog.
Jan 14 2021, 14:39
majcosta committed rABC6a7934983f7f: [backport#17696] qt: Force set nPruneSize in QSettings after the intro dialog (authored by fanquake <fanquake@gmail.com>).
[backport#17696] qt: Force set nPruneSize in QSettings after the intro dialog
Jan 14 2021, 14:39
teamcity updated the summary of D8917: [consensus] MOVEONLY: Move single-sig checking EvalScript code to EvalChecksig.
Jan 14 2021, 14:38
PiRK requested review of D8917: [consensus] MOVEONLY: Move single-sig checking EvalScript code to EvalChecksig.
Jan 14 2021, 14:38
teamcity updated the summary of D8916: [backport#15874] Resolve the qt/guiutil <-> qt/optionsmodel CD.
Jan 14 2021, 14:38
majcosta accepted D8915: Add a test for the banscore deprecation.
Jan 14 2021, 14:37
majcosta requested review of D8916: [backport#15874] Resolve the qt/guiutil <-> qt/optionsmodel CD.
Jan 14 2021, 14:37
majcosta accepted D8912: cli -getinfo: use getbalances instead of deprecated getwalletinfo balance.
Jan 14 2021, 14:37
Fabien updated the diff for D8915: Add a test for the banscore deprecation.

Rebase

Jan 14 2021, 14:08
Fabien planned changes to D8915: Add a test for the banscore deprecation.
Jan 14 2021, 14:06
PiRK closed D8910: Remove PID file at the very end.
Jan 14 2021, 14:01
PiRK committed rABC3393b7018419: Remove PID file at the very end (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
Remove PID file at the very end
Jan 14 2021, 14:01
PiRK updated the diff for D8912: cli -getinfo: use getbalances instead of deprecated getwalletinfo balance.

deduplicate line and add PR number to revision

Jan 14 2021, 14:01
PiRK updated the summary of D8912: cli -getinfo: use getbalances instead of deprecated getwalletinfo balance.
Jan 14 2021, 13:57
majcosta added a comment to D8912: cli -getinfo: use getbalances instead of deprecated getwalletinfo balance.

also "Backport of PR18574" is missing from summary

Jan 14 2021, 13:54
majcosta requested changes to D8912: cli -getinfo: use getbalances instead of deprecated getwalletinfo balance.
Jan 14 2021, 13:53
majcosta accepted D8910: Remove PID file at the very end.
Jan 14 2021, 13:50
majcosta accepted D8911: rpc: Make verifychain default values static, not depend on global args.
Jan 14 2021, 13:49
PiRK requested changes to D8914: [backport#17453] gui: Fix intro dialog labels when the prune button is toggled.

PR15874 seems to be the missing backport

Jan 14 2021, 13:42
Fabien requested review of D8915: Add a test for the banscore deprecation.
Jan 14 2021, 13:36
teamcity added a comment to D8914: [backport#17453] gui: Fix intro dialog labels when the prune button is toggled.
Jan 14 2021, 13:26
PiRK accepted D8913: [backport#17696] qt: Force set nPruneSize in QSettings after the intro dialog.
Jan 14 2021, 13:19
PiRK updated the diff for D8910: Remove PID file at the very end.

move node.args = nullptr; after fs::remove(GetPidFile(*node.args)) (see PR19779 / D8646))

Jan 14 2021, 13:10
teamcity updated the summary of D8914: [backport#17453] gui: Fix intro dialog labels when the prune button is toggled.
Jan 14 2021, 13:04
majcosta updated the summary of D8914: [backport#17453] gui: Fix intro dialog labels when the prune button is toggled.
Jan 14 2021, 13:03
majcosta requested review of D8914: [backport#17453] gui: Fix intro dialog labels when the prune button is toggled.
Jan 14 2021, 13:03
teamcity updated the summary of D8913: [backport#17696] qt: Force set nPruneSize in QSettings after the intro dialog.
Jan 14 2021, 13:02
majcosta requested review of D8913: [backport#17696] qt: Force set nPruneSize in QSettings after the intro dialog.
Jan 14 2021, 13:02
Fabien closed D8908: Fix a -Wunused-variable in the locale fuzzer.
Jan 14 2021, 13:01
Fabien committed rABCf05eb5a011cb: Fix a -Wunused-variable in the locale fuzzer (authored by Fabien).
Fix a -Wunused-variable in the locale fuzzer
Jan 14 2021, 13:01
bytesofman added a comment to D8811: [cashtab] Upgrade node modules.

I think this diff is now obsolete. Package updates and dependencies have been handled in other diffs, most recently D8905.

Jan 14 2021, 12:45
PiRK planned changes to D8910: Remove PID file at the very end.
Jan 14 2021, 12:44
Joey King <joseph.roy.king@gmail.com> closed D8905: Moving dev dependencies to dev, removing unused deps, updates some of them.
Jan 14 2021, 12:40
Joey King <joseph.roy.king@gmail.com> committed rABCd188a658d95d: Moving dev dependencies to dev, removing unused deps, updates some of them (authored by Joey King <joseph.roy.king@gmail.com>).
Moving dev dependencies to dev, removing unused deps, updates some of them
Jan 14 2021, 12:40
PiRK requested review of D8912: cli -getinfo: use getbalances instead of deprecated getwalletinfo balance.
Jan 14 2021, 12:30
bytesofman updated the diff for D8907: [Cashtab] parse sats from scanned qr code amount param.

Move address parser checks into functions, add checksum conversion for ecash prefix

Jan 14 2021, 12:24
teamcity updated the summary of D8911: rpc: Make verifychain default values static, not depend on global args.
Jan 14 2021, 12:09
PiRK requested review of D8911: rpc: Make verifychain default values static, not depend on global args.
Jan 14 2021, 12:09
majcosta requested changes to D8910: Remove PID file at the very end.

tests failing

Jan 14 2021, 11:58
PiRK closed D8894: Update -blocksonly documentation.
Jan 14 2021, 11:49
PiRK committed rABCd5a049238ea5: Update -blocksonly documentation (authored by glowang).
Update -blocksonly documentation
Jan 14 2021, 11:49
majcosta accepted D8908: Fix a -Wunused-variable in the locale fuzzer.
Jan 14 2021, 11:34
majcosta accepted D8905: Moving dev dependencies to dev, removing unused deps, updates some of them.
Jan 14 2021, 11:29