Page MenuHomePhabricator
Feed Advanced Search

Oct 14 2024

Fabien requested changes to D16906: [ecash-herald] Stop handling block connected event.

For the next follow-up: you can remove the memoryCache entry for the block status as well as it's no longer needed

Oct 14 2024, 20:22
Fabien accepted D16905: [seeder] Remove variable that is never read.
Oct 14 2024, 19:33
Fabien accepted D16904: [seeder] Get rid of pointless `wait` variable and params.

There clearly was an attempt to make the thread sleep longer if there is no processing to do, but the implementation failed. In any case > 5s of delay should be enough to not create any meaningful load on the CPU even with hundreds of crawlers.

Oct 14 2024, 19:32
Fabien requested changes to D16896: [Cashtab] Support testnet with env variable.

The address handling seems incomplete but otherwise looks ok

Oct 14 2024, 19:22
Fabien accepted D16499: [seeder] Make unreliable node reasons clear and consistent.
Oct 14 2024, 19:14
Fabien closed D16901: [doc] Add pytest to the required dependencies.
Oct 14 2024, 18:58
Fabien committed rABCd6d1d19a434e: [doc] Add pytest to the required dependencies (authored by Fabien).
[doc] Add pytest to the required dependencies
Oct 14 2024, 18:58
Fabien closed D16903: Bump version to 0.30.3.
Oct 14 2024, 18:58
Fabien committed rABC7af303ca3281: Bump version to 0.30.3 (authored by Fabien).
Bump version to 0.30.3
Oct 14 2024, 18:58
Fabien updated the summary of D16902: Deprecate the ARM (32 bits) variant.
Oct 14 2024, 12:57
Fabien updated the diff for D16902: Deprecate the ARM (32 bits) variant.

Add a release note

Oct 14 2024, 12:57
Fabien requested review of D16903: Bump version to 0.30.3.
Oct 14 2024, 12:49
Fabien added a comment to D16902: Deprecate the ARM (32 bits) variant.

This will need a release note

Oct 14 2024, 10:25
Fabien requested review of D16902: Deprecate the ARM (32 bits) variant.
Oct 14 2024, 10:25
Fabien requested review of D16901: [doc] Add pytest to the required dependencies.
Oct 14 2024, 10:10

Oct 12 2024

Fabien accepted D16897: add missing cstdint include in iguana_formatter.h.
Oct 12 2024, 09:46

Oct 11 2024

Fabien accepted D16895: [e.cash] Fix up some wordings on Build page.
Oct 11 2024, 17:12
Fabien accepted D16894: [explorer] Improve faucet success message.
Oct 11 2024, 17:12
Fabien closed D16893: Bump version to 0.30.2.
Oct 11 2024, 09:34
Fabien committed rABC26ec213726be: Bump version to 0.30.2 (authored by Fabien).
Bump version to 0.30.2
Oct 11 2024, 09:34
Fabien requested review of D16893: Bump version to 0.30.2.
Oct 11 2024, 09:25
Fabien closed D16889: [chronik] Add a test for invalidated blocks on a parked chain.
Oct 11 2024, 07:51
Fabien committed rABC0fb8fe8b3e1e: [chronik] Add a test for invalidated blocks on a parked chain (authored by Fabien).
[chronik] Add a test for invalidated blocks on a parked chain
Oct 11 2024, 07:51
Fabien added inline comments to D16889: [chronik] Add a test for invalidated blocks on a parked chain.
Oct 11 2024, 07:50

Oct 10 2024

Fabien accepted D16890: [explorer] testnet faucet page.
Oct 10 2024, 21:57
Fabien requested changes to D16890: [explorer] testnet faucet page.
Oct 10 2024, 21:22
Fabien added a comment to D16890: [explorer] testnet faucet page.

@bot preview-explorer

Oct 10 2024, 21:10
Fabien accepted D16888: Merge bitcoin/bitcoin#27177: test: fix intermittent issue in `feature_bip68_sequence`.
Oct 10 2024, 21:08
Fabien requested changes to D16881: Improve performance of p2p inv to send queues.
Oct 10 2024, 20:59
Fabien accepted D16887: [Cashtab] Default to variable supply for token creation.
Oct 10 2024, 20:57
Fabien requested review of D16889: [chronik] Add a test for invalidated blocks on a parked chain.
Oct 10 2024, 20:54
Fabien closed D16886: [chronik] Gracefully handle invalidated block with no undo data.
Oct 10 2024, 16:53
Fabien committed rABCf04553696cad: [chronik] Gracefully handle invalidated block with no undo data (authored by Fabien).
[chronik] Gracefully handle invalidated block with no undo data
Oct 10 2024, 16:53
Fabien requested review of D16886: [chronik] Gracefully handle invalidated block with no undo data.
Oct 10 2024, 15:45
Fabien closed D16884: [explorer] Change the chonik backend.
Oct 10 2024, 14:23
Fabien committed rABC3b1ef7c39593: [explorer] Change the chonik backend (authored by Fabien).
[explorer] Change the chonik backend
Oct 10 2024, 14:23
Fabien requested review of D16884: [explorer] Change the chonik backend.
Oct 10 2024, 14:22
Fabien accepted D16883: [electrum] rename migrate_data.py to update.py and fix module docstring.
Oct 10 2024, 12:14
Fabien requested changes to D16881: Improve performance of p2p inv to send queues.
Oct 10 2024, 12:14
Fabien closed D16882: [CI] Don't build iguana for archlinux and debian packages.
Oct 10 2024, 11:19
Fabien committed rABC47c98cb0f373: [CI] Don't build iguana for archlinux and debian packages (authored by Fabien).
[CI] Don't build iguana for archlinux and debian packages
Oct 10 2024, 11:19
Fabien requested review of D16882: [CI] Don't build iguana for archlinux and debian packages.
Oct 10 2024, 09:48
Fabien committed rABC3b26649cd927: Bump version to 0.30.1 (authored by Fabien).
Bump version to 0.30.1
Oct 10 2024, 07:43
Fabien committed rABC5a3dd8183dfc: p2p: Avoid prematurely clearing download state for other peers (authored by Suhas Daftuar <sdaftuar@chaincode.com>).
p2p: Avoid prematurely clearing download state for other peers
Oct 10 2024, 07:09
Fabien committed rABC2701a514b014: Avoid headers assertions in the compact block workflow (authored by Fabien).
Avoid headers assertions in the compact block workflow
Oct 10 2024, 06:51
Fabien closed D16877: [faucet] Help typescript to infer the type of an empty array.
Oct 10 2024, 06:51
Fabien committed rABC0edc15f825e9: [faucet] Help typescript to infer the type of an empty array (authored by Fabien).
[faucet] Help typescript to infer the type of an empty array
Oct 10 2024, 06:51

Oct 9 2024

Fabien requested review of D16877: [faucet] Help typescript to infer the type of an empty array.
Oct 9 2024, 19:02
Fabien accepted D16876: [avalanche] Add test case of vote status for manually added stake winner.
Oct 9 2024, 18:39

Oct 8 2024

Fabien accepted D16868: [token-server + cashtab] Implement recaptcha for token rewards.
Oct 8 2024, 20:10
Fabien closed D16872: [explorer] Switch the testnet explorer to the final URL.
Oct 8 2024, 19:59
Fabien committed rABCc51c04a3267c: [explorer] Switch the testnet explorer to the final URL (authored by Fabien).
[explorer] Switch the testnet explorer to the final URL
Oct 8 2024, 19:59
Fabien accepted D16869: [token-server] Remove duplicated test.
Oct 8 2024, 19:59
Fabien requested review of D16872: [explorer] Switch the testnet explorer to the final URL.
Oct 8 2024, 19:57
Fabien closed D16870: [chronik-doc] Update the to final URL.
Oct 8 2024, 19:51
Fabien committed rABC2df0a8a49605: [chronik-doc] Update the to final URL (authored by Fabien).
[chronik-doc] Update the to final URL
Oct 8 2024, 19:51
Fabien requested review of D16870: [chronik-doc] Update the to final URL.
Oct 8 2024, 19:45
Fabien closed D16867: Build a package for Ubuntu 24.04 "Noble Numbat".
Oct 8 2024, 18:38
Fabien committed rABC05ae3ef39bef: Build a package for Ubuntu 24.04 "Noble Numbat" (authored by Fabien).
Build a package for Ubuntu 24.04 "Noble Numbat"
Oct 8 2024, 18:38
Fabien closed D16865: [faucet] Add a faucet application.
Oct 8 2024, 18:37
Fabien committed rABC3d313ee39669: [faucet] Add a faucet application (authored by Fabien).
[faucet] Add a faucet application
Oct 8 2024, 18:37
Fabien added inline comments to D16865: [faucet] Add a faucet application.
Oct 8 2024, 18:37
Fabien updated the diff for D16865: [faucet] Add a faucet application.

Feedback

Oct 8 2024, 18:21
Fabien requested review of D16867: Build a package for Ubuntu 24.04 "Noble Numbat".
Oct 8 2024, 18:11
Fabien added inline comments to D16865: [faucet] Add a faucet application.
Oct 8 2024, 17:58
Fabien accepted D16866: [chronik] remove outdated comment for enable_lokad_id_index.
Oct 8 2024, 16:38
Fabien updated the test plan for D16865: [faucet] Add a faucet application.
Oct 8 2024, 14:26
Fabien updated the diff for D16865: [faucet] Add a faucet application.

Fix the rate limit applying to the balance endpoint due to route conflict, and fix the npm start script

Oct 8 2024, 14:26
Fabien planned changes to D16865: [faucet] Add a faucet application.
Oct 8 2024, 14:20
Fabien updated the test plan for D16865: [faucet] Add a faucet application.
Oct 8 2024, 14:19
Fabien requested review of D16865: [faucet] Add a faucet application.
Oct 8 2024, 14:18

Oct 7 2024

Fabien closed D16826: [herald] Show invalidated blocks.
Oct 7 2024, 19:56
Fabien committed rABC43f19a37b28f: [herald] Show invalidated blocks (authored by Fabien).
[herald] Show invalidated blocks
Oct 7 2024, 19:56
Fabien added inline comments to D16826: [herald] Show invalidated blocks.
Oct 7 2024, 19:56
Fabien closed D16863: [herald] Generate a block mock file that passes the linter.
Oct 7 2024, 19:55
Fabien committed rABC2343eaf87839: [herald] Generate a block mock file that passes the linter (authored by Fabien).
[herald] Generate a block mock file that passes the linter
Oct 7 2024, 19:55
Fabien requested review of D16863: [herald] Generate a block mock file that passes the linter.
Oct 7 2024, 19:50
Fabien updated the diff for D16826: [herald] Show invalidated blocks.

Feedback

Oct 7 2024, 19:49
Fabien added inline comments to D16826: [herald] Show invalidated blocks.
Oct 7 2024, 18:20
Fabien published D16826: [herald] Show invalidated blocks for review.
Oct 7 2024, 15:08
Fabien closed D16861: [herald] Fix parsing of the staking reward winner.
Oct 7 2024, 15:06
Fabien committed rABC4a1e75ee7025: [herald] Fix parsing of the staking reward winner (authored by Fabien).
[herald] Fix parsing of the staking reward winner
Oct 7 2024, 15:06
Fabien closed D16862: [herald] Fix the headers, lint the package.
Oct 7 2024, 15:06
Fabien committed rABCe36e63a307a6: [herald] Fix the headers, lint the package (authored by Fabien).
[herald] Fix the headers, lint the package
Oct 7 2024, 15:06
Fabien updated the diff for D16862: [herald] Fix the headers, lint the package.

Simplify the regex

Oct 7 2024, 13:24
Fabien added inline comments to D16862: [herald] Fix the headers, lint the package.
Oct 7 2024, 13:22
Fabien requested review of D16862: [herald] Fix the headers, lint the package.
Oct 7 2024, 08:56
Fabien requested review of D16861: [herald] Fix parsing of the staking reward winner.
Oct 7 2024, 08:39

Oct 4 2024

Fabien accepted D16859: Add link to credit paper in RTT comment.
Oct 4 2024, 17:34
Fabien accepted D16858: [token-server] Reject queries with insufficient recaptcha score.
Oct 4 2024, 17:29
Fabien closed D16857: Fix a race condition in the validation_chainstatemanager_tests.
Oct 4 2024, 08:59
Fabien committed rABC69ac51d4fd25: Fix a race condition in the validation_chainstatemanager_tests (authored by Fabien).
Fix a race condition in the validation_chainstatemanager_tests
Oct 4 2024, 08:59
Fabien requested review of D16857: Fix a race condition in the validation_chainstatemanager_tests.
Oct 4 2024, 08:32

Oct 3 2024

Fabien accepted D16854: [token-server + cashtab] Implement captchas for free XEC rewards.
Oct 3 2024, 19:55
Fabien changed the visibility for D16823: [avalanche] Activate heartbeat on November 15, 2024.
Oct 3 2024, 19:26
Fabien accepted D16837: [avalanche] Add a way to get stake contender vote status.
Oct 3 2024, 17:17
Fabien closed D16853: [iguana] Run the tests when cross compiled.
Oct 3 2024, 15:32
Fabien committed rABCea210968afce: [iguana] Run the tests when cross compiled (authored by Fabien).
[iguana] Run the tests when cross compiled
Oct 3 2024, 15:32
Fabien accepted D16852: [Iguana] Add `-format=csv` to iguana.
Oct 3 2024, 15:31
Fabien accepted D16851: [Iguana] Refactor interpreter and formatter.
Oct 3 2024, 15:27