Page MenuHomePhabricator
Feed Advanced Search

Nov 26 2024

emack requested changes to D17186: [cashtab] UI Overhaul.
Nov 26 2024, 10:31

Nov 25 2024

emack accepted D17196: [bip21] Introduce a spec for supporting simple token send txs.
Nov 25 2024, 03:57
emack accepted D17195: [ecash-herald] Add network staking info to daily summaries.
Nov 25 2024, 01:45
emack added a comment to D17196: [bip21] Introduce a spec for supporting simple token send txs.

is the exclusion of non-send token txs on the basis that they're not a use case for QR payments?

Nov 25 2024, 01:28

Nov 24 2024

emack accepted D17180: [ecash-herald] Add staker info to block msgs.
Nov 24 2024, 12:48
emack accepted D17192: [Cashtab] Support ALP tokens.
Nov 24 2024, 11:23

Nov 23 2024

emack accepted D17191: [Cashtab] CreateTokenForm to typescript.
Nov 23 2024, 01:38
emack accepted D17188: [Cashtab] Use available sk and pk rather than deriving from wif and ecc.
Nov 23 2024, 01:16

Nov 22 2024

emack accepted D17168: [Cashtab] Migrate to new wallet shape that includes ecash-lib-ready sk and pk.
Nov 22 2024, 09:34

Nov 21 2024

emack requested changes to D17168: [Cashtab] Migrate to new wallet shape that includes ecash-lib-ready sk and pk.
Nov 21 2024, 23:53
emack accepted D17177: [chronik-client] Support isFinal key for Tx.
Nov 21 2024, 23:20
emack accepted D17170: [ecashaddrjs] Stop using buffer and webpack.
Nov 21 2024, 22:22
emack accepted D17175: [ecash-herald] Get arc lint to work for ts.
Nov 21 2024, 05:08
emack accepted D17176: [ecash-herald] Show less info in daily msgs.
Nov 21 2024, 05:03
emack accepted D17154: [Cashtab] Convert Token, validation, and other deps to ts.
Nov 21 2024, 05:03
emack accepted D17173: [alias-server] Patch CI failures caused by Mongo Memory Server dep.
Nov 21 2024, 05:01
emack accepted D17174: [token-server] Fix ts lint and add to arc lint.
Nov 21 2024, 04:37
emack requested changes to D17154: [Cashtab] Convert Token, validation, and other deps to ts.
Nov 21 2024, 04:16

Nov 20 2024

emack accepted D17164: [ecash-herald] Patch bug in tracking per-token agora volume.
Nov 20 2024, 06:25

Nov 17 2024

emack accepted D17153: [Cashtab] Convert OrderBook component to ts as prep for adding websocket support.
Nov 17 2024, 02:54

Nov 16 2024

emack accepted D17140: [Cashtab] More ts implementation as prep for wallet upgrade.
Nov 16 2024, 14:01
emack accepted D17146: [Cashtab] Show NFT offer on token page.
Nov 16 2024, 13:58
emack requested changes to D17140: [Cashtab] More ts implementation as prep for wallet upgrade.
Nov 16 2024, 12:01
emack requested changes to D17146: [Cashtab] Show NFT offer on token page.
Nov 16 2024, 11:41

Nov 14 2024

emack accepted D17136: [ecash-herald] Standardize the way we convert satoshi values to formatted amounts.
Nov 14 2024, 12:40
emack accepted D17128: [Cashtab] More improvements to agora partial sale tx parsing.
Nov 14 2024, 10:32

Nov 13 2024

emack added a comment to D17128: [Cashtab] More improvements to agora partial sale tx parsing.

summary and test plan are still TBD?

Nov 13 2024, 21:47
emack accepted D17122: [Cashtab] Convert agora screen to typescript.
Nov 13 2024, 10:47
emack accepted D17127: [Cashtab] Modify csp headers to allow base64 font used in swiper.
Nov 13 2024, 07:03
emack accepted D17126: [Cashtab] Add type deps for ts conversion.
Nov 13 2024, 01:50
emack accepted D17123: [Cashtab] Remove redundant spinner from agora screen.
Nov 13 2024, 01:48

Nov 12 2024

emack accepted D17120: [Cashtab] Patch bug in tx parsing to correctly parse agora partial sales.
Nov 12 2024, 23:27
emack accepted D17119: [ecash-herald] Present daily total volume for agora.
Nov 12 2024, 23:11
emack accepted D17118: [ecash-herald] Lint for typescript.
Nov 12 2024, 23:04
emack accepted D17074: [Cashtab] Add Collection component to better organize and render NFTs.
Nov 12 2024, 22:53

Nov 10 2024

emack requested changes to D17074: [Cashtab] Add Collection component to better organize and render NFTs.
Nov 10 2024, 01:28

Nov 8 2024

emack accepted D17103: [Cashtab] Patch ts bug in button components and propagate type.
Nov 8 2024, 13:44
emack accepted D17102: [Cashtab] Patch unit test in wallet.
Nov 8 2024, 13:42
emack accepted D17101: [Cashtab] Correct tx history parsing of nft parent mint txs.
Nov 8 2024, 13:39
emack accepted D17099: [Cashtab] Patch overflow issues in Agora from long names and tickers.
Nov 8 2024, 13:07
emack accepted D17100: [Cashtab] slpv1 to ts.
Nov 8 2024, 10:04
emack accepted D17097: [Cashtab] Support minting additional NFT Parent tokens.
Nov 8 2024, 03:33
emack requested changes to D17091: [Cashtab] Upgrade slpv1 methods to ts.

Build aint healthy

Nov 8 2024, 03:32
emack accepted D17093: [Cashtab] Update and implement jest setup file.
Nov 8 2024, 03:03

Nov 7 2024

emack requested changes to D17091: [Cashtab] Upgrade slpv1 methods to ts.
Nov 7 2024, 10:34
emack requested changes to D17097: [Cashtab] Support minting additional NFT Parent tokens.
Nov 7 2024, 10:25
emack accepted D17096: [Cashtab] Improve styles for button components.
Nov 7 2024, 10:17
emack requested changes to D17093: [Cashtab] Update and implement jest setup file.

src/components/Swap/Swap.js: const sideshift = window.sideshift;

Nov 7 2024, 10:09
emack accepted D17080: [Cashtab] Wallet methods to ts.
Nov 7 2024, 10:01

Nov 6 2024

emack published D17087: [Cashtab] Alternate token icon source for animated images for review.
Nov 6 2024, 13:38
emack accepted D17083: [Cashtab] Add canvas mock to prevent annoying jest debug logs.
Nov 6 2024, 11:33
emack accepted D17081: [Cashtab] Add fn and test cases for agora oneshot fuel inputs.
Nov 6 2024, 11:05
emack requested changes to D17080: [Cashtab] Wallet methods to ts.
Nov 6 2024, 07:37
emack accepted D17084: [Cashtab] Add a jest setup file to avoid repeating global mocks.
Nov 6 2024, 07:30
emack accepted D17079: [Cashtab] Migrate CashtabSettings to ts.
Nov 6 2024, 03:10
emack accepted D17078: [Cashtab] Convert CashtabCache to ts.
Nov 6 2024, 03:06

Nov 5 2024

emack accepted D17072: [ecash-agora] Update linter settings for monorepo consistency.
Nov 5 2024, 06:24
emack requested changes to D17072: [ecash-agora] Update linter settings for monorepo consistency.
Nov 5 2024, 04:18

Nov 4 2024

emack accepted D17065: [ecash-herald + token-server] Update typescript and docker build settings.
Nov 4 2024, 00:51
emack accepted D17063: [Cashtab] Patch bug in manage agora offers.
Nov 4 2024, 00:43

Nov 3 2024

emack accepted D17064: [Cashtab] Add OrderBook (with no icon) to token info page.
Nov 3 2024, 11:52
emack requested changes to D17063: [Cashtab] Patch bug in manage agora offers.

actually, after you've listed two offers, verified they render as one merged orderbook, then I've noticed:

  • you need to cancel twice on the same orderbook, is this because it's representative of 2 offers?
  • the orderbook in manage listings become a "Buy token", which makes sense since you no longer have any offers left, but shouldn't it not be displayed at all?
Nov 3 2024, 11:24
emack accepted D17063: [Cashtab] Patch bug in manage agora offers.

Have verified the merging of orderbooks for the same token offer, though I wasn't getting a duplicate key error in the first place on master (v2.49.1).

Nov 3 2024, 11:18
emack accepted D17060: [ecash-herald] Implement typescript.
Nov 3 2024, 11:03
emack accepted D17062: [token-server] Improve organization of test files.
Nov 3 2024, 10:53

Nov 2 2024

emack accepted D17053: [Cashtab] Implement typescript.
Nov 2 2024, 00:54

Nov 1 2024

emack accepted D17052: [Cashtab] Improved styling for OrderBook.
Nov 1 2024, 00:11
emack accepted D17054: [Cashtab] Lint GoogleAnalytics.js.
Nov 1 2024, 00:06

Oct 31 2024

emack accepted D17055: [Cashtab] Remove debug statement from test file.
Oct 31 2024, 23:30
emack accepted D17051: [Cashtab] Organize OrderBook and styles.
Oct 31 2024, 23:29
emack accepted D17045: [Cashtab] Render a token info page for any tokenId, regardless of user balance.
Oct 31 2024, 12:11
emack accepted D17047: [ecash-herald] Parse NFTs and agora oneshot txs.
Oct 31 2024, 12:05
emack accepted D17050: [token-server] Patch bug in token validation function.
Oct 31 2024, 12:04
emack accepted D17049: [Cashtab] Update bad tokenId validation function.
Oct 31 2024, 11:05
emack requested changes to D17047: [ecash-herald] Parse NFTs and agora oneshot txs.
Oct 31 2024, 04:44
emack requested changes to D17045: [Cashtab] Render a token info page for any tokenId, regardless of user balance.

http://localhost:3000/#/token/ just renders a blank page with the header - perhaps default to / route?.

Oct 31 2024, 04:17
emack accepted D17044: [Cashtab] Improve bignumber parsing for token agora.
Oct 31 2024, 02:58

Oct 30 2024

emack requested changes to D17044: [Cashtab] Improve bignumber parsing for token agora.

And perhaps for another diff, add a Max button to buy the full offer?

Oct 30 2024, 12:21
emack accepted D17041: [token-server] Link token blacklist with icon approval actions.
Oct 30 2024, 06:27
emack accepted D17034: [Cashtab] Add margin to info boxes.
Oct 30 2024, 01:39
emack accepted D17036: [Cashtab] Use token-server blacklist for agora.
Oct 30 2024, 01:37
emack requested changes to D17041: [token-server] Link token blacklist with icon approval actions.
Oct 30 2024, 01:36
emack requested changes to D17036: [Cashtab] Use token-server blacklist for agora.
Oct 30 2024, 01:04
emack accepted D17035: [Cashtab] Remove repeated and unnecessary specialized styled component.
Oct 30 2024, 00:56
emack accepted D17042: [Cashtab] Use ABC chronik first.
Oct 30 2024, 00:50

Oct 29 2024

emack accepted D17020: [token-server] Add database and initialize blacklist endpoints.
Oct 29 2024, 13:16
emack added a comment to D17005: [Cashtab] Upgrade existing token page to show trading info and display tokens the user does not hold.

image.png (1×329 px, 60 KB)

This is pretty unsightly - can you separate the orderbook in its own Buy Alita toggle?

Oct 29 2024, 12:51
emack requested changes to D17005: [Cashtab] Upgrade existing token page to show trading info and display tokens the user does not hold.

More than half the diff seems to be linting changes. Can you touch it and lint in a separate diff and then rebase this one?

Oct 29 2024, 12:45
emack accepted D17019: [ecash-herald] Parse agora actions.
Oct 29 2024, 12:26

Oct 28 2024

emack requested changes to D17019: [ecash-herald] Parse agora actions.
Oct 28 2024, 12:39
emack accepted D17017: [Cashtab] Refactor Orderbook to handle more logic.
Oct 28 2024, 11:50

Oct 27 2024

emack requested changes to D17017: [Cashtab] Refactor Orderbook to handle more logic.
Oct 27 2024, 03:25

Oct 26 2024

emack accepted D17016: [Cashtab] Fix agora depth bar fill effect.
Oct 26 2024, 22:34

Oct 25 2024

emack accepted D16998: [Cashtab] Patch cancel vs buy distinction in agora partials.
Oct 25 2024, 08:31
emack accepted D16994: [Cashtab] Patch tx parsing for agora buy/sell/cancel.
Oct 25 2024, 00:18

Oct 24 2024

emack accepted D16975: [Cashtab] Move google analytics id out of monorepo.
Oct 24 2024, 05:37
emack accepted D16972: [Cashtab] Parse agora oneshot buys and sells.
Oct 24 2024, 05:32
emack accepted D16973: [ecash-agora] Catch up changelog for next published version.
Oct 24 2024, 02:07
emack accepted D16974: [ecash-herald] Deprecate block-based daily msgs.
Oct 24 2024, 02:05
emack accepted D16846: [Cashtab] Support agora partial listings, cancels, and buys.
Oct 24 2024, 02:01