Page MenuHomePhabricator
Feed Advanced Search

Feb 17 2025

PiRK requested review of D17670: [electrum] support newer protobuf library versions.
Feb 17 2025, 15:13
PiRK accepted D17668: Bump version to 0.30.12.
Feb 17 2025, 14:44
PiRK accepted D17669: [avalanche] Deprecate the peer availability score.
Feb 17 2025, 14:43

Feb 16 2025

PiRK requested changes to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

I was wrong in my previous comment, changing the name of fields in protobuf files does not break compatibility for clients of Chronik.

Feb 16 2025, 08:11
PiRK closed D17664: [chronik] implement electrum RPC method blockchain.scripthash.get_history.
Feb 16 2025, 08:07
PiRK committed rABC0372571b7f77: [chronik] implement electrum RPC method blockchain.scripthash.get_history (authored by PiRK).
[chronik] implement electrum RPC method blockchain.scripthash.get_history
Feb 16 2025, 08:07

Feb 15 2025

PiRK added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

Partial review up to and including ecash-agora (just a comment nit)

Feb 15 2025, 16:34
PiRK added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

Partial review (everything cashtab)

Feb 15 2025, 14:40
PiRK added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

Partial review up to and including cashtab/src/airdrop/index.ts

Feb 15 2025, 10:25
PiRK updated the diff for D17664: [chronik] implement electrum RPC method blockchain.scripthash.get_history.

remove debugging print

Feb 15 2025, 07:55

Feb 14 2025

PiRK updated the diff for D17664: [chronik] implement electrum RPC method blockchain.scripthash.get_history.

clippy

Feb 14 2025, 11:14
PiRK requested review of D17664: [chronik] implement electrum RPC method blockchain.scripthash.get_history.
Feb 14 2025, 09:02

Feb 13 2025

PiRK accepted D17662: Make it possible to disable Tor binds and abort startup on bind failure.
Feb 13 2025, 11:24
PiRK accepted D17663: Bump the block sync timeout in p2p_ibd_stalling.
Feb 13 2025, 11:13
PiRK accepted D17573: [electrum] Sign stakes using Trezor devices.
Feb 13 2025, 09:59
PiRK accepted D17661: Better port collision management for the functional tests.
Feb 13 2025, 09:44
PiRK accepted D17661: Better port collision management for the functional tests.
Feb 13 2025, 09:19
PiRK added inline comments to D17573: [electrum] Sign stakes using Trezor devices.
Feb 13 2025, 07:59
PiRK requested changes to D17573: [electrum] Sign stakes using Trezor devices.
Feb 13 2025, 07:56
PiRK accepted D17573: [electrum] Sign stakes using Trezor devices.
Feb 13 2025, 07:50

Feb 12 2025

PiRK added inline comments to D17573: [electrum] Sign stakes using Trezor devices.
Feb 12 2025, 10:39
PiRK added inline comments to D17573: [electrum] Sign stakes using Trezor devices.
Feb 12 2025, 10:36

Feb 11 2025

PiRK closed D17646: wallet: avoid rescans if under the snapshot.
Feb 11 2025, 14:43
PiRK committed rABC2069f3c76279: wallet: avoid rescans if under the snapshot (authored by James O'Beirne <james.obeirne@gmail.com>).
wallet: avoid rescans if under the snapshot
Feb 11 2025, 14:43
PiRK added inline comments to D17658: Add a simplifygbt option to simplify parsing the block template for miners.
Feb 11 2025, 14:42
PiRK accepted D17657: Bump version to 0.30.11.
Feb 11 2025, 14:34
PiRK updated the diff for D17646: wallet: avoid rescans if under the snapshot.

rebase again

Feb 11 2025, 14:04
PiRK accepted D17656: Temporarly disable the getavaaddr_interval_test.
Feb 11 2025, 12:33
PiRK closed D17605: [chronik] implement the blockchain.scripthash.get_balance Electrum method.
Feb 11 2025, 11:28
PiRK committed rABC6db422501d60: [chronik] implement the blockchain.scripthash.get_balance Electrum method (authored by PiRK).
[chronik] implement the blockchain.scripthash.get_balance Electrum method
Feb 11 2025, 11:28
PiRK updated the diff for D17605: [chronik] implement the blockchain.scripthash.get_balance Electrum method.

rebase, nit

Feb 11 2025, 10:14
PiRK accepted D17655: test: improve robustness of connect_nodes().
Feb 11 2025, 09:42
PiRK updated the diff for D17646: wallet: avoid rescans if under the snapshot.

rebase. I'm convinced the feature_assumevalid.py failure is unrelated to this diff

Feb 11 2025, 08:34
PiRK closed D17635: assumeutxo cleanup: Move IsInitialBlockDownload & NotifyHeaderTip to ChainstateManager.
Feb 11 2025, 08:31
PiRK committed rABCdb526ab596e1: assumeutxo cleanup: Move IsInitialBlockDownload & NotifyHeaderTip to… (authored by Ryan Ofsky <ryan@ofsky.org>).
assumeutxo cleanup: Move IsInitialBlockDownload & NotifyHeaderTip to…
Feb 11 2025, 08:31
PiRK closed D17651: [electrum] fix output parsing when pay-to field is empty.
Feb 11 2025, 07:07
PiRK committed rABC1b64fae67afe: [electrum] fix output parsing when pay-to field is empty (authored by SomberNight <somber.night@protonmail.com>).
[electrum] fix output parsing when pay-to field is empty
Feb 11 2025, 07:07

Feb 9 2025

PiRK closed D17652: test: fix test failures in test/functional/p2p_timeouts.py.
Feb 9 2025, 13:41
PiRK committed rABC8fc3de71d547: test: fix test failures in test/functional/p2p_timeouts.py (authored by Jon Atack <jon@atack.com>).
test: fix test failures in test/functional/p2p_timeouts.py
Feb 9 2025, 13:41
PiRK accepted D17654: Remove useless timeouts in p2p_timeouts.
Feb 9 2025, 13:39

Feb 8 2025

PiRK requested review of D17652: test: fix test failures in test/functional/p2p_timeouts.py.
Feb 8 2025, 17:01
PiRK updated the test plan for D17651: [electrum] fix output parsing when pay-to field is empty.
Feb 8 2025, 16:48
PiRK planned changes to D17646: wallet: avoid rescans if under the snapshot.

need to investigate that CI second failure (the first one is clearly unrelated)

Feb 8 2025, 16:46
PiRK requested review of D17651: [electrum] fix output parsing when pay-to field is empty.
Feb 8 2025, 16:39
PiRK updated the diff for D17646: wallet: avoid rescans if under the snapshot.

rebase

Feb 8 2025, 10:33
PiRK closed D17645: wallet: make chain optional for CWallet::Create.
Feb 8 2025, 10:32
PiRK committed rABC95c17f9917b3: wallet: make chain optional for CWallet::Create (authored by Ivan Metlushko <metlushko@gmail.com>).
wallet: make chain optional for CWallet::Create
Feb 8 2025, 10:32
PiRK closed D17644: CWallet::Create move chain init message up into calling code.
Feb 8 2025, 10:32
PiRK committed rABCf8e022ee1291: CWallet::Create move chain init message up into calling code (authored by Ivan Metlushko <metlushko@gmail.com>).
CWallet::Create move chain init message up into calling code
Feb 8 2025, 10:32
PiRK closed D17643: refactor: Add CWallet:::AttachChain method.
Feb 8 2025, 10:32
PiRK committed rABC4cab5ee30993: refactor: Add CWallet:::AttachChain method (authored by Russell Yanofsky <russ@yanofsky.org>).
refactor: Add CWallet:::AttachChain method
Feb 8 2025, 10:32
PiRK closed D17642: refactor: move first run detection to client code.
Feb 8 2025, 10:31
PiRK committed rABCbfa2db91321b: refactor: move first run detection to client code (authored by Ivan Metlushko <metlushko@gmail.com>).
refactor: move first run detection to client code
Feb 8 2025, 10:31

Feb 7 2025

PiRK added inline comments to D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.
Feb 7 2025, 11:13

Feb 6 2025

PiRK updated the diff for D17646: wallet: avoid rescans if under the snapshot.

squash with 26282 (more helpful error message)

Feb 6 2025, 15:19
PiRK requested review of D17646: wallet: avoid rescans if under the snapshot.
Feb 6 2025, 15:11
PiRK requested review of D17645: wallet: make chain optional for CWallet::Create.
Feb 6 2025, 15:10
PiRK requested review of D17644: CWallet::Create move chain init message up into calling code.
Feb 6 2025, 15:09
PiRK requested review of D17643: refactor: Add CWallet:::AttachChain method.
Feb 6 2025, 15:08
PiRK requested review of D17642: refactor: move first run detection to client code.
Feb 6 2025, 15:07
PiRK updated the summary of D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.
Feb 6 2025, 09:39
PiRK closed D17634: chainparams: add blockhash to AssumeutxoData.
Feb 6 2025, 07:40
PiRK committed rABC1d28ffc21aad: chainparams: add blockhash to AssumeutxoData (authored by James O'Beirne <james.obeirne@pm.me>).
chainparams: add blockhash to AssumeutxoData
Feb 6 2025, 07:40
PiRK closed D17633: assumeutxo: remove snapshot during -reindex{-chainstate}.
Feb 6 2025, 07:40
PiRK committed rABC48785be9d2f7: assumeutxo: remove snapshot during -reindex{-chainstate} (authored by James O'Beirne <james.obeirne@pm.me>).
assumeutxo: remove snapshot during -reindex{-chainstate}
Feb 6 2025, 07:40
PiRK closed D17632: net_processing: Request assumeutxo background chain blocks.
Feb 6 2025, 07:40
PiRK committed rABCca3c72fce46d: net_processing: Request assumeutxo background chain blocks (authored by Suhas Daftuar <sdaftuar@chaincode.com>).
net_processing: Request assumeutxo background chain blocks
Feb 6 2025, 07:40
PiRK committed rABC07763f6aa047: [net processing] pass a Peer to FindNextBlocksToDownload (authored by PiRK).
[net processing] pass a Peer to FindNextBlocksToDownload
Feb 6 2025, 07:40
PiRK closed D17631: [net processing] pass a Peer to FindNextBlocksToDownload.
Feb 6 2025, 07:40

Feb 5 2025

PiRK updated the summary of D17634: chainparams: add blockhash to AssumeutxoData.
Feb 5 2025, 18:56

Feb 4 2025

PiRK requested review of D17635: assumeutxo cleanup: Move IsInitialBlockDownload & NotifyHeaderTip to ChainstateManager.
Feb 4 2025, 16:58
PiRK added a comment to D17634: chainparams: add blockhash to AssumeutxoData.

Note that the feature_deterministic_chain_setup.py test only exists in Bitcoin ABC, Bitcoin Core does not have it. We added it to demonstrate that the hardcoded regtests chainparams (block hashes and txoutsetinfo), which differ from Core due to differences in the block header format, are actually correct.

Feb 4 2025, 14:29
PiRK requested review of D17634: chainparams: add blockhash to AssumeutxoData.
Feb 4 2025, 14:25
PiRK requested review of D17633: assumeutxo: remove snapshot during -reindex{-chainstate}.
Feb 4 2025, 14:24
PiRK requested review of D17632: net_processing: Request assumeutxo background chain blocks.
Feb 4 2025, 14:23
PiRK updated the summary of D17631: [net processing] pass a Peer to FindNextBlocksToDownload.
Feb 4 2025, 08:28
PiRK requested review of D17631: [net processing] pass a Peer to FindNextBlocksToDownload.
Feb 4 2025, 08:28
PiRK closed D17629: bugfix: correct is_snapshot_cs in VerifyDB.
Feb 4 2025, 07:05
PiRK committed rABC9b78e7fbb03e: bugfix: correct is_snapshot_cs in VerifyDB (authored by James O'Beirne <james.obeirne@pm.me>).
bugfix: correct is_snapshot_cs in VerifyDB
Feb 4 2025, 07:05

Feb 3 2025

PiRK requested review of D17629: bugfix: correct is_snapshot_cs in VerifyDB.
Feb 3 2025, 10:22
PiRK accepted D17623: [ecash-lib] Better behavior of withPrefix() method in Address class.
Feb 3 2025, 08:15

Feb 1 2025

PiRK updated the diff for D17605: [chronik] implement the blockchain.scripthash.get_balance Electrum method.

rebase

Feb 1 2025, 07:52

Jan 31 2025

PiRK closed D17620: test: Avoid intermittent timeout in feature_assumevalid.py.
Jan 31 2025, 19:16
PiRK committed rABCb70bc3b15dcd: test: Avoid intermittent timeout in feature_assumevalid.py (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
test: Avoid intermittent timeout in feature_assumevalid.py
Jan 31 2025, 19:16
PiRK requested review of D17620: test: Avoid intermittent timeout in feature_assumevalid.py.
Jan 31 2025, 19:00
PiRK added a comment to D17605: [chronik] implement the blockchain.scripthash.get_balance Electrum method.

Unrelated failure, maybe fixed by https://github.com/bitcoin/bitcoin/pull/26651

Jan 31 2025, 18:49
PiRK updated the diff for D17605: [chronik] implement the blockchain.scripthash.get_balance Electrum method.

rebase
The previous CI failure is unrelated

Jan 31 2025, 14:43
PiRK accepted D17618: [avalanche] Track the finalized txs total sigchecks.
Jan 31 2025, 14:29
PiRK accepted D17617: [avalanche] Track the total size of finalized txs.
Jan 31 2025, 14:28
PiRK closed D17611: [chronik] return empty transaction history for an unknown scripthash.
Jan 31 2025, 14:13
PiRK committed rABCf7183b1f90d8: [chronik] return empty transaction history for an unknown scripthash (authored by PiRK).
[chronik] return empty transaction history for an unknown scripthash
Jan 31 2025, 14:13
PiRK accepted D17613: [avalanche] Fix flaky abc_p2p_getavaaddr.py test.
Jan 31 2025, 07:20

Jan 30 2025

PiRK accepted D17616: [avalanche] Eliminate taking unnecessary locks on cs_stakingRewards when getting stake contender status.
Jan 30 2025, 18:15
PiRK planned changes to D17605: [chronik] implement the blockchain.scripthash.get_balance Electrum method.

the failure seems unrelated, this diff shouldn't affect chronik_plugins, but i'll investigate just to be sure

Jan 30 2025, 18:13
PiRK published D17605: [chronik] implement the blockchain.scripthash.get_balance Electrum method for review.
Jan 30 2025, 14:53
PiRK requested changes to D17613: [avalanche] Fix flaky abc_p2p_getavaaddr.py test.

The getavalanchepeerinfo errors probably because a proof is not yet registered when it is called.

Jan 30 2025, 14:52
PiRK requested review of D17611: [chronik] return empty transaction history for an unknown scripthash.
Jan 30 2025, 13:02

Jan 29 2025

PiRK committed rABCb4ca4a8c259c: [chronik] make -chronikelectrumbind require -chronikscripthashindex (authored by PiRK).
[chronik] make -chronikelectrumbind require -chronikscripthashindex
Jan 29 2025, 12:09
PiRK closed D17599: [chronik] make -chronikelectrumbind require -chronikscripthashindex.
Jan 29 2025, 12:09

Jan 28 2025

PiRK accepted D17604: [cmake] Fix check-crates.
Jan 28 2025, 15:53