Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Mar 3 2025

PiRK committed rABCc71468342225: tests: use noban_tx_relay in more tests (authored by PiRK).
tests: use noban_tx_relay in more tests
Mar 3 2025, 08:11

Feb 28 2025

PiRK accepted D17729: [avalanche] Fix a race in contenders voting test.
Feb 28 2025, 21:21
PiRK requested review of D17730: tests: use noban_tx_relay in more tests.
Feb 28 2025, 21:19
PiRK closed D17722: indexes, refactor: Remove CBlockIndex* uses in index Init methods.
Feb 28 2025, 20:13
PiRK committed rABC3f303c2e897e: indexes, refactor: Remove CBlockIndex* uses in index Init methods (authored by Ryan Ofsky <ryan@ofsky.org>).
indexes, refactor: Remove CBlockIndex* uses in index Init methods
Feb 28 2025, 20:13
PiRK closed D17721: indexes, refactor: Remove CBlockIndex* uses in coinstatsindex LookUpOne function.
Feb 28 2025, 20:13
PiRK committed rABCef4a1052f5f0: indexes, refactor: Remove CBlockIndex* uses in coinstatsindex LookUpOne function (authored by Ryan Ofsky <ryan@ofsky.org>).
indexes, refactor: Remove CBlockIndex* uses in coinstatsindex LookUpOne function
Feb 28 2025, 20:13
PiRK accepted D17725: [ecash-herald] Send daily summaries to the main chat.
Feb 28 2025, 20:11
PiRK accepted D17724: [ecash-herald] Do not use polling for the telegram bot.
Feb 28 2025, 20:10
PiRK updated the diff for D17723: [kernel 2c/n] Introduce kernel::Context, encapsulate global init/teardown.

rm Makefile.am

Feb 28 2025, 15:26
PiRK requested review of D17723: [kernel 2c/n] Introduce kernel::Context, encapsulate global init/teardown.
Feb 28 2025, 15:25
PiRK accepted D17717: [avalanche] Also finalize the ancestors of a transaction.
Feb 28 2025, 13:44
PiRK requested review of D17722: indexes, refactor: Remove CBlockIndex* uses in index Init methods.
Feb 28 2025, 13:08
PiRK requested review of D17721: indexes, refactor: Remove CBlockIndex* uses in coinstatsindex LookUpOne function.
Feb 28 2025, 13:07
PiRK closed D17714: index: fix reindex-chainstate with active indexes.
Feb 28 2025, 12:10
PiRK committed rABC1583f9118eba: index: fix reindex-chainstate with active indexes (authored by Martin Zumsande <mzumsande@gmail.com>).
index: fix reindex-chainstate with active indexes
Feb 28 2025, 12:10
PiRK updated the diff for D17714: index: fix reindex-chainstate with active indexes.

use -noparkdeepreorg and mine 5 blocks

Feb 28 2025, 07:47

Feb 27 2025

PiRK added inline comments to D17714: index: fix reindex-chainstate with active indexes.
Feb 27 2025, 16:04
PiRK updated the diff for D17714: index: fix reindex-chainstate with active indexes.

fix clang-tidy style error, fix test flakiness (mine enough new block to trigger automatic unparking on the other node, 5 was not enough)

Feb 27 2025, 15:58
PiRK planned changes to D17714: index: fix reindex-chainstate with active indexes.
Feb 27 2025, 15:17
PiRK requested review of D17714: index: fix reindex-chainstate with active indexes.
Feb 27 2025, 15:10
PiRK closed D17706: refactor: use std::string for thread names.
Feb 27 2025, 10:21
PiRK committed rABC2d464809a97d: refactor: use std::string for thread names (authored by stickies-v <stickies-v@protonmail.com>).
refactor: use std::string for thread names
Feb 27 2025, 10:21
PiRK committed rABC3926deb8fa05: refactor: use std::string for index names (authored by stickies-v <stickies-v@protonmail.com>).
refactor: use std::string for index names
Feb 27 2025, 10:21
PiRK closed D17707: refactor: use std::string for index names.
Feb 27 2025, 10:21
PiRK closed D17705: indexes, refactor: Pass Chain interface instead of CChainState class to indexes.
Feb 27 2025, 10:21
PiRK committed rABC94e4f949ce51: indexes, refactor: Pass Chain interface instead of CChainState class to indexes (authored by Ryan Ofsky <ryan@ofsky.org>).
indexes, refactor: Pass Chain interface instead of CChainState class to indexes
Feb 27 2025, 10:21
PiRK accepted D17713: Prevent occasional timeout in feature_assumevalid.
Feb 27 2025, 10:15
PiRK closed D17686: [chronik] add Electrum RPC server.donation_address.
Feb 27 2025, 07:28
PiRK committed rABC1e96a8544247: [chronik] add Electrum RPC server.donation_address (authored by PiRK).
[chronik] add Electrum RPC server.donation_address
Feb 27 2025, 07:28
PiRK updated the diff for D17706: refactor: use std::string for thread names.

remove unused include

Feb 27 2025, 07:23
PiRK updated the diff for D17705: indexes, refactor: Pass Chain interface instead of CChainState class to indexes.

remove unnecessary forward declaration

Feb 27 2025, 07:22

Feb 26 2025

PiRK added a comment to D17705: indexes, refactor: Pass Chain interface instead of CChainState class to indexes.

I'll keep looking what's wrong with feature_assumevalid, but it is not related to this diff.

Feb 26 2025, 16:59
PiRK closed D17704: index: Move last_locator_write_time and logging to end of threadsync loop.
Feb 26 2025, 16:54
PiRK closed D17703: doc: BaseIndex sync behavior with empty datadir.
Feb 26 2025, 16:54
PiRK committed rABCa23a2ae0eda8: index: Move last_locator_write_time and logging to end of threadsync loop (authored by Fabian Jahr <fjahr@protonmail.com>).
index: Move last_locator_write_time and logging to end of threadsync loop
Feb 26 2025, 16:54
PiRK committed rABC8e4b9a1ff950: doc: BaseIndex sync behavior with empty datadir (authored by James O'Beirne <james.obeirne@pm.me>).
doc: BaseIndex sync behavior with empty datadir
Feb 26 2025, 16:54
PiRK committed rABCef3b321b2815: index: Don't commit a best block before indexing it during sync (authored by Martin Zumsande <mzumsande@gmail.com>).
index: Don't commit a best block before indexing it during sync
Feb 26 2025, 16:54
PiRK closed D17702: index: Don't commit a best block before indexing it during sync.
Feb 26 2025, 16:54
PiRK updated the diff for D17686: [chronik] add Electrum RPC server.donation_address.

use the constant in strings

Feb 26 2025, 15:57
PiRK requested review of D17707: refactor: use std::string for index names.
Feb 26 2025, 15:47
PiRK requested review of D17706: refactor: use std::string for thread names.
Feb 26 2025, 15:45
PiRK requested review of D17705: indexes, refactor: Pass Chain interface instead of CChainState class to indexes.
Feb 26 2025, 15:44
PiRK requested review of D17704: index: Move last_locator_write_time and logging to end of threadsync loop.
Feb 26 2025, 15:32
PiRK updated the summary of D17703: doc: BaseIndex sync behavior with empty datadir.
Feb 26 2025, 15:32
PiRK requested review of D17703: doc: BaseIndex sync behavior with empty datadir.
Feb 26 2025, 15:31
PiRK requested review of D17702: index: Don't commit a best block before indexing it during sync.
Feb 26 2025, 15:30
PiRK updated the diff for D17686: [chronik] add Electrum RPC server.donation_address.

make max length a constexpr

Feb 26 2025, 10:52
PiRK updated the summary of D17686: [chronik] add Electrum RPC server.donation_address.
Feb 26 2025, 10:40
PiRK updated the diff for D17686: [chronik] add Electrum RPC server.donation_address.

chech the donation address length

Feb 26 2025, 09:10

Feb 25 2025

PiRK committed rABC40402b2ac954: wallet: Ignore chainStateFlushed notifications while attaching chain (authored by Martin Zumsande <mzumsande@gmail.com>).
wallet: Ignore chainStateFlushed notifications while attaching chain
Feb 25 2025, 11:32
PiRK closed D17689: wallet: Ignore chainStateFlushed notifications while attaching chain.
Feb 25 2025, 11:32
PiRK updated the diff for D17689: wallet: Ignore chainStateFlushed notifications while attaching chain.

remove first comment which would mess with formatting if left inline and is already explained by the previous block of comments
add a comment as suggested to first call m_attaching_chain = false

Feb 25 2025, 10:37
PiRK updated the diff for D17689: wallet: Ignore chainStateFlushed notifications while attaching chain.

rebase

Feb 25 2025, 08:34
PiRK accepted D17695: [avalanche] Make payout scripts unique in contenders test.
Feb 25 2025, 08:32
PiRK closed D17688: doc: Improve ZMQ documentation.
Feb 25 2025, 08:31
PiRK committed rABCc52393d22e61: doc: Improve ZMQ documentation (authored by node01 <mbildwic@protonmail.com>).
doc: Improve ZMQ documentation
Feb 25 2025, 08:31
PiRK accepted D17693: [avalanche] Cleanup payout address optionality.
Feb 25 2025, 08:23
PiRK accepted D17694: test: Ignore UTF-8 errors in assert_debug_log.
Feb 25 2025, 08:22
PiRK closed D17691: test: refactor: use `create_block` parameters.
Feb 25 2025, 08:12
PiRK committed rABCf4d4a586a65b: test: refactor: use `create_block` parameters (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
test: refactor: use `create_block` parameters
Feb 25 2025, 08:12

Feb 24 2025

PiRK committed rABC33c0dc6359a1: test: remove unnecessary block rehashing prior to solving (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
test: remove unnecessary block rehashing prior to solving
Feb 24 2025, 17:08
PiRK closed D17690: test: remove unnecessary block rehashing prior to solving.
Feb 24 2025, 17:08
PiRK added inline comments to D17691: test: refactor: use `create_block` parameters.
Feb 24 2025, 16:31
PiRK updated the diff for D17691: test: refactor: use `create_block` parameters.

don't shadow j either

Feb 24 2025, 16:28
PiRK requested review of D17691: test: refactor: use `create_block` parameters.
Feb 24 2025, 16:26
PiRK requested review of D17690: test: remove unnecessary block rehashing prior to solving.
Feb 24 2025, 13:21

Feb 23 2025

PiRK planned changes to D17689: wallet: Ignore chainStateFlushed notifications while attaching chain.

CI failure most likely unrelated, but will have to investigate anyway (tomorrow)

Feb 23 2025, 09:25
PiRK requested review of D17689: wallet: Ignore chainStateFlushed notifications while attaching chain.
Feb 23 2025, 09:12

Feb 22 2025

PiRK added a comment to D17688: doc: Improve ZMQ documentation.

Backported as a dependency of https://github.com/bitcoin/bitcoin/pull/27596/commits/f073917a9e7ba423643dcae0339776470b628f65

Feb 22 2025, 15:19
PiRK requested review of D17688: doc: Improve ZMQ documentation.
Feb 22 2025, 15:19
PiRK updated the diff for D17686: [chronik] add Electrum RPC server.donation_address.

fix comment layout

Feb 22 2025, 09:21

Feb 21 2025

PiRK requested review of D17686: [chronik] add Electrum RPC server.donation_address.
Feb 21 2025, 16:57
PiRK accepted D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

Still lgtm

Feb 21 2025, 14:20
PiRK accepted D17684: [chronik] Fix the chronik_plugins test.
Feb 21 2025, 14:05
PiRK accepted D17682: Fix nullptr clientModel access during shutdown.
Feb 21 2025, 13:42
PiRK closed D17681: [chronik] make the maximum history length for electrum RPCs an init param.
Feb 21 2025, 10:35
PiRK committed rABCb760220009df: [chronik] make the maximum history length for electrum RPCs an init param (authored by PiRK).
[chronik] make the maximum history length for electrum RPCs an init param
Feb 21 2025, 10:35

Feb 20 2025

PiRK retitled D17681: [chronik] make the maximum history length for electrum RPCs an init param from [chronik] make the maximum history length an init param to [chronik] make the maximum history length for electrum RPCs an init param.
Feb 20 2025, 19:36
PiRK requested review of D17681: [chronik] make the maximum history length for electrum RPCs an init param.
Feb 20 2025, 19:21
PiRK closed D17676: [chronik] implement server.version electrum method.
Feb 20 2025, 07:38
PiRK committed rABC91ef9971ad45: [chronik] implement server.version electrum method (authored by PiRK).
[chronik] implement server.version electrum method
Feb 20 2025, 07:38
PiRK accepted D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Feb 20 2025, 07:24

Feb 19 2025

PiRK accepted D17677: Improve reliability of abc_rpc_getavalancheproofs.
Feb 19 2025, 11:50
PiRK accepted D17675: [chronik] Consistently sync the validation queue in functional tests.
Feb 19 2025, 11:49
PiRK updated the diff for D17676: [chronik] implement server.version electrum method.

remove done TODO

Feb 19 2025, 09:35
PiRK added inline comments to D17676: [chronik] implement server.version electrum method.
Feb 19 2025, 09:34
PiRK updated the summary of D17676: [chronik] implement server.version electrum method.
Feb 19 2025, 09:33
PiRK requested review of D17676: [chronik] implement server.version electrum method.
Feb 19 2025, 09:33

Feb 18 2025

PiRK accepted D17674: [avalanche] Deprecate the node availability score in the peerinfo RPC.
Feb 18 2025, 17:12
PiRK committed rABC9205e1004401: test: Add explicit onion bind to p2p_permissions (authored by Ava Chow <github@achow101.com>).
test: Add explicit onion bind to p2p_permissions
Feb 18 2025, 14:46
PiRK closed D17673: test: Add explicit onion bind to p2p_permissions.
Feb 18 2025, 14:46
PiRK requested review of D17673: test: Add explicit onion bind to p2p_permissions.
Feb 18 2025, 13:19
PiRK closed D17672: [chronik] Implement blockchain.scripthash.listunspent electrum method.
Feb 18 2025, 12:12
PiRK committed rABCe09df7e9e3ab: [chronik] Implement blockchain.scripthash.listunspent electrum method (authored by PiRK).
[chronik] Implement blockchain.scripthash.listunspent electrum method
Feb 18 2025, 12:12
PiRK closed D17670: [electrum] support newer protobuf library versions.
Feb 18 2025, 12:12
PiRK committed rABC36570956a320: [electrum] support newer protobuf library versions (authored by PiRK).
[electrum] support newer protobuf library versions
Feb 18 2025, 12:12
PiRK accepted D17671: Re-enable the getavaaddr_interval_test.

let's see if it pops up on CI again

Feb 18 2025, 09:41
PiRK requested review of D17672: [chronik] Implement blockchain.scripthash.listunspent electrum method.
Feb 18 2025, 09:22

Feb 17 2025

PiRK added a comment to D17670: [electrum] support newer protobuf library versions.

This was the error, fyi

Traceback (most recent call last):
  File "/home/pierre/dev/bitcoin-abc/electrum/electrumabc_plugins/fusion/fusion.py", line 518, in run
    if self.run_round(covert):
       ^^^^^^^^^^^^^^^^^^^^^^
  File "/home/pierre/dev/bitcoin-abc/electrum/electrumabc_plugins/fusion/fusion.py", line 518, in run
    if self.run_round(covert):
       ^^^^^^^^^^^^^^^^^^^^^^
  File "/home/pierre/dev/bitcoin-abc/electrum/electrumabc_plugins/fusion/fusion.py", line 1341, in run_round
    inpcomp = validate_proof_internal(
              ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/pierre/dev/bitcoin-abc/electrum/electrumabc_plugins/fusion/validation.py", line 179, in validate_proof_internal
    msg = proto_strict_parse(pb.Proof(), proofblob)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/pierre/dev/bitcoin-abc/electrum/electrumabc_plugins/fusion/validation.py", line 84, in proto_strict_parse
    check(not msg.UnknownFields(), "has extra fields")
              ^^^^^^^^^^^^^^^^^^^
  File "/home/pierre/dev/bitcoin-abc/electrum/electrumabc_plugins/fusion/fusion.py", line 1341, in run_round
    inpcomp = validate_proof_internal(
              ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/pierre/dev/bitcoin-abc/electrum/electrumabc_plugins/fusion/validation.py", line 179, in validate_proof_internal
    msg = proto_strict_parse(pb.Proof(), proofblob)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
NotImplementedError: unknown field accessor
  File "/home/pierre/dev/bitcoin-abc/electrum/electrumabc_plugins/fusion/validation.py", line 84, in proto_strict_parse
    check(not msg.UnknownFields(), "has extra fields")
              ^^^^^^^^^^^^^^^^^^^
NotImplementedError: unknown field accessor
Feb 17 2025, 15:14
First
Prev
Next