Page MenuHomePhabricator
Feed Advanced Search

Mar 13 2025

PiRK planned changes to D17785: [electrum] install a custom version of trezorlib.
Mar 13 2025, 09:57
PiRK updated the diff for D17785: [electrum] install a custom version of trezorlib.

rebase on D17797 (extracted some changes not directly related to trezor)

Mar 13 2025, 09:56
PiRK requested review of D17797: [electrum] also use patched btchip-python in non-deterministic requirements-hw.txt.
Mar 13 2025, 09:52
PiRK requested review of D17796: [electrum] bump hidapi and remove --only-binary workaround.
Mar 13 2025, 09:46
PiRK closed D17790: [electrum] build: use pyca/cryptography release version.
Mar 13 2025, 09:41
PiRK committed rABCe5f570af9696: [electrum] build: use pyca/cryptography release version (authored by EchterAgo).
[electrum] build: use pyca/cryptography release version
Mar 13 2025, 09:41
PiRK added a comment to D17795: [avalanche] Use the block fitter to track the finalized txs statistics.

my review collided with an update that fixed the issue

Mar 13 2025, 08:17
PiRK accepted D17795: [avalanche] Use the block fitter to track the finalized txs statistics.
Mar 13 2025, 08:16
PiRK requested changes to D17795: [avalanche] Use the block fitter to track the finalized txs statistics.

This diff somehow pulls blockfitter.cpp into bitcoin-chainstate's dependencies, so you need to add it a second time in CMakeList.txt

Mar 13 2025, 08:15
PiRK accepted D17793: Extract the block fitting logic from the block assembler logic.
Mar 13 2025, 08:10
PiRK accepted D17792: Reset the block template in the constructor.
Mar 13 2025, 07:55
PiRK accepted D17791: Use constants for the coinbase reserved size in the block assembler.
Mar 13 2025, 07:52
PiRK closed D17787: [electrum] enable the Build Avalanche Proof context menu action when possible for Trezor wallets.
Mar 13 2025, 07:46
PiRK committed rABC41118e547b70: [electrum] enable the Build Avalanche Proof context menu action when possible… (authored by PiRK).
[electrum] enable the Build Avalanche Proof context menu action when possible…
Mar 13 2025, 07:46
PiRK updated the summary of D17787: [electrum] enable the Build Avalanche Proof context menu action when possible for Trezor wallets.
Mar 13 2025, 07:45

Mar 12 2025

PiRK requested review of D17790: [electrum] build: use pyca/cryptography release version.
Mar 12 2025, 19:49
PiRK accepted D17786: [Cashtab] Patch header links to token page in extension.
Mar 12 2025, 18:55
PiRK updated the diff for D17777: [electrum] freeze UTXOs that may contain ALP tokens.

feedback + handle case of same transaction added twice without clearing first (don't duplicate outpoints, don't even bother rescanning the transaction)

Mar 12 2025, 18:54
PiRK requested review of D17787: [electrum] enable the Build Avalanche Proof context menu action when possible for Trezor wallets.
Mar 12 2025, 18:40
PiRK published D17785: [electrum] install a custom version of trezorlib for review.
Mar 12 2025, 18:23
PiRK added inline comments to D17777: [electrum] freeze UTXOs that may contain ALP tokens.
Mar 12 2025, 16:09

Mar 11 2025

PiRK updated the diff for D17777: [electrum] freeze UTXOs that may contain ALP tokens.

minor UI improvement (change the greyed out spend action text to tell why the coin is unspendable)

Mar 11 2025, 20:59
PiRK updated the summary of D17777: [electrum] freeze UTXOs that may contain ALP tokens.
Mar 11 2025, 20:50
PiRK published D17777: [electrum] freeze UTXOs that may contain ALP tokens for review.
Mar 11 2025, 19:56

Mar 10 2025

PiRK accepted D17771: [avalanche] Remove useless timeout in the tx finalization test.
Mar 10 2025, 16:04
PiRK accepted D17770: [electrum] Add native eCash support for compatible Trezor One firmware.
Mar 10 2025, 13:29

Mar 7 2025

PiRK committed rABC3e0722f77bc2: [electrum] implement eMPP parsing (authored by PiRK).
[electrum] implement eMPP parsing
Mar 7 2025, 15:46
PiRK closed D17760: [electrum] implement eMPP parsing.
Mar 7 2025, 15:46
PiRK updated the diff for D17760: [electrum] implement eMPP parsing.

remove a print

Mar 7 2025, 13:10
PiRK added inline comments to D17760: [electrum] implement eMPP parsing.
Mar 7 2025, 13:09
PiRK updated the diff for D17760: [electrum] implement eMPP parsing.

support opcode 0x01, write more tests, find out that the op == OpCodes.OP_PUSHDATA4 branch is wrong, fix it

Mar 7 2025, 13:08
PiRK closed D17758: [electrum] rename package slp -> tokens.
Mar 7 2025, 12:48
PiRK closed D17759: [electrum] add copyright header to slp.py.
Mar 7 2025, 12:48
PiRK committed rABCfd987ce15b52: [electrum] add copyright header to slp.py (authored by PiRK).
[electrum] add copyright header to slp.py
Mar 7 2025, 12:48
PiRK committed rABC91072984102b: [electrum] rename package slp -> tokens (authored by PiRK).
[electrum] rename package slp -> tokens
Mar 7 2025, 12:48
PiRK closed D17757: [electrum] import the slp module directly.
Mar 7 2025, 12:48
PiRK committed rABC5d0411c26b96: [electrum] import the slp module directly (authored by PiRK).
[electrum] import the slp module directly
Mar 7 2025, 12:48
PiRK accepted D17762: [lint patch] resolve arc lint issue.

A flynt false positive

Mar 7 2025, 08:47

Mar 6 2025

PiRK added inline comments to D17760: [electrum] implement eMPP parsing.
Mar 6 2025, 17:34
PiRK added inline comments to D17760: [electrum] implement eMPP parsing.
Mar 6 2025, 17:32
PiRK updated the diff for D17760: [electrum] implement eMPP parsing.

add tests for incorrect data length in otherwise valid succession of push ops

Mar 6 2025, 17:28
PiRK requested review of D17760: [electrum] implement eMPP parsing.
Mar 6 2025, 16:41
PiRK updated the diff for D17758: [electrum] rename package slp -> tokens.

make this a move only commit

Mar 6 2025, 16:40
PiRK updated the summary of D17759: [electrum] add copyright header to slp.py.
Mar 6 2025, 16:39
PiRK requested review of D17759: [electrum] add copyright header to slp.py.
Mar 6 2025, 16:35
PiRK planned changes to D17758: [electrum] rename package slp -> tokens.

let's add the headers in a separate diff, so it is clear that no code was changed

Mar 6 2025, 16:32
PiRK requested review of D17758: [electrum] rename package slp -> tokens.
Mar 6 2025, 16:31
PiRK requested review of D17757: [electrum] import the slp module directly.
Mar 6 2025, 16:30
PiRK closed D17753: test: adjust chainstate tests to use recognized snapshot base.
Mar 6 2025, 09:35
PiRK committed rABC43c4d6926372: test: adjust chainstate tests to use recognized snapshot base (authored by James O'Beirne <james.obeirne@pm.me>).
test: adjust chainstate tests to use recognized snapshot base
Mar 6 2025, 09:35

Mar 5 2025

PiRK requested review of D17753: test: adjust chainstate tests to use recognized snapshot base.
Mar 5 2025, 14:43

Mar 4 2025

PiRK closed D17750: index: verify blocks data existence only once.
Mar 4 2025, 14:37
PiRK closed D17749: init: don't start indexes sync thread prematurely.
Mar 4 2025, 14:37
PiRK committed rABCc7c0f9d22238: index: verify blocks data existence only once (authored by furszy <matiasfurszyfer@protonmail.com>).
index: verify blocks data existence only once
Mar 4 2025, 14:37
PiRK committed rABC4708298172e0: init: don't start indexes sync thread prematurely (authored by furszy <matiasfurszyfer@protonmail.com>).
init: don't start indexes sync thread prematurely
Mar 4 2025, 14:37
PiRK committed rABC8ec06eaff80b: make GetFirstStoredBlock assert that 'start_block' always has data (authored by furszy <matiasfurszyfer@protonmail.com>).
make GetFirstStoredBlock assert that 'start_block' always has data
Mar 4 2025, 14:37
PiRK closed D17748: refactor: simplify pruning violation check.
Mar 4 2025, 14:37
PiRK closed D17747: make GetFirstStoredBlock assert that 'start_block' always has data.
Mar 4 2025, 14:37
PiRK committed rABC8b333e573585: refactor: simplify pruning violation check (authored by furszy <matiasfurszyfer@protonmail.com>).
refactor: simplify pruning violation check
Mar 4 2025, 14:37
PiRK closed D17746: refactor: init indexes, decouple 'Start()' from the creation step.
Mar 4 2025, 14:37
PiRK closed D17745: rename 'loadblk' thread name to 'initload'.
Mar 4 2025, 14:37
PiRK committed rABCf31a5561bd77: refactor: init indexes, decouple 'Start()' from the creation step (authored by furszy <matiasfurszyfer@protonmail.com>).
refactor: init indexes, decouple 'Start()' from the creation step
Mar 4 2025, 14:37
PiRK committed rABC648994976d40: rename 'loadblk' thread name to 'initload' (authored by PiRK).
rename 'loadblk' thread name to 'initload'
Mar 4 2025, 14:37
PiRK closed D17744: init: start indexes sync earlier.
Mar 4 2025, 14:37
PiRK committed rABCd5b31e212b22: init: start indexes sync earlier (authored by furszy <matiasfurszyfer@protonmail.com>).
init: start indexes sync earlier
Mar 4 2025, 14:37
PiRK accepted D17751: [avalanche] Add the finalized transactions ancestors to the list of recently finalized items.
Mar 4 2025, 14:30
PiRK added inline comments to D17751: [avalanche] Add the finalized transactions ancestors to the list of recently finalized items.
Mar 4 2025, 13:21
PiRK updated the summary of D17750: index: verify blocks data existence only once.
Mar 4 2025, 10:32
PiRK requested review of D17750: index: verify blocks data existence only once.
Mar 4 2025, 10:22
PiRK updated the summary of D17749: init: don't start indexes sync thread prematurely.
Mar 4 2025, 10:18
PiRK requested review of D17749: init: don't start indexes sync thread prematurely.
Mar 4 2025, 10:18
PiRK requested review of D17748: refactor: simplify pruning violation check.
Mar 4 2025, 10:12
PiRK requested review of D17747: make GetFirstStoredBlock assert that 'start_block' always has data.
Mar 4 2025, 10:11
PiRK added inline comments to D17746: refactor: init indexes, decouple 'Start()' from the creation step.
Mar 4 2025, 10:10
PiRK updated the summary of D17746: refactor: init indexes, decouple 'Start()' from the creation step.
Mar 4 2025, 10:09
PiRK requested review of D17746: refactor: init indexes, decouple 'Start()' from the creation step.
Mar 4 2025, 10:08
PiRK requested review of D17745: rename 'loadblk' thread name to 'initload'.
Mar 4 2025, 10:05
PiRK requested review of D17744: init: start indexes sync earlier.
Mar 4 2025, 10:03
PiRK closed D17742: Bugfix: RPC/blockchain: pruneblockchain: Return the height of the actual last pruned block.
Mar 4 2025, 10:00
PiRK committed rABC160855839e52: Bugfix: RPC/blockchain: pruneblockchain: Return the height of the actual last… (authored by Luke Dashjr <luke-jr+git@utopios.org>).
Bugfix: RPC/blockchain: pruneblockchain: Return the height of the actual last…
Mar 4 2025, 10:00
PiRK closed D17743: Bump version to 0.30.13.
Mar 4 2025, 10:00
PiRK committed rABCd4bbff907ce8: Bump version to 0.30.13 (authored by PiRK).
Bump version to 0.30.13
Mar 4 2025, 10:00
PiRK updated the summary of D17742: Bugfix: RPC/blockchain: pruneblockchain: Return the height of the actual last pruned block.
Mar 4 2025, 09:21
PiRK updated the diff for D17742: Bugfix: RPC/blockchain: pruneblockchain: Return the height of the actual last pruned block.

add a release note and rebase&

Mar 4 2025, 09:21
PiRK updated the diff for D17743: Bump version to 0.30.13.

rebase

Mar 4 2025, 09:20
PiRK requested review of D17743: Bump version to 0.30.13.
Mar 4 2025, 09:12
PiRK requested review of D17742: Bugfix: RPC/blockchain: pruneblockchain: Return the height of the actual last pruned block.
Mar 4 2025, 08:56

Mar 3 2025

PiRK closed D17736: refactor: Reduce number of SanityChecks return values and return util::Result.
Mar 3 2025, 16:11
PiRK committed rABC4b9853aa63ac: refactor: Reduce number of SanityChecks return values and return util::Result (authored by Ryan Ofsky <ryan@ofsky.org>).
refactor: Reduce number of SanityChecks return values and return util::Result
Mar 3 2025, 16:11
PiRK closed D17723: [kernel 2c/n] Introduce kernel::Context, encapsulate global init/teardown.
Mar 3 2025, 16:11
PiRK committed rABC7bc86ab136f9: [kernel 2c/n] Introduce kernel::Context, encapsulate global init/teardown (authored by Carl Dong <contact@carldong.me>).
[kernel 2c/n] Introduce kernel::Context, encapsulate global init/teardown
Mar 3 2025, 16:11
PiRK closed D17735: build: remove ENABLE_GLICB_COMPAT from builds.
Mar 3 2025, 16:11
PiRK committed rABCb1e851853035: build: remove ENABLE_GLICB_COMPAT from builds (authored by PiRK).
build: remove ENABLE_GLICB_COMPAT from builds
Mar 3 2025, 16:11
PiRK requested review of D17736: refactor: Reduce number of SanityChecks return values and return util::Result.
Mar 3 2025, 14:38
PiRK updated the diff for D17723: [kernel 2c/n] Introduce kernel::Context, encapsulate global init/teardown.

depend on D17735 to address one of the review items

Mar 3 2025, 14:19
teamcity awarded D17735: build: remove ENABLE_GLICB_COMPAT from builds a Piece of Eight token.
Mar 3 2025, 14:08
PiRK published D17735: build: remove ENABLE_GLICB_COMPAT from builds for review.

@bot guix-linux guix-win guix-osx

Mar 3 2025, 14:08
teamcity awarded D17735: build: remove ENABLE_GLICB_COMPAT from builds a Haypence token.
Mar 3 2025, 13:46
PiRK added inline comments to D17723: [kernel 2c/n] Introduce kernel::Context, encapsulate global init/teardown.
Mar 3 2025, 10:44
PiRK closed D17730: tests: use noban_tx_relay in more tests.
Mar 3 2025, 08:11