rebase onto D17945
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Apr 17 2025
Apr 17 2025
PiRK retitled D17945: test: add "Debug" build to slow builds from test: add "Debug" builds to slow builds to test: add "Debug" build to slow builds.
PiRK added a reverting change for D6308: Make nChainTx private, ass facility to update it: rABC01b4aa9a8761: inline chain stats updating.
PiRK added a reverting change for D17872: block index: split ResetChainStats from UpdateChainStats: rABC01b4aa9a8761: inline chain stats updating.
inline chain stats updating
PiRK committed rABC5112370f0353: rpc: Add MaybeArg() and Arg() default helper (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
rpc: Add MaybeArg() and Arg() default helper
PiRK committed rABC92b26b9a5582: rpc: use RPCArg::Optional::OMITTED over OMITTED_NAMED_ARG (authored by PiRK).
rpc: use RPCArg::Optional::OMITTED over OMITTED_NAMED_ARG
PiRK committed rABC1622f57da88a: rpc: RPCHelpMan fixes (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
rpc: RPCHelpMan fixes
add TMPL_INST for bool from https://github.com/bitcoin/bitcoin/pull/28331/commits/c73cd423636e06df46742f573640ca773b281ffc
(needed for preventing a linker error with the unit test added in core#29277)
Apr 16 2025
Apr 16 2025
let's try a larger timeout factor for the Debug build.
The test fails because the node restart with -reindex=1 is not done loading blocks after 60 s which triggers the assertions in test_node.py line 386
rebase again
reduce indentation as per review
PiRK committed rABC087505795565: test: fix generation of conflicting transactions in chronik_electrum_blockchain. (authored by PiRK).
test: fix generation of conflicting transactions in chronik_electrum_blockchain.
there is still something wrong. Either i didn't have Debug while testing, or Arcanist is confused by my rebasing
wrong diff see D17931
rebase on D17938
rebase on D17938
PiRK added a reverting change for D17872: block index: split ResetChainStats from UpdateChainStats: D17938: inline chain stats updating.
PiRK committed rABC03f1074ec32e: test: make MiniWallet produce deterministic transactions (authored by PiRK).
test: make MiniWallet produce deterministic transactions
Apr 15 2025
Apr 15 2025
PiRK added a reverting change for D6308: Make nChainTx private, ass facility to update it: D17938: inline chain stats updating.
add extended tests to plan
Bump version to 0.31.2
still the debug failure to be investigated
move release notes to proper file, split MiniWallet determinism into its own diff D17933, fix file permissions and shebangs for tests
arcanist created a new diff for some reason
Apr 14 2025
Apr 14 2025
fix release notes, investigate test failure on CI
Review suggestion:
PiRK committed rABC147451e8d798: assumeutxo: Check deserialized coins for out of range values (authored by PiRK).
assumeutxo: Check deserialized coins for out of range values
PiRK committed rABC0131c1a63c9e: rpc: Improve importdescriptor RPC error messages (authored by PiRK).
rpc: Improve importdescriptor RPC error messages
PiRK committed rABCe3c0e83285c4: validation: Don't assume m_chain_tx_count in GuessVerificationProgress (authored by Fabian Jahr <fjahr@protonmail.com>).
validation: Don't assume m_chain_tx_count in GuessVerificationProgress
PiRK committed rABCab94fbe74208: rpc: Make pruneheight also reflect undo data presence (authored by Fabian Jahr <fjahr@protonmail.com>).
rpc: Make pruneheight also reflect undo data presence
PiRK committed rABCcd986cbab636: refactor, blockstorage: Generalize GetFirstStoredBlock (authored by PiRK).
refactor, blockstorage: Generalize GetFirstStoredBlock
strinrg layouts
Apr 12 2025
Apr 12 2025
PiRK added inline comments to D17926: validation: Don't assume m_chain_tx_count in GuessVerificationProgress.
PiRK requested review of D17926: validation: Don't assume m_chain_tx_count in GuessVerificationProgress.
Apr 11 2025
Apr 11 2025
rebase
pass status by const ref
include <functional>
PiRK committed rABC073ac4d70ec0: test: add coverage for rpc error when trying to rescan beyond pruned data (authored by brunoerg <brunoely.gc@gmail.com>).
test: add coverage for rpc error when trying to rescan beyond pruned data
PiRK committed rABCa6ef9e78d417: test: run feature_pruning.py without wallet compiled (authored by PiRK).
test: run feature_pruning.py without wallet compiled
PiRK committed rABC302a7e7f9443: rpc: Enable wallet import on pruned nodes (authored by Aurèle Oulès <aurele@oules.com>).
rpc: Enable wallet import on pruned nodes
PiRK committed rABCa1687cb9c668: test: stop node before calling assert_start_raises_init_error (authored by Martin Zumsande <mzumsande@gmail.com>).
test: stop node before calling assert_start_raises_init_error
Apr 10 2025
Apr 10 2025
PiRK committed rABC845f8476e440: wallet: validationinterface: only handle active chain notifications (authored by James O'Beirne <james.obeirne@pm.me>).
wallet: validationinterface: only handle active chain notifications
PiRK requested review of D17922: test: add coverage for rpc error when trying to rescan beyond pruned data.
we need to specify the block version in feature_pruning as well (missing backport that specifies version 4 as the default in create_block)
teamcity awarded D17918: wallet: validationinterface: only handle active chain notifications a Haypence token.
PiRK updated the diff for D17918: wallet: validationinterface: only handle active chain notifications.
remove debugging print
PiRK requested review of D17918: wallet: validationinterface: only handle active chain notifications.
Apr 9 2025
Apr 9 2025
it looks good to me. You could also remove the "-schumpeteractivationtime" stuff, it looks like now it is no longer used outside of tests
PiRK committed rABCf881f585a838: test: Introduce ensure_for helper (authored by Fabian Jahr <fjahr@protonmail.com>).
test: Introduce ensure_for helper
Apr 8 2025
Apr 8 2025