Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Apr 25 2025

PiRK added inline comments to D17988: refactor: Replace string chain name constants with ChainTypes.
Apr 25 2025, 19:35
PiRK updated the diff for D17988: refactor: Replace string chain name constants with ChainTypes.

rebase

Apr 25 2025, 09:36
PiRK closed D17987: refactor: Create chaintype files.
Apr 25 2025, 09:34
PiRK committed rABC481f947c6730: refactor: Create chaintype files (authored by TheCharlatan <seb.kung@gmail.com>).
refactor: Create chaintype files
Apr 25 2025, 09:34
PiRK accepted D17995: [CI] Improve artifacts management and allow for custom artifact directory.
Apr 25 2025, 09:32
PiRK published D17994: rpc: Enhance metadata of the dumptxoutset output for review.
Apr 25 2025, 06:13

Apr 24 2025

PiRK accepted D17992: Better uniqueness of the temp dirs for functional tests.
Apr 24 2025, 15:30
PiRK updated the diff for D17987: refactor: Create chaintype files.

don't use C-style cast

Apr 24 2025, 14:08
PiRK closed D17985: rpc: Optimize serialization disk space of dumptxoutset.
Apr 24 2025, 14:06
PiRK committed rABCf23054071280: rpc: Optimize serialization disk space of dumptxoutset (authored by Fabian Jahr <fjahr@protonmail.com>).
rpc: Optimize serialization disk space of dumptxoutset
Apr 24 2025, 14:06
PiRK updated the diff for D17989: Fix chainparams includes.

rebase

Apr 24 2025, 14:01
PiRK updated the diff for D17988: refactor: Replace string chain name constants with ChainTypes.

fix argument name

Apr 24 2025, 13:59
PiRK published D17985: rpc: Optimize serialization disk space of dumptxoutset for review.
Apr 24 2025, 11:46
PiRK updated the summary of D17989: Fix chainparams includes.
Apr 24 2025, 11:14
PiRK updated the summary of D17989: Fix chainparams includes.
Apr 24 2025, 11:12
PiRK added a comment to D17988: refactor: Replace string chain name constants with ChainTypes.

It's a big diff, but the change is pretty trivial. I suggest paying particular attention to paymentserver.cpp during the review because of the raw pointers.

Apr 24 2025, 11:11
PiRK requested review of D17989: Fix chainparams includes.
Apr 24 2025, 11:03
PiRK requested review of D17988: refactor: Replace string chain name constants with ChainTypes.
Apr 24 2025, 11:01
PiRK requested review of D17987: refactor: Create chaintype files.
Apr 24 2025, 10:57

Apr 23 2025

PiRK accepted D17982: wallet: Reset chain notifications handler if AttachChain fails.
Apr 23 2025, 16:04
PiRK accepted D17981: wallet: Postpone wallet loading notification for encrypted wallets.
Apr 23 2025, 16:02
PiRK accepted D17980: wallet: Call load handlers without cs_wallet locked.
Apr 23 2025, 16:01
PiRK accepted D17979: Update test/sanitizer_suppressions/lsan.
Apr 23 2025, 15:59
PiRK accepted D17978: qt: Call setParent() in the parent's context.
Apr 23 2025, 11:35
PiRK updated the summary of D17978: qt: Call setParent() in the parent's context.
Apr 23 2025, 11:34
PiRK closed D17968: assumeUTXO: fix peers disconnection during sync.
Apr 23 2025, 10:42
PiRK committed rABC02749df2f926: assumeUTXO: fix peers disconnection during sync (authored by furszy <matiasfurszyfer@protonmail.com>).
assumeUTXO: fix peers disconnection during sync
Apr 23 2025, 10:42
PiRK updated the diff for D17968: assumeUTXO: fix peers disconnection during sync.

squash with core#30880 (fixes intermittent failure in test)

Apr 23 2025, 09:23
PiRK accepted D17977: Work around a bug in clang < 13.
Apr 23 2025, 09:21
PiRK accepted D17976: Add a release note for the coinstatsindex improvement.
Apr 23 2025, 09:07
PiRK accepted D17970: Disable util::Result copying and assignment.
Apr 23 2025, 08:09
PiRK accepted D17971: [avalanche] Fix a lock order inversion.
Apr 23 2025, 07:37
PiRK accepted D17975: [CI] Fix missing argument in the build script.
Apr 23 2025, 07:37

Apr 22 2025

PiRK closed D17966: assumeutxo,p2p: Start downloading historical blocks from common ancestor.
Apr 22 2025, 21:43
PiRK committed rABC9b32c3476a3e: assumeutxo,p2p: Start downloading historical blocks from common ancestor (authored by Martin Zumsande <mzumsande@gmail.com>).
assumeutxo,p2p: Start downloading historical blocks from common ancestor
Apr 22 2025, 21:43
PiRK committed rABC56115c774db2: init: avoid unsetting service bits from `nLocalServices` (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
init: avoid unsetting service bits from `nLocalServices`
Apr 22 2025, 18:44
PiRK closed D17962: init: avoid unsetting service bits from `nLocalServices`.
Apr 22 2025, 18:44
PiRK planned changes to D17968: assumeUTXO: fix peers disconnection during sync.
Apr 22 2025, 15:30
PiRK updated the diff for D17968: assumeUTXO: fix peers disconnection during sync.

rebase

Apr 22 2025, 14:20
PiRK updated the diff for D17966: assumeutxo,p2p: Start downloading historical blocks from common ancestor.

rebase

Apr 22 2025, 14:20
PiRK updated the diff for D17962: init: avoid unsetting service bits from `nLocalServices`.

rebase

Apr 22 2025, 14:19
PiRK updated the diff for D17968: assumeUTXO: fix peers disconnection during sync.

--blank line

Apr 22 2025, 13:38
PiRK requested review of D17968: assumeUTXO: fix peers disconnection during sync.
Apr 22 2025, 13:33
PiRK accepted D17958: wallet: Move restorewallet() logic to the wallet section.

lgtm, just check that the build-debug passes on CI after rebasing on D17964

Apr 22 2025, 13:29
PiRK requested review of D17966: assumeutxo,p2p: Start downloading historical blocks from common ancestor.
Apr 22 2025, 13:28
PiRK accepted D17964: Safegcd-based modular inverses in MuHash3072.
Apr 22 2025, 13:15
PiRK accepted D17965: [cmake] Add an override option for tmpdirprefix when running functional tests.
Apr 22 2025, 10:53
PiRK added inline comments to D17964: Safegcd-based modular inverses in MuHash3072.
Apr 22 2025, 10:45
PiRK accepted D17963: fuzz: Update FuzzedDataProvider.h from upstream (LLVM).
Apr 22 2025, 09:13
teamcity awarded D17962: init: avoid unsetting service bits from `nLocalServices` a Haypence token.
Apr 22 2025, 07:24
PiRK requested review of D17962: init: avoid unsetting service bits from `nLocalServices`.
Apr 22 2025, 06:47

Apr 21 2025

PiRK closed D17952: refactor: remove ::vpwallets and related global variables.
Apr 21 2025, 21:07
PiRK committed rABCb59ed33b3ac1: refactor: remove ::vpwallets and related global variables (authored by Russell Yanofsky <russ@yanofsky.org>).
refactor: remove ::vpwallets and related global variables
Apr 21 2025, 21:07
PiRK updated the diff for D17952: refactor: remove ::vpwallets and related global variables.

rebase on D17960

Apr 21 2025, 18:36
PiRK accepted D17961: Temporarly ignore the ASAN build failure in wallet_assumeutxo.
Apr 21 2025, 15:59
PiRK accepted D17960: gui: Unregister wallet notifications before unloading wallets.
Apr 21 2025, 15:58
teamcity awarded D17952: refactor: remove ::vpwallets and related global variables a Piece of Eight token.
Apr 21 2025, 13:02
PiRK added a comment to D17952: refactor: remove ::vpwallets and related global variables.

@bot build-tsan

Apr 21 2025, 13:02
PiRK accepted D17957: wallet: refactor GetNewDestination, use BResult.
Apr 21 2025, 11:33
PiRK accepted D17956: send: refactor CreateTransaction flow to return a BResult<CTransactionRef>.
Apr 21 2025, 11:23
PiRK accepted D17954: wallet, refactor: return out-params of CreateTransaction() as optional struct.
Apr 21 2025, 06:20

Apr 20 2025

PiRK planned changes to D17952: refactor: remove ::vpwallets and related global variables.
Apr 20 2025, 05:47

Apr 19 2025

PiRK updated the summary of D17952: refactor: remove ::vpwallets and related global variables.
Apr 19 2025, 21:36
PiRK updated the diff for D17952: refactor: remove ::vpwallets and related global variables.

squash with core#22992

Apr 19 2025, 21:36
PiRK added a comment to D17952: refactor: remove ::vpwallets and related global variables.

Maybe core#22992

Apr 19 2025, 19:31
PiRK updated the diff for D17952: refactor: remove ::vpwallets and related global variables.

more clang-tidy issues (argument names)

Apr 19 2025, 17:21
PiRK added a comment to D17952: refactor: remove ::vpwallets and related global variables.

Let's see if the build-debug segfault is happening consistently

Apr 19 2025, 17:02
PiRK updated the diff for D17952: refactor: remove ::vpwallets and related global variables.

clang-tidy warnings

Apr 19 2025, 17:01
PiRK committed rABCd5c9b24c385c: walletdb: don't read db every time that a new WalletBatch is created, fix last… (authored by furszy <matiasfurszyfer@protonmail.com>).
walletdb: don't read db every time that a new WalletBatch is created, fix last…
Apr 19 2025, 16:48
PiRK closed D17951: walletdb: don't read db every time that a new WalletBatch is created, fix last client version update.
Apr 19 2025, 16:48
PiRK requested changes to D17954: wallet, refactor: return out-params of CreateTransaction() as optional struct.
Apr 19 2025, 16:47
PiRK accepted D17953: rpc: Add specific error code for "wallet already loaded".
Apr 19 2025, 16:45
PiRK planned changes to D17952: refactor: remove ::vpwallets and related global variables.
Apr 19 2025, 11:02
teamcity awarded D17952: refactor: remove ::vpwallets and related global variables a Haypence token.
Apr 19 2025, 08:45
PiRK added a comment to D17952: refactor: remove ::vpwallets and related global variables.

@bot build-asan

Apr 19 2025, 08:44
PiRK requested review of D17952: refactor: remove ::vpwallets and related global variables.
Apr 19 2025, 08:44
PiRK requested review of D17951: walletdb: don't read db every time that a new WalletBatch is created, fix last client version update.
Apr 19 2025, 06:39

Apr 18 2025

PiRK accepted D17950: [avalanche] Fix stake contender unit test occasional failure.
Apr 18 2025, 19:16

Apr 17 2025

PiRK closed D17948: rpc: Include assumeutxo as a failure reason of rescanblockchain.
Apr 17 2025, 20:32
PiRK committed rABCcfca26a80a31: rpc: Include assumeutxo as a failure reason of rescanblockchain (authored by Fabian Jahr <fjahr@protonmail.com>).
rpc: Include assumeutxo as a failure reason of rescanblockchain
Apr 17 2025, 20:32
PiRK closed D17931: add loadtxoutset & getchainstates RPCs, add functional tests.
Apr 17 2025, 20:32
PiRK committed rABCdc73f741fad1: add loadtxoutset & getchainstates RPCs, add functional tests (authored by James O'Beirne <james.obeirne@gmail.com>).
add loadtxoutset & getchainstates RPCs, add functional tests
Apr 17 2025, 20:32
PiRK updated the diff for D17931: add loadtxoutset & getchainstates RPCs, add functional tests.

rebase so i can do arc land --revision D17931 (apparently to force a revision the commit must match )

Apr 17 2025, 20:30
PiRK closed D17947: RPC: access RPC arguments by name.
Apr 17 2025, 20:26
PiRK committed rABC977989ed441c: RPC: access RPC arguments by name (authored by stickies-v <stickies-v@protonmail.com>).
RPC: access RPC arguments by name
Apr 17 2025, 20:26
PiRK closed D17946: rpc, refactor: clean-up `addnode`.
Apr 17 2025, 20:26
PiRK committed rABC159c0dc33237: rpc, refactor: clean-up `addnode` (authored by brunoerg <brunoely.gc@gmail.com>).
rpc, refactor: clean-up `addnode`
Apr 17 2025, 20:26
PiRK updated the diff for D17947: RPC: access RPC arguments by name.

remove accidental character in doxygen doc

Apr 17 2025, 15:39
PiRK added inline comments to D17947: RPC: access RPC arguments by name.
Apr 17 2025, 15:35
PiRK requested review of D17948: rpc: Include assumeutxo as a failure reason of rescanblockchain.
Apr 17 2025, 15:35
PiRK updated the diff for D17931: add loadtxoutset & getchainstates RPCs, add functional tests.

url in RPC doc

Apr 17 2025, 15:32
PiRK requested review of D17947: RPC: access RPC arguments by name.
Apr 17 2025, 15:29
PiRK requested review of D17946: rpc, refactor: clean-up `addnode`.
Apr 17 2025, 15:12
PiRK updated the diff for D17931: add loadtxoutset & getchainstates RPCs, add functional tests.

update syncing -> synced also in test

Apr 17 2025, 14:27
PiRK added inline comments to D17931: add loadtxoutset & getchainstates RPCs, add functional tests.
Apr 17 2025, 14:26
PiRK abandoned D17934: add loadtxoutset & getchainstates RPCs, add functional tests.

forgot to specify --update D17931

Apr 17 2025, 14:25
PiRK updated the diff for D17931: add loadtxoutset & getchainstates RPCs, add functional tests.

fix placeholder text for relmease notes

Apr 17 2025, 14:25
PiRK updated the diff for D17934: add loadtxoutset & getchainstates RPCs, add functional tests.

fix release notes placeholder

Apr 17 2025, 14:24
PiRK updated the diff for D17931: add loadtxoutset & getchainstates RPCs, add functional tests.

use bitcoinabc.org url for doc, don't set a short timeout in wait_until_stopped remove release notes, rename cs -> chainstate

Apr 17 2025, 14:22
PiRK committed rABC86362b831598: test: add "Debug" build to slow builds (authored by PiRK).
test: add "Debug" build to slow builds
Apr 17 2025, 13:15
First
Prev
Next