I ran a full IBD + 12 hours of normal operation, got about 2100 connections during this time, and didn't see a single "Misbehavior" log

rebase

fix the p2p_timeouts.py flakiness by dropping the ping test.

will require a rebase after the parent revision is fixed

I didn't see any intermittent test failures by running it 100 times. So I suggest we keep it unless we start seeing test failures on CI

It didn't take long before failing on CI: https://reviews.bitcoinabc.org/D18034#411094

rebase so I can arc patch on the server

@bot build-ibd-no-assumevalid-checkpoint

test only one message and complete the comment just below to mention why we don't wait_for_disconnect in this test

set it also to false in registerVotes

comment style

replaced by D18021

add a test

initialize disconnect when declaring it. Just don't overwrite false with false

rebase to clean CI. The test failure was for the previous diff version

100 -> true

OK with the behavior fix. Not sure about the clarity of name. Maybe isRemoteProofPresent or hasRemoteProof would be clearer? Or maybe a line of doc for hasRemoteProofStatus and isRemoteProof would clarify things.

I don't understand how this change can cause test failures. Is this based on the master, or on a commit that intentionnaly breaks the tests?

That test failure is a problem with transaction ordering when querying a chronik plugin..

In D17988#410266, @Fabien wrote:

The build failure is unrelated but must be investigated

Looking

pass block hash by const reference & mark function as static

rebase

missing headers ++, unrelated changes --, forward declaration in chainparamsbase.h