Page MenuHomePhabricator
Feed Advanced Search

May 23 2025

PiRK committed rABC27f226810d4d: doc: Improve assumeutxo guide and add more docs/comments (authored by Fabian Jahr <fjahr@protonmail.com>).
doc: Improve assumeutxo guide and add more docs/comments
May 23 2025, 14:10
PiRK closed D18125: [doc] move doc/assumeutxo.md to doc/design.
May 23 2025, 14:10
PiRK committed rABCc7aa13ffe2ea: [doc] move doc/assumeutxo.md to doc/design (authored by PiRK).
[doc] move doc/assumeutxo.md to doc/design
May 23 2025, 14:10
PiRK closed D18131: [test] fix intermittent issues in chronik_electrum_blockchain.
May 23 2025, 12:30
PiRK committed rABC6e3fc0e0fc35: [test] fix intermittent issues in chronik_electrum_blockchain (authored by PiRK).
[test] fix intermittent issues in chronik_electrum_blockchain
May 23 2025, 12:30
PiRK added inline comments to D18131: [test] fix intermittent issues in chronik_electrum_blockchain.
May 23 2025, 11:18
PiRK updated the summary of D18131: [test] fix intermittent issues in chronik_electrum_blockchain.
May 23 2025, 11:18
PiRK requested review of D18131: [test] fix intermittent issues in chronik_electrum_blockchain.
May 23 2025, 11:17
PiRK updated the diff for D18126: doc: Improve assumeutxo guide and add more docs/comments.

feedback

May 23 2025, 10:56
PiRK added inline comments to D18126: doc: Improve assumeutxo guide and add more docs/comments.
May 23 2025, 10:55
PiRK closed D18128: [test] add a verbose logger to ChronikElectrumClient.
May 23 2025, 10:43
PiRK committed rABCfcfc6e89405b: [test] add a verbose logger to ChronikElectrumClient (authored by PiRK).
[test] add a verbose logger to ChronikElectrumClient
May 23 2025, 10:43
PiRK closed D18127: [chronik] fix typo in error message for chronikelectrummaxhistory range check.
May 23 2025, 10:43
PiRK committed rABC66c5ff54693b: [chronik] fix typo in error message for chronikelectrummaxhistory range check (authored by PiRK).
[chronik] fix typo in error message for chronikelectrummaxhistory range check
May 23 2025, 10:43

May 22 2025

PiRK updated the diff for D18128: [test] add a verbose logger to ChronikElectrumClient.

make comment a proper sentence

May 22 2025, 21:02
PiRK added inline comments to D18128: [test] add a verbose logger to ChronikElectrumClient.
May 22 2025, 20:49
PiRK requested review of D18128: [test] add a verbose logger to ChronikElectrumClient.
May 22 2025, 20:46
PiRK requested review of D18127: [chronik] fix typo in error message for chronikelectrummaxhistory range check.
May 22 2025, 14:36
PiRK added inline comments to D18126: doc: Improve assumeutxo guide and add more docs/comments.
May 22 2025, 13:58
PiRK requested review of D18126: doc: Improve assumeutxo guide and add more docs/comments.
May 22 2025, 13:56
PiRK requested review of D18125: [doc] move doc/assumeutxo.md to doc/design.
May 22 2025, 13:52
PiRK added inline comments to D18123: [chronik] Electrum: add the server.features endpoint.
May 22 2025, 08:48
PiRK accepted D18123: [chronik] Electrum: add the server.features endpoint.
May 22 2025, 08:46

May 21 2025

PiRK accepted D18122: [chronik] Electrum: support prefixless addresses.
May 21 2025, 08:03
PiRK closed D18120: [electrum] notify users of release 5.4.2.
May 21 2025, 07:58
PiRK committed rABC9054e5547767: [electrum] notify users of release 5.4.2 (authored by PiRK).
[electrum] notify users of release 5.4.2
May 21 2025, 07:58
PiRK accepted D18121: [bitcoinsuite-core] Fix a potential out of bounds access during address decoding.
May 21 2025, 07:54

May 20 2025

PiRK requested review of D18120: [electrum] notify users of release 5.4.2.
May 20 2025, 20:05
PiRK accepted D18118: [chronik] Electrum: Add the address.get_scripthash endpoint.
May 20 2025, 15:49
PiRK accepted D18114: [chronik] Electrum: gracefully error when the message is too big to be serialized.
May 20 2025, 15:43
PiRK requested changes to D18114: [chronik] Electrum: gracefully error when the message is too big to be serialized.

there is a debbuging true || that needs removing

May 20 2025, 12:59
PiRK closed D18116: [electrum] remove mention of Trezor 1's custom firmware in release note.
May 20 2025, 08:14
PiRK committed rABC36ba9e85ab71: [electrum] remove mention of Trezor 1's custom firmware in release note (authored by PiRK).
[electrum] remove mention of Trezor 1's custom firmware in release note
May 20 2025, 08:14
PiRK updated the diff for D18116: [electrum] remove mention of Trezor 1's custom firmware in release note.

update

May 20 2025, 08:03
PiRK requested review of D18116: [electrum] remove mention of Trezor 1's custom firmware in release note.
May 20 2025, 07:51
PiRK accepted D18115: [electrum] Remove support for the custom firmware on Trezor One.
May 20 2025, 07:17
PiRK added a comment to D18114: [chronik] Electrum: gracefully error when the message is too big to be serialized.

Suggested test plan:

May 20 2025, 06:34

May 19 2025

PiRK accepted D18113: [chronik] Electrum: implicitely enable the scripthashindex if the electrum interface is used.
May 19 2025, 20:55
PiRK closed D18111: [chronik] implement mock server.peers.subscribe electrum RPC.
May 19 2025, 14:26
PiRK committed rABC46742ef18ff2: [chronik] implement mock server.peers.subscribe electrum RPC (authored by PiRK).
[chronik] implement mock server.peers.subscribe electrum RPC
May 19 2025, 14:26
PiRK accepted D18112: [chronik] Electrum: Use TLS as a default protocol.
May 19 2025, 14:20
PiRK updated the diff for D18111: [chronik] implement mock server.peers.subscribe electrum RPC.

fix copied comment

May 19 2025, 11:59
PiRK requested review of D18111: [chronik] implement mock server.peers.subscribe electrum RPC.
May 19 2025, 11:18
PiRK accepted D18108: [chronik] Electrum: handle unconfirmed parents in history.
May 19 2025, 10:37
PiRK accepted D18087: [chronik] Add the blockchain.scripthash.subscribe endpoint.
May 19 2025, 09:43
PiRK updated the summary of D18108: [chronik] Electrum: handle unconfirmed parents in history.
May 19 2025, 08:56
PiRK accepted D18107: [chronik] Electrum: don't assume notifications are returning in array in tests.
May 19 2025, 08:55
PiRK accepted D18106: [chronik] Electrum: consistently avoid repeating the serde_json namespace.
May 19 2025, 08:54
PiRK accepted D18105: [chronik] Electrum: don't enforce returning an array in notifications.
May 19 2025, 08:54

May 16 2025

PiRK closed D18099: [assumeutxo] add release notes.
May 16 2025, 12:57
PiRK committed rABCced8ea5d728c: [assumeutxo] add release notes (authored by PiRK).
[assumeutxo] add release notes
May 16 2025, 12:57
PiRK closed D18093: [assumeutxo] add mainnet and testnet UTXO snapshot checkpoints.
May 16 2025, 12:57
PiRK committed rABC047e69a74a99: [assumeutxo] add mainnet and testnet UTXO snapshot checkpoints (authored by PiRK).
[assumeutxo] add mainnet and testnet UTXO snapshot checkpoints
May 16 2025, 12:57
PiRK accepted D18087: [chronik] Add the blockchain.scripthash.subscribe endpoint.

Tested with an address that initially has confirmed transactions, then receives a mempool transaction, then a new block gets mined: all 3 hashes are identical with Chronik and Fulcrum.

May 16 2025, 12:41
PiRK added a comment to D18087: [chronik] Add the blockchain.scripthash.subscribe endpoint.

Actually I'm only getting the same result for a single tx in the mempool. When the block is mined the status differs.
I imagine that Chronik does not guarantee that the transaction history is ordered in the same order as inside the block.

May 16 2025, 10:05
PiRK accepted D18087: [chronik] Add the blockchain.scripthash.subscribe endpoint.

I'm now getting the same results with Fulcrum and Chronik, with the expected exception of histories containing transactions with unconfirmed parents.

May 16 2025, 09:38
PiRK updated the diff for D18099: [assumeutxo] add release notes.

markdown fix for url

May 16 2025, 09:25
PiRK updated the diff for D18099: [assumeutxo] add release notes.

add a paragraph for chronik vs assumeutxo incompatibility

May 16 2025, 08:48
PiRK updated the diff for D18093: [assumeutxo] add mainnet and testnet UTXO snapshot checkpoints.

remove block date in comment

May 16 2025, 08:32
PiRK committed rABC5a6d424c4a67: Bump version to 0.31.5 (authored by PiRK).
Bump version to 0.31.5
May 16 2025, 06:12
PiRK closed D18098: Bump version to 0.31.5.
May 16 2025, 06:12

May 15 2025

PiRK published D18093: [assumeutxo] add mainnet and testnet UTXO snapshot checkpoints for review.
May 15 2025, 19:52
PiRK requested review of D18099: [assumeutxo] add release notes.
May 15 2025, 19:45
PiRK requested review of D18098: Bump version to 0.31.5.
May 15 2025, 19:19
PiRK added inline comments to D18087: [chronik] Add the blockchain.scripthash.subscribe endpoint.
May 15 2025, 16:28
PiRK added inline comments to D18087: [chronik] Add the blockchain.scripthash.subscribe endpoint.
May 15 2025, 16:20
PiRK added inline comments to D18087: [chronik] Add the blockchain.scripthash.subscribe endpoint.
May 15 2025, 16:10
PiRK accepted D18097: [chronik] Electrum: handle multiple messages in a single packet in the test framework.
May 15 2025, 15:13
PiRK added inline comments to D18097: [chronik] Electrum: handle multiple messages in a single packet in the test framework.
May 15 2025, 15:12
PiRK accepted D18096: Add checkoints after the May 2025 network upgrade.
May 15 2025, 13:47
PiRK accepted D18095: [website] Update the upgrade page after the may 15, 2025 upgrade.
May 15 2025, 13:38
PiRK added a comment to D18094: [e.cash] Mark upgrade as complete - 2025-05-15.

utack

May 15 2025, 13:10
PiRK accepted D18092: [chronik] Add the blockchain.headers.unsubscribe endpoint.
May 15 2025, 10:51
PiRK accepted D18090: [chronik] Fix "elided lifetime has a name" warnings.
May 15 2025, 06:13

May 14 2025

PiRK accepted D18089: [chronik] Extract scripthash history lookup into its own function.
May 14 2025, 20:41

May 13 2025

PiRK closed D18079: [assumeutxo] document and enforce incompatability with -chronik.
May 13 2025, 14:07
PiRK committed rABC29a3da832574: [assumeutxo] document and enforce incompatability with -chronik (authored by PiRK).
[assumeutxo] document and enforce incompatability with -chronik
May 13 2025, 14:07
PiRK updated the diff for D18079: [assumeutxo] document and enforce incompatability with -chronik.

we can only pass "-chronik" if chronik is compiled. Unfortunately there is no convenient way to start the node only if chronik is compiled, so start it with no params if we are not going to run that test.
Add a couple of chronik calls to better check that chronik was succesfully started.

May 13 2025, 08:02
PiRK accepted D18084: [chronik-client] Properly handle txs ordering in the test.

optional suggestions. The bytes flipping + explicit byteorder specification hurts my brain.

May 13 2025, 06:04
PiRK added inline comments to D18084: [chronik-client] Properly handle txs ordering in the test.
May 13 2025, 06:03

May 12 2025

PiRK accepted D18083: More clang-tidy fixes.
May 12 2025, 22:04
PiRK accepted D18081: Remove c++20 header.
May 12 2025, 20:11
PiRK accepted D18082: Fix a use after free error.
May 12 2025, 19:53
teamcity awarded D18073: refactor: Make const refs vars where applicable and enable related clang-tidy checks a Piece of Eight token.
May 12 2025, 19:47
PiRK added a comment to D18073: refactor: Make const refs vars where applicable and enable related clang-tidy checks.

@bot build-tsan

May 12 2025, 19:47
teamcity awarded D18076: clang-tidy: Add more performance checks a Haypence token.
May 12 2025, 19:04
PiRK added a comment to D18076: clang-tidy: Add more performance checks.

@bot build-tsan

May 12 2025, 19:04
teamcity awarded D18071: clang-tidy: Add `performance-no-automatic-move` check a Haypence token.
May 12 2025, 19:04
PiRK added a comment to D18071: clang-tidy: Add `performance-no-automatic-move` check.

@bot build-tsan

May 12 2025, 19:04
PiRK accepted D18080: [chronik] Electrum: add the blockchain.headers.subscribe endpoint.

looks good. Tested on mainnet, results are identical to electrum.bitcoinabc.org

May 12 2025, 18:42
PiRK closed D18076: clang-tidy: Add more performance checks.
May 12 2025, 18:39
PiRK planned changes to D18079: [assumeutxo] document and enforce incompatability with -chronik.
May 12 2025, 18:39
PiRK committed rABCc76a8db83fc4: clang-tidy: Add more performance checks (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
clang-tidy: Add more performance checks
May 12 2025, 18:39
PiRK closed D18075: clang-tidy: Add `performance-inefficient-vector-operation` check.
May 12 2025, 18:39
PiRK committed rABC4faf6bb42918: clang-tidy: Add `performance-inefficient-vector-operation` check (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
clang-tidy: Add `performance-inefficient-vector-operation` check
May 12 2025, 18:39
PiRK closed D18074: Fix clang-tidy readability-const-return-type violations.
May 12 2025, 18:39
PiRK closed D18073: refactor: Make const refs vars where applicable and enable related clang-tidy checks.
May 12 2025, 18:39
PiRK committed rABCfe1b2b8724d7: Fix clang-tidy readability-const-return-type violations (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
Fix clang-tidy readability-const-return-type violations
May 12 2025, 18:39
PiRK committed rABC83dd42f64f19: tidy: add readability-redundant-declaration (authored by fanquake <fanquake@gmail.com>).
tidy: add readability-redundant-declaration
May 12 2025, 18:39
PiRK closed D18072: tidy: add readability-redundant-declaration.
May 12 2025, 18:39