May 31 2025

PiRK closed D18177: qt: Use QRegularExpression in AddressBookSortFilterProxyModel class.

PiRK closed D18176: test: Add tests for tableView in AddressBookPage dialog.

PiRK committed rABC8b29bd47a6f4: qt: Use QRegularExpression in AddressBookSortFilterProxyModel class (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).

qt: Use QRegularExpression in AddressBookSortFilterProxyModel class

PiRK committed rABC34ac317bea88: qt: Replace QRegExp with QRegularExpression (authored by w0xlt <94266259+w0xlt@users.noreply.github.com>).

qt: Replace QRegExp with QRegularExpression

PiRK committed rABCf01762842a8f: test: Add tests for tableView in AddressBookPage dialog (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).

test: Add tests for tableView in AddressBookPage dialog

PiRK closed D18164: qt: Do not pass WalletModel* to a queued connection.

PiRK closed D18163: qt: Replace `QCoreApplication::quit()` with `QCoreApplication::exit(0)`.

PiRK committed rABC7d5163beff28: qt: Do not pass WalletModel* to a queued connection (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).

qt: Do not pass WalletModel* to a queued connection

PiRK committed rABC0a567d65df81: qt: Replace `QCoreApplication::quit()` with `QCoreApplication::exit(0)` (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).

qt: Replace `QCoreApplication::quit()` with `QCoreApplication::exit(0)`

PiRK accepted D18181: [chronik] Rename estimate_fee to estimate_feerate_sats_per_kb.

PiRK closed D18170: Reapply "gui: Do not exit and re-enter main event loop during shutdown".

PiRK accepted D18180: [chronik] Electrum: flush the send buffer in tests.

Jun 2 2025, 08:33

May 31 2025

PiRK added a comment to D18177: qt: Use QRegularExpression in AddressBookSortFilterProxyModel class.

Note that we are still at least one backport short of being able to test the Qt6 code branches (core-gui#623)

May 31 2025, 11:46

PiRK requested review of D18178: qt: Replace QRegExp with QRegularExpression.

May 31 2025, 11:45

PiRK requested review of D18177: qt: Use QRegularExpression in AddressBookSortFilterProxyModel class.

May 31 2025, 11:43

PiRK requested review of D18176: test: Add tests for tableView in AddressBookPage dialog.

May 31 2025, 11:42

PiRK updated the diff for D18164: qt: Do not pass WalletModel* to a queued connection.

add an assertion that m_executor is not null

May 31 2025, 06:23

PiRK updated the diff for D18163: qt: Replace `QCoreApplication::quit()` with `QCoreApplication::exit(0)`.

rebase after landing D18170

May 31 2025, 06:17

May 31 2025, 06:15

PiRK added a reverting change for D18150: gui: Do not exit and re-enter main event loop during shutdown: rABC82570aaa9fb4: Reapply "gui: Do not exit and re-enter main event loop during shutdown".

May 31 2025, 06:15

PiRK committed rABC82570aaa9fb4: Reapply "gui: Do not exit and re-enter main event loop during shutdown" (authored by PiRK).

Reapply "gui: Do not exit and re-enter main event loop during shutdown"

May 31 2025, 06:15

May 29 2025

PiRK published D18170: Reapply "gui: Do not exit and re-enter main event loop during shutdown" for review.

May 29 2025, 22:17

PiRK planned changes to D18163: qt: Replace `QCoreApplication::quit()` with `QCoreApplication::exit(0)`.

May 29 2025, 14:28

PiRK requested review of D18163: qt: Replace `QCoreApplication::quit()` with `QCoreApplication::exit(0)`.

will need to be rebased onto D18170 (if/when it is tested and reviewed)

May 29 2025, 14:28

PiRK accepted D18169: [chronik] Electrum: Implement the blockchain.header.get endpoint.

May 29 2025, 14:25

PiRK added a reverting change for D18150: gui: Do not exit and re-enter main event loop during shutdown: D18170: Reapply "gui: Do not exit and re-enter main event loop during shutdown".

May 29 2025, 14:20

PiRK added inline comments to D18164: qt: Do not pass WalletModel* to a queued connection.

May 29 2025, 09:49

PiRK requested changes to D18169: [chronik] Electrum: Implement the blockchain.header.get endpoint.

almost LGTM

May 29 2025, 09:40

PiRK accepted D18167: [chronik] Electrum: Implement the blockchain.estimatefee endpoint.

May 29 2025, 09:19

PiRK accepted D18161: [chronik] Electrum: implement address.(un)subscribe endpoints.

May 29 2025, 09:16

May 28 2025

PiRK accepted D18166: Revert "gui: Do not exit and re-enter main event loop during shutdown".

May 28 2025, 13:02

PiRK closed D18165: [doc] add a download link for assumeutxo snapshots.

May 28 2025, 09:15

PiRK committed rABC3cfa46ddb686: [doc] add a download link for assumeutxo snapshots (authored by PiRK).

[doc] add a download link for assumeutxo snapshots

May 28 2025, 09:15

PiRK retitled D18165: [doc] add a download link for assumeutxo snapshots from [doc] add ia download link for assumeutxo snapshots to [doc] add a download link for assumeutxo snapshots.

May 28 2025, 09:07

PiRK requested review of D18165: [doc] add a download link for assumeutxo snapshots.

May 28 2025, 09:06

PiRK accepted D18162: [secp256k1] Actually use debian 12 on CI.

May 28 2025, 08:55

PiRK requested review of D18164: qt: Do not pass WalletModel* to a queued connection.

May 28 2025, 08:53

PiRK requested review of D18163: qt: Replace `QCoreApplication::quit()` with `QCoreApplication::exit(0)`.

May 28 2025, 08:52

PiRK accepted D18156: [chronik] Electrum: Implement the *.get_mempool endpoint.

May 28 2025, 06:24

May 27 2025

PiRK accepted D18159: ci: Adjust Docker image to Debian 12 "bookworm".

May 27 2025, 15:09

PiRK accepted D18158: [secp256k1] ct: Use volatile "trick" in all fe/scalar cmov implementations.

May 27 2025, 15:07

PiRK accepted D18157: [secp256k1] Use modified divsteps with initial delta=1/2 for constant-time.

May 27 2025, 14:58

PiRK requested changes to D18156: [chronik] Electrum: Implement the *.get_mempool endpoint.

looks good but clippy is unhappy about a needless borrow

May 27 2025, 14:54

PiRK accepted D18154: [chronik] Electrum: Implement the *.get_first_use endpoints.

May 27 2025, 08:21

PiRK requested changes to D18154: [chronik] Electrum: Implement the *.get_first_use endpoints.

May 27 2025, 07:00

PiRK added inline comments to D18154: [chronik] Electrum: Implement the *.get_first_use endpoints.

May 27 2025, 06:59

PiRK accepted D18151: [chronik] Electrum: implement peer discovery endpoints.

May 27 2025, 06:46

May 26 2025

PiRK accepted D18153: [chronik] Electrum: implement address.get_balance, get_history and listunspent.

May 26 2025, 15:11

PiRK accepted D18152: [chronik] Electrum: implement the banner endoint.

May 26 2025, 14:46

PiRK closed D18150: gui: Do not exit and re-enter main event loop during shutdown.

PiRK committed rABC1219aeddf633: gui: Do not exit and re-enter main event loop during shutdown (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).

gui: Do not exit and re-enter main event loop during shutdown

PiRK committed rABC8728198bcb8e: gui: replace some QDialog::exec() with safer QDialog::show() calls (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).

gui: replace some QDialog::exec() with safer QDialog::show() calls

PiRK closed D18146: qt: don't pass config to BitcoinApplication::requestShutdown.

PiRK closed D18149: gui: replace some QDialog::exec() with safer QDialog::show() calls.

PiRK committed rABC076cec51f98f: qt: don't pass config to BitcoinApplication::requestShutdown (authored by PiRK).

qt: don't pass config to BitcoinApplication::requestShutdown

PiRK committed rABC68514a0d2cc5: qt: make BitcoinGui::config a const ref (authored by PiRK).

qt: make BitcoinGui::config a const ref

PiRK closed D18145: qt: make BitcoinGui::config a const ref.

PiRK accepted D18148: [chronik] Bump karyon_jsonrpc to version 0.3.2.

I have been able to request a very large history that didn't work before this diff.

May 26 2025, 11:32

PiRK closed D18141: qt: Do not assume `qDBusRegisterMetaType` return type.

PiRK committed rABCc0960d91959f: qt: Do not use `QKeyEvent` copy constructor (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).

qt: Do not use `QKeyEvent` copy constructor

PiRK closed D18140: qt: Do not use `QKeyEvent` copy constructor.

PiRK committed rABC826973909760: qt: Do not assume `qDBusRegisterMetaType` return type (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).

qt: Do not assume `qDBusRegisterMetaType` return type

PiRK closed D18138: qt: misc fixed for deprecation warnings.

PiRK closed D18139: qt: Remove `QApplication::globalStrut()` call.

PiRK committed rABCcdc0de237e20: qt: Remove `QApplication::globalStrut()` call (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).

qt: Remove `QApplication::globalStrut()` call

PiRK committed rABC4e3c327e3eb2: qt: misc fixed for deprecation warnings (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).

qt: misc fixed for deprecation warnings

PiRK closed D18137: qt: Avoid potential -Wdeprecated-enum-enum-conversion warnings.

PiRK committed rABC50946bc94edf: qt: Avoid potential -Wdeprecated-enum-enum-conversion warnings (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).

qt: Avoid potential -Wdeprecated-enum-enum-conversion warnings