Update per @jasonbcox feedback
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jul 9 2019
Jul 9 2019
Update per @Fabien comments
Jul 8 2019
Jul 8 2019
Mengerian added inline comments to D3474: Implement new checkmultisig trigger logic and execution logic..
Jul 2 2019
Jul 2 2019
Prettify README title
Change alt text to "Bitcoin ABC Logo"
Update test plan for alt text
Jun 28 2019
Jun 28 2019
D3444: Bump version to 0.19.10 is now accepted and ready to land.
Jun 27 2019
Jun 27 2019
Checked mainnet and testnet with my local node.
Jun 26 2019
Jun 26 2019
Looks good to me.
It all looks good to me.
Jun 25 2019
Jun 25 2019
Jun 23 2019
Jun 23 2019
In D3331#80339, @markblundeberg wrote:Note: in principle in this Diff, I could take out the two remaining *uses* of this flag as well, from MANDATORY_SCRIPT_VERIFY_FLAGS and from GetNextBlockScriptFlags (aka GetBlockScriptFlags). At the moment they are removed in the follow-up diff D3332.
If I did this, then D3332 would be basically a pure test-cleanup diff that quite manifestly doesn't touch any consensus code.
Jun 13 2019
Jun 13 2019
Jun 10 2019
Jun 10 2019
Jun 9 2019
Jun 9 2019
D3262: Add script tests with valid 64-byte ECDSA signatures. is now accepted and ready to land.
Checked throught the Diff again, looks good to me.
Jun 8 2019
Jun 8 2019
D3262: Add script tests with valid 64-byte ECDSA signatures. is now accepted and ready to land.
This looks good to me. I played around with this a bit, it all seems to work.
Mengerian committed rABC3c56495801af: Update timing.json Segwit Recovery functional test name (authored by Mengerian).
Update timing.json Segwit Recovery functional test name
Remove added newline
Did another pass over the Diff today, it looks good to me.
Jun 7 2019
Jun 7 2019
D3255: Remove unused great wall activation code is now accepted and ready to land.
Looks good to me.
D3253: Remove Schnorr activation now requires changes to proceed.
Looks good overall, I noted a couple minor nits.
Jun 5 2019
Jun 5 2019
Clean up Segwit Recovery feature
Mengerian added reviewers for D3194: Clean up Segwit Recovery feature: markblundeberg, Fabien, jasonbcox.
Add more reviewers
Abandon in favor of D3194
Abandon in favor of D3194
Abandon in favor of D3194
Abandon in favor of D3194
Update script test comments per Mark's suggestion
Rebase
Jun 4 2019
Jun 4 2019
Mengerian added a revision to T653: Clean up past upgrades: D3194: Clean up Segwit Recovery feature.
@deadalnix I don't have a clear understanding of what you want.
May 31 2019
May 31 2019
Update test plan
Improve description
Rebase on D3065
Rename test class
Rename functional test
May 30 2019
May 30 2019
Rebase on D3065
Restore functional test portion that test accepting blocks containing Segwit recovery transactions.
Add dependency to description.
Herald added a reviewer for D3160: Make SCRIPT_DISALLOW_SEGWIT_RECOVERY a standard flag: Restricted Project.
Edit description.
Change functional test to run at "current" time.
Rebase on updated D3248
Add unit tests for "0 left on stack" case with segwit recovery disallowed.
Clarify descriptions of script tests so that it's easier to see tests with the flag enabled.
Mengerian committed rABCa9d87ac6ade5: Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from Schnorr test (authored by Mengerian).
Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from Schnorr test
Add post-upgrade testnet checkpoint
May 29 2019
May 29 2019
@deadalnix I am trying to follow the step you outlined here: https://reviews.bitcoinabc.org/D3065#72372
Mengerian added a revision to T653: Clean up past upgrades: D3148: Invert meaning of Segwit Recovery flag..
Mengerian added a revision to T653: Clean up past upgrades: D3149: Add post-upgrade testnet checkpoint.
To do: add to standard flags.
Work in progress
Rebase on D3148
I will rebase this on top of D3148 as-per @deadalnix review comment.
May 28 2019
May 28 2019
Herald added a reviewer for D3144: Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from Schnorr test: deadalnix.
Herald added a reviewer for D3143: Rename SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag in scriptflags.cpp: Restricted Project.
Mengerian committed rABC11febd55e5a8: Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from script tests (authored by Mengerian).
Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from script tests
Mengerian updated the diff for D3140: Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from script tests.
Keep flag name in scriptflags.cpp list
Mengerian added inline comments to D3140: Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from script tests.
Mengerian updated the diff for D3140: Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from script tests.
Remove duplicate test cases
Herald added a reviewer for D3140: Remove SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag from script tests: Restricted Project.
May 27 2019
May 27 2019
Mengerian committed rABC47a8898b14e7: Add comments indicating "Schnorr" in Schnorr-related script tests. (authored by Mengerian).
Add comments indicating "Schnorr" in Schnorr-related script tests.
Herald added a reviewer for D3130: Add comments indicating "Schnorr" in Schnorr-related script tests.: deadalnix.
Mengerian committed rABCed9bf5b2e489: Rename SCRIPT_ENABLE_CHECKDATASIG to SCRIPT_VERIFY_CHECKDATASIG_SIGOPS. (authored by Mengerian).
Rename SCRIPT_ENABLE_CHECKDATASIG to SCRIPT_VERIFY_CHECKDATASIG_SIGOPS.
Mengerian updated the diff for D3112: Rename SCRIPT_ENABLE_CHECKDATASIG to SCRIPT_VERIFY_CHECKDATASIG_SIGOPS..
Rebase
Mengerian updated the diff for D3112: Rename SCRIPT_ENABLE_CHECKDATASIG to SCRIPT_VERIFY_CHECKDATASIG_SIGOPS..
Rebase
Mengerian updated the diff for D3112: Rename SCRIPT_ENABLE_CHECKDATASIG to SCRIPT_VERIFY_CHECKDATASIG_SIGOPS..
Don't rename flag in script tests.
Rebase on master.
May 25 2019
May 25 2019
Mengerian added inline comments to D3113: Comments: More comments on functions/globals in standard.h..