@tobias_ruck Could you change the name to OP_REVERSEBYTES in the Diff title?
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Jan 20 2020
It would reverse the metric setting logic as to avoid a double negation. Everything else is good to go.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
fixes code comments
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
reverted code
Build Bitcoin-ABC / Diffs / Diff Testing started.
remove reverted code
The final revert is done in D4946
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
rebase from master
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Update as per comments
The general approach look good. Obviously, Without changing ScriptExecutionMetrics, it's hard to ensure your invariants hold, so you may want to unpod that guy as well.
Diff updated to address feedback.
The method has changed since the last revision: I added a new option that allow the caller to set a meaningful test suite name and use it in the JUnit output.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Add an option to set the name.
Unhappy tests on my local run (with upgrade activated):
abc-mempool-accept-txn.py | ✖ Failed | 1 s abc-p2p-fullblocktest.py | ✖ Failed | 45 s feature_block.py | ✖ Failed | 62 s
The C++ tests seems to be totally happy, the main issue is dealing with functional tests.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
is wip
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
@deadalnix returning for review due to slight changes. Note after our discussion that ScriptExecutionMetrics will remain a pure struct (as it is in this diff) since accumulation etc will happen elsewhere.
Build Bitcoin-ABC / Diffs / Diff Testing started.
remove dependency on D4834 , use xor
Build Bitcoin-ABC / Diffs / Diff Testing started.
Jan 19 2020
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.