Rebase
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
May 13 2020
May 12 2020
Fixed two assert_debug_log usages that "depend" on the old behavior, but don't need to.
In D6041#147892, @Fabien wrote:This is causing a large number of tests to fail
After some discussion with Fabien, it's clear this solution is not robust enough in the short term to warrant a bandaid that is not scalable in the long-term.
May 11 2020
Fix comment
Make the review checking more similar to arc land's implementation so
as not to have to check for the ABC reviewer group specifically.
Rebase on the right stack so tests pass
Bump misbehaving factor to 20
Fix median calculation when both elements are odd
In D6017#147418, @Fabien wrote:I don't understand why you need to do the check in this script. Isn't it already checked by arc land ?
- Use genesis time from chainparams
- Use Misbehaving() instead of just logging
Just remove the pretty printing entirely
Tweaked error message text
In D6018#147472, @deadalnix wrote:I have no problem with this per se now that it is done, but you got to wonder how that became a problem worth fixing in the first place. Why not run these scripts from master to begin with instead of using the version of the patch?
May 10 2020
May 8 2020
Fix lint issue
May 7 2020
Submitted upstream: https://github.com/jgarzik/univalue/pull/70
- UniValueStream -> UniValueStreamWriter
- Use getter instead of direct access to str
I assume this work is related to https://github.com/bitcoin/bitcoin/pull/15976/commits/d7c97edeea8cee10ad9da1f940d39d5073ac142d
We already own this part of the code due to D364 and that commit on Core appears to be shuffling DisconnectResult into validation.h which is not a good long-term solution.
This looks like the right approach, but the naming should change now that it sits on its own at the src level.