Page MenuHomePhabricator
Feed Advanced Search

Nov 21 2024

teamcity awarded D17178: [Cmake] Use CMAKE_PROJECT_NAME in src/config/CMakeLists.txt a Haypence token.
Nov 21 2024, 13:53
tobias_ruck retitled D17178: [Cmake] Use CMAKE_PROJECT_NAME in src/config/CMakeLists.txt from [Cmake] Add ROOT_PROJECT_NAME, use in src/config/CMakeLists.txt to [Cmake] Use CMAKE_PROJECT_NAME in src/config/CMakeLists.txt.
Nov 21 2024, 13:47
tobias_ruck updated the diff for D17178: [Cmake] Use CMAKE_PROJECT_NAME in src/config/CMakeLists.txt.

remove unrelated changes

Nov 21 2024, 13:41
tobias_ruck updated the diff for D17178: [Cmake] Use CMAKE_PROJECT_NAME in src/config/CMakeLists.txt.

we already have CMAKE_PROJECT_NAME, use that instead of making our own

Nov 21 2024, 13:40
tobias_ruck requested review of D17178: [Cmake] Use CMAKE_PROJECT_NAME in src/config/CMakeLists.txt.
Nov 21 2024, 13:36

Nov 20 2024

tobias_ruck added a comment to D17167: [chronik] updated dependencies - Cargo.lock.

@bot build-chronik-plugins

Nov 20 2024, 12:50
tobias_ruck requested changes to D17167: [chronik] updated dependencies - Cargo.lock.

the title is wrong (the file was already there) and the test plan too (missing -)

Nov 20 2024, 12:49
tobias_ruck accepted D17155: [CHRONIK] add is_final to tx struct in util.rs.
Nov 20 2024, 11:43

Nov 19 2024

tobias_ruck requested changes to D17155: [CHRONIK] add is_final to tx struct in util.rs.
Nov 19 2024, 22:12

Nov 9 2024

tobias_ruck accepted D17043: [chronik] implement scripthash type for utxos endpoints.
Nov 9 2024, 17:26
tobias_ruck accepted D17037: [chronik] index scripts by scripthashes in the mempool.

beautifully written!

Nov 9 2024, 17:16

Nov 8 2024

tobias_ruck added inline comments to D17043: [chronik] implement scripthash type for utxos endpoints.
Nov 8 2024, 13:37

Nov 5 2024

teamcity awarded D16966: [Chronik] Build Bitcoin Core with Chronik attached a Like token.
Nov 5 2024, 10:01
teamcity awarded D16966: [Chronik] Build Bitcoin Core with Chronik attached a Love token.
Nov 5 2024, 09:24
teamcity awarded D16966: [Chronik] Build Bitcoin Core with Chronik attached a Like token.
Nov 5 2024, 08:58
teamcity awarded D16966: [Chronik] Build Bitcoin Core with Chronik attached a Love token.
Nov 5 2024, 08:16

Nov 4 2024

tobias_ruck added inline comments to D17037: [chronik] index scripts by scripthashes in the mempool.
Nov 4 2024, 12:45

Nov 2 2024

tobias_ruck added inline comments to D17046: [new lokad] Add spec for onchain trollbox for tokens.
Nov 2 2024, 08:18
tobias_ruck accepted D17046: [new lokad] Add spec for onchain trollbox for tokens.
Nov 2 2024, 05:05

Nov 1 2024

tobias_ruck added inline comments to D17037: [chronik] index scripts by scripthashes in the mempool.
Nov 1 2024, 19:36
tobias_ruck added inline comments to D17037: [chronik] index scripts by scripthashes in the mempool.
Nov 1 2024, 19:34
tobias_ruck requested changes to D17037: [chronik] index scripts by scripthashes in the mempool.
Nov 1 2024, 19:31
tobias_ruck added inline comments to D16937: [chronik] add scripthash option to the various script endpoints.
Nov 1 2024, 19:28
tobias_ruck accepted D16937: [chronik] add scripthash option to the various script endpoints.

One nit

Nov 1 2024, 19:27
tobias_ruck accepted D16944: [ecash-agora] Add validation to _acceptTxBuilder to prevent creation of unspendable offers.

Otherwise lgtm

Nov 1 2024, 19:19
tobias_ruck requested changes to D17046: [new lokad] Add spec for onchain trollbox for tokens.

Otherwise seems good to go, the timeFirstSeen seems fine.

Nov 1 2024, 17:42

Oct 31 2024

tobias_ruck requested changes to D17046: [new lokad] Add spec for onchain trollbox for tokens.
Oct 31 2024, 07:56
tobias_ruck added a comment to D17046: [new lokad] Add spec for onchain trollbox for tokens.

We might also want to use Shammah's CashWeb, which is much more generic and powerful, but also creates much less data on-chain:

Oct 31 2024, 07:56

Oct 30 2024

tobias_ruck requested changes to D17037: [chronik] index scripts by scripthashes in the mempool.
Oct 30 2024, 17:16
tobias_ruck requested changes to D16937: [chronik] add scripthash option to the various script endpoints.
Oct 30 2024, 16:39
tobias_ruck requested changes to D16944: [ecash-agora] Add validation to _acceptTxBuilder to prevent creation of unspendable offers.
Oct 30 2024, 16:29
tobias_ruck requested changes to D17046: [new lokad] Add spec for onchain trollbox for tokens.
Oct 30 2024, 16:19

Oct 29 2024

tobias_ruck requested changes to D16937: [chronik] add scripthash option to the various script endpoints.
Oct 29 2024, 11:30

Oct 26 2024

tobias_ruck requested changes to D16937: [chronik] add scripthash option to the various script endpoints.
Oct 26 2024, 11:59

Oct 25 2024

tobias_ruck published D17000: [64-bit ints] Move `{Add,Sub}Int63Overflow(Emulated)` impl to cpp file for review.
Oct 25 2024, 08:55
tobias_ruck updated the summary of D16996: [64-bit ints] Change `CScriptNum::getint` to return `int64_t`.
Oct 25 2024, 08:45
tobias_ruck updated the diff for D16996: [64-bit ints] Change `CScriptNum::getint` to return `int64_t`.

remove getint32, change ScriptNum10::getint instead to support int64_t

Oct 25 2024, 08:42
tobias_ruck accepted D16827: [chronik] store a scripthash -> script index.

One comment nit

Oct 25 2024, 08:16

Oct 24 2024

tobias_ruck requested review of D16996: [64-bit ints] Change `CScriptNum::getint` to return `int64_t`.
Oct 24 2024, 23:57
tobias_ruck accepted D16990: [ecash-herald] Parse token actions in daily summary msgs.
Oct 24 2024, 23:52
tobias_ruck accepted D16991: [Cashtab] Patch displayed spot prices for agora offers.
Oct 24 2024, 23:40
tobias_ruck accepted D16995: [ecash-agora] Improve approximation for USD-esque tokens.

Note: you can remove the note or un-bold it and move it to the bottom

Oct 24 2024, 23:21
teamcity awarded D16966: [Chronik] Build Bitcoin Core with Chronik attached a Like token.
Oct 24 2024, 22:16
tobias_ruck requested changes to D16827: [chronik] store a scripthash -> script index.
Oct 24 2024, 19:27
tobias_ruck closed D16981: [CI] Update build-configurations with secp256k1 dependencies.
Oct 24 2024, 14:17
tobias_ruck committed rABC218edc02974a: [CI] Update build-configurations with secp256k1 dependencies (authored by tobias_ruck).
[CI] Update build-configurations with secp256k1 dependencies
Oct 24 2024, 14:17
tobias_ruck abandoned D16907: [ecash-lib] Add `rust-secp256k1`, use in `ecash-lib-wasm`.
Oct 24 2024, 13:17
tobias_ruck requested changes to D16937: [chronik] add scripthash option to the various script endpoints.
Oct 24 2024, 12:24
tobias_ruck closed D16982: [Iguana] Display empty stack items as `""`.
Oct 24 2024, 12:10
tobias_ruck committed rABCde1c383640b3: [Iguana] Display empty stack items as `""` (authored by tobias_ruck).
[Iguana] Display empty stack items as `""`
Oct 24 2024, 12:09
tobias_ruck requested review of D16982: [Iguana] Display empty stack items as `""`.
Oct 24 2024, 10:07
tobias_ruck closed D16980: [linter] Fix shebang lint false positive.
Oct 24 2024, 09:34
tobias_ruck committed rABCcabdfe09fbe5: [linter] Fix shebang lint false positive (authored by tobias_ruck).
[linter] Fix shebang lint false positive
Oct 24 2024, 09:34
tobias_ruck requested changes to D16937: [chronik] add scripthash option to the various script endpoints.
Oct 24 2024, 09:28
tobias_ruck requested changes to D16827: [chronik] store a scripthash -> script index.
Oct 24 2024, 09:14
tobias_ruck added inline comments to D16827: [chronik] store a scripthash -> script index.
Oct 24 2024, 09:14
tobias_ruck requested review of D16981: [CI] Update build-configurations with secp256k1 dependencies.
Oct 24 2024, 09:05
tobias_ruck requested review of D16980: [linter] Fix shebang lint false positive.
Oct 24 2024, 09:04
tobias_ruck closed D16956: [ecash-secp256k1] Add `ecash-secp256k1`, use in `ecash-lib-wasm`.
Oct 24 2024, 08:23
tobias_ruck committed rABCbeb30ceabc8b: [ecash-secp256k1] Add `ecash-secp256k1`, use in `ecash-lib-wasm` (authored by tobias_ruck).
[ecash-secp256k1] Add `ecash-secp256k1`, use in `ecash-lib-wasm`
Oct 24 2024, 08:23
tobias_ruck added a comment to D16827: [chronik] store a scripthash -> script index.

It seems like you're not indexing the mempool for scripthash yet, will this be in another diff? If so, add it to the summary. Otherwise I think it's fine to keep it in this diff, it's just a relatively simple HashMap.

Oct 24 2024, 08:20
teamcity awarded D16966: [Chronik] Build Bitcoin Core with Chronik attached a Love token.
Oct 24 2024, 08:09
tobias_ruck updated the diff for D16956: [ecash-secp256k1] Add `ecash-secp256k1`, use in `ecash-lib-wasm`.

fix is_empty

Oct 24 2024, 07:33
tobias_ruck updated the diff for D16956: [ecash-secp256k1] Add `ecash-secp256k1`, use in `ecash-lib-wasm`.

uncomment secp256k1_sys test

Oct 24 2024, 07:31

Oct 23 2024

tobias_ruck updated the diff for D16956: [ecash-secp256k1] Add `ecash-secp256k1`, use in `ecash-lib-wasm`.

fix one usage of PublicKey

Oct 23 2024, 23:42
tobias_ruck added inline comments to D16956: [ecash-secp256k1] Add `ecash-secp256k1`, use in `ecash-lib-wasm`.
Oct 23 2024, 23:12
tobias_ruck updated the diff for D16956: [ecash-secp256k1] Add `ecash-secp256k1`, use in `ecash-lib-wasm`.
  • update URLs in Cargo.toml
  • update README
  • remove unused elligator const
  • remove unused deprecated functions, and undeprecate functions that clearly are useful
  • uncomment test
Oct 23 2024, 23:11
tobias_ruck closed D16968: [secp256k1] Backport "'Schnorrsig API overhaul' fixups".
Oct 23 2024, 22:22
tobias_ruck committed rABC79b2e673791c: [secp256k1] Backport "'Schnorrsig API overhaul' fixups" (authored by tobias_ruck).
[secp256k1] Backport "'Schnorrsig API overhaul' fixups"
Oct 23 2024, 22:22
tobias_ruck updated the diff for D16968: [secp256k1] Backport "'Schnorrsig API overhaul' fixups".

rebase onto master

Oct 23 2024, 21:00
tobias_ruck updated the diff for D16968: [secp256k1] Backport "'Schnorrsig API overhaul' fixups".

remove unneeded installs

Oct 23 2024, 20:42
tobias_ruck added inline comments to D16968: [secp256k1] Backport "'Schnorrsig API overhaul' fixups".
Oct 23 2024, 20:39
tobias_ruck closed D16953: [ecash-secp256k1] Add `ecash-secp256k1-sys`.
Oct 23 2024, 20:30
tobias_ruck committed rABCd3f9fae6c48e: [ecash-secp256k1] Add `ecash-secp256k1-sys` (authored by tobias_ruck).
[ecash-secp256k1] Add `ecash-secp256k1-sys`
Oct 23 2024, 20:30
teamcity awarded D16966: [Chronik] Build Bitcoin Core with Chronik attached a Like token.
Oct 23 2024, 19:47
teamcity awarded D16966: [Chronik] Build Bitcoin Core with Chronik attached a Love token.
Oct 23 2024, 19:39
teamcity awarded D16966: [Chronik] Build Bitcoin Core with Chronik attached a Like token.
Oct 23 2024, 19:14
teamcity awarded D16966: [Chronik] Build Bitcoin Core with Chronik attached a Love token.
Oct 23 2024, 18:46
teamcity awarded D16966: [Chronik] Build Bitcoin Core with Chronik attached a Like token.
Oct 23 2024, 18:36
teamcity awarded D16966: [Chronik] Build Bitcoin Core with Chronik attached a Love token.
Oct 23 2024, 18:26
teamcity awarded D16966: [Chronik] Build Bitcoin Core with Chronik attached a Like token.
Oct 23 2024, 18:17
teamcity awarded D16966: [Chronik] Build Bitcoin Core with Chronik attached a Love token.
Oct 23 2024, 17:59
teamcity awarded D16966: [Chronik] Build Bitcoin Core with Chronik attached a Like token.
Oct 23 2024, 17:28
teamcity awarded D16953: [ecash-secp256k1] Add `ecash-secp256k1-sys` a Doubloon token.
Oct 23 2024, 16:45
tobias_ruck added a comment to D16953: [ecash-secp256k1] Add `ecash-secp256k1-sys`.

@bot build-ecash-secp256k1

Oct 23 2024, 16:45
teamcity awarded D16966: [Chronik] Build Bitcoin Core with Chronik attached a Mountain of Wealth token.
Oct 23 2024, 16:43
tobias_ruck closed D16958: [secp256k1] Backport "Schnorrsig API overhaul".
Oct 23 2024, 16:35
tobias_ruck committed rABCc422b039a7f5: [secp256k1] Backport "Schnorrsig API overhaul" (authored by tobias_ruck).
[secp256k1] Backport "Schnorrsig API overhaul"
Oct 23 2024, 16:35
tobias_ruck updated the diff for D16953: [ecash-secp256k1] Add `ecash-secp256k1-sys`.

use TOPLEVEL, imitated after ibd.sh

Oct 23 2024, 16:34
tobias_ruck added inline comments to D16953: [ecash-secp256k1] Add `ecash-secp256k1-sys`.
Oct 23 2024, 16:32
teamcity awarded D16966: [Chronik] Build Bitcoin Core with Chronik attached a Doubloon token.
Oct 23 2024, 16:21
tobias_ruck requested review of D16968: [secp256k1] Backport "'Schnorrsig API overhaul' fixups".
Oct 23 2024, 16:11
tobias_ruck updated the diff for D16958: [secp256k1] Backport "Schnorrsig API overhaul".

also backport README change

Oct 23 2024, 16:03
teamcity awarded D16966: [Chronik] Build Bitcoin Core with Chronik attached a Piece of Eight token.
Oct 23 2024, 15:33
teamcity awarded D16966: [Chronik] Build Bitcoin Core with Chronik attached a Haypence token.
Oct 23 2024, 15:18
tobias_ruck added inline comments to D16827: [chronik] store a scripthash -> script index.
Oct 23 2024, 15:09

Oct 22 2024

teamcity awarded D16956: [ecash-secp256k1] Add `ecash-secp256k1`, use in `ecash-lib-wasm` a Mountain of Wealth token.
Oct 22 2024, 20:25
tobias_ruck added a comment to D16956: [ecash-secp256k1] Add `ecash-secp256k1`, use in `ecash-lib-wasm`.

@bot build-ecash-secp256k1

Oct 22 2024, 20:25
tobias_ruck updated the summary of D16953: [ecash-secp256k1] Add `ecash-secp256k1-sys`.
Oct 22 2024, 20:23
tobias_ruck updated the summary of D16956: [ecash-secp256k1] Add `ecash-secp256k1`, use in `ecash-lib-wasm`.
Oct 22 2024, 20:16