add back const qualifier for colorText (never moved)

In the test plan it should probably be createwallet instead of create (that worked for me)

fix remaining warning

15:34:35

/work/src/minerfund.cpp:80:13: error: this STL algorithm call should be replaced with a container method [performance-inefficient-algorithm,-warnings-as-errors]

This does not work yet. When testing on mainnet with a very recent snapshot, the node crashed before finishing background IBD because chronik tried to index a mempool tx that was spending coins not yet indexed.

The CI found more, confirmed locally by nuking the build dir & ccache and restarting the compilation from scratch

the CI keeps finding more when locally the build passes

more

i missed two

move dummy code to #else branch

don't use conditional compilation for lambda definition

fix clang-tidy warning

will likely have to wrap the lambda captures in #if ENABLE_CHRONIK blocks to prevent error: lambda capture 'args' is not used [-Werror,-Wunused-lambda-capture]

fully support chronik (in the long run this is less work than repeatedly explaining that chronik should be enabled with a restart only after background validation is complete)

give up on using std::optional

try a copy

try another workaround

In D18054#411619, @Fabien wrote:

Nice ! Should --repeat also imply --failfast ? What do you think ?

workaround for false-positive -Werror=maybe-uninitialized: try opt.value() instead of *opt

check that the blockchain is restored after the temporary rollback

rebase

fix -Werror=reorder warning

rebase on bugfix

rebase