In D670#12833, @deadalnix wrote:There should be aa GetID *and* a GetHash. They can both do the same thing internally for now, but we need both to begin with. Then gradually move from using uint256 to TxId or TxHash which should flag the pieces of code that use the wrong one.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Dec 7 2017
Dec 7 2017
Nov 28 2017
Nov 28 2017
Nov 16 2017
Nov 16 2017
Herald added a reviewer for D707: Refactoring txid to txhash; wallet functionality: Restricted Project.
Nov 13 2017
Nov 13 2017
Herald added a reviewer for D672: Refactoring txid to txhash; other core functions: Restricted Project.
Herald added a reviewer for D671: Refactoring txid to txhash; mempool and validation: Restricted Project.
I would like to note that I still have reservations to this solution compared to the SIGHASH solution. The risk of changing the meaning of txid must be carefully considered.
Oct 19 2017
Oct 19 2017
Thanks. I understand this is too big as I commented on slack, but I also think it's wrong and needs discussion.
Oct 18 2017
Oct 18 2017
Herald added a reviewer for D614: MalFix: Type separation of txids to txhash and unspentid: Restricted Project.
tomtomtom7 updated the diff for D613: MalFix: Drop support for GetTransaction lookups using the UTXO-index.
Attempt stacking
tomtomtom7 updated the diff for D613: MalFix: Drop support for GetTransaction lookups using the UTXO-index.
Attempt stacking
Herald added a reviewer for D613: MalFix: Drop support for GetTransaction lookups using the UTXO-index: Restricted Project.
Fix linter to use clang-format-3.8
Oct 13 2017
Oct 13 2017
Herald added a reviewer for D598: MalFix: Drop auto-requesting parents of orphans from the same peer: Restricted Project.
Only change is 1079-1077. Is the policy on linter whitespace cleanup to always accept?
Herald added a reviewer for D597: MalFix: Drop lookup in UTXO set to prevent unneeded relay: Restricted Project.
My apologies for stubbornly reopening the discussion but I believe one is still needed; hopefully short yet open. Please consider (along the arguments on the ml):
Oct 12 2017
Oct 12 2017
Oct 10 2017
Oct 10 2017
tomtomtom7 committed rABCf1a0dab0217c: Fix compile errors in Amount caused by ambiguous instantation (authored by tomtomtom7).
Fix compile errors in Amount caused by ambiguous instantation
tomtomtom7 updated the diff for D594: Fix compile errors in Amount caused by ambiguous instantation.
Added include type_traits
tomtomtom7 updated the diff for D594: Fix compile errors in Amount caused by ambiguous instantation.
Add message to static assert
Herald added a reviewer for D594: Fix compile errors in Amount caused by ambiguous instantation: Restricted Project.
Oct 3 2017
Oct 3 2017
tomtomtom7 added inline comments to D571: Implement the proposed difficulty adjustement algorithm proposed in the ML.
Oct 2 2017
Oct 2 2017
tomtomtom7 added a reviewer for D572: Add an utility to convert string of bits from base 2^N to 2^M .: tomtomtom7.
tomtomtom7 committed rABCb0a5cc08e8da: Ensure backupwallet fails if the target is the same as the source (authored by tomtomtom7).
Ensure backupwallet fails if the target is the same as the source
Sep 25 2017
Sep 25 2017
tomtomtom7 committed rABC01fccce249b4: Use a single node in high_priority_transaction test to prevent sync problems (authored by tomtomtom7).
Use a single node in high_priority_transaction test to prevent sync problems
Sep 21 2017
Sep 21 2017
tomtomtom7 added a comment to D550: Ensure backupwallet fails if the target is the same as the source.
I don't think I meant to "done" the comment in code. I just meant to comment on it; have to get used to the interface...
tomtomtom7 added inline comments to D550: Ensure backupwallet fails if the target is the same as the source.
Ok. I see the complexity is minimal, and the merits of the dynamic approach.
I am not sure why you suggest an RPC command? Why not just config?
Herald added a reviewer for D551: Use a single node in high_priority_transaction test to prevent sync problems: Restricted Project.
tomtomtom7 updated the diff for D550: Ensure backupwallet fails if the target is the same as the source.
Cleanup test to use assert_raises_jsonrpc
tomtomtom7 added a comment to D550: Ensure backupwallet fails if the target is the same as the source.
Could you investigate a bit more?
Sep 20 2017
Sep 20 2017
tomtomtom7 updated the diff for D550: Ensure backupwallet fails if the target is the same as the source.
tomtomtom7 retitled D550: Ensure backupwallet fails if the target is the same as the source from Ensure backupwallet failse if the target is the same as the source to Ensure backupwallet fails if the target is the same as the source.
Herald added a reviewer for D550: Ensure backupwallet fails if the target is the same as the source: Restricted Project.