Accepting , the release notes updates have been added in D503.

It would be very helpful to port also the applicable release notes "Low-level RPC changes" which was part of the PR9853.
Simply referring to PR9853 in the release notes would not be very useful because some of the affected RPC calls mentioned there are not applicable to ABC (e.g. 'bumpfee').

Checked that the backport is accurate, but please fix the attribution instances

Nice catch, accepting to get a second confirmation on the Travis result.
I think I need to look at why the errors related to the directory name didn't stop Travis.

Looks good, except for the attribution issue

Addressed in D482

Changes made based on previous review comments, quite a few so I'm returning to review:

Add comments from review, update minimum chain work and defaultAssumeValid hashes

@sickpig : Yes, you are right. I will update the definitions accordingly (also need to update testnet's defaultAssumeValid hash).

The flag should not really be necessary in my view, although I can live with it as an interim measure.

The URI (main part of this issue) is done, marking as Resolved.

From discussions on Slack, it's become clear that a reference member is to be avoided and a pointer used instead.

Back to review for more feedback on what changes exactly are required for this diff.

Use references instead of pointer

so you're decidedly against changing copyright notices to include us?

After eliminating all occurrences of 'using namespace std', I found that make_pair still does not need to be qualified in this file, nor in others (e.g. net_processing.cpp).
This leaves only Boost as the source (ref. http://www.boost.org/doc/libs/1_46_1/doc/html/boost/proto/functional/make_pair.html).

I think we should only apply "our" copyright notices to files where we have made actual changes, not introduce a blanket claim on files with minimal changes (e.g. formatting only etc).
As developers we shouldn't be so lazy to not add/update it when we make changes to files.
Once in a while one can scan for modified files for which the copyright hasn't been added or updated correctly, and fix them.

All good from my side.

I don't know how you managed to paste a raw linted diff in (apparently), but the changeset works alright (built, tested) and the problem is fixed, so I'm happy to accept this one.

Remove the option to disable preferential cash node peering

No, you're right, -noprefcashpeer is not working as intended. I'd need to elaborate the condition you pointed at.
If we want to keep the option, that is.

I've tested this on two mainnet nodes for a while now.
Seems no problem in keeping connections to existing nodes, and I have not noticed any non-NODE_CASH nodes in my outbounds anymore.

Nice, thanks. Accepted on code review basis, @CCulianu you are responsible if this breaks Mac users :-)

Seems ok. I have no way of testing this, but the changes do match earlier BU commit 045a999785d .

Something relevant to this matter:

No longer needed since UAHF has passed.

My view is we should steer clear of the name 'Emergent Consensus', and since we are going to implement policy choice here, call it something like 'Configurable Chain Acceptance Policy' (CCAP) or similar. (since this will in future not be used only for blocksize).

Nothing objectionable here - accepting so that we can cleanly fix remaining tests.

Looks ok, tested in conjunction with other qa-test related Diffs as a group (425 430 431 433 434 435 432) and the tests in this one passed.

Looks ok, tested in conjuction with other qa-test related Diffs as a group (425 430 431 433 434 435 432) and the tests in this one passed.

Superceded by D428 - you can abandon this one.

Add wallet RPC files which were using namespace std

Agree with @sickpig 's review comment which has not been addressed

@dgenr8 : testing rawtransactions doesn't fail for me on current ABC head.
Were you testing with additional patches that then necessitate this one?

Didn't apply cleanly, but tested ok.

Nit fixes look fine.

Looks ok, though the code will need some post-processing love later on e.g. eliminate same-line comments, put some docstrings etc.

I think you are right that a search needs to be made.
Demangling the make_pair related symbols in src/wallet/libbitcoin_wallet_a-walletdb.o showed them as being std::make_pair (without this patch applied).
So they are coming from somewhere.

• Added criptolayer.net DNS seeds
• Updated FreeBSD build instructions

Please add D332 (Fixed FreeBSD build instructions) while revising
Thanks

Add optional installation of python3 for qa tests