Page MenuHomePhabricator
Feed Advanced Search

Nov 30 2018

schancel added a reverting change for rSTAGING49ff27fedd36: [rpc] Deprecate estimatefee RPC: rSTAGINGa4c86bad8530: [rpc] Undeprecate estimatefee.
Nov 30 2018, 21:30
schancel committed rSTAGINGb4460fcaa584: [rpc] Add a unittest for IsDeprecatedRPCEnabled (authored by schancel).
[rpc] Add a unittest for IsDeprecatedRPCEnabled
Nov 30 2018, 21:30
schancel updated the summary of D2159: [Part 1 of 4] [qa] De-globalize port seeding.
Nov 30 2018, 21:02
schancel retitled D2159: [Part 1 of 4] [qa] De-globalize port seeding from [qa] De-globalize port seeding to [Part 1 of 3] [qa] De-globalize port seeding.
Nov 30 2018, 21:01
schancel updated the diff for D2159: [Part 1 of 4] [qa] De-globalize port seeding.

Split diff up part 1

Nov 30 2018, 20:59
schancel planned changes to D2159: [Part 1 of 4] [qa] De-globalize port seeding.

rpcbind_test is using static port. Need to test this on linux and fix it.

Nov 30 2018, 06:48
schancel added inline comments to D2159: [Part 1 of 4] [qa] De-globalize port seeding.
Nov 30 2018, 06:45
schancel updated the summary of D2159: [Part 1 of 4] [qa] De-globalize port seeding.
Nov 30 2018, 06:37
Herald added a reviewer for D2159: [Part 1 of 4] [qa] De-globalize port seeding: deadalnix.
Nov 30 2018, 06:34
schancel updated the summary of D2155: [qa] Switch to using multiprocessing instead of threading.
Nov 30 2018, 05:34
schancel abandoned D2154: [qa] Fix portseed calculation to avoid collisions.
Nov 30 2018, 05:34
schancel accepted D2151: Use sys.exit(...) instead of exit(...): exit(...) should not be used in programs.
Nov 30 2018, 05:33
schancel updated the diff for D2156: [qa] Dyanmically import tests so we can start adding decorators.

Add exception handling on importing module

Nov 30 2018, 04:35
schancel added a comment to D2155: [qa] Switch to using multiprocessing instead of threading.
Nov 30 2018, 04:27
schancel added a comment to D2156: [qa] Dyanmically import tests so we can start adding decorators.

Something is going on here causing RPC to not initialize properly. I need to hunt it down.

Nov 30 2018, 03:39
schancel planned changes to D2156: [qa] Dyanmically import tests so we can start adding decorators.
Nov 30 2018, 03:36
schancel planned changes to D2157: [qa] Add extended decorator to signal which tests are long running.
Nov 30 2018, 03:35
schancel planned changes to D2158: [qa] Stop maintaining for using test timings..
Nov 30 2018, 03:35
Herald added a reviewer for D2158: [qa] Stop maintaining for using test timings.: deadalnix.
Nov 30 2018, 03:33
schancel updated the summary of D2157: [qa] Add extended decorator to signal which tests are long running.
Nov 30 2018, 03:28
Herald added a reviewer for D2157: [qa] Add extended decorator to signal which tests are long running: deadalnix.
Nov 30 2018, 03:27
schancel updated the summary of D2156: [qa] Dyanmically import tests so we can start adding decorators.
Nov 30 2018, 03:24
Herald added a reviewer for D2156: [qa] Dyanmically import tests so we can start adding decorators: deadalnix.
Nov 30 2018, 03:24
Herald added a reviewer for D2155: [qa] Switch to using multiprocessing instead of threading: deadalnix.
Nov 30 2018, 03:20
Herald added a reviewer for D2154: [qa] Fix portseed calculation to avoid collisions: deadalnix.
Nov 30 2018, 03:16
Herald added a reviewer for D2153: [qa] Make src_dir handling more robust: deadalnix.
Nov 30 2018, 03:09
Herald added a reviewer for D2152: [qa] Make src_dir handling more robust: deadalnix.
Nov 30 2018, 03:09

Nov 29 2018

schancel requested changes to D1894: Added RPCCommand base classes in preparation for RPC migration.
Nov 29 2018, 22:43
schancel retitled D2149: [Part 1] Core PR 11531: p2p-acceptblock improvements from Backport 1 of many for Core PR 11531: p2p-acceptblock improvements to [Part 1] Core PR 11531: p2p-acceptblock improvements.
Nov 29 2018, 22:33
schancel accepted D2149: [Part 1] Core PR 11531: p2p-acceptblock improvements.
Nov 29 2018, 22:33
schancel updated the diff for D1969: [Part 2 of 5] Add a CChainState class to clarify internal interfaces.

Rebase, remove excess whitespace change

Nov 29 2018, 21:57
schancel committed rABC9e90803c6e02: Rename wallet functional test files to match bitcoin core (authored by schancel).
Rename wallet functional test files to match bitcoin core
Nov 29 2018, 21:51
schancel requested review of D1969: [Part 2 of 5] Add a CChainState class to clarify internal interfaces.
Nov 29 2018, 21:51
schancel closed D1992: Rename wallet functional test files to match bitcoin core.
Nov 29 2018, 21:50
schancel updated the diff for D1992: Rename wallet functional test files to match bitcoin core.

Rebase an update timings

Nov 29 2018, 21:39
schancel committed rABC007da3b2780f: [Part 1 of 5] Add a CChainState class to clarify internal interfaces (authored by Matt Corallo <git@bluematt.me>).
[Part 1 of 5] Add a CChainState class to clarify internal interfaces
Nov 29 2018, 21:11
schancel closed D1968: [Part 1 of 5] Add a CChainState class to clarify internal interfaces.
Nov 29 2018, 21:10
schancel committed rABC90348f6ecce9: Rename account to label where appropriate (authored by Russell Yanofsky <russ@yanofsky.org>).
Rename account to label where appropriate
Nov 29 2018, 21:01
schancel closed D1986: Rename account to label where appropriate.
Nov 29 2018, 21:01
schancel updated the diff for D1986: Rename account to label where appropriate.

Rebase, fix nits

Nov 29 2018, 20:13

Nov 28 2018

schancel accepted D2131: Defaults block index received time to 0 when init from a block header.
Nov 28 2018, 21:11
schancel accepted D2130: Fix abc-finalize-block.py header propagation issue.
Nov 28 2018, 21:07
schancel retitled D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet from Split signrawtransaction into wallet and non-wallet to [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.
Nov 28 2018, 20:59
schancel updated the summary of D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.
Nov 28 2018, 20:58
schancel requested changes to D1894: Added RPCCommand base classes in preparation for RPC migration.
Nov 28 2018, 20:58
schancel planned changes to D2036: [doc] update release process.
Nov 28 2018, 18:53
schancel added inline comments to D2037: Update mempool fee estimator to factor in rollingMinimumFeerate.
Nov 28 2018, 18:02
schancel accepted D2146: Fix some nits in bip68-112-113-p2p.py.
Nov 28 2018, 17:40
schancel removed reviewers for D2037: Update mempool fee estimator to factor in rollingMinimumFeerate: deadalnix, jasonbcox.
Nov 28 2018, 17:13
schancel added inline comments to D2130: Fix abc-finalize-block.py header propagation issue.
Nov 28 2018, 17:08
schancel planned changes to D2135: [wip] Move primary globals to globals.h.
Nov 28 2018, 16:45
schancel planned changes to D1476: Revert "Prepare a flag for charging for excessive utxo creation".
Nov 28 2018, 06:20

Nov 27 2018

schancel committed rABC407240d4555f: Fix nits in bitcoingui.cpp (authored by schancel).
Fix nits in bitcoingui.cpp
Nov 27 2018, 21:24
schancel closed D2144: Fix nits in bitcoingui.cpp.
Nov 27 2018, 21:24
schancel abandoned D2125: Delay finalization until 2 hours after IBD is recorded as finished.
Nov 27 2018, 19:08
schancel updated the diff for D2144: Fix nits in bitcoingui.cpp.

Fix more nits

Nov 27 2018, 19:05
schancel retitled D2144: Fix nits in bitcoingui.cpp from fix nits in bitcoingui.cpp to Fix nits in bitcoingui.cpp.
Nov 27 2018, 18:26
schancel added inline comments to D2135: [wip] Move primary globals to globals.h.
Nov 27 2018, 18:23
schancel updated the diff for D2135: [wip] Move primary globals to globals.h.

Minor cleanup. Still doenst' link

Nov 27 2018, 18:21
Herald added a reviewer for D2144: Fix nits in bitcoingui.cpp: deadalnix.
Nov 27 2018, 18:13
schancel updated the diff for D2139: Record when a block was fully received and checked.

Update per feedback

Nov 27 2018, 16:09
schancel added a reverting change for rABCeb27c4cab519: Record when block was fully received: rABC6997d0c8dd56: Revert "Record when block was fully received".
Nov 27 2018, 01:45
schancel committed rABC6997d0c8dd56: Revert "Record when block was fully received" (authored by schancel).
Revert "Record when block was fully received"
Nov 27 2018, 01:45
schancel closed D2138: Revert "Record when block was fully received".
Nov 27 2018, 01:45
schancel added inline comments to D2139: Record when a block was fully received and checked.
Nov 27 2018, 01:43
schancel committed rABCe235671dfd1e: Update contributing guide to include additional reading (authored by schancel).
Update contributing guide to include additional reading
Nov 27 2018, 01:42
schancel closed D2129: Update contributing guide to include additional reading.
Nov 27 2018, 01:42

Nov 26 2018

schancel updated the diff for D2139: Record when a block was fully received and checked.

Add missing sections

Nov 26 2018, 23:16
schancel updated the summary of D2139: Record when a block was fully received and checked.
Nov 26 2018, 23:16
Herald added a reviewer for D2139: Record when a block was fully received and checked: deadalnix.
Nov 26 2018, 23:14
Herald added a reviewer for D2138: Revert "Record when block was fully received": deadalnix.
Nov 26 2018, 23:13
schancel added a reverting change for rABCeb27c4cab519: Record when block was fully received: D2138: Revert "Record when block was fully received".
Nov 26 2018, 23:13
schancel committed rABCeb27c4cab519: Record when block was fully received (authored by schancel).
Record when block was fully received
Nov 26 2018, 21:45
schancel closed D2128: Record when block was fully received.
Nov 26 2018, 21:45
schancel updated the diff for D2133: Move shared qt/bitcoind initialization steps to shared functions..

Fix comment

Nov 26 2018, 21:23
schancel updated the diff for D2133: Move shared qt/bitcoind initialization steps to shared functions..

Fix locking behavior when daemonizing

Nov 26 2018, 19:45
Herald added a reviewer for D2135: [wip] Move primary globals to globals.h: Restricted Project.
Nov 26 2018, 19:16
schancel added inline comments to D2133: Move shared qt/bitcoind initialization steps to shared functions..
Nov 26 2018, 18:32

Nov 25 2018

schancel accepted D2069: Rename function in bip65 integration test so it does not collide with create_transaction.
Nov 25 2018, 23:54
Herald added a reviewer for D2134: Nits in src/qt/init.cpp: Restricted Project.
Nov 25 2018, 23:32
Herald added a reviewer for D2133: Move shared qt/bitcoind initialization steps to shared functions.: Restricted Project.
Nov 25 2018, 23:24
schancel accepted D2131: Defaults block index received time to 0 when init from a block header.
Nov 25 2018, 23:15
schancel accepted D2130: Fix abc-finalize-block.py header propagation issue.
Nov 25 2018, 20:03
schancel requested review of D1968: [Part 1 of 5] Add a CChainState class to clarify internal interfaces.
Nov 25 2018, 17:47
schancel requested review of D1937: Change the maxtxfee to be per kb..
Nov 25 2018, 17:30
schancel requested review of D1936: Move handling for `-maxtxfee` to the config object.
Nov 25 2018, 17:29
schancel added inline comments to D1936: Move handling for `-maxtxfee` to the config object.
Nov 25 2018, 17:29
schancel requested review of D2037: Update mempool fee estimator to factor in rollingMinimumFeerate.
Nov 25 2018, 17:27
schancel added inline comments to D2130: Fix abc-finalize-block.py header propagation issue.
Nov 25 2018, 17:25
schancel requested review of D1986: Rename account to label where appropriate.
Nov 25 2018, 17:16
D1986: Rename account to label where appropriate is now accepted and ready to land.
Nov 25 2018, 17:16
schancel updated the summary of D2130: Fix abc-finalize-block.py header propagation issue.
Nov 25 2018, 17:07
schancel requested review of D1936: Move handling for `-maxtxfee` to the config object.
Nov 25 2018, 09:45
schancel committed rABC3b248bbe567c: Remove unused parameter for AcceptBlock (authored by schancel).
Remove unused parameter for AcceptBlock
Nov 25 2018, 09:40
schancel closed D2127: Remove unused parameter for AcceptBlock.
Nov 25 2018, 09:40
Herald added a reviewer for D2129: Update contributing guide to include additional reading: Restricted Project.
Nov 25 2018, 01:16
schancel updated the diff for D2128: Record when block was fully received.

Update ordering in one more place

Nov 25 2018, 00:44
schancel updated the diff for D2128: Record when block was fully received.

Update ordering of variables

Nov 25 2018, 00:42
schancel updated the diff for D2128: Record when block was fully received.

Correctly test BlockReceived time

Nov 25 2018, 00:22
schancel added inline comments to D2128: Record when block was fully received.
Nov 25 2018, 00:17