Page MenuHomePhabricator
Feed Advanced Search

Nov 29 2018

deadalnix added inline comments to D2140: [avalanche] Delegate node management to caller.
Nov 29 2018, 16:04
deadalnix updated the diff for D2143: [avalanche] Expire queries once they reached their timeout..

rebase

Nov 29 2018, 15:19
deadalnix updated the diff for D2140: [avalanche] Delegate node management to caller.

Add NO_NODE constant instead of using magic numbers.
Fix typos

Nov 29 2018, 15:02
deadalnix committed rABCaa5be8bc1cca: [avalanche] Make sure the round variable is initialized properly (authored by deadalnix).
[avalanche] Make sure the round variable is initialized properly
Nov 29 2018, 14:50
deadalnix closed D2147: [avalanche] Make sure the round variable is initialized properly.
Nov 29 2018, 14:50
Herald added a reviewer for D2147: [avalanche] Make sure the round variable is initialized properly: Restricted Project.
Nov 29 2018, 12:42
deadalnix accepted D1968: [Part 1 of 5] Add a CChainState class to clarify internal interfaces.
Nov 29 2018, 00:53
deadalnix accepted D2131: Defaults block index received time to 0 when init from a block header.
Nov 29 2018, 00:14
deadalnix accepted D1986: Rename account to label where appropriate.
Nov 29 2018, 00:08

Nov 28 2018

deadalnix committed rABC1951a4e6cfef: [avalanche] Use a multi_index to track request so it is easy to determine which… (authored by deadalnix).
[avalanche] Use a multi_index to track request so it is easy to determine which…
Nov 28 2018, 23:43
deadalnix closed D2137: [avalanche] Use a multi_index to track request so it is easy to determine which timed out..
Nov 28 2018, 23:43
deadalnix added inline comments to D2139: Record when a block was fully received and checked.
Nov 28 2018, 17:51
deadalnix added inline comments to D2037: Update mempool fee estimator to factor in rollingMinimumFeerate.
Nov 28 2018, 17:34
deadalnix requested changes to D2131: Defaults block index received time to 0 when init from a block header.
Nov 28 2018, 17:20
deadalnix accepted D2146: Fix some nits in bip68-112-113-p2p.py.
Nov 28 2018, 17:16
deadalnix updated the diff for D2143: [avalanche] Expire queries once they reached their timeout..

rebase and fix typo

Nov 28 2018, 15:30
deadalnix updated the diff for D2137: [avalanche] Use a multi_index to track request so it is easy to determine which timed out..

Remove the whatever field

Nov 28 2018, 12:56
deadalnix requested review of D2137: [avalanche] Use a multi_index to track request so it is easy to determine which timed out..
Nov 28 2018, 12:52

Nov 27 2018

deadalnix committed rABC751f09e7dbac: [avalanche] Enforce cooldown request present in AvalancheResponse (authored by deadalnix).
[avalanche] Enforce cooldown request present in AvalancheResponse
Nov 27 2018, 19:05
deadalnix closed D2122: [avalanche] Enforce cooldown request present in AvalancheResponse.
Nov 27 2018, 19:03
deadalnix committed rABC1f50cf0e7ef3: [avalanche] Ensure block added to avalanche have the proper acceptance. (authored by deadalnix).
[avalanche] Ensure block added to avalanche have the proper acceptance.
Nov 27 2018, 19:01
deadalnix closed D2117: [avalanche] Ensure block added to avalanche have the proper acceptance..
Nov 27 2018, 19:01
Herald added a reviewer for D2143: [avalanche] Expire queries once they reached their timeout.: Restricted Project.
Nov 27 2018, 15:29
deadalnix requested changes to D2135: [wip] Move primary globals to globals.h.

I would advise strongly against moving these globals around unless you can ensure that initialization will be done in proper order. Initialization across modules is linker dependent, unless you want to specify it using a linker script so they'd better not depend on each other, which I wouldn't bet on.

Nov 27 2018, 13:50
deadalnix committed rABCefb6682eb066: [avalanche] consistently use avanodeid in avalanche's test. (authored by deadalnix).
[avalanche] consistently use avanodeid in avalanche's test.
Nov 27 2018, 13:42
deadalnix closed D2142: [avalanche] consistently use avanodeid in avalanche's test..
Nov 27 2018, 13:41
deadalnix updated the diff for D2140: [avalanche] Delegate node management to caller.

Fix typo

Nov 27 2018, 13:40
deadalnix added inline comments to D2140: [avalanche] Delegate node management to caller.
Nov 27 2018, 13:37
deadalnix requested review of D2122: [avalanche] Enforce cooldown request present in AvalancheResponse.

There is nothing actionable in that review.

Nov 27 2018, 13:08
deadalnix updated the diff for D2117: [avalanche] Ensure block added to avalanche have the proper acceptance..

Add a check for invalid blocks

Nov 27 2018, 13:05
deadalnix updated the summary of D2117: [avalanche] Ensure block added to avalanche have the proper acceptance..
Nov 27 2018, 13:00
Herald added a reviewer for D2142: [avalanche] consistently use avanodeid in avalanche's test.: Restricted Project.
Nov 27 2018, 12:57
deadalnix changed the visibility for D2141: Enforce protocol message size against INV message size.
Nov 27 2018, 12:49
deadalnix accepted D2141: Enforce protocol message size against INV message size.
Nov 27 2018, 12:48
deadalnix requested changes to D2141: Enforce protocol message size against INV message size.
Nov 27 2018, 00:59
deadalnix requested changes to D2131: Defaults block index received time to 0 when init from a block header.
Nov 27 2018, 00:30
deadalnix added inline comments to D2131: Defaults block index received time to 0 when init from a block header.
Nov 27 2018, 00:27

Nov 26 2018

deadalnix accepted D2138: Revert "Record when block was fully received".
Nov 26 2018, 23:45
deadalnix requested changes to D2139: Record when a block was fully received and checked.
Nov 26 2018, 23:44
Herald added a reviewer for D2140: [avalanche] Delegate node management to caller: Restricted Project.
Nov 26 2018, 23:39
deadalnix requested changes to D2130: Fix abc-finalize-block.py header propagation issue.

There are several errors in the comments. Adding assertions to check them would be a good idea in addition to fixing them.

Nov 26 2018, 23:21
Herald added a reviewer for D2137: [avalanche] Use a multi_index to track request so it is easy to determine which timed out.: Restricted Project.
Nov 26 2018, 20:45

Nov 25 2018

deadalnix requested changes to D2130: Fix abc-finalize-block.py header propagation issue.

The overall logic look sund, but overall style needs to be improved.

Nov 25 2018, 17:10
deadalnix requested changes to D1936: Move handling for `-maxtxfee` to the config object.
Nov 25 2018, 17:05
deadalnix updated the diff for D2117: [avalanche] Ensure block added to avalanche have the proper acceptance..

Fix vairable name

Nov 25 2018, 17:02
deadalnix added inline comments to D2117: [avalanche] Ensure block added to avalanche have the proper acceptance..
Nov 25 2018, 17:00
deadalnix committed rABCddc32b011f5f: Make CNodeStats a struct and add a blurb explaining what it is. (authored by deadalnix).
Make CNodeStats a struct and add a blurb explaining what it is.
Nov 25 2018, 16:44
deadalnix closed D2126: Make CNodeStats a struct and add a blurb explaining what it is..
Nov 25 2018, 16:44

Nov 24 2018

deadalnix updated the diff for D2117: [avalanche] Ensure block added to avalanche have the proper acceptance..

rebase

Nov 24 2018, 18:00
Herald added a reviewer for D2126: Make CNodeStats a struct and add a blurb explaining what it is.: Restricted Project.
Nov 24 2018, 16:48
deadalnix committed rABCd98df9d1f7fa: [avalanche] Implement the challenge/response protocol (authored by deadalnix).
[avalanche] Implement the challenge/response protocol
Nov 24 2018, 16:33
deadalnix closed D2046: [avalanche] Implement the challenge/response protocol.
Nov 24 2018, 16:32
deadalnix updated the diff for D2122: [avalanche] Enforce cooldown request present in AvalancheResponse.

Fix typo

Nov 24 2018, 15:34
deadalnix updated the diff for D2117: [avalanche] Ensure block added to avalanche have the proper acceptance..

Fix comments

Nov 24 2018, 14:52
deadalnix updated the diff for D2046: [avalanche] Implement the challenge/response protocol.

Check against wrong ordering.

Nov 24 2018, 14:05

Nov 23 2018

deadalnix updated the diff for D2046: [avalanche] Implement the challenge/response protocol.

rebase

Nov 23 2018, 16:38
deadalnix updated the diff for D2046: [avalanche] Implement the challenge/response protocol.

rebase

Nov 23 2018, 16:06
deadalnix committed rABC91e28d4f1b1f: [avalanche] Report the list of finalized blocks when votes are accounted for (authored by deadalnix).
[avalanche] Report the list of finalized blocks when votes are accounted for
Nov 23 2018, 15:52
deadalnix closed D2045: [avalanche] Report the list of finalized blocks when votes are accounted for.
Nov 23 2018, 15:51
deadalnix updated the diff for D2045: [avalanche] Report the list of finalized blocks when votes are accounted for.

rebase

Nov 23 2018, 15:41
Herald added a reviewer for D2122: [avalanche] Enforce cooldown request present in AvalancheResponse: Restricted Project.
Nov 23 2018, 02:13
deadalnix changed the visibility for D2046: [avalanche] Implement the challenge/response protocol.
Nov 23 2018, 01:48
deadalnix accepted D2120: Move CLTV from scriptSig to scriptPubKey in bip65-cltv-p2p.py.
Nov 23 2018, 00:25
deadalnix updated the diff for D2117: [avalanche] Ensure block added to avalanche have the proper acceptance..

Fix comments

Nov 23 2018, 00:22

Nov 22 2018

deadalnix changed the visibility for D2117: [avalanche] Ensure block added to avalanche have the proper acceptance..
Nov 22 2018, 23:26
deadalnix committed rABC81fcace04fdf: [avalanche] Add support to poll multiple block at once. (authored by deadalnix).
[avalanche] Add support to poll multiple block at once.
Nov 22 2018, 23:10
deadalnix closed D2121: [avalanche] Add support to poll multiple block at once..
Nov 22 2018, 23:09
deadalnix updated the diff for D2117: [avalanche] Ensure block added to avalanche have the proper acceptance..

Only poll blocks worth polling.

Nov 22 2018, 21:43
deadalnix updated the summary of D2117: [avalanche] Ensure block added to avalanche have the proper acceptance..
Nov 22 2018, 21:43
deadalnix updated the diff for D2046: [avalanche] Implement the challenge/response protocol.

pfrom => pnode

Nov 22 2018, 21:21
deadalnix updated the diff for D2046: [avalanche] Implement the challenge/response protocol.

rebase and adapt to changes made to the stack

Nov 22 2018, 21:12
deadalnix updated the diff for D2045: [avalanche] Report the list of finalized blocks when votes are accounted for.

Remove redundant code

Nov 22 2018, 21:05
deadalnix updated the diff for D2045: [avalanche] Report the list of finalized blocks when votes are accounted for.

Use a better reporting technique

Nov 22 2018, 20:45
deadalnix updated the diff for D2121: [avalanche] Add support to poll multiple block at once..

rebase

Nov 22 2018, 19:49
deadalnix committed rABCf245a0ce69ec: [avalanche] Add a facility to select invs to poll (authored by deadalnix).
[avalanche] Add a facility to select invs to poll
Nov 22 2018, 19:00
deadalnix closed D2044: [avalanche] Add a facility to select invs to poll.
Nov 22 2018, 19:00
D2044: [avalanche] Add a facility to select invs to poll is now accepted and ready to land.
Nov 22 2018, 18:59
deadalnix updated the summary of D2045: [avalanche] Report the list of finalized blocks when votes are accounted for.
Nov 22 2018, 18:51
deadalnix updated the summary of D2004: Reconsider parked chains when enough works piles up.
Nov 22 2018, 18:50
deadalnix updated the summary of D2004: Reconsider parked chains when enough works piles up.
Nov 22 2018, 18:49
deadalnix requested changes to D2120: Move CLTV from scriptSig to scriptPubKey in bip65-cltv-p2p.py.
Nov 22 2018, 18:49
Herald added a reviewer for D2121: [avalanche] Add support to poll multiple block at once.: Restricted Project.
Nov 22 2018, 18:44
deadalnix accepted D2116: [qa] Fix bip65-cltv-p2p to be compatible with magnetic anomaly.
Nov 22 2018, 18:42
deadalnix committed rABC3aeef6295cbe: [avalanche] Create an event loop facility. (authored by deadalnix).
[avalanche] Create an event loop facility.
Nov 22 2018, 18:23
deadalnix closed D2043: [avalanche] Create an event loop facility..
Nov 22 2018, 18:23
deadalnix updated the diff for D2043: [avalanche] Create an event loop facility..

rebase

Nov 22 2018, 18:22
deadalnix committed rABC7fd9d97515b9: [avalanche] Add a block registry and facility to register votes on these blocks. (authored by deadalnix).
[avalanche] Add a block registry and facility to register votes on these blocks.
Nov 22 2018, 18:15
deadalnix closed D2042: [avalanche] Add a block registry and facility to register votes on these blocks..
Nov 22 2018, 18:14
deadalnix removed a reviewer for D2042: [avalanche] Add a block registry and facility to register votes on these blocks.: jasonbcox.
Nov 22 2018, 18:12
deadalnix accepted D2119: Fix nits in bip65-cltv-p2p.py.
Nov 22 2018, 17:58
deadalnix committed rABC5606e0ab8d93: Move finalization suck as reconsiderblock actualy reconsider blocks (authored by deadalnix).
Move finalization suck as reconsiderblock actualy reconsider blocks
Nov 22 2018, 17:37
deadalnix closed D2118: Move finalization suck as reconsiderblock actualy reconsider blocks.
Nov 22 2018, 17:36
deadalnix updated the diff for D2118: Move finalization suck as reconsiderblock actualy reconsider blocks.

Add an wrapper to check for finalization.

Nov 22 2018, 17:36
deadalnix requested changes to D2116: [qa] Fix bip65-cltv-p2p to be compatible with magnetic anomaly.
Nov 22 2018, 17:13
deadalnix retitled D2116: [qa] Fix bip65-cltv-p2p to be compatible with magnetic anomaly from [qa] Fix bip65-cltb-p2p to be compatible with magnetic anomaly to [qa] Fix bip65-cltv-p2p to be compatible with magnetic anomaly.
Nov 22 2018, 16:55
Herald added a reviewer for D2118: Move finalization suck as reconsiderblock actualy reconsider blocks: Restricted Project.
Nov 22 2018, 16:54
deadalnix committed rABC0f56a224223d: Fix various bugs in the seeder. (authored by deadalnix).
Fix various bugs in the seeder.
Nov 22 2018, 16:14
deadalnix closed D2113: Fix various bugs in the seeder..
Nov 22 2018, 16:14
deadalnix accepted D2114: [rpc] add getfinalizedblockhash to return the current finalized block.
Nov 22 2018, 15:17
deadalnix requested changes to D2114: [rpc] add getfinalizedblockhash to return the current finalized block.
Nov 22 2018, 15:15