The changes to wallettests.cpp are not in there.

That is a very good backport.

rebase

This is still doing many things at once. Changing the API of the RPC is more than enough for its own patch for instance.

Can you rebase this ?

I made numerous comments on the implementation as it's probably useful feedback, the code itself being fragile and quite hacky, but I do not think this is fixable as the approach makes no sense to begin with. This just run a random test binary in a way that cannot be relied upon in any workflow using heuristics that hardly catch anything.

So it does looks like that you clearly have a diff for the RPC specifically that detaches itself.

It's also unclear that the change actually reflects accurately the parameters requirements as if fDNS is not set, then the email is not required, which clearly indicate that in some situations, it is indeed optional.

The test plan does not cover the change in any meaningful way.

Fix various comments

I trust that you know what you are doing. It comes with tests and all, and worst case scenario, we can fix it.

Ok the general flow of the code and test looks good. However I'm not convinced that the check for banning actually checks anything. Can you remove the whitelist and then make sure to test manually that the node gets banned when sending a transaction that is actually invalid, for instance a schnorr multisig transaction?

Remove test cases added by mistake

rebase

More braces

You may want to report that the backport was fubared, so there is no need to do excavation to figure out what happened.

Ok some comments, but nothing really bad. This will be in very soon.

This is in pretty good shape now. The test looks great. I still got a few things to improve, but this is getting there.