Page MenuHomePhabricator
Feed Advanced Search

Jul 1 2019

deadalnix closed D3484: Prevent mutex lock fail even if --enable-debug.
Jul 1 2019, 12:15
deadalnix committed rABC4d7ec287dbad: qa: Initialize lockstack to prevent null pointer deref (authored by MarcoFalke <falke.marco@gmail.com>).
qa: Initialize lockstack to prevent null pointer deref
Jul 1 2019, 12:07
deadalnix closed D3476: qa: Initialize lockstack to prevent null pointer deref.
Jul 1 2019, 12:06
deadalnix committed rABC1def43643660: Add braces in sync.{h|cpp} (authored by deadalnix).
Add braces in sync.{h|cpp}
Jul 1 2019, 12:04
deadalnix closed D3475: Add braces in sync.{h|cpp}.
Jul 1 2019, 12:03
D3470: Add documentation on how to display python deprecation warnings is now accepted and ready to land.
Jul 1 2019, 12:03
D3496: Fix a shadow warning in askpassphrasedialog.cpp is now accepted and ready to land.
Jul 1 2019, 12:02
deadalnix committed rABCf9869acaa5bc: test: Fix dangling wallet pointer in vpwallets (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
test: Fix dangling wallet pointer in vpwallets
Jul 1 2019, 01:57
deadalnix closed D3487: test: Fix dangling wallet pointer in vpwallets.
Jul 1 2019, 01:57

Jun 30 2019

deadalnix created D3490: wallet: Add HasWallets.
Jun 30 2019, 23:50
deadalnix created D3488: wallet: Add AddWallet, RemoveWallet, GetWallet and GetWallets.
Jun 30 2019, 23:43
deadalnix created D3487: test: Fix dangling wallet pointer in vpwallets.
Jun 30 2019, 23:35
deadalnix created D3486: refactor: Drop CWalletRef typedef.
Jun 30 2019, 23:09
deadalnix created D3485: test: Make g_insecure_rand_ctx thread_local.
Jun 30 2019, 22:30
deadalnix created D3484: Prevent mutex lock fail even if --enable-debug.
Jun 30 2019, 21:47
D3473: [refactor multisig] consolidate legacy mode logic now requires changes to proceed.

This would benefit from changing the code a bit more, but in more elementary steps.

Jun 30 2019, 21:13
D3482: Merge #11094: Docs: Hash in ZMQ hash is raw bytes, not hex is now accepted and ready to land.
Jun 30 2019, 20:48
D3478: Merge #10655: Properly document target_confirmations in listsinceblock is now accepted and ready to land.
Jun 30 2019, 20:48
D3479: Merge #10912: [tests] Fix incorrect memory_cleanse(…) call in crypto_tests.cpp is now accepted and ready to land.
Jun 30 2019, 20:46
D3481: Merge #11083: Fix combinerawtransaction RPC help result section is now accepted and ready to land.
Jun 30 2019, 20:45
D3480: Merge #11011: [Trivial] Add a comment on the use of prevector in script. is now accepted and ready to land.
Jun 30 2019, 20:45
D3477: Merge #13622: Remove mapRequest tracking that just effects Qt display. is now accepted and ready to land.
Jun 30 2019, 20:44
deadalnix created D3476: qa: Initialize lockstack to prevent null pointer deref.
Jun 30 2019, 16:35
deadalnix created D3475: Add braces in sync.{h|cpp}.
Jun 30 2019, 16:27
D3452: [ibd.sh] Store datadir and debug.log paths in variables now requires changes to proceed.
Jun 30 2019, 00:45
D3443: Added fetch-chainparams.py to fetch chainparam block values from a node using HTTP RPC now requires changes to proceed.

The description of the diff has now gone completely off rail. It start by discussing philosophy and then goes on to explain what not to do. That's a good sign that you are not focused on what you should be doing but on abstract matter that do not matter. Case in point the script red a json and output a json with the same infos in it, but in a very complex and highly specialized manner - which goes completely against the UNIX philosophy, BTW. Either you want to do a tool that fetch things from the RPC and output them in JSON (hint, that's bitcoin-cli) or you do something that extract the relevant infos and put them in a form that's usable. You can even drop the pretense of being a UNIX philosopher and do a script that does both at once.

Jun 30 2019, 00:36
deadalnix added a comment to D3443: Added fetch-chainparams.py to fetch chainparam block values from a node using HTTP RPC.

bitcoin-cli clearly doesn't need the node to be started with custom parameters. So why is it required here?

Jun 30 2019, 00:15
D3434: Clamp walletpassphrase timeout to 2^(30) seconds and check its bounds is now accepted and ready to land.
Jun 30 2019, 00:12
deadalnix added a comment to D3450: Make unit tests use the insecure_rand_ctx exclusively.

rebase

Jun 30 2019, 00:05
D3453: [ibd.sh] Add chainwork sanity check now requires changes to proceed.

The test plan doesn't test the feature. For all we know this could fail to extract the proper value for chain work and just copare to zero or something and you wouldn't know it.

Jun 30 2019, 00:00

Jun 29 2019

D3472: add SCRIPT_ENABLE_SCHNORR_MULTISIG flag for new multisig mode now requires changes to proceed.

Call it SCHNORR_MULTISIG or something. New multisig is a great name up to the point we need a new new multisig.

Jun 29 2019, 23:58
D3470: Add documentation on how to display python deprecation warnings now requires changes to proceed.
Jun 29 2019, 23:57
D3468: Merge #11516: crypto: Add test cases covering the relevant HMAC-SHA{256,512} key length boundaries is now accepted and ready to land.
Jun 29 2019, 23:55
D3471: Merge #9868: Abstract out the command line options for block assembly now requires changes to proceed.
Jun 29 2019, 23:46
deadalnix added a comment to D3441: Handle various leftover from PR10321.

rebase and fix details to match the PR better

Jun 29 2019, 23:41
deadalnix committed rABC5be0cb874c80: Add unit tests for signals generated by ProcessNewBlock() (authored by Jesse Cohen <jc@jc.lol>).
Add unit tests for signals generated by ProcessNewBlock()
Jun 29 2019, 21:21
deadalnix closed D3437: Add unit tests for signals generated by ProcessNewBlock().
Jun 29 2019, 21:21
deadalnix committed rABC188c6ab4b8e5: Fix concurrency-related bugs in ActivateBestChain (authored by Jesse Cohen <jc@jc.lol>).
Fix concurrency-related bugs in ActivateBestChain
Jun 29 2019, 21:16
deadalnix closed D3436: Fix concurrency-related bugs in ActivateBestChain.
Jun 29 2019, 21:16

Jun 28 2019

D3460: qa: Add missing syncwithvalidationinterfacequeue to tests is now accepted and ready to land.
Jun 28 2019, 14:34
deadalnix added a comment to D3437: Add unit tests for signals generated by ProcessNewBlock().

rebase

Jun 28 2019, 14:16
deadalnix added a comment to D3436: Fix concurrency-related bugs in ActivateBestChain.

Rebase

Jun 28 2019, 14:09
deadalnix committed rABC461bec4096a5: Do not unlock cs_main in ABC unless we've actually made progress. (authored by Matt Corallo <git@bluematt.me>).
Do not unlock cs_main in ABC unless we've actually made progress.
Jun 28 2019, 14:07
deadalnix closed D3435: Do not unlock cs_main in ABC unless we've actually made progress..
Jun 28 2019, 14:06
D3458: qa: Rename cli.args to cli.options is now accepted and ready to land.
Jun 28 2019, 14:06
D3459: qa: Make TestNodeCLI command optional in send_cli is now accepted and ready to land.

This is the type of PR you typicaly may want to backport in one piece to reduce the work involved.

Jun 28 2019, 14:06
D3457: test_runner: Readable output if create_cache.py fails is now accepted and ready to land.
Jun 28 2019, 14:04
D3456: Fix a typo in functional tests documentation is now accepted and ready to land.
Jun 28 2019, 14:03
deadalnix added a comment to D3441: Handle various leftover from PR10321.

Rebase

Jun 28 2019, 14:02
D3265: add new encoding checker for Schnorr sigs is now accepted and ready to land.
Jun 28 2019, 13:58
deadalnix committed rABCe0856fd24ff6: Do not permit copying FastRandomContexts (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Do not permit copying FastRandomContexts
Jun 28 2019, 13:51
deadalnix closed D3454: Do not permit copying FastRandomContexts.
Jun 28 2019, 13:51
deadalnix committed rABC1236be7d3b0a: Simplify testing RNG code (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Simplify testing RNG code
Jun 28 2019, 13:46
deadalnix closed D3451: Simplify testing RNG code.
Jun 28 2019, 13:46
deadalnix committed rABC232034f4aae3: Use a local FastRandomContext in a few more places in net (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Use a local FastRandomContext in a few more places in net
Jun 28 2019, 13:41
deadalnix closed D3447: Use a local FastRandomContext in a few more places in net.
Jun 28 2019, 13:41
D3455: Trivial: Fix spelling in zapwallettxes test description is now accepted and ready to land.
Jun 28 2019, 13:40
deadalnix committed rABC5354651279af: Use a FastRandomContext in LimitOrphanTxSize (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Use a FastRandomContext in LimitOrphanTxSize
Jun 28 2019, 13:39
deadalnix closed D3448: Use a FastRandomContext in LimitOrphanTxSize.
Jun 28 2019, 13:39
deadalnix committed rABCf8f1272d9e7e: Introduce a Shuffle for FastRandomContext and use it in wallet and coinselection (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Introduce a Shuffle for FastRandomContext and use it in wallet and coinselection
Jun 28 2019, 13:35
deadalnix closed D3449: Introduce a Shuffle for FastRandomContext and use it in wallet and coinselection.
Jun 28 2019, 13:35
deadalnix committed rABC814ecbd1177c: Bugfix: randbytes should seed when needed (non reachable issue) (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Bugfix: randbytes should seed when needed (non reachable issue)
Jun 28 2019, 13:30
deadalnix closed D3446: Bugfix: randbytes should seed when needed (non reachable issue).
Jun 28 2019, 13:30
deadalnix committed rABC8d19410b648e: Make addrman use its local RNG exclusively (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Make addrman use its local RNG exclusively
Jun 28 2019, 13:28
deadalnix closed D3445: Make addrman use its local RNG exclusively.
Jun 28 2019, 13:28
D3442: Merge #11210: Stop test_bitcoin-qt touching ~/.bitcoin is now accepted and ready to land.
Jun 28 2019, 01:27
deadalnix created D3454: Do not permit copying FastRandomContexts.
Jun 28 2019, 00:29
deadalnix created D3451: Simplify testing RNG code.
Jun 28 2019, 00:12
deadalnix created D3450: Make unit tests use the insecure_rand_ctx exclusively.
Jun 28 2019, 00:06

Jun 27 2019

deadalnix created D3449: Introduce a Shuffle for FastRandomContext and use it in wallet and coinselection.
Jun 27 2019, 23:52
deadalnix created D3448: Use a FastRandomContext in LimitOrphanTxSize.
Jun 27 2019, 23:47
deadalnix created D3447: Use a local FastRandomContext in a few more places in net.
Jun 27 2019, 23:44
deadalnix created D3446: Bugfix: randbytes should seed when needed (non reachable issue).
Jun 27 2019, 23:40
deadalnix created D3445: Make addrman use its local RNG exclusively.
Jun 27 2019, 23:38
deadalnix added a comment to D3441: Handle various leftover from PR10321.

Revert prevector_tester ctor.

Jun 27 2019, 23:08
deadalnix retitled D3441: Handle various leftover from PR10321 from Handle variosu leftover from PR10321 to Handle various leftover from PR10321.
Jun 27 2019, 23:04
deadalnix added a comment to D3438: Update seeds for 0.19.9 release.

No change for tests?

Jun 27 2019, 17:51
D3332: remove SCRIPT_ENABLE_SCHNORR flag and clean up tests is now accepted and ready to land.
Jun 27 2019, 17:50
deadalnix created D3441: Handle various leftover from PR10321.
Jun 27 2019, 17:28
deadalnix created D3437: Add unit tests for signals generated by ProcessNewBlock().
Jun 27 2019, 16:48
deadalnix created D3436: Fix concurrency-related bugs in ActivateBestChain.
Jun 27 2019, 16:42
deadalnix created D3435: Do not unlock cs_main in ABC unless we've actually made progress..
Jun 27 2019, 16:38
deadalnix committed rABC1f934d334612: shuffle selected coins before transaction finalization (authored by Gregory Sanders <gsanders87@gmail.com>).
shuffle selected coins before transaction finalization
Jun 27 2019, 15:04
deadalnix closed D3429: shuffle selected coins before transaction finalization.
Jun 27 2019, 15:04
D3433: Fix incorrect Markdown link is now accepted and ready to land.
Jun 27 2019, 15:03
D3420: Diagnose unsuitable outputs in lockunspent(). is now accepted and ready to land.
Jun 27 2019, 15:02
deadalnix created D3429: shuffle selected coins before transaction finalization.
Jun 27 2019, 02:45
D3193: Added update-chainparams.py to fetch and replace assume valid block values from a node using HTTP RPC now requires changes to proceed.

Rather than grepping and replacing within the script, you could simply generate a header that is 100% generated by the script and defines a few constants that then get used in the chainparam code. You'll get a more robust design and people won't get merge conflicts with a bot.

Jun 27 2019, 01:04

Jun 26 2019

D3416: clean up script_tests -- move segwit recovery into static json is now accepted and ready to land.
Jun 26 2019, 23:07
D3423: Fix the timestamp format when -logtimemicros is set is now accepted and ready to land.
Jun 26 2019, 23:06
D3425: Don't attempt mempool entry for wallet tx on start if already in mempool is now accepted and ready to land.
Jun 26 2019, 23:05
D3427: Fix string concatenation to os.path.join and add exception case is now accepted and ready to land.
Jun 26 2019, 23:04
D3417: [sigencoding] refactor schnorr size check is now accepted and ready to land.

This makes the code more semantically driven. Me gusta :)

Jun 26 2019, 23:02
D3418: Fix exit in generate_header.py and some formatting nits is now accepted and ready to land.
Jun 26 2019, 23:02
D3420: Diagnose unsuitable outputs in lockunspent(). now requires changes to proceed.
Jun 26 2019, 23:01
D3426: [rpc] mempoolinfo should take ::minRelayTxFee into account is now accepted and ready to land.
Jun 26 2019, 22:58
D3421: [Trivial] BTC => BCH in functional tests comments is now accepted and ready to land.
Jun 26 2019, 22:50
D3424: [tests] Combine logs on failure is now accepted and ready to land.
Jun 26 2019, 22:50
deadalnix committed rABCcb56cbc0d97e: bench: Make CoinSelection output groups pass eligibility filter (authored by Andrew Chow <achow101-github@achow101.com>).
bench: Make CoinSelection output groups pass eligibility filter
Jun 26 2019, 22:43
deadalnix closed D3428: bench: Make CoinSelection output groups pass eligibility filter.
Jun 26 2019, 22:43