Page MenuHomePhabricator
Feed Advanced Search

Jul 6 2019

deadalnix accepted D3545: [coverage] Remove subtrees and benchmarks from coverage report.
Jul 6 2019, 15:15
deadalnix accepted D3530: Make various functions in src/test/ static.
Jul 6 2019, 15:13
deadalnix accepted D3554: Add share/rpcuser to dist. source code archive.
Jul 6 2019, 15:13
deadalnix updated the diff for D3551: Default to cashaddr in most of the Qt API.

Add release notes

Jul 6 2019, 15:12
deadalnix updated the diff for D3536: Only generate cashaddr URI from the GUI.

Rebase

Jul 6 2019, 15:10
deadalnix committed rABC0ecd638de300: docs: Add a note about the source code filename naming convention (authored by practicalswift <practicalswift@users.noreply.github.com>).
docs: Add a note about the source code filename naming convention
Jul 6 2019, 15:05
deadalnix closed D3572: docs: Add a note about the source code filename naming convention.
Jul 6 2019, 15:05
deadalnix planned changes to D3566: test: Plug memory leaks and stack-use-after-scope.

Fixing the DoS test require to get the banman PR backported. looks like this will have to wait.

Jul 6 2019, 15:04
deadalnix requested changes to D3464: [rpc] Add logging RPC.
Jul 6 2019, 14:36
deadalnix accepted D3526: Make printchunk() in support/lockedpool.cpp static.
Jul 6 2019, 14:34
deadalnix created D3572: docs: Add a note about the source code filename naming convention.
Jul 6 2019, 14:27
deadalnix committed rABC7012821336a0: Use CashAddr everywhere in the Qt interface (authored by deadalnix).
Use CashAddr everywhere in the Qt interface
Jul 6 2019, 14:10
deadalnix closed D3549: Use CashAddr everywhere in the Qt interface.
Jul 6 2019, 14:10
deadalnix requested review of D3552: Various nits in the Qt code.
Jul 6 2019, 14:07
deadalnix committed rABCe328c02961d8: Take CChainParams explicitely in PaymentServer (authored by deadalnix).
Take CChainParams explicitely in PaymentServer
Jul 6 2019, 14:07
deadalnix closed D3548: Take CChainParams explicitely in PaymentServer.
Jul 6 2019, 14:07
deadalnix committed rABCbcde96f2a506: Always use cashaddr for dummy addresses in the GUI (authored by deadalnix).
Always use cashaddr for dummy addresses in the GUI
Jul 6 2019, 14:05
deadalnix closed D3543: Always use cashaddr for dummy addresses in the GUI.
Jul 6 2019, 14:05
deadalnix committed rABCd72cd1e6b3b1: Only handle cashaddr prefix in OpenURIDialog (authored by deadalnix).
Only handle cashaddr prefix in OpenURIDialog
Jul 6 2019, 13:50
deadalnix closed D3539: Only handle cashaddr prefix in OpenURIDialog.
Jul 6 2019, 13:50

Jul 5 2019

deadalnix created D3566: test: Plug memory leaks and stack-use-after-scope.
Jul 5 2019, 16:28
deadalnix added a comment to D3565: test: Check RPC argument mapping.

Sounds like this should be added to the release checklist or to a linter.

Jul 5 2019, 16:11
deadalnix accepted D3557: tests: Remove compatibility code not needed now when we're on Python 3.
Jul 5 2019, 14:20
deadalnix accepted D3556: Change all python files to use Python3.
Jul 5 2019, 13:55
deadalnix requested changes to D3554: Add share/rpcuser to dist. source code archive.

This should have a cmake equivalent.

Jul 5 2019, 13:54
deadalnix requested changes to D3555: Rename rpcuser.py to rpcauth.py.
Jul 5 2019, 13:53
deadalnix requested changes to D3545: [coverage] Remove subtrees and benchmarks from coverage report.

Check RPC mapping is missing. Sounds like you are missing some backport.

Jul 5 2019, 13:51
deadalnix accepted D3553: rpcuser.py: Use 'python' not 'python2'.
Jul 5 2019, 13:49
deadalnix requested changes to D3557: tests: Remove compatibility code not needed now when we're on Python 3.

This patch depend on itself...

Jul 5 2019, 13:49

Jul 4 2019

deadalnix created D3552: Various nits in the Qt code.
Jul 4 2019, 19:42
deadalnix created D3551: Default to cashaddr in most of the Qt API.
Jul 4 2019, 19:13
deadalnix created D3550: Remove EncodeDestination's overload relying on global state.
Jul 4 2019, 17:25
deadalnix created D3549: Use CashAddr everywhere in the Qt interface.
Jul 4 2019, 17:22
deadalnix accepted D3546: [build] Don't fail when passed --disable-lcov and lcov isn't available.
Jul 4 2019, 16:12
deadalnix accepted D3547: [build] Warn that only libconsensus can be built without boost.
Jul 4 2019, 16:12
deadalnix accepted D3544: Use AC_ARG_VAR to set ARFLAGS..
Jul 4 2019, 16:11
deadalnix accepted D3515: Make CWallet IsSpent and IsLockedCoin take a COutPoint as parameter.
Jul 4 2019, 16:11
deadalnix updated the diff for D3539: Only handle cashaddr prefix in OpenURIDialog.

Remove leftover header that is not required anymore

Jul 4 2019, 16:10
deadalnix created D3548: Take CChainParams explicitely in PaymentServer.
Jul 4 2019, 15:58
deadalnix created D3543: Always use cashaddr for dummy addresses in the GUI.
Jul 4 2019, 12:06

Jul 3 2019

deadalnix requested changes to D3540: make check in parallel - turbo mode.

Core has soem code doing this. cmake needs to be kept in sync with automake.

Jul 3 2019, 23:39
deadalnix accepted D3541: Merge #10313: [Consensus] Add constant for maximum stack size.
Jul 3 2019, 23:37
deadalnix accepted D3452: [ibd.sh] Store datadir and debug.log paths in variables.
Jul 3 2019, 18:31
deadalnix requested changes to D3515: Make CWallet IsSpent and IsLockedCoin take a COutPoint as parameter.
Jul 3 2019, 18:30
deadalnix created D3539: Only handle cashaddr prefix in OpenURIDialog.
Jul 3 2019, 18:27
deadalnix requested changes to D3530: Make various functions in src/test/ static.

See D3526

Jul 3 2019, 18:26
deadalnix committed rABCad4678991e96: Activate cashaddr by default (authored by deadalnix).
Activate cashaddr by default
Jul 3 2019, 16:23
deadalnix closed D3538: Activate cashaddr by default.
Jul 3 2019, 16:23
deadalnix added inline comments to D3515: Make CWallet IsSpent and IsLockedCoin take a COutPoint as parameter.
Jul 3 2019, 16:05
deadalnix created D3538: Activate cashaddr by default.
Jul 3 2019, 14:43
deadalnix committed rABC563841135476: Backport base58 tests from PR11167 (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Backport base58 tests from PR11167
Jul 3 2019, 14:19
deadalnix closed D3509: Backport base58 tests from PR11167.
Jul 3 2019, 14:19
deadalnix accepted D3511: Merge #11772: [tests] Change invalidblockrequest to use BitcoinTestFramework.
Jul 3 2019, 13:46
deadalnix accepted D3514: Merge #11773: [tests] Change feature_block.py to use BitcoinTestFramework.
Jul 3 2019, 13:40
deadalnix requested changes to D3526: Make printchunk() in support/lockedpool.cpp static.

This is definitively not a merge of 13163 like the title imply. This makes for completely incomprehensible history.

Jul 3 2019, 13:15
deadalnix accepted D3528: Merge #13048: [tests] Fix feature_block flakiness.
Jul 3 2019, 13:14
deadalnix accepted D3527: Merge #13003: qa: Add test for orphan handling.
Jul 3 2019, 13:11
deadalnix accepted D3537: Revert "Workaround to Travis-CI Wine/Mingw build hanging occasionally".

Please remove travis altogether if you are going that road.

Jul 3 2019, 13:09
deadalnix accepted D3530: Make various functions in src/test/ static.
Jul 3 2019, 13:09
deadalnix accepted D3520: RPC: Add child transactions to getrawmempool verbose output.
Jul 3 2019, 13:07
deadalnix updated the diff for D3509: Backport base58 tests from PR11167.

Address comments

Jul 3 2019, 13:02
deadalnix requested changes to D3528: Merge #13048: [tests] Fix feature_block flakiness.

The description is fubared

Jul 3 2019, 02:27
deadalnix accepted D3533: Merge #12424: Fix rescan test failure due to unset g_address_type, g_change_type.

likestamp

Jul 3 2019, 02:26
deadalnix accepted D3531: Merge #12127: Remove unused mempool index.
Jul 3 2019, 02:26
deadalnix requested changes to D3515: Make CWallet IsSpent and IsLockedCoin take a COutPoint as parameter.
Jul 3 2019, 01:18
deadalnix created D3536: Only generate cashaddr URI from the GUI.
Jul 3 2019, 01:14
deadalnix accepted D3517: [LINTER] Fix the python format string when dealing with arrays.
Jul 3 2019, 01:12
deadalnix requested changes to D3531: Merge #12127: Remove unused mempool index.

Please update the description to mention the PR properly.

Jul 3 2019, 01:10
deadalnix accepted D3532: Merge #12293: [rpc] Mention that HD is enabled if hdmasterkeyid is present.
Jul 3 2019, 01:08
deadalnix accepted D3534: Merge #12150: Fix ListCoins test failure due to unset g_address_type, g_change_type.
Jul 3 2019, 01:07
deadalnix accepted D3521: qa: Fix python TypeError in script.py.
Jul 3 2019, 01:02

Jul 2 2019

D3453: [ibd.sh] Add chainwork sanity check now requires changes to proceed.
Jul 2 2019, 01:37
deadalnix accepted D3510: Merge #13163: Make it clear which functions that are intended to be translation unit local (wallet files).
Jul 2 2019, 00:54

Jul 1 2019

deadalnix added inline comments to D3505: Merge #10347: Use range-based for loops (C++11) when looping over vector elements.
Jul 1 2019, 22:54
deadalnix added inline comments to D3505: Merge #10347: Use range-based for loops (C++11) when looping over vector elements.
Jul 1 2019, 22:53
deadalnix committed rABCa4c619c43fb0: test: Make g_insecure_rand_ctx thread_local (authored by MarcoFalke <falke.marco@gmail.com>).
test: Make g_insecure_rand_ctx thread_local
Jul 1 2019, 22:48
deadalnix closed D3485: test: Make g_insecure_rand_ctx thread_local.
Jul 1 2019, 22:48
D3507: Pull Doxyfile artifact from build.bitcoinabc.org now requires changes to proceed.

The host serving the doc should probably not be the one building it. The description of the diff doesn't explain why this is necessary.

Jul 1 2019, 22:47
deadalnix committed rABC4f21390dbe60: Make unit tests use the insecure_rand_ctx exclusively (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Make unit tests use the insecure_rand_ctx exclusively
Jul 1 2019, 22:44
deadalnix closed D3450: Make unit tests use the insecure_rand_ctx exclusively.
Jul 1 2019, 22:44
deadalnix committed rABC93e1fc4228a0: Handle various leftover from PR10321 (authored by deadalnix).
Handle various leftover from PR10321
Jul 1 2019, 22:15
deadalnix closed D3441: Handle various leftover from PR10321.
Jul 1 2019, 22:15
deadalnix closed D3500: Various nits in the Qt code.
Jul 1 2019, 21:57
deadalnix committed rABCcad612f796db: Various nits in the Qt code (authored by deadalnix).
Various nits in the Qt code
Jul 1 2019, 21:57
deadalnix created D3509: Backport base58 tests from PR11167.
Jul 1 2019, 21:57
deadalnix requested changes to D3502: Added a script to generate chainparams constants header files.
Jul 1 2019, 20:41
deadalnix added a comment to D3500: Various nits in the Qt code.

rebase

Jul 1 2019, 20:25
deadalnix created D3500: Various nits in the Qt code.
Jul 1 2019, 16:00
deadalnix committed rABC6464b9da357e: wallet: Add HasWallets (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
wallet: Add HasWallets
Jul 1 2019, 13:58
deadalnix closed D3490: wallet: Add HasWallets.
Jul 1 2019, 13:58
deadalnix closed D3488: wallet: Add AddWallet, RemoveWallet, GetWallet and GetWallets.
Jul 1 2019, 13:54
deadalnix committed rABC8c14a287a324: wallet: Add AddWallet, RemoveWallet, GetWallet and GetWallets (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
wallet: Add AddWallet, RemoveWallet, GetWallet and GetWallets
Jul 1 2019, 13:54
D3499: qa: Prepare functional tests for Windows is now accepted and ready to land.
Jul 1 2019, 13:51
D3498: Fix a-vs-an typos is now accepted and ready to land.
Jul 1 2019, 13:50
deadalnix added a comment to D3490: wallet: Add HasWallets.

rebase

Jul 1 2019, 12:51
deadalnix added a comment to D3488: wallet: Add AddWallet, RemoveWallet, GetWallet and GetWallets.

rebase and add braces

Jul 1 2019, 12:30
D3497: wallet: Disallow abandon of conflicted txes is now accepted and ready to land.
Jul 1 2019, 12:23
deadalnix committed rABC26936e274ee2: refactor: Drop CWalletRef typedef (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
refactor: Drop CWalletRef typedef
Jul 1 2019, 12:22
deadalnix closed D3486: refactor: Drop CWalletRef typedef.
Jul 1 2019, 12:21
deadalnix committed rABC3f2ff0c81dbe: Prevent mutex lock fail even if --enable-debug (authored by Akio Nakamura <nakamura@dgtechnologies.co.jp>).
Prevent mutex lock fail even if --enable-debug
Jul 1 2019, 12:15