Page MenuHomePhabricator
Feed Advanced Search

Jul 10 2019

deadalnix accepted D3635: [wallet] Pass error message back from CWallet::Verify().
Jul 10 2019, 15:07
deadalnix accepted D3632: [wallet] Add CWallet::Verify function.
Jul 10 2019, 15:05
deadalnix committed rABC7ed6717f8a38: Regenerate timing.json (authored by deadalnix).
Regenerate timing.json
Jul 10 2019, 15:04
deadalnix closed D3633: Regenerate timing.json.
Jul 10 2019, 15:04
deadalnix requested changes to D3627: [refactor multisig] remove redundant stack check.

This code must remain "obviously correct" as much as possible. Systematically doing bound check before accessing an element is absolutely part of that process.

Jul 10 2019, 15:02
deadalnix accepted D3631: wallet: Make vpwallets usage thread safe.
Jul 10 2019, 14:59
deadalnix requested changes to D3625: [refactor multisig] make const values up front.
Jul 10 2019, 14:58
deadalnix added inline comments to D3618: Rename wallet database classes.
Jul 10 2019, 14:41
deadalnix updated the diff for D3618: Rename wallet database classes.

iRebase on top of D3618 and fix comments.

Jul 10 2019, 14:41
deadalnix created D3634: wallet: Initialize m_last_block_processed to nullptr. Initialize fields where defined..
Jul 10 2019, 14:33
deadalnix created D3633: Regenerate timing.json.
Jul 10 2019, 14:17
deadalnix committed rABC6509f482538a: Rename wallet_accounts.py test (authored by Russell Yanofsky <russ@yanofsky.org>).
Rename wallet_accounts.py test
Jul 10 2019, 13:33
deadalnix closed D3624: Rename wallet_accounts.py test.
Jul 10 2019, 13:32
deadalnix requested changes to D3627: [refactor multisig] remove redundant stack check.

This makes me a bit worried, to be honest. Isn't it possible to move the nulldummy check near the bound check? This will avoid the spooky action at a distance effect (which is probably why this redundant check survived here in the first place).

Jul 10 2019, 02:35
deadalnix added inline comments to D3626: [refactor multisig] separate nullfail from stack cleanup.
Jul 10 2019, 02:32
deadalnix requested changes to D3625: [refactor multisig] make const values up front.
Jul 10 2019, 02:27
deadalnix requested changes to D3625: [refactor multisig] make const values up front.
Jul 10 2019, 02:01
deadalnix accepted D3623: Merge #10728: fix typo in help text for removeprunedfunds.
Jul 10 2019, 01:54
deadalnix created D3624: Rename wallet_accounts.py test.
Jul 10 2019, 00:21
deadalnix requested changes to D3623: Merge #10728: fix typo in help text for removeprunedfunds.
Jul 10 2019, 00:11

Jul 9 2019

deadalnix accepted D3617: [schnorr functional test] improve tx handling.
Jul 9 2019, 23:48
deadalnix accepted D3616: [schnorr functional test] simplify funding logic.
Jul 9 2019, 23:46
deadalnix accepted D3620: Merge #10581: Simplify return values of GetCoin/HaveCoin(InCache).
Jul 9 2019, 23:42
deadalnix accepted D3615: [schnorr functional test] change block setup logic.
Jul 9 2019, 23:40
deadalnix requested changes to D3620: Merge #10581: Simplify return values of GetCoin/HaveCoin(InCache).
Jul 9 2019, 23:25
deadalnix accepted D3621: Merge #10684: Remove no longer used mempool.exists(outpoint).
Jul 9 2019, 23:21
deadalnix accepted D3622: Merge #10685: Clarify CCoinsViewMemPool documentation..
Jul 9 2019, 23:20
deadalnix accepted D3613: [script_tests] add tests for pubkey encoding with strictenc + nullfail.

Accepting, but this probably needs to be shuffled around based on change in the parent's diff.

Jul 9 2019, 20:30
deadalnix accepted D3611: [qt] Add support to search the address book.
Jul 9 2019, 20:26
deadalnix accepted D3601: [schnorr functional test] remove ComparisonTestFramework dependency.
Jul 9 2019, 20:24
deadalnix accepted D3614: Merge #14571: [tests] Test that nodes respond to getdata with notfound.
Jul 9 2019, 20:22
deadalnix requested changes to D3612: [script_tests] consolidate multisig order tests.

These are tests we inherited from core. I don't see a good reason to reorder it all.

Jul 9 2019, 20:20
deadalnix accepted D3607: Move CheckBlock() call to critical section.
Jul 9 2019, 20:12
deadalnix accepted D3599: Merge #10191: [trivial] Rename unused RPC arguments 'dummy'.
Jul 9 2019, 20:11
deadalnix created D3618: Rename wallet database classes.
Jul 9 2019, 18:59
deadalnix accepted D3583: Merge #13039: Add logging and error handling for file syncing.
Jul 9 2019, 17:33
deadalnix accepted D3606: tests: Fix lock-order-inversion (potential deadlock) in DoS_tests..
Jul 9 2019, 17:28
deadalnix accepted D3604: Optimize PNG images.
Jul 9 2019, 17:28
deadalnix accepted D3610: [script_tests] add small NUM2BIN case.
Jul 9 2019, 17:27
deadalnix accepted D3609: Fix scheduler test race due to BOOST_CHECK in multithreaded context.
Jul 9 2019, 17:26
deadalnix committed rABCb911146913f1: Various nits in the wallet code (authored by deadalnix).
Various nits in the wallet code
Jul 9 2019, 16:40
deadalnix closed D3608: Various nits in the wallet code.
Jul 9 2019, 16:40
deadalnix created D3608: Various nits in the wallet code.
Jul 9 2019, 13:50
deadalnix accepted D3605: Implements a virtual destructor on the BaseRequestHandler class..

It's actually a good idea to build with -Wdelete-non-virtual-dtor if the compiler supports it.

Jul 9 2019, 12:17
deadalnix requested changes to D3604: Optimize PNG images.

How come this is changing images we inherited from core ? Second, is this lossy ? If it is, it should not be done on source material.

Jul 9 2019, 12:16
deadalnix requested changes to D3606: tests: Fix lock-order-inversion (potential deadlock) in DoS_tests..
Jul 9 2019, 12:13
deadalnix requested changes to D3581: Merge #10657: Utils: Improvements to ECDSA key-handling code.

The comment in the interpreter should probably be added somewhere in sigencoding.cpp

Jul 9 2019, 01:53
deadalnix accepted D3596: Add the sanitizers suppression files and use them in teamcity build.
Jul 9 2019, 01:32
deadalnix requested changes to D3471: Merge #9868: Abstract out the command line options for block assembly.
Jul 9 2019, 01:30
deadalnix requested changes to D3507: Pull Doxyfile artifact from build.bitcoinabc.org.
Jul 9 2019, 01:13
deadalnix added a comment to D3507: Pull Doxyfile artifact from build.bitcoinabc.org.

If whatever is calling this dockerfile has these parameters, then wouldn't that be better to simply download the file and copy it within the docker image ?

Jul 9 2019, 01:12
deadalnix accepted D3600: Merge #10627: fixed listunspent rpc convert parameter.
Jul 9 2019, 01:04
deadalnix accepted D3602: Merge #10559: Change semantics of HaveCoinInCache to match HaveCoin.
Jul 9 2019, 01:03

Jul 8 2019

deadalnix added inline comments to D3474: Implement new checkmultisig trigger logic and execution logic..
Jul 8 2019, 17:21
deadalnix committed rABCaceb19bb7114: Split off key_io_tests from base58_tests (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Split off key_io_tests from base58_tests
Jul 8 2019, 17:19
deadalnix closed D3578: Split off key_io_tests from base58_tests.
Jul 8 2019, 17:19
deadalnix accepted D3593: [LINTER] Enforce source code file name conventions.
Jul 8 2019, 17:17
deadalnix committed rABCef3a4e71ac11: Partial backport of Core PR11167 to have similar feature in base58_tests.cpp (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Partial backport of Core PR11167 to have similar feature in base58_tests.cpp
Jul 8 2019, 15:51
deadalnix closed D3594: Partial backport of Core PR11167 to have similar feature in base58_tests.cpp.
Jul 8 2019, 15:51
deadalnix requested changes to D3474: Implement new checkmultisig trigger logic and execution logic..
Jul 8 2019, 15:17
deadalnix requested changes to D3473: [refactor multisig] consolidate legacy mode logic.
Jul 8 2019, 14:44
deadalnix accepted D3472: add SCRIPT_ENABLE_SCHNORR_MULTISIG flag for new multisig mode.
Jul 8 2019, 14:21
deadalnix committed rABC816d31b4f1da: Use cstdint in generated test headers (authored by deadalnix).
Use cstdint in generated test headers
Jul 8 2019, 14:16
deadalnix closed D3574: Use cstdint in generated test headers.
Jul 8 2019, 14:16
deadalnix updated the diff for D3578: Split off key_io_tests from base58_tests.

Rebase on top of D3594

Jul 8 2019, 14:08
deadalnix created D3594: Partial backport of Core PR11167 to have similar feature in base58_tests.cpp.
Jul 8 2019, 14:00
deadalnix added inline comments to D3578: Split off key_io_tests from base58_tests.
Jul 8 2019, 12:54
deadalnix requested review of D3574: Use cstdint in generated test headers.
Jul 8 2019, 12:46
deadalnix committed rABC8a7143e1c26e: Split key_io (address/key encodings) off from base58 (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Split key_io (address/key encodings) off from base58
Jul 8 2019, 12:28
deadalnix closed D3577: Split key_io (address/key encodings) off from base58.
Jul 8 2019, 12:28
deadalnix committed rABCe61a3659d2b3: Stop using CBase58Data for ext keys (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Stop using CBase58Data for ext keys
Jul 8 2019, 12:24
deadalnix closed D3576: Stop using CBase58Data for ext keys.
Jul 8 2019, 12:24
deadalnix accepted D3579: Merge #11747: Fix: Open files read only if requested.
Jul 8 2019, 12:23
deadalnix accepted D3592: [LINTER] Add a linter to replace `unsigned char` with `uint8_t`.
Jul 8 2019, 12:22
deadalnix committed rABCb56057837ced: Replace CBitcoinSecret with {Encode,Decode}Secret (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Replace CBitcoinSecret with {Encode,Decode}Secret
Jul 8 2019, 12:12
deadalnix closed D3575: Replace CBitcoinSecret with {Encode,Decode}Secret.
Jul 8 2019, 12:12
deadalnix accepted D3591: Move make check test logs out of tree.
Jul 8 2019, 11:40
deadalnix requested changes to D3583: Merge #13039: Add logging and error handling for file syncing.

Why C style error handling is garbage illustrated. I'll do a proper review later on.

Jul 8 2019, 00:50
deadalnix requested changes to D3579: Merge #11747: Fix: Open files read only if requested.
Jul 8 2019, 00:48
deadalnix committed rABC841945f0b308: Remove test for legacy address when parsing URL in the GUI (authored by deadalnix).
Remove test for legacy address when parsing URL in the GUI
Jul 8 2019, 00:34
deadalnix closed D3573: Remove test for legacy address when parsing URL in the GUI.
Jul 8 2019, 00:34

Jul 7 2019

deadalnix accepted D3555: Rename rpcuser.py to rpcauth.py.
Jul 7 2019, 14:47
deadalnix created D3578: Split off key_io_tests from base58_tests.
Jul 7 2019, 14:46
deadalnix created D3577: Split key_io (address/key encodings) off from base58.
Jul 7 2019, 14:38
deadalnix created D3576: Stop using CBase58Data for ext keys.
Jul 7 2019, 14:34
deadalnix created D3575: Replace CBitcoinSecret with {Encode,Decode}Secret.
Jul 7 2019, 14:29
deadalnix created D3574: Use cstdint in generated test headers.
Jul 7 2019, 13:09
deadalnix updated the diff for D3573: Remove test for legacy address when parsing URL in the GUI.

Remove unecessary header include

Jul 7 2019, 00:30
deadalnix created D3573: Remove test for legacy address when parsing URL in the GUI.
Jul 7 2019, 00:26

Jul 6 2019

deadalnix committed rABCf4d83da10303: Various nits in the Qt code (authored by deadalnix).
Various nits in the Qt code
Jul 6 2019, 23:46
deadalnix closed D3552: Various nits in the Qt code.
Jul 6 2019, 23:46
deadalnix committed rABCbb674b35bc25: Remove EncodeDestination's overload relying on global state (authored by deadalnix).
Remove EncodeDestination's overload relying on global state
Jul 6 2019, 16:53
deadalnix closed D3550: Remove EncodeDestination's overload relying on global state.
Jul 6 2019, 16:53
deadalnix committed rABCfb3575c34274: Default to cashaddr in most of the Qt API (authored by deadalnix).
Default to cashaddr in most of the Qt API
Jul 6 2019, 16:48
deadalnix closed D3551: Default to cashaddr in most of the Qt API.
Jul 6 2019, 16:48
deadalnix committed rABCbb02e6dd4724: Only generate cashaddr URI from the GUI (authored by deadalnix).
Only generate cashaddr URI from the GUI
Jul 6 2019, 16:46
deadalnix closed D3536: Only generate cashaddr URI from the GUI.
Jul 6 2019, 16:46
deadalnix updated the diff for D3551: Default to cashaddr in most of the Qt API.

Remove unecessary include

Jul 6 2019, 15:58
deadalnix requested changes to D3507: Pull Doxyfile artifact from build.bitcoinabc.org.
Jul 6 2019, 15:24
deadalnix added a comment to D3507: Pull Doxyfile artifact from build.bitcoinabc.org.

I read the rationale and did not understand any of it. It seems like Doxyfile is generated by the build system now, but that doesn't explain why it has to be done on the machine hosting the doc. If deploying artifacts on host is something that is challenging, then it seems like this problem should be talked, because this is pretty much the ONLY thing that deployment does.

Jul 6 2019, 15:24