Reddit is not a good place for this kind of questions.
Jul 18 2019
Jul 17 2019
ju is probably about the worse name possible.
This has not addressed the concern one bit.
Jul 16 2019
It doesn't looks like this is creating a self consistent API. In fact, you are importing assumption about the whole program (namely, that there is one config) into BlockAssembler, which a very clear and very bad regression.
Jul 15 2019
Jul 14 2019
Update cland-format to enforce the new style
Jul 13 2019
Jul 12 2019
Jul 11 2019
That's not good either. Removing the tooltip doesn't fix the problem.
THis fix for MSVC is not backported.
This is reintroducing global state, so no.
This is looking more like something, but:
1/ Naming is terrible, not even descriptive of anything.
2/ It seems strange to me that you need to rely on bitcoin-cli, when both bitcoin-cli and the test framework - this last one being in python, there may even be code that is reusable - manage to fetch the infos directly. Calling into the shell brings a ton fo baggage, especially since, presumably, this will be called from a shell to begin with.
3/ This require a fulling synced node for mainnet and testnet on the same machine running the script.
4/ It doesn't look like there is a way to only update mainnet or testnet.
Jul 10 2019
There is a tool that can do this automatically and exaustively. Use it.
I'll just pretend that never saw this.