Page MenuHomePhabricator
Feed Advanced Search

Feb 8 2019

Fabien requested changes to D2508: [tests] nulldummy cleanup.
Feb 8 2019, 12:13
Herald added a reviewer for D2520: Fix trailing ';' in walletdb_tests: deadalnix.
Feb 8 2019, 12:05
Herald added a reviewer for D2519: Fix name collision in crypto_tests: deadalnix.
Feb 8 2019, 12:02
Fabien updated the summary of D2460: [CI] Run functional tests bost pre and post great wall.
Feb 8 2019, 11:11
Fabien updated the diff for D2460: [CI] Run functional tests bost pre and post great wall.

Rebase on top of D2518

Feb 8 2019, 11:10
Fabien updated the test plan for D2518: Add an argument to the test framework to enable great wall activation.
Feb 8 2019, 11:09
Fabien requested changes to D2508: [tests] nulldummy cleanup.
Feb 8 2019, 11:04
Herald added a reviewer for D2518: Add an argument to the test framework to enable great wall activation: deadalnix.
Feb 8 2019, 10:50
Fabien updated the diff for D2452: Make the number service of service flag bits to display a constant.

Set the constant as the last non experimental service bit.
No longer filter more than avoiding experimental bits.

Feb 8 2019, 08:40

Feb 5 2019

Fabien updated the diff for D2492: Make test_runner.py scripts argument accept wildcard.

Back to re.sub() instead of replace()

Feb 5 2019, 09:24
Fabien planned changes to D2460: [CI] Run functional tests bost pre and post great wall.

Dependency abandonned

Feb 5 2019, 08:41
Fabien abandoned D2490: Remove duplicated whitelist=127.0.0.1 argument from comptool tests.
Feb 5 2019, 08:41
Fabien abandoned D2459: Add a cli option to the test framework to add an argument to all nodes.

Need a better solution

Feb 5 2019, 08:40
Fabien committed rABC1f651f46bcb8: [CMAKE] Fix cmake check-functional dependencies (authored by Fabien).
[CMAKE] Fix cmake check-functional dependencies
Feb 5 2019, 08:15
Fabien closed D2498: [CMAKE] Fix cmake check-functional dependencies.
Feb 5 2019, 08:15
Fabien added inline comments to D2494: [CMAKE] Run test/util/bitcoin-util-test.py with ninja check.
Feb 5 2019, 08:09
Fabien committed rABC300531300aee: ArgsManager: special handling for -regtest and -testnet (authored by Anthony Towns <aj@erisian.com.au>).
ArgsManager: special handling for -regtest and -testnet
Feb 5 2019, 07:59
Fabien closed D2436: ArgsManager: special handling for -regtest and -testnet.
Feb 5 2019, 07:59
Fabien committed rABCe498befb04e9: Limit some options to only apply on mainnet when in default section (authored by Anthony Towns <aj@erisian.com.au>).
Limit some options to only apply on mainnet when in default section
Feb 5 2019, 07:58
Fabien closed D2435: Limit some options to only apply on mainnet when in default section.
Feb 5 2019, 07:58
Fabien committed rABCf3a3fd103236: ArgsManager: support config file sections (authored by Anthony Towns <aj@erisian.com.au>).
ArgsManager: support config file sections
Feb 5 2019, 07:57
Fabien closed D2434: ArgsManager: support config file sections.
Feb 5 2019, 07:57
Fabien committed rABCc8ab745844c2: ArgsManager: drop m_negated_args (authored by Anthony Towns <aj@erisian.com.au>).
ArgsManager: drop m_negated_args
Feb 5 2019, 07:56
Fabien closed D2433: ArgsManager: drop m_negated_args.
Feb 5 2019, 07:55
Fabien committed rABCf9092cd61146: ArgsManager: keep command line and config file arguments separate (authored by Anthony Towns <aj@erisian.com.au>).
ArgsManager: keep command line and config file arguments separate
Feb 5 2019, 07:54
Fabien closed D2432: ArgsManager: keep command line and config file arguments separate.
Feb 5 2019, 07:54

Feb 4 2019

Fabien updated the diff for D2494: [CMAKE] Run test/util/bitcoin-util-test.py with ninja check.

bitcoin-util-test => check-bitcoin-util

Feb 4 2019, 18:59
Fabien added inline comments to D2494: [CMAKE] Run test/util/bitcoin-util-test.py with ninja check.
Feb 4 2019, 17:36
Fabien updated the diff for D2494: [CMAKE] Run test/util/bitcoin-util-test.py with ninja check.

Remove now useless add_test

Feb 4 2019, 17:35
Fabien updated the diff for D2498: [CMAKE] Fix cmake check-functional dependencies.

Also add bitcoin-cli dependency

Feb 4 2019, 16:16
Fabien updated the test plan for D2498: [CMAKE] Fix cmake check-functional dependencies.
Feb 4 2019, 16:15
Fabien planned changes to D2498: [CMAKE] Fix cmake check-functional dependencies.
Feb 4 2019, 16:07
Fabien committed rABC81eb83a1962b: Fix nits in unit tests (authored by Fabien).
Fix nits in unit tests
Feb 4 2019, 15:58
Fabien closed D2495: Fix nits in unit tests.
Feb 4 2019, 15:58
Fabien committed rABC3f86119db7f1: Fix a Clang -Wshadow warning in rcu.h (authored by Fabien).
Fix a Clang -Wshadow warning in rcu.h
Feb 4 2019, 15:58
Fabien closed D2491: Fix a Clang -Wshadow warning in rcu.h.
Feb 4 2019, 15:57
Herald added a reviewer for D2498: [CMAKE] Fix cmake check-functional dependencies: deadalnix.
Feb 4 2019, 15:54
Fabien added inline comments to D2494: [CMAKE] Run test/util/bitcoin-util-test.py with ninja check.
Feb 4 2019, 15:46
Fabien updated the test plan for D2494: [CMAKE] Run test/util/bitcoin-util-test.py with ninja check.
Feb 4 2019, 15:44
Fabien updated the diff for D2494: [CMAKE] Run test/util/bitcoin-util-test.py with ninja check.

Remove wrapping the script with ctest

Feb 4 2019, 15:44
Fabien abandoned D2497: [CMAKE] Allow test_bitcoin unit tests to run in parallel.

Newer cmake version would run test suites in parallel.
Running tests within suites in parallel could overcharge the cpu

Feb 4 2019, 13:47
Fabien updated the test plan for D2497: [CMAKE] Allow test_bitcoin unit tests to run in parallel.
Feb 4 2019, 13:31
Fabien requested review of D2459: Add a cli option to the test framework to add an argument to all nodes.

@deadalnix The idea is to provide a mechanism for running the tests with greatwallactivationtime enabled. This diff together with D2460 allow for running the tests both pre and post update using the CI.
This is a followup of the discussion on slack regarding D2431.

Feb 4 2019, 13:24
Fabien requested review of D2497: [CMAKE] Allow test_bitcoin unit tests to run in parallel.

Run cmake from build directory in test plan
@deadalnix I suppose this is what you meant ? Or is there something else ? Of course I tested all of this

Feb 4 2019, 12:22
Fabien updated the test plan for D2497: [CMAKE] Allow test_bitcoin unit tests to run in parallel.
Feb 4 2019, 12:18
Fabien updated the test plan for D2497: [CMAKE] Allow test_bitcoin unit tests to run in parallel.
Feb 4 2019, 12:18
Fabien updated the test plan for D2497: [CMAKE] Allow test_bitcoin unit tests to run in parallel.
Feb 4 2019, 12:11
Fabien updated the diff for D2491: Fix a Clang -Wshadow warning in rcu.h.

Rename optr => rhs

Feb 4 2019, 12:09
Herald added a reviewer for D2497: [CMAKE] Allow test_bitcoin unit tests to run in parallel: deadalnix.
Feb 4 2019, 11:32
Herald added a reviewer for D2496: [CMAKE] Refactor test_bitcoin unit tests declaration: deadalnix.
Feb 4 2019, 11:29
Herald added a reviewer for D2495: Fix nits in unit tests: deadalnix.
Feb 4 2019, 11:22
Herald added a reviewer for D2494: [CMAKE] Run test/util/bitcoin-util-test.py with ninja check: deadalnix.
Feb 4 2019, 11:07
Herald added a reviewer for D2493: [CMAKE] Add secp256k1 and univalue tests to the cmake check target: deadalnix.
Feb 4 2019, 11:01
Herald added a reviewer for D2492: Make test_runner.py scripts argument accept wildcard: deadalnix.
Feb 4 2019, 10:11
Herald added a reviewer for D2491: Fix a Clang -Wshadow warning in rcu.h: deadalnix.
Feb 4 2019, 10:08
Herald added a reviewer for D2490: Remove duplicated whitelist=127.0.0.1 argument from comptool tests: deadalnix.
Feb 4 2019, 10:06
Fabien updated the summary of D2459: Add a cli option to the test framework to add an argument to all nodes.
Feb 4 2019, 09:32
Fabien updated the diff for D2459: Add a cli option to the test framework to add an argument to all nodes.

Do not override arguments when using TestNode.extra_args, but extend them instead

Feb 4 2019, 09:30
Fabien updated the test plan for D2459: Add a cli option to the test framework to add an argument to all nodes.
Feb 4 2019, 09:26

Feb 3 2019

Fabien updated the test plan for D2459: Add a cli option to the test framework to add an argument to all nodes.
Feb 3 2019, 22:15
Fabien updated the test plan for D2459: Add a cli option to the test framework to add an argument to all nodes.
Feb 3 2019, 21:40
Fabien accepted D2289: Ban nodes providing an invalid checksum in a message header.

OK for banning directly in order to handle the version checksum case

Feb 3 2019, 14:10

Feb 1 2019

Fabien updated the diff for D2452: Make the number service of service flag bits to display a constant.

Move the boundary into the service bits enum

Feb 1 2019, 20:54
Fabien committed rABC73fbd55965ef: Drop upgrade-cancel callback registration for a generic "cancelable" (authored by Matt Corallo <git@bluematt.me>).
Drop upgrade-cancel callback registration for a generic "cancelable"
Feb 1 2019, 20:44
Fabien closed D2476: Drop upgrade-cancel callback registration for a generic "cancelable".
Feb 1 2019, 20:44
Fabien committed rABC176af7cb6d46: Remove trailing space in logging.cpp (authored by Fabien).
Remove trailing space in logging.cpp
Feb 1 2019, 11:20
Fabien closed D2456: Remove trailing space in logging.cpp.
Feb 1 2019, 11:20
Herald added a reviewer for D2476: Drop upgrade-cancel callback registration for a generic "cancelable": deadalnix.
Feb 1 2019, 11:16
Fabien claimed T511: Backport Core PR 10770.
Feb 1 2019, 10:02 · Backport
Fabien updated the diff for D2452: Make the number service of service flag bits to display a constant.

Update as per feedback

Feb 1 2019, 09:23

Jan 31 2019

Fabien planned changes to D2462: Make c++14 standard the default for compilation.

I would also have someone to test on OSX, atm I only checked that it builds on gitian.
I'm keeping it out of queue for now.

Jan 31 2019, 23:09
Fabien claimed T517: Backport Core PR 9680.
Jan 31 2019, 17:07 · Backport
Fabien committed rABC0ecab1630825: Remove NODE_WITNESS from messages.py (authored by Fabien).
Remove NODE_WITNESS from messages.py
Jan 31 2019, 16:43
Fabien closed D2443: Remove NODE_WITNESS from messages.py.
Jan 31 2019, 16:43
Herald added a reviewer for D2464: Use c++14 generic std::rbegin() and std::rend() instead of class methods: deadalnix.
Jan 31 2019, 16:42
Herald added a reviewer for D2463: Migrate MakeUnique to c++14 std::make_unique: deadalnix.
Jan 31 2019, 16:39
Herald added a reviewer for D2462: Make c++14 standard the default for compilation: deadalnix.
Jan 31 2019, 16:38
Herald added a reviewer for D2461: Drop support for OpenBSD: deadalnix.
Jan 31 2019, 16:36
Fabien updated the diff for D2460: [CI] Run functional tests bost pre and post great wall.

Run on non-master

Jan 31 2019, 16:33
Herald added a reviewer for D2460: [CI] Run functional tests bost pre and post great wall: Restricted Project.
Jan 31 2019, 16:11
Fabien accepted D2458: [cmake] Update secp256k1 test name to match the one in cmake.
Jan 31 2019, 14:42
Herald added a reviewer for D2459: Add a cli option to the test framework to add an argument to all nodes: deadalnix.
Jan 31 2019, 14:39
Herald added a reviewer for D2456: Remove trailing space in logging.cpp: deadalnix.
Jan 31 2019, 11:16
Fabien committed rABCdf298ba489b3: Check for unused imports in *.py files (authored by Fabien).
Check for unused imports in *.py files
Jan 31 2019, 11:08
Fabien closed D2451: Check for unused imports in *.py files.
Jan 31 2019, 11:07
Fabien committed rABCaadde70bfcb4: Use compile-time constants instead of unnamed enumerations (authored by practicalswift <practicalswift@users.noreply.github.com>).
Use compile-time constants instead of unnamed enumerations
Jan 31 2019, 11:04
Fabien closed D2454: Use compile-time constants instead of unnamed enumerations.
Jan 31 2019, 11:04
Fabien committed rABC8fac3ab4fe1b: Fix unused imports in contrib/ python scripts (authored by Fabien).
Fix unused imports in contrib/ python scripts
Jan 31 2019, 11:03
Fabien closed D2445: Fix unused imports in contrib/ python scripts.
Jan 31 2019, 11:03
Fabien added inline comments to D2452: Make the number service of service flag bits to display a constant.
Jan 31 2019, 11:02
Fabien updated the diff for D2452: Make the number service of service flag bits to display a constant.

Update using the largest flag position as the boundary instead of a constant

Jan 31 2019, 11:00
Fabien updated the diff for D2443: Remove NODE_WITNESS from messages.py.

Comment instead of removing

Jan 31 2019, 10:28
Fabien updated the diff for D2432: ArgsManager: keep command line and config file arguments separate.

Fix comments layout

Jan 31 2019, 10:25
Fabien accepted D2455: Enable Schnorr signature verification in CHECK(DATA)SIG(VERIFY).

I can't think of any missing test

Jan 31 2019, 10:16
Fabien requested changes to D2341: Enforce NULLDUMMY.

One nit, looks good to me otherwise.
Please request review when you're adding comments so the diff pops up in the review queue again.

Jan 31 2019, 08:45
Fabien accepted D2371: [Radix] Use RCUPtr to keep track of items in the tree.
Jan 31 2019, 08:30
Fabien added a comment to D2169: [secp256k1] Implement Schnorr signatures.

Please don't care about the last comment, this has already been discussed offline.
I failed to found how to delete my comment, if possible at all.

Jan 31 2019, 08:27
Fabien accepted D2169: [secp256k1] Implement Schnorr signatures.
Jan 31 2019, 08:12
Fabien added inline comments to D2432: ArgsManager: keep command line and config file arguments separate.
Jan 31 2019, 06:46

Jan 30 2019

Fabien committed rABC7541142d9a3c: Fix unused imports in lint/ python scripts (authored by Fabien).
Fix unused imports in lint/ python scripts
Jan 30 2019, 17:18