Page MenuHomePhabricator
Feed Advanced Search

Jun 26 2020

Fabien requested review of D6749: [CI] Make the build configuration a class.
Jun 26 2020, 14:51
Fabien requested review of D6748: [CI] Filter what is printed to the console and log it to files.
Jun 26 2020, 13:06
Fabien added inline comments to D6748: [CI] Filter what is printed to the console and log it to files.
Jun 26 2020, 13:05
Fabien updated the summary of D6748: [CI] Filter what is printed to the console and log it to files.
Jun 26 2020, 13:05
Fabien planned changes to D6748: [CI] Filter what is printed to the console and log it to files.
Jun 26 2020, 12:43
Fabien requested review of D6748: [CI] Filter what is printed to the console and log it to files.
Jun 26 2020, 12:43
Fabien requested review of D6735: [CI] Manage the build artifacts from the configuration.
Jun 26 2020, 07:47
Fabien accepted D6746: [CI] Ensure llvm-symbolizer is available in PATH.
Jun 26 2020, 07:24
Fabien requested changes to D6744: [linter] add exceptions to include guards and file name linters.
Jun 26 2020, 07:11
Fabien requested changes to D6741: [backport#17076] tests: Add fuzzing harness for CheckTransaction(...), IsStandardTx(...) and other CTransaction related functions.
Jun 26 2020, 07:05
Fabien accepted D6740: [backport#17069] tests: Pass fuzzing inputs as constant references.
Jun 26 2020, 06:49

Jun 25 2020

Fabien added a comment to D6735: [CI] Manage the build artifacts from the configuration.

Finally ready for review !

Jun 25 2020, 20:12
Fabien updated the diff for D6735: [CI] Manage the build artifacts from the configuration.

Restore teamcity detection

Jun 25 2020, 19:53
Fabien committed rABC3b5adc501f6e: [CI] Add a templating system to the configuration (authored by Fabien).
[CI] Add a templating system to the configuration
Jun 25 2020, 19:32
Fabien closed D6733: [CI] Add a templating system to the configuration.
Jun 25 2020, 19:32
Fabien committed rABC5c30ada8955f: [CI] Include the teamcity-messages library and display the build name (authored by Fabien).
[CI] Include the teamcity-messages library and display the build name
Jun 25 2020, 19:32
Fabien closed D6732: [CI] Include the teamcity-messages library and display the build name.
Jun 25 2020, 19:31
Fabien planned changes to D6735: [CI] Manage the build artifacts from the configuration.
Jun 25 2020, 19:30
Fabien updated the diff for D6735: [CI] Manage the build artifacts from the configuration.

Use a relative path

Jun 25 2020, 19:29
Fabien planned changes to D6735: [CI] Manage the build artifacts from the configuration.
Jun 25 2020, 18:08
Fabien updated the diff for D6735: [CI] Manage the build artifacts from the configuration.

Fix Path vs PurePath

Jun 25 2020, 18:08
Fabien planned changes to D6735: [CI] Manage the build artifacts from the configuration.
Jun 25 2020, 17:52
Fabien updated the diff for D6735: [CI] Manage the build artifacts from the configuration.

Test without teamcity detection

Jun 25 2020, 17:52
Fabien planned changes to D6735: [CI] Manage the build artifacts from the configuration.
Jun 25 2020, 17:00
Fabien updated the diff for D6735: [CI] Manage the build artifacts from the configuration.

Relocate the artifacts dir

Jun 25 2020, 17:00
Fabien accepted D6739: Fix build path in build-make-generator.
Jun 25 2020, 16:45
Fabien planned changes to D6735: [CI] Manage the build artifacts from the configuration.
Jun 25 2020, 16:18
Fabien updated the diff for D6735: [CI] Manage the build artifacts from the configuration.

Try not specifying an output path

Jun 25 2020, 16:16
Fabien updated the diff for D6735: [CI] Manage the build artifacts from the configuration.

Yet another try

Jun 25 2020, 16:00
Fabien planned changes to D6735: [CI] Manage the build artifacts from the configuration.
Jun 25 2020, 15:43
Fabien updated the diff for D6735: [CI] Manage the build artifacts from the configuration.

Still not working, trying something else

Jun 25 2020, 15:43
Fabien planned changes to D6735: [CI] Manage the build artifacts from the configuration.
Jun 25 2020, 14:50
Fabien updated the diff for D6735: [CI] Manage the build artifacts from the configuration.

Use artifact path from the current environment

Jun 25 2020, 14:50
Fabien planned changes to D6735: [CI] Manage the build artifacts from the configuration.
Jun 25 2020, 14:41
Fabien requested review of D6735: [CI] Manage the build artifacts from the configuration.
Jun 25 2020, 14:26
Fabien requested review of D6733: [CI] Add a templating system to the configuration.
Jun 25 2020, 10:53
Fabien requested review of D6732: [CI] Include the teamcity-messages library and display the build name.
Jun 25 2020, 09:39
Fabien accepted D6719: [CI] Make sure every build directory is under a common 'build' directory.
Jun 25 2020, 07:09
Fabien accepted D6726: [CI] Cleanup unused build-configurations wrapper.
Jun 25 2020, 06:50
Fabien added inline comments to D6710: [backport#15492] [rpc] remove deprecated generate method.
Jun 25 2020, 06:45
Fabien requested changes to D6710: [backport#15492] [rpc] remove deprecated generate method.
Jun 25 2020, 06:44
Fabien committed rABC0855a1adc243: [CI] Allow for setting environment variables from the configuration file (authored by Fabien).
[CI] Allow for setting environment variables from the configuration file
Jun 25 2020, 06:38
Fabien closed D6722: [CI] Allow for setting environment variables from the configuration file.
Jun 25 2020, 06:38

Jun 24 2020

Fabien committed rABCd870000060bd: [CI] Set build timeout in the configuration file (authored by Fabien).
[CI] Set build timeout in the configuration file
Jun 24 2020, 21:24
Fabien closed D6715: [CI] Set build timeout in the configuration file.
Jun 24 2020, 21:24
Fabien added a comment to D6722: [CI] Allow for setting environment variables from the configuration file.

@bot build-linux-aarch64 build-linux-arm

Jun 24 2020, 21:23
Fabien added inline comments to D6719: [CI] Make sure every build directory is under a common 'build' directory.
Jun 24 2020, 21:07
Fabien requested review of D6722: [CI] Allow for setting environment variables from the configuration file.
Jun 24 2020, 20:59
Fabien committed rABC606195478576: [LINTER] Enforce shellcheck >= 0.7.0 (authored by Fabien).
[LINTER] Enforce shellcheck >= 0.7.0
Jun 24 2020, 20:58
Fabien closed D6720: [LINTER] Enforce shellcheck >= 0.7.0.
Jun 24 2020, 20:58
Fabien updated the diff for D6715: [CI] Set build timeout in the configuration file.

Rebase and lower the default timeout to 1h

Jun 24 2020, 20:30
Fabien updated the summary of D6715: [CI] Set build timeout in the configuration file.
Jun 24 2020, 20:29
Fabien added inline comments to D6715: [CI] Set build timeout in the configuration file.
Jun 24 2020, 20:28
Fabien added inline comments to D6719: [CI] Make sure every build directory is under a common 'build' directory.
Jun 24 2020, 20:21
Fabien committed rABCedfeaac02471: [CI] Convert the build-configurations.sh script to python, read config (authored by Fabien).
[CI] Convert the build-configurations.sh script to python, read config
Jun 24 2020, 20:19
Fabien closed D6711: [CI] Convert the build-configurations.sh script to python, read config.
Jun 24 2020, 20:19
Fabien requested changes to D6719: [CI] Make sure every build directory is under a common 'build' directory.
Jun 24 2020, 20:18
Fabien accepted D6718: [CI] Fix a bug where CI scripts are not able to build in directories that are not one level below the project root.
Jun 24 2020, 20:15
Fabien requested review of D6720: [LINTER] Enforce shellcheck >= 0.7.0.
Jun 24 2020, 20:13
Fabien updated the diff for D6711: [CI] Convert the build-configurations.sh script to python, read config.

Feedback

Jun 24 2020, 19:38
Fabien requested review of D6715: [CI] Set build timeout in the configuration file.
Jun 24 2020, 19:30
Fabien updated the diff for D6711: [CI] Convert the build-configurations.sh script to python, read config.

Remove debug stuff

Jun 24 2020, 18:38
Fabien planned changes to D6711: [CI] Convert the build-configurations.sh script to python, read config.
Jun 24 2020, 18:37
Fabien requested review of D6711: [CI] Convert the build-configurations.sh script to python, read config.
Jun 24 2020, 18:37
Fabien closed D6703: [CI] Split build-configurations.sh into individual scripts.
Jun 24 2020, 17:37
Fabien committed rABCb3a674ca6d0d: [CI] Split build-configurations.sh into individual scripts (authored by Fabien).
[CI] Split build-configurations.sh into individual scripts
Jun 24 2020, 17:37
Fabien committed rABCa19ca67bb8c1: [CI] Extract the CI build facitilties to it's own script and source it (authored by Fabien).
[CI] Extract the CI build facitilties to it's own script and source it
Jun 24 2020, 17:37
Fabien closed D6701: [CI] Extract the CI build facitilties to it's own script and source it.
Jun 24 2020, 17:37
Fabien committed rABCWEB7d9d3206a117: [WEB] Update .arcconfig phabricator URI to the new syntax (authored by Fabien).
[WEB] Update .arcconfig phabricator URI to the new syntax
Jun 24 2020, 17:36
Fabien closed D6706: [WEB] Update .arcconfig phabricator URI to the new syntax.
Jun 24 2020, 17:36
Fabien requested review of D6706: [WEB] Update .arcconfig phabricator URI to the new syntax.
Jun 24 2020, 14:24
Fabien committed rABCd01d818ac573: Update .arcconfig phabricator URI to the new syntax (authored by Fabien).
Update .arcconfig phabricator URI to the new syntax
Jun 24 2020, 14:21
Fabien closed D6704: Update .arcconfig phabricator URI to the new syntax.
Jun 24 2020, 14:21
Fabien requested review of D6704: Update .arcconfig phabricator URI to the new syntax.
Jun 24 2020, 14:06
Fabien requested review of D6703: [CI] Split build-configurations.sh into individual scripts.
Jun 24 2020, 13:28
Fabien accepted D6698: [refactor] Add useful-for-dos "reason" field to CValidationState.
Jun 24 2020, 13:25
Fabien accepted D6702: Add jemalloc as a dependency on osx.
Jun 24 2020, 12:56
Fabien requested changes to D6702: Add jemalloc as a dependency on osx.

Good catch !

Jun 24 2020, 12:50
Fabien requested review of D6701: [CI] Extract the CI build facitilties to it's own script and source it.
Jun 24 2020, 10:44
Fabien committed rABCe5b59f324ec9: [CI] Wrap build_depends.sh on ibd.sh into functions (authored by Fabien).
[CI] Wrap build_depends.sh on ibd.sh into functions
Jun 24 2020, 08:59
Fabien closed D6690: [CI] Wrap build_depends.sh on ibd.sh into functions.
Jun 24 2020, 08:58
Fabien committed rABCd38e5d68a9b7: [CI] Setup don't need to be a function (authored by Fabien).
[CI] Setup don't need to be a function
Jun 24 2020, 08:58
Fabien closed D6689: [CI] Setup don't need to be a function.
Jun 24 2020, 08:58
Fabien accepted D6700: LookupBlockIndex -> CACHED_INVALID.
Jun 24 2020, 08:29
Fabien accepted D6699: [refactor] Drop redundant nDoS, corruptionPossible, SetCorruptionPossible.
Jun 24 2020, 08:28
Fabien requested changes to D6698: [refactor] Add useful-for-dos "reason" field to CValidationState.
Jun 24 2020, 08:26
Fabien added a comment to D6692: [land-bot] Preserve committer name and email.

Can you explain how it works ? Are the exported variables interpreted by arc land (I don't see any reference in the doc) ?

Jun 24 2020, 07:20
Fabien accepted D6691: [land-bot] Skip sanity check during arc patch.
Jun 24 2020, 07:09

Jun 23 2020

Fabien abandoned D6675: Do not review.
Jun 23 2020, 19:55
Fabien requested review of D6690: [CI] Wrap build_depends.sh on ibd.sh into functions.
Jun 23 2020, 19:54
Fabien updated the diff for D6689: [CI] Setup don't need to be a function.

Fix CI_SCRIPT_DIR so it doesn't depend on the caller location

Jun 23 2020, 19:35
Fabien planned changes to D6689: [CI] Setup don't need to be a function.
Jun 23 2020, 17:38
Fabien requested review of D6689: [CI] Setup don't need to be a function.
Jun 23 2020, 16:53
Fabien committed rABCc55ecd0094c1: [CI] Remove duplicated `cd` to the build dir with build-make-generator (authored by Fabien).
[CI] Remove duplicated `cd` to the build dir with build-make-generator
Jun 23 2020, 16:52
Fabien closed D6688: [CI] Remove duplicated `cd` to the build dir with build-make-generator.
Jun 23 2020, 16:52
Fabien requested review of D6688: [CI] Remove duplicated `cd` to the build dir with build-make-generator.
Jun 23 2020, 16:43
Fabien committed rABCc4b1781e835f: [CI] Wrap the build_autotools.sh script in a function (authored by Fabien).
[CI] Wrap the build_autotools.sh script in a function
Jun 23 2020, 16:42
Fabien closed D6687: [CI] Wrap the build_autotools.sh script in a function.
Jun 23 2020, 16:42
Fabien closed D6686: [CI] Make the build_autotools.sh script take a list of targets.
Jun 23 2020, 16:41
Fabien committed rABC4f31ce8a67fa: [CI] Make the build_autotools.sh script take a list of targets (authored by Fabien).
[CI] Make the build_autotools.sh script take a list of targets
Jun 23 2020, 16:41