Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Jan 26 2021

majcosta accepted D9071: Remove CCoinsViewCache::GetValueIn(...).
Jan 26 2021, 20:04
majcosta updated the diff for D9066: [backport#18727] test: Add CreateWalletFromFile test.

updated diff with changes that would've been in PR16426 (and renamed a lambda parameter to avoid a -Wshadow). this solved the build-debug error, but uncovered a TSAN warning. investigating that.

Jan 26 2021, 19:09
majcosta accepted D9070: gui: Add close window shortcut.
Jan 26 2021, 19:03
majcosta accepted D9069: test: Fix p2p_leak intermittent issue.
Jan 26 2021, 18:58
majcosta accepted D9068: test: use unittest and test_runner for test framework unit testing.
Jan 26 2021, 18:57
majcosta accepted D9067: rpc: Do not advertise dumptxoutset as a way to flush the chainstate.
Jan 26 2021, 18:55
majcosta accepted D9065: test: fix message for ECC_InitSanityCheck test.
Jan 26 2021, 18:54
majcosta accepted D9064: fix: update rest info on block size and json.
Jan 26 2021, 18:54
majcosta planned changes to D9066: [backport#18727] test: Add CreateWalletFromFile test.

investigate failure

Jan 26 2021, 17:33
majcosta planned changes to D8671: Add a --descriptors option to various tests.
Jan 26 2021, 17:14
majcosta requested review of D9066: [backport#18727] test: Add CreateWalletFromFile test.
Jan 26 2021, 17:11
majcosta commandeered D8671: Add a --descriptors option to various tests.

giving this a whirl

Jan 26 2021, 16:57
majcosta accepted D9062: tests: Don't limit fuzzing inputs to 1 MB for afl-fuzz (now: ∞ ∀ fuzzers).
Jan 26 2021, 13:52
majcosta accepted D9058: [WEBSITE] Add a logos page.
Jan 26 2021, 13:04
majcosta abandoned D9057: [backport#18691] test: add wait_for_cookie_credentials() to framework for rpcwait tests.

already done, abandoning

Jan 26 2021, 12:29

Jan 25 2021

majcosta requested review of D9057: [backport#18691] test: add wait_for_cookie_credentials() to framework for rpcwait tests.
Jan 25 2021, 22:57
majcosta accepted D9049: [net processing] Move Misbehaving() to PeerManager.
Jan 25 2021, 18:49
majcosta added a comment to D9049: [net processing] Move Misbehaving() to PeerManager.

@bot build-debug

Jan 25 2021, 18:17
majcosta requested changes to D9049: [net processing] Move Misbehaving() to PeerManager.
Jan 25 2021, 15:48

Jan 22 2021

majcosta accepted D9039: Bump version to 0.22.13.
Jan 22 2021, 14:27
majcosta updated the diff for D9020: [CashAddr] deprecate legacy prefixes maintaining backwards compatibility.

rebase

Jan 22 2021, 11:36
majcosta updated the diff for D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.

rebase

Jan 22 2021, 11:35
majcosta updated the diff for D9020: [CashAddr] deprecate legacy prefixes maintaining backwards compatibility.

fix missing braces error for gcc-8

Jan 22 2021, 00:34
majcosta planned changes to D9020: [CashAddr] deprecate legacy prefixes maintaining backwards compatibility.
Jan 22 2021, 00:10

Jan 21 2021

majcosta requested review of D9020: [CashAddr] deprecate legacy prefixes maintaining backwards compatibility.
Jan 21 2021, 21:52
majcosta updated the diff for D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.

removed the last backward compatibility tests I missed the first time around.

Jan 21 2021, 21:36
majcosta planned changes to D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.

missed some stuff in tests

Jan 21 2021, 21:22
majcosta updated the summary of D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.
Jan 21 2021, 21:21
majcosta updated the diff for D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.

cut all backwards compatibility changes from the patch, this is a pure prefix change now.

Jan 21 2021, 21:20
majcosta accepted D9009: [wallet] Update the rebroadcast frequency to be ~1/day..
Jan 21 2021, 13:53
majcosta accepted D9012: [mempool] Persist unbroadcast set to mempool.dat.

discussed off Phab, the wait_until import should be removed in PR19752

Jan 21 2021, 13:53
majcosta accepted D9006: [mempool] Track "unbroadcast" transactions.
Jan 21 2021, 13:49
majcosta requested changes to D9012: [mempool] Persist unbroadcast set to mempool.dat.
Jan 21 2021, 13:39
majcosta accepted D9011: [test] Integration tests for unbroadcast functionality.
Jan 21 2021, 13:35
majcosta updated the summary of D9011: [test] Integration tests for unbroadcast functionality.
Jan 21 2021, 13:20
majcosta accepted D9010: [refactor/test] Extract P2PTxInvStore into test framework.
Jan 21 2021, 13:18
majcosta accepted D9008: [p2p] Reattempt initial send of unbroadcast transactions.
Jan 21 2021, 13:14
majcosta accepted D9007: [util] Add method that returns random time in milliseconds.
Jan 21 2021, 13:11
majcosta requested changes to D9006: [mempool] Track "unbroadcast" transactions.
Jan 21 2021, 13:09
majcosta accepted D9005: tests: Add fuzzing harness for Golomb-Rice coding (GolombRiceEncode/GolombRiceDecode).
Jan 21 2021, 13:01
majcosta accepted D9004: fuzz: fix unused variable compiler warning.
Jan 21 2021, 12:43
majcosta accepted D9003: Add fuzzer version of randomized prevector test.
Jan 21 2021, 12:41
majcosta closed D8992: [backport#18754] bench: add CAddrMan benchmarks.
Jan 21 2021, 12:30
majcosta committed rABC8b0b3a190975: [backport#18754] bench: add CAddrMan benchmarks (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#18754] bench: add CAddrMan benchmarks
Jan 21 2021, 12:30
majcosta closed D8993: [backport#18669] log: Use Join() helper when listing log categories.
Jan 21 2021, 12:29
majcosta committed rABCf9ec355922bb: [backport#18669] log: Use Join() helper when listing log categories (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#18669] log: Use Join() helper when listing log categories
Jan 21 2021, 12:28
majcosta closed D8994: [backport#18777] wallet: Recommend absolute path for dumpwallet.
Jan 21 2021, 12:26
majcosta committed rABCd0fa5ad23b7c: [backport#18777] wallet: Recommend absolute path for dumpwallet (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#18777] wallet: Recommend absolute path for dumpwallet
Jan 21 2021, 12:26
majcosta updated the diff for D8992: [backport#18754] bench: add CAddrMan benchmarks.

addressed feedback

Jan 21 2021, 12:03
majcosta accepted D8997: [CI] Elect more builds to run on diff depending on simple heuristic.
Jan 21 2021, 11:58
majcosta abandoned D8990: [backport#18665] Do not expose and consider -logthreadnames when it does not work.

oh, looks like this one isn't helpful then. abandoning.

Jan 21 2021, 11:57
teamcity awarded D8992: [backport#18754] bench: add CAddrMan benchmarks a Haypence token.
Jan 21 2021, 08:55
majcosta updated the diff for D8992: [backport#18754] bench: add CAddrMan benchmarks.

rebase

Jan 21 2021, 00:35

Jan 20 2021

majcosta requested review of D8994: [backport#18777] wallet: Recommend absolute path for dumpwallet.
Jan 20 2021, 19:29
majcosta requested review of D8993: [backport#18669] log: Use Join() helper when listing log categories.
Jan 20 2021, 19:23
majcosta requested review of D8992: [backport#18754] bench: add CAddrMan benchmarks.
Jan 20 2021, 18:52
majcosta accepted D8988: test: use zero-argument super() shortcut (Python 3.0+).
Jan 20 2021, 18:19
majcosta accepted D8991: test: Fix intermittent failure in wallet_importmulti.
Jan 20 2021, 18:01
majcosta accepted D8989: test: Remove raw-tx byte juggling in mempool_reorg.
Jan 20 2021, 17:58
majcosta accepted D8987: tests: Add fuzzing harnesses for classes/functions in policy/fees.h, checkqueue.h and cuckoocache.h. Add fuzzing coverage..
Jan 20 2021, 17:35
majcosta requested review of D8990: [backport#18665] Do not expose and consider -logthreadnames when it does not work.
Jan 20 2021, 16:57
majcosta accepted D8979: tests: Add fuzzing harnesses for functions/classes in chain.h and protocol.h.
Jan 20 2021, 16:47
majcosta requested changes to D8979: tests: Add fuzzing harnesses for functions/classes in chain.h and protocol.h.
Jan 20 2021, 15:18

Jan 18 2021

majcosta closed D8938: [backport#16945#18181] refactor: introduce CChainState::GetCoinsCacheSizeState [plus fix].
Jan 18 2021, 13:06
majcosta committed rABC7680ec0096b1: [backport#16945#18181] refactor: introduce CChainState::GetCoinsCacheSizeState… (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
[backport#16945#18181] refactor: introduce CChainState::GetCoinsCacheSizeState…
Jan 18 2021, 13:05
teamcity awarded D8938: [backport#16945#18181] refactor: introduce CChainState::GetCoinsCacheSizeState [plus fix] a Doubloon token.
Jan 18 2021, 11:32
majcosta updated the diff for D8938: [backport#16945#18181] refactor: introduce CChainState::GetCoinsCacheSizeState [plus fix].

removed commented leftover debugging line and adapted the test for Coin::DynamicMemoryUsage() on 32-bit

Jan 18 2021, 11:12
teamcity awarded D8938: [backport#16945#18181] refactor: introduce CChainState::GetCoinsCacheSizeState [plus fix] a Piece of Eight token.
Jan 18 2021, 08:54
teamcity awarded D8938: [backport#16945#18181] refactor: introduce CChainState::GetCoinsCacheSizeState [plus fix] a Haypence token.
Jan 18 2021, 08:38

Jan 17 2021

majcosta updated the summary of D8938: [backport#16945#18181] refactor: introduce CChainState::GetCoinsCacheSizeState [plus fix].
Jan 17 2021, 12:11
majcosta accepted D8937: refactor: Remove unused methods CBloomFilter::reset()/clear().
Jan 17 2021, 10:37
majcosta accepted D8936: tests: have coins simulation test also use CCoinsViewDB.
Jan 17 2021, 10:35
majcosta accepted D8935: script: Disallow silent bool -> CScript conversion.
Jan 17 2021, 10:33
majcosta requested review of D8938: [backport#16945#18181] refactor: introduce CChainState::GetCoinsCacheSizeState [plus fix].
Jan 17 2021, 10:26

Jan 15 2021

majcosta closed D8921: [backport#16380] Remove unused bits from the service flags enum.
Jan 15 2021, 16:23
majcosta committed rABCb051c69478dd: [backport#16380] Remove unused bits from the service flags enum (authored by fanquake <fanquake@gmail.com>).
[backport#16380] Remove unused bits from the service flags enum
Jan 15 2021, 16:23
majcosta accepted D8932: test: Verify findCommonAncestor always initializes outputs.
Jan 15 2021, 15:35
majcosta accepted D8929: test: Add various low-level p2p tests.
Jan 15 2021, 14:45
majcosta accepted D8931: test: coverage improvements in interface-bitcoin_cli.py.
Jan 15 2021, 14:43
majcosta accepted D8930: [doc] Update thread information in developer docs.
Jan 15 2021, 14:20
majcosta requested changes to D8929: test: Add various low-level p2p tests.
Jan 15 2021, 13:53
majcosta updated the diff for D8921: [backport#16380] Remove unused bits from the service flags enum.

corrected date of removal and removed declaration in messages.py

Jan 15 2021, 11:31

Jan 14 2021

majcosta accepted D8918: Deprecate the `setexcessiveblock` RPC.
Jan 14 2021, 17:43
majcosta requested review of D8921: [backport#16380] Remove unused bits from the service flags enum.
Jan 14 2021, 17:42
majcosta accepted D8920: test: Remove REJECT message code.
Jan 14 2021, 17:15
majcosta accepted D8919: rpc: Remove deprecated migration code.
Jan 14 2021, 17:13
majcosta closed D8914: [backport#17453] gui: Fix intro dialog labels when the prune button is toggled.
Jan 14 2021, 15:38
majcosta committed rABCfbd564ae6a78: [backport#17453] gui: Fix intro dialog labels when the prune button is toggled (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
[backport#17453] gui: Fix intro dialog labels when the prune button is toggled
Jan 14 2021, 15:38
majcosta closed D8916: [backport#15874] Resolve the qt/guiutil <-> qt/optionsmodel CD.
Jan 14 2021, 15:38
majcosta committed rABCfc8c7fd5b1fa: [backport#15874] Resolve the qt/guiutil <-> qt/optionsmodel CD (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
[backport#15874] Resolve the qt/guiutil <-> qt/optionsmodel CD
Jan 14 2021, 15:38
majcosta updated the diff for D8914: [backport#17453] gui: Fix intro dialog labels when the prune button is toggled.

rebase on top of D8916 which fixes the circular dependency h/t @PiRK

Jan 14 2021, 14:41
majcosta closed D8913: [backport#17696] qt: Force set nPruneSize in QSettings after the intro dialog.
Jan 14 2021, 14:39
majcosta committed rABC6a7934983f7f: [backport#17696] qt: Force set nPruneSize in QSettings after the intro dialog (authored by fanquake <fanquake@gmail.com>).
[backport#17696] qt: Force set nPruneSize in QSettings after the intro dialog
Jan 14 2021, 14:39
majcosta accepted D8915: Add a test for the banscore deprecation.
Jan 14 2021, 14:37
majcosta requested review of D8916: [backport#15874] Resolve the qt/guiutil <-> qt/optionsmodel CD.
Jan 14 2021, 14:37
majcosta accepted D8912: cli -getinfo: use getbalances instead of deprecated getwalletinfo balance.
Jan 14 2021, 14:37
majcosta added a comment to D8912: cli -getinfo: use getbalances instead of deprecated getwalletinfo balance.

also "Backport of PR18574" is missing from summary

Jan 14 2021, 13:54
majcosta requested changes to D8912: cli -getinfo: use getbalances instead of deprecated getwalletinfo balance.
Jan 14 2021, 13:53
majcosta accepted D8910: Remove PID file at the very end.
Jan 14 2021, 13:50
majcosta accepted D8911: rpc: Make verifychain default values static, not depend on global args.
Jan 14 2021, 13:49
First
Prev
Next