Memory is getting fuzzy since this was a week or so ago... but Fabien and I were investigating bitcoin-qt not building with cmake 3.5. We found that an error was appearing that CMP0071 wasn't supported, so we tried various methods of disabling CMP0071 if the policy was not found. This resulting in a protobuf compilation failure that I'm not very familiar with. Instead of futzing with the protobuf dependency, we opted to bump the cmake version. This works with no other changes.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jan 15 2019
Jan 15 2019
Herald added a reviewer for D2321: Document assumptions that are being made to avoid NULL pointer dereferences: Restricted Project.
Herald added a reviewer for D2320: Merge #10303: [bench] Include ms/blk stats in Connect* benchmarks.: Restricted Project.
jasonbcox added inline comments to D2289: Ban nodes providing an invalid checksum in a message header.
jasonbcox added a comment to D2258: Bump cmake version 3.5 -> 3.10 to match lowest supported version for CMP0071.
Jan 14 2019
Jan 14 2019
jasonbcox committed rABCfef011298d33: Update disclosure and gitian signing keys (authored by jasonbcox).
Update disclosure and gitian signing keys
Fix zero'd checksum and simplified checksum index calculation
jasonbcox added inline comments to D2289: Ban nodes providing an invalid checksum in a message header.
jasonbcox added inline comments to D1894: Added RPCCommand base classes in preparation for RPC migration.
jasonbcox updated the diff for D1894: Added RPCCommand base classes in preparation for RPC migration.
- Rebased
- Fixed pointer ownership of RPCServer::commands
- RPCCommand::GetName() is no longer unexpectedly virtual
- Cleaned up the tests and comments
Rebase + changes according to feedback
Fix typo in 0.18.6 release notes
Jan 13 2019
Jan 13 2019
jasonbcox retitled D2300: Various nits in the RCU mechanism from Various nits in the RUC mechanism to Various nits in the RCU mechanism.
Jan 11 2019
Jan 11 2019
jasonbcox retitled D2297: Upgrade clang-format to 7.0 from Upgrade clanf-format to 7.0 to Upgrade clang-format to 7.0.
jasonbcox committed rABC6b1219302b6f: Add commands to copy the manifest files as part of the gitian building process… (authored by jasonbcox).
Add commands to copy the manifest files as part of the gitian building process…
jasonbcox updated the test plan for D2289: Ban nodes providing an invalid checksum in a message header.
Rewrote the test to include:
- valid message
- invalid message derived from an invalid one
Rewrote the changes I introduced in mininode.py to be more elegant
jasonbcox updated the diff for D2285: Add commands to copy the manifest files as part of the gitian building process, as they're generated in a separate location.
Rebase + don't be dumb and actually give the commands to complete the task without having to think about it
jasonbcox retitled D2285: Add commands to copy the manifest files as part of the gitian building process, as they're generated in a separate location from Add reminder to copy the manifest files as part of the gitian building process, as they're generated in a separate location to Add commands to copy the manifest files as part of the gitian building process, as they're generated in a separate location.
Update because Phab wants me to
Herald added a reviewer for D2289: Ban nodes providing an invalid checksum in a message header: Restricted Project.
Jan 10 2019
Jan 10 2019
jasonbcox updated the diff for D2285: Add commands to copy the manifest files as part of the gitian building process, as they're generated in a separate location.
Updated according to feedback, including command from the old comment
Please update doc/release-process.md so that it's clear to use this script instead of manually.
Herald added a reviewer for D2285: Add commands to copy the manifest files as part of the gitian building process, as they're generated in a separate location: Restricted Project.
Jan 9 2019
Jan 9 2019
Missing bitcoin-qt updates? Did you make sure to build latest master? (it has a bug fix that causes bitcoin-qt to crash while generating manpages)
Already completed by f16d66e52
jasonbcox closed T514: Backport Core PR 9424, a subtask of T417: Backport PR10244 from core, as Invalid.
jasonbcox committed rABC10866362b7d4: Move SEND_CONFIRM_DELAY to sendcoinsdialog.h (authored by jasonbcox).
Move SEND_CONFIRM_DELAY to sendcoinsdialog.h
jasonbcox committed rABC13ffe9a92f88: Update chainparams for 0.18.6 release (authored by jasonbcox).
Update chainparams for 0.18.6 release
Jan 8 2019
Jan 8 2019
jasonbcox edited subtasks for T417: Backport PR10244 from core, added: T508: Backport Core PR 10839; removed: T509: Backport Core PR 10769.
Herald added a reviewer for D2272: Move SEND_CONFIRM_DELAY to sendcoinsdialog.h: Restricted Project.
jasonbcox committed rABCa045556a6775: contrib: Add support for out-of-tree builds in gen-manpages.sh (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
contrib: Add support for out-of-tree builds in gen-manpages.sh
jasonbcox closed T507: Backport Core PR 12266, a subtask of T417: Backport PR10244 from core, as Resolved.
jasonbcox committed rABCa9d157640140: Move scheduler/threadGroup into common-init instead of per-app (authored by Matt Corallo <git@bluematt.me>).
Move scheduler/threadGroup into common-init instead of per-app
Herald added a reviewer for D2271: contrib: Add support for out-of-tree builds in gen-manpages.sh: Restricted Project.