In D2483#57852, @Mengerian wrote:In D2483#57845, @markblundeberg wrote:switch to generic flag-based activation that applies for all upgrades.
Interesting, if I understand correctly this would also work for the Replay Protection reorg code.
So does that mean the "IsReplayProtectionEnabled" portion could also be removed?
(I guess best done in a separate Diff)
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Feb 7 2019
Feb 7 2019
A couple of comments not addressed as I disagree with them (see replies above).
switch to generic flag-based activation that applies for all upgrades.
rebased for childrens' sake
make sure peers don't ban each other when tx would be valid before/after upgrade.
clean up last revision
(still need to add that p2p banning logic)
don't clear mempool but instead reprocess it (both upgrade/downgrade)
Feb 5 2019
Feb 5 2019
Alternative implementation in its own file, here : D2501
Herald added a reviewer for D2501: add Schnorr signing module to test_framework [alternative implementation]: deadalnix.
Feb 4 2019
Feb 4 2019
markblundeberg retitled D2483: Schnorr signature activation from Schnorr signature activation to [Target v0.19] Schnorr signature activation.
markblundeberg updated the diff for D2455: Enable Schnorr signature verification in CHECK(DATA)SIG(VERIFY).
rebased (fixed merge conflict with other added script_tests)
markblundeberg added inline comments to D2455: Enable Schnorr signature verification in CHECK(DATA)SIG(VERIFY).
rebased ; misc nits
Seems fine overall, perhaps premature though, do you have an immediate need for these refactors?
markblundeberg added inline comments to D2457: [schnorr] Refactor the signature process in reusable component.
markblundeberg updated the diff for D2455: Enable Schnorr signature verification in CHECK(DATA)SIG(VERIFY).
naming changes; add comments
(still need to add that p2p banning logic)
advance/rewind logic
markblundeberg updated the diff for D2489: fix dependency lcg.h in CMakeLists and Makefile.test.include.
oops, fixed the wrong thing
markblundeberg updated the summary of D2489: fix dependency lcg.h in CMakeLists and Makefile.test.include.
Herald added a reviewer for D2489: fix dependency lcg.h in CMakeLists and Makefile.test.include: deadalnix.
markblundeberg requested review of D2455: Enable Schnorr signature verification in CHECK(DATA)SIG(VERIFY).
Feb 3 2019
Feb 3 2019
In D2487#57038, @Mengerian wrote:Typo in title:
implemenation -> implementation
markblundeberg retitled D2487: add Schnorr signing implementation to test_framework from add Schnorr signing implemention to test_framework to add Schnorr signing implementation to test_framework.
markblundeberg retitled D2487: add Schnorr signing implementation to test_framework from add Schnorr signing implemenation to test_framework to add Schnorr signing implemention to test_framework.
(re-reading ... needs a few comment fixups)
markblundeberg added a comment to D2455: Enable Schnorr signature verification in CHECK(DATA)SIG(VERIFY).
In D2455#56983, @Mengerian wrote:Can the title of this be changed? I find it a bit difficult to parse.
Something like "Enable Schnorr signature verification in CHECK(DATA)SIG(VERIFY)" would be clearer IMO.
markblundeberg updated the test plan for D2455: Enable Schnorr signature verification in CHECK(DATA)SIG(VERIFY).
In D2483#56890, @deadalnix wrote:If node A has activated the fork, but B still hasn't, and A broadcast a tx that uses schnorr sigs to B, then B will ban A. Dig in the history for the activation of the original fork to figure out what kind of fix are possible and how to test.
markblundeberg updated the diff for D2455: Enable Schnorr signature verification in CHECK(DATA)SIG(VERIFY).
add new test module for 64/65 byte sigs ; tweaks on script_tests
markblundeberg added inline comments to D2457: [schnorr] Refactor the signature process in reusable component.
Feb 2 2019
Feb 2 2019
markblundeberg added inline comments to D2457: [schnorr] Refactor the signature process in reusable component.
markblundeberg added inline comments to D2457: [schnorr] Refactor the signature process in reusable component.
markblundeberg added inline comments to D2455: Enable Schnorr signature verification in CHECK(DATA)SIG(VERIFY).
markblundeberg added inline comments to D2455: Enable Schnorr signature verification in CHECK(DATA)SIG(VERIFY).
markblundeberg added a comment to D2455: Enable Schnorr signature verification in CHECK(DATA)SIG(VERIFY).
In D2455#56778, @deadalnix wrote:You may want to add a unit test for similar to checkdatasig_tests (also, that guys would benefit from using the LCG) for the schnorr sigs. Unit test allows to be more thorough. script_tests allows to have test vector everybody can reuse or test against. Both have their purpose an are necessary.
remove custom messaging
markblundeberg updated the test plan for D2455: Enable Schnorr signature verification in CHECK(DATA)SIG(VERIFY).
markblundeberg updated the diff for D2455: Enable Schnorr signature verification in CHECK(DATA)SIG(VERIFY).
rewrote tests; removed trick for generating valid 64-byte ecdsa
markblundeberg added a comment to D2455: Enable Schnorr signature verification in CHECK(DATA)SIG(VERIFY).
OK, thanks for the in depth ideas on how to organize this.
markblundeberg added a comment to D2455: Enable Schnorr signature verification in CHECK(DATA)SIG(VERIFY).
Possibly the whole business about generating valid 64 byte ECDSA sigs can be taken out...
markblundeberg updated the diff for D2455: Enable Schnorr signature verification in CHECK(DATA)SIG(VERIFY).
Note that when the old tests were applied, 7 of them failed due to the change in specification to ban 64+1-byte ECDSA sigs in CHECKMULTISIG. They were updated accordingly.
Feb 1 2019
Feb 1 2019
rebase; add comments; use new lcg.h test module
markblundeberg updated the diff for D2475: sigencoding_tests : use pseudorandom generator for flag patterns.
rm comment
markblundeberg added inline comments to D2475: sigencoding_tests : use pseudorandom generator for flag patterns.
markblundeberg updated the diff for D2475: sigencoding_tests : use pseudorandom generator for flag patterns.
rebased
changed name; misc comments from amaury
changed to return 32bit; expand attribution & explanation; more tests
markblundeberg updated the diff for D2475: sigencoding_tests : use pseudorandom generator for flag patterns.
updated to use D2480
markblundeberg updated the diff for D2475: sigencoding_tests : use pseudorandom generator for flag patterns.
ensure flags=00000...000 is done at start; rewrap LCG as class & separate test
markblundeberg added inline comments to D2475: sigencoding_tests : use pseudorandom generator for flag patterns.
OK looks good, I added a couple of comments showing how this will have to integrate with the schnorr flag
In D2477#56464, @Mengerian wrote:@markblundeberg Have a look at D2478. Does it make more sense with that one added after?
I split the refactor into two, this one to pave the way for banning 64-byte ECDSA signatures, and D2478 to make it easy to add Schnorr.
My idea is to add the code to restrict 64-byte signature inside CheckRawECDSASignatureEncoding, and add the code allowing 64-byte signatures (with no DER checks) in CheckRawSignatureEncoding
Maybe it would be less confusing if I combine the diffs into one.
(CheckTransactionECDSASignatureEncoding could also be called CheckTransactionSignatureEncodingButNo65ByteSignaturesAllowedIfSchnorrEnabled, at least that is the function that CHECKMULTISIG must call per specification.)
markblundeberg added a comment to D2475: sigencoding_tests : use pseudorandom generator for flag patterns.
Does this hit enough flag combinations? See comments in the code..
Herald added a reviewer for D2475: sigencoding_tests : use pseudorandom generator for flag patterns: deadalnix.
Jan 31 2019
Jan 31 2019
markblundeberg retitled D2469: Add SCRIPT_ENABLE_SCHNORR support to sigencoding from ban 64-byte signatures in CHECKMULTISIG when SCRIPT_ENABLE_SCHNORR to ban 64+1 byte signatures in CHECKMULTISIG when SCRIPT_ENABLE_SCHNORR.
Beautifully simple way to do an exception, which is reflected in the shortness of the Diff.
Herald added a reviewer for D2467: add tests throwing Schnorr signatures at opcodes when they are disallowed: deadalnix.