Was superseded by D4221.

Applying const T x : seq where T is a built-in type.

Duplicated with D4191.
Reason: arc usage error.

In D4191#100850, @deadalnix wrote:

In D4191#100826, @fpelliccioni wrote:

In D4191#100495, @deadalnix wrote:

Part of the PR are missing.

It is a partial application of the PR, I forgot to clarify it, sorry. (summary edited).
I didn't apply the rule for built-in types, because it makes no sense:
for (int x : seq)
is preferred over
for (int const& x : seq).
Have I missed anything else?

for (const int x : seq) is even better. There are still some missing, for instance in qt/bitcoingui.cpp .

test plan fixed.

In D4189#100853, @deadalnix wrote:

The test plan doesn't run.

The test plan is meant to describe the step you took to ensure that this patch is good. Clearly, the step described do not match what you have done, as they simply do not work.

In D4179#100740, @deadalnix wrote:

The test plan is meant to actually be ran.

In D4179#100728, @deadalnix wrote:

I see that you use make check-all in many tests. If you are using cmake, you should use ninja as it is faster. But right now, cmake is only a secondary option, so make sure the autotool build works.

update the summary to clarify that it is a partial application of the PR.

In D4191#100495, @deadalnix wrote:

Part of the PR are missing.

updated test plan.

fixes test plan.

fixes building error.

fixes building errors.

Duplicated: D4178

Rebase from master branch.

Test Plan fixed.

In D4142#99061, @jasonbcox wrote:

Can you clarify if the other instances are missing or all of them are already applied to the codebase?

Removes obvious type checks.

Test plan fixed.