Page MenuHomePhabricator
Feed All Stories

May 10 2019

teamcity added a comment to D3023: [tests] Remove unused and duplicate imports.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 10 2019, 21:42
Herald added a reviewer for D3023: [tests] Remove unused and duplicate imports: Restricted Project.
May 10 2019, 21:41
teamcity added a comment to D3022: Merge #10045: [trivial] Fix typos in comments.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 10 2019, 21:27
teamcity added a comment to D3022: Merge #10045: [trivial] Fix typos in comments.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 10 2019, 21:13
Herald added a reviewer for D3022: Merge #10045: [trivial] Fix typos in comments: Restricted Project.
May 10 2019, 21:12
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC822224e62410: [tests] remove txdb.h dependency from test_bitcoin.h (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).
[tests] remove txdb.h dependency from test_bitcoin.h
May 10 2019, 20:45
Diffusion closed D2963: [tests] remove txdb.h dependency from test_bitcoin.h.
May 10 2019, 20:45
Fabien accepted D2963: [tests] remove txdb.h dependency from test_bitcoin.h.
May 10 2019, 19:01
teamcity added a comment to D2964: Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 10 2019, 18:20
Nico Guiton <nico@bitframe.org> committed rABC6f47fcfacfed: Merge #11351: Refactor: Modernize disallowed copy constructors/assignment (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Merge #11351: Refactor: Modernize disallowed copy constructors/assignment
May 10 2019, 18:09
Diffusion closed D2983: Merge #11351: Refactor: Modernize disallowed copy constructors/assignment.
May 10 2019, 18:09
teamcity added a comment to D2983: Merge #11351: Refactor: Modernize disallowed copy constructors/assignment.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 10 2019, 18:08
teamcity added a comment to D2964: Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 10 2019, 18:06
nakihito updated the diff for D2964: Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead..

Previously mentioned issue was resolved with Fabien's suggestion of using .front().

May 10 2019, 18:06
Fabien updated the summary of D3020: [CMAKE] Add cross compiling support for ARM32 and ARM64.
May 10 2019, 18:04
markblundeberg accepted D2983: Merge #11351: Refactor: Modernize disallowed copy constructors/assignment.

Looks good, thanks!

May 10 2019, 18:00
teamcity added a comment to D2983: Merge #11351: Refactor: Modernize disallowed copy constructors/assignment.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 10 2019, 17:54
nakihito updated the diff for D2983: Merge #11351: Refactor: Modernize disallowed copy constructors/assignment.

Removed changes in txdb.h.

May 10 2019, 17:53
Nico Guiton <nico@bitframe.org> committed rABC70295b86c562: Merge #11155: Trivial: Documentation fixes for CVectorWriter ctors (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #11155: Trivial: Documentation fixes for CVectorWriter ctors
May 10 2019, 17:42
Diffusion closed D2982: Merge #11155: Trivial: Documentation fixes for CVectorWriter ctors.
May 10 2019, 17:42
jasonbcox accepted D3016: build: Remove -I for everything but project root.
May 10 2019, 16:35
teamcity added a comment to D3011: Merge #9833: Trivial: fix comments referencing AppInit2.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 10 2019, 16:31
teamcity added a comment to D3010: update release notes.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 10 2019, 16:29
teamcity added a comment to D3012: Backport current GetDifficulty logic (& tests) from Core.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 10 2019, 16:25
teamcity added a comment to D3011: Merge #9833: Trivial: fix comments referencing AppInit2.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 10 2019, 16:17
markblundeberg updated the diff for D3011: Merge #9833: Trivial: fix comments referencing AppInit2.

fix oopsie noticed by Jason

May 10 2019, 16:17
teamcity added a comment to D3021: Merge #12151: rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 10 2019, 16:16
teamcity added a comment to D3010: update release notes.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 10 2019, 16:15
markblundeberg updated the diff for D3010: update release notes.

update per Jason comments

May 10 2019, 16:14
markblundeberg added a comment to D3021: Merge #12151: rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON.

Due to divergent histories, the blockchain_tests affected in original PR do not exist yet in ABC; this will be fixed in child diff (D3012)

May 10 2019, 16:13
teamcity added a comment to D3012: Backport current GetDifficulty logic (& tests) from Core.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 10 2019, 16:11
markblundeberg updated the diff for D3012: Backport current GetDifficulty logic (& tests) from Core.

rebase onto D3021

May 10 2019, 16:10
markblundeberg updated the summary of D3014: Merge #10095: refactor: Move GetDifficulty out of `rpc/server.h`.
May 10 2019, 16:03
teamcity added a comment to D3021: Merge #12151: rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 10 2019, 16:02
markblundeberg updated the summary of D3021: Merge #12151: rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON.
May 10 2019, 16:02
Herald added a reviewer for D3021: Merge #12151: rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON: deadalnix.
May 10 2019, 16:01
jasonbcox requested changes to D3010: update release notes.

Added my suggestions which include capitalization, periods, and some rewordings.

May 10 2019, 15:23
jasonbcox requested changes to D3011: Merge #9833: Trivial: fix comments referencing AppInit2.
May 10 2019, 15:19
markblundeberg planned changes to D3012: Backport current GetDifficulty logic (& tests) from Core.
May 10 2019, 15:18
jasonbcox added a comment to D3009: Merge #9980: Fix mem access violation merkleblock.

still exists in this form in Core.

I notice the comment in merkleblock.h in ABC is noticeably different from Core, did we put that in or missing backport?

May 10 2019, 15:17
jasonbcox committed rABC034171f92e1b: Merge #12415: Interrupt loading thread after shutdown request (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #12415: Interrupt loading thread after shutdown request
May 10 2019, 15:17
jasonbcox closed D2958: Merge #12415: Interrupt loading thread after shutdown request.
May 10 2019, 15:17
Fabien accepted D2933: db: Remove obsolete methods from CBlockTreeDB..
May 10 2019, 15:08
Fabien accepted D2958: Merge #12415: Interrupt loading thread after shutdown request.
May 10 2019, 15:07
teamcity added a comment to D3020: [CMAKE] Add cross compiling support for ARM32 and ARM64.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 10 2019, 14:53
markblundeberg updated the summary of D3012: Backport current GetDifficulty logic (& tests) from Core.
May 10 2019, 14:43
teamcity added a comment to D3020: [CMAKE] Add cross compiling support for ARM32 and ARM64.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 10 2019, 14:39
Herald added a reviewer for D3020: [CMAKE] Add cross compiling support for ARM32 and ARM64: deadalnix.
May 10 2019, 14:38
teamcity added a comment to D3019: [CMAKE] Add cross build toolchain files for PC Linux platform.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 10 2019, 14:34
teamcity added a comment to D3019: [CMAKE] Add cross build toolchain files for PC Linux platform.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 10 2019, 14:19
Herald added a reviewer for D3019: [CMAKE] Add cross build toolchain files for PC Linux platform: deadalnix.
May 10 2019, 14:18
teamcity added a comment to D3018: [CMAKE] Fix CMake cross build for OSX.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 10 2019, 12:09
teamcity added a comment to D3018: [CMAKE] Fix CMake cross build for OSX.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 10 2019, 11:55
Herald added a reviewer for D3018: [CMAKE] Fix CMake cross build for OSX: deadalnix.
May 10 2019, 11:54
teamcity added a comment to D3017: [CMAKE] Add QT plugins according to the target platform.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 10 2019, 11:42
Fabien updated the summary of D3017: [CMAKE] Add QT plugins according to the target platform.
May 10 2019, 11:29
teamcity added a comment to D3017: [CMAKE] Add QT plugins according to the target platform.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 10 2019, 11:28
Herald added a reviewer for D3017: [CMAKE] Add QT plugins according to the target platform: deadalnix.
May 10 2019, 11:27
teamcity added a comment to D2948: [CMAKE] Fix the prl conversion script library path issue.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 10 2019, 11:07
teamcity added a comment to D2948: [CMAKE] Fix the prl conversion script library path issue.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 10 2019, 10:53
Fabien updated the diff for D2948: [CMAKE] Fix the prl conversion script library path issue.

Rebase

May 10 2019, 10:52
teamcity added a comment to D2892: [CMAKE] Add an option to enable the glibc compatibility features.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 10 2019, 10:24
teamcity added a comment to D3016: build: Remove -I for everything but project root.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 10 2019, 10:10
teamcity added a comment to D2892: [CMAKE] Add an option to enable the glibc compatibility features.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 10 2019, 10:10
Fabien updated the diff for D2892: [CMAKE] Add an option to enable the glibc compatibility features.

Rebase

May 10 2019, 10:10
Fabien committed rABC004264ca8c67: [CMAKE] Fix the prl conversion script linking against lib_NOTFOUND (authored by Fabien).
[CMAKE] Fix the prl conversion script linking against lib_NOTFOUND
May 10 2019, 10:07
Fabien closed D2949: [CMAKE] Fix the prl conversion script linking against lib_NOTFOUND.
May 10 2019, 10:07
Fabien committed rABC72f4670444b5: [CMAKE] Determine the Qt library directory from a public variable (authored by Fabien).
[CMAKE] Determine the Qt library directory from a public variable
May 10 2019, 10:06
Fabien closed D2947: [CMAKE] Determine the Qt library directory from a public variable.
May 10 2019, 10:06
Fabien committed rABCd39eb4619980: [CMAKE] Add an option to statically link libstdc++ (authored by Fabien).
[CMAKE] Add an option to statically link libstdc++
May 10 2019, 10:05
Fabien closed D2966: [CMAKE] Add an option to statically link libstdc++.
May 10 2019, 10:05
Fabien committed rABC8808e31743fb: [CMAKE] Add an option to reduce exports (authored by Fabien).
[CMAKE] Add an option to reduce exports
May 10 2019, 10:02
Fabien closed D2965: [CMAKE] Add an option to reduce exports.
May 10 2019, 10:02
teamcity added a comment to D3016: build: Remove -I for everything but project root.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 10 2019, 09:56
Herald added a reviewer for D3016: build: Remove -I for everything but project root: deadalnix.
May 10 2019, 09:55
Fabien triaged T649: Backport PR11651 as High priority.
May 10 2019, 09:48
teamcity added a comment to D3015: [CMAKE] Add support for libqrencode.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 10 2019, 09:05
teamcity added a comment to D3015: [CMAKE] Add support for libqrencode.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 10 2019, 08:51
Herald added a reviewer for D3015: [CMAKE] Add support for libqrencode: deadalnix.
May 10 2019, 08:50
teamcity added a comment to D3012: Backport current GetDifficulty logic (& tests) from Core.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 10 2019, 05:39
teamcity added a comment to D3014: Merge #10095: refactor: Move GetDifficulty out of `rpc/server.h`.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 10 2019, 05:34
markblundeberg added a comment to D3013: [rpc] Move tojson.h into blockchain.h.

note: TxToJSON is not in blockchain.cpp and doesn't need to be in a header either

May 10 2019, 05:30
teamcity added a comment to D3013: [rpc] Move tojson.h into blockchain.h.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 10 2019, 05:27
teamcity added a comment to D3012: Backport current GetDifficulty logic (& tests) from Core.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 10 2019, 05:25
markblundeberg updated the diff for D3012: Backport current GetDifficulty logic (& tests) from Core.

rebase onto 10095 backport

May 10 2019, 05:24
teamcity added a comment to D3014: Merge #10095: refactor: Move GetDifficulty out of `rpc/server.h`.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 10 2019, 05:20
Herald added a reviewer for D3014: Merge #10095: refactor: Move GetDifficulty out of `rpc/server.h`: deadalnix.
May 10 2019, 05:19
teamcity added a comment to D3013: [rpc] Move tojson.h into blockchain.h.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 10 2019, 05:14
Herald added a reviewer for D3013: [rpc] Move tojson.h into blockchain.h: deadalnix.
May 10 2019, 05:13
markblundeberg planned changes to D3012: Backport current GetDifficulty logic (& tests) from Core.
May 10 2019, 05:00
teamcity added a comment to D3012: Backport current GetDifficulty logic (& tests) from Core.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 10 2019, 04:41
teamcity added a comment to D3012: Backport current GetDifficulty logic (& tests) from Core.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 10 2019, 04:28
markblundeberg retitled D3012: Backport current GetDifficulty logic (& tests) from Core from Backport GetDifficulty logic from Core to Backport current GetDifficulty logic from Core.
May 10 2019, 04:27
Herald added a reviewer for D3012: Backport current GetDifficulty logic (& tests) from Core: deadalnix.
May 10 2019, 04:27
teamcity added a comment to D3011: Merge #9833: Trivial: fix comments referencing AppInit2.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 10 2019, 03:28
teamcity added a comment to D3011: Merge #9833: Trivial: fix comments referencing AppInit2.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

May 10 2019, 03:15
Herald added a reviewer for D3011: Merge #9833: Trivial: fix comments referencing AppInit2: deadalnix.
May 10 2019, 03:13
teamcity added a comment to D3010: update release notes.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

May 10 2019, 03:07
markblundeberg added a parent task for T648: Backport PR 12806 qa: Fix function names in feature_blocksdir: T631: Backport PR 15118 "Refactor block file logic".
May 10 2019, 02:57
markblundeberg added a subtask for T631: Backport PR 15118 "Refactor block file logic": T648: Backport PR 12806 qa: Fix function names in feature_blocksdir.
May 10 2019, 02:57