The fact you should ECM to implement this is of little interest as fr as the API is concerned.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
May 14 2019
Clearing my queue, see D3035
I get the warnings, which compiler do you use ?
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
This is actually 1/2 commits, but the second one doesn't seem very applicable because of changes made in the past: https://reviews.bitcoinabc.org/rABC87d967d48f2702d8f7972a1b43ddae0054640836
The warnings core had don't actually occur in our code base because of some other changes made before (we don't need to use the global dustRelayFee). However, renaming the arguments should help to prevent some confusion and will hopefully keep merge conflicts in future backports to a minimum.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Re-added full constructor comment.
May 13 2019
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
rebase ; change casting style per comments
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
rebase
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
In D3013#71477, @schancel wrote:Okay, I see. That's weird -- still not sure *toJSON functions should go there, but okay.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Okay, I see. That's weird -- still not sure *toJSON functions should go there, but okay.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Added {}.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Update help ordering and add missing newline in release notes.
Ah I see the extra clause is the fix you mention.
You were first to submit, you get the priority
Which one should we do? ( D3026 ) 😂
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
In D3013#71320, @schancel wrote:I think more and more stuff should be better organized. Core doesn't seem to care about separating stuff out much.
However, this is just my opinion. It seems Amaury shared it. I hope we don't prevent ourself from making needed organizational changes indefinitely because of backports.
make check has nothing to do in the test plan
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.