The fact you should ECM to implement this is of little interest as fr as the API is concerned.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
May 14 2019
May 14 2019
Fabien requested changes to D3026: Merge #10267: New -includeconf argument for including external configuration files.
Clearing my queue, see D3035
Fabien requested changes to D3014: Merge #10095: refactor: Move GetDifficulty out of `rpc/server.h`.
I get the warnings, which compiler do you use ?
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
This is actually 1/2 commits, but the second one doesn't seem very applicable because of changes made in the past: https://reviews.bitcoinabc.org/rABC87d967d48f2702d8f7972a1b43ddae0054640836
The warnings core had don't actually occur in our code base because of some other changes made before (we don't need to use the global dustRelayFee). However, renaming the arguments should help to prevent some confusion and will hopefully keep merge conflicts in future backports to a minimum.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Herald added a reviewer for D3040: Merge #10431: Prevent shadowing the global dustRelayFee: Restricted Project.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Herald added a reviewer for D3039: Consensus: Minimal way to move dust out of consensus: Restricted Project.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Re-added full constructor comment.
May 13 2019
May 13 2019
Added missing release notes
teamcity added a comment to D3021: Merge #12151: rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
teamcity added a comment to D3014: Merge #10095: refactor: Move GetDifficulty out of `rpc/server.h`.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
teamcity added a comment to D3021: Merge #12151: rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
markblundeberg updated the diff for D3021: Merge #12151: rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON.
rebase ; change casting style per comments
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
teamcity added a comment to D3014: Merge #10095: refactor: Move GetDifficulty out of `rpc/server.h`.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
markblundeberg updated the diff for D3014: Merge #10095: refactor: Move GetDifficulty out of `rpc/server.h`.
rebase
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC4967c68c3891: [rpc] Move tojson.h into blockchain.h (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).
[rpc] Move tojson.h into blockchain.h
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Herald added a reviewer for D3038: Merge #10280: [test] Unit test amount.h/amount.cpp: Restricted Project.
Updated seed list for 0.19.6 release
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
In D3013#71477, @schancel wrote:Okay, I see. That's weird -- still not sure *toJSON functions should go there, but okay.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABCebda0526aed6: update release notes (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).
update release notes
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Okay, I see. That's weird -- still not sure *toJSON functions should go there, but okay.
Nico Guiton <nico@bitframe.org> committed rABC24ad36f71b92: Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead. (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead.
Nico Guiton <nico@bitframe.org> committed rABCef4c9456bbf3: [tests] Remove unused and duplicate imports (authored by practicalswift <practicalswift@users.noreply.github.com>).
[tests] Remove unused and duplicate imports
teamcity added a comment to D2964: Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead..
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
teamcity added a comment to D2964: Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead..
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
nakihito updated the diff for D2964: Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead..
Added {}.
teamcity added a comment to D3035: New -includeconf argument for including external configuration files.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Fabien updated the summary of D3035: New -includeconf argument for including external configuration files.
teamcity added a comment to D3035: New -includeconf argument for including external configuration files.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Fabien updated the diff for D3035: New -includeconf argument for including external configuration files.
Update help ordering and add missing newline in release notes.
Fabien added a parent task for T541: Backport Core PR10267 to support includeconf: T652: Backport PR13126.
May 13 2019, 14:51 · Restricted Project
Fabien added a subtask for T652: Backport PR13126: T541: Backport Core PR10267 to support includeconf.
Fabien removed a subtask for T541: Backport Core PR10267 to support includeconf: T652: Backport PR13126.
May 13 2019, 14:51 · Restricted Project
Fabien removed a parent task for T652: Backport PR13126: T541: Backport Core PR10267 to support includeconf.
Fabien added a subtask for T541: Backport Core PR10267 to support includeconf: T652: Backport PR13126.
May 13 2019, 14:50 · Restricted Project
Fabien added a parent task for T652: Backport PR13126: T541: Backport Core PR10267 to support includeconf.
markblundeberg added a comment to D3035: New -includeconf argument for including external configuration files.
Ah I see the extra clause is the fix you mention.
You were first to submit, you get the priority
markblundeberg added a comment to D3035: New -includeconf argument for including external configuration files.
Which one should we do? ( D3026 ) 😂
teamcity added a comment to D3035: New -includeconf argument for including external configuration files.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
teamcity added a comment to D3035: New -includeconf argument for including external configuration files.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Herald added a reviewer for D3035: New -includeconf argument for including external configuration files: deadalnix.
markblundeberg added inline comments to D2964: Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead..
In D3013#71320, @schancel wrote:I think more and more stuff should be better organized. Core doesn't seem to care about separating stuff out much.
However, this is just my opinion. It seems Amaury shared it. I hope we don't prevent ourself from making needed organizational changes indefinitely because of backports.
Fabien requested changes to D2964: Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead..
make check has nothing to do in the test plan
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.