Page MenuHomePhabricator
Feed All Stories

Tue, May 14

Fabien updated the test plan for D3041: [CMAKE] Allow to use sanitizers with cmake.
Tue, May 14, 14:05
Fabien planned changes to D3041: [CMAKE] Allow to use sanitizers with cmake.
Tue, May 14, 14:03
deadalnix accepted D3034: [CMAKE] Disable OpenGL in Qt static build for OSX.
Tue, May 14, 13:23
deadalnix requested changes to D3041: [CMAKE] Allow to use sanitizers with cmake.

The fact you should ECM to implement this is of little interest as fr as the API is concerned.

Tue, May 14, 13:22
Fabien accepted D3021: Merge #12151: rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON.
Tue, May 14, 12:03
Fabien requested changes to D3026: Merge #10267: New -includeconf argument for including external configuration files.

Clearing my queue, see D3035

Tue, May 14, 11:53
Fabien requested changes to D3014: Merge #10095: refactor: Move GetDifficulty out of `rpc/server.h`.
Tue, May 14, 10:19
Fabien accepted D3040: Merge #10431: Prevent shadowing the global dustRelayFee.

I get the warnings, which compiler do you use ?

Tue, May 14, 09:56
Fabien requested changes to D3039: Consensus: Minimal way to move dust out of consensus.
Tue, May 14, 09:50
teamcity added a comment to D3041: [CMAKE] Allow to use sanitizers with cmake.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Tue, May 14, 08:36
Fabien accepted D3009: Merge #9980: Fix mem access violation merkleblock.
Tue, May 14, 08:35
Fabien accepted D2762: Update disclosure policy standards.
Tue, May 14, 08:28
teamcity added a comment to D3041: [CMAKE] Allow to use sanitizers with cmake.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Tue, May 14, 08:22
Herald added a reviewer for D3041: [CMAKE] Allow to use sanitizers with cmake: deadalnix.
Tue, May 14, 08:21
Fabien accepted D3038: Merge #10280: [test] Unit test amount.h/amount.cpp.
Tue, May 14, 06:10
teamcity added a comment to D3040: Merge #10431: Prevent shadowing the global dustRelayFee.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Tue, May 14, 02:00
nakihito added a comment to D3039: Consensus: Minimal way to move dust out of consensus.

This is actually 1/2 commits, but the second one doesn't seem very applicable because of changes made in the past: https://reviews.bitcoinabc.org/rABC87d967d48f2702d8f7972a1b43ddae0054640836

Tue, May 14, 01:53
nakihito updated the test plan for D3038: Merge #10280: [test] Unit test amount.h/amount.cpp.
Tue, May 14, 01:50
nakihito updated the test plan for D3039: Consensus: Minimal way to move dust out of consensus.
Tue, May 14, 01:49
nakihito added a comment to D3040: Merge #10431: Prevent shadowing the global dustRelayFee.

The issue core had doesn't actually occur in our code base because of some other changes made before, how renaming the arguments should help to prevent confusion and will hopefully keep merge conflicts in future backports to a minimum.

Tue, May 14, 01:49
teamcity added a comment to D3039: Consensus: Minimal way to move dust out of consensus.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Tue, May 14, 01:47
nakihito updated the test plan for D3040: Merge #10431: Prevent shadowing the global dustRelayFee.
Tue, May 14, 01:47
teamcity added a comment to D3040: Merge #10431: Prevent shadowing the global dustRelayFee.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Tue, May 14, 01:46
Herald added a reviewer for D3040: Merge #10431: Prevent shadowing the global dustRelayFee: Restricted Project.
Tue, May 14, 01:46
teamcity added a comment to D3039: Consensus: Minimal way to move dust out of consensus.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Tue, May 14, 01:33
Herald added a reviewer for D3039: Consensus: Minimal way to move dust out of consensus: Restricted Project.
Tue, May 14, 01:32
teamcity added a comment to D3038: Merge #10280: [test] Unit test amount.h/amount.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Tue, May 14, 00:54
nakihito updated the diff for D3038: Merge #10280: [test] Unit test amount.h/amount.cpp.

Re-added full constructor comment.

Tue, May 14, 00:39
nakihito updated the summary of D3038: Merge #10280: [test] Unit test amount.h/amount.cpp.
Tue, May 14, 00:37

Mon, May 13

jasonbcox committed rABC15afe1da08a5: Added missing release notes (authored by jasonbcox).
Added missing release notes
Mon, May 13, 22:35
jasonbcox closed D3037: Added missing release notes.
Mon, May 13, 22:35
Fabien accepted D3037: Added missing release notes.
Mon, May 13, 20:40
teamcity added a comment to D3021: Merge #12151: rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Mon, May 13, 20:14
teamcity added a comment to D3014: Merge #10095: refactor: Move GetDifficulty out of `rpc/server.h`.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Mon, May 13, 20:00
teamcity added a comment to D3021: Merge #12151: rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Mon, May 13, 20:00
markblundeberg updated the diff for D3021: Merge #12151: rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON.

rebase ; change casting style per comments

Mon, May 13, 20:00
teamcity added a comment to D3038: Merge #10280: [test] Unit test amount.h/amount.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Mon, May 13, 19:53
teamcity added a comment to D3037: Added missing release notes.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Mon, May 13, 19:48
teamcity added a comment to D3014: Merge #10095: refactor: Move GetDifficulty out of `rpc/server.h`.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Mon, May 13, 19:47
markblundeberg updated the diff for D3014: Merge #10095: refactor: Move GetDifficulty out of `rpc/server.h`.

rebase

Mon, May 13, 19:46
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC4967c68c3891: [rpc] Move tojson.h into blockchain.h (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).
[rpc] Move tojson.h into blockchain.h
Mon, May 13, 19:41
Diffusion closed D3013: [rpc] Move tojson.h into blockchain.h.
Mon, May 13, 19:41
jasonbcox requested changes to D3021: Merge #12151: rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON.
Mon, May 13, 19:41
markblundeberg accepted D3037: Added missing release notes.
Mon, May 13, 19:40
teamcity added a comment to D3038: Merge #10280: [test] Unit test amount.h/amount.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Mon, May 13, 19:39
Herald added a reviewer for D3038: Merge #10280: [test] Unit test amount.h/amount.cpp: Restricted Project.
Mon, May 13, 19:38
jasonbcox committed rABCd2551147a913: Updated seed list for 0.19.6 release (authored by jasonbcox).
Updated seed list for 0.19.6 release
Mon, May 13, 19:35
jasonbcox closed D3036: Updated seed list for 0.19.6 release.
Mon, May 13, 19:35
teamcity added a comment to D3037: Added missing release notes.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Mon, May 13, 19:35
Herald added a reviewer for D3037: Added missing release notes: Restricted Project.
Mon, May 13, 19:34
markblundeberg added a comment to D3013: [rpc] Move tojson.h into blockchain.h.

Okay, I see. That's weird -- still not sure *toJSON functions should go there, but okay.

Mon, May 13, 19:17
teamcity added a comment to D3036: Updated seed list for 0.19.6 release.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Mon, May 13, 19:16
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABCebda0526aed6: update release notes (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).
update release notes
Mon, May 13, 19:14
Diffusion closed D3010: update release notes.
Mon, May 13, 19:13
jasonbcox accepted D3010: update release notes.
Mon, May 13, 19:09
Fabien accepted D3036: Updated seed list for 0.19.6 release.
Mon, May 13, 19:05
teamcity added a comment to D3036: Updated seed list for 0.19.6 release.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Mon, May 13, 19:02
Herald added a reviewer for D3036: Updated seed list for 0.19.6 release: Restricted Project.
Mon, May 13, 19:01
schancel accepted D3013: [rpc] Move tojson.h into blockchain.h.
Mon, May 13, 18:45
schancel added a comment to D3013: [rpc] Move tojson.h into blockchain.h.

Okay, I see. That's weird -- still not sure *toJSON functions should go there, but okay.

Mon, May 13, 18:45
Nico Guiton <nico@bitframe.org> committed rABC24ad36f71b92: Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead. (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead.
Mon, May 13, 17:50
Diffusion closed D2964: Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead..
Mon, May 13, 17:50
Nico Guiton <nico@bitframe.org> committed rABCef4c9456bbf3: [tests] Remove unused and duplicate imports (authored by practicalswift <practicalswift@users.noreply.github.com>).
[tests] Remove unused and duplicate imports
Mon, May 13, 17:36
Diffusion closed D3023: [tests] Remove unused and duplicate imports.
Mon, May 13, 17:36
teamcity added a comment to D2964: Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Mon, May 13, 17:27
Fabien accepted D3023: [tests] Remove unused and duplicate imports.
Mon, May 13, 17:21
Fabien accepted D2964: Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead..
Mon, May 13, 17:20
nakihito updated the test plan for D3023: [tests] Remove unused and duplicate imports.
Mon, May 13, 17:14
nakihito updated the test plan for D3024: [tests] Remove unused variables.
Mon, May 13, 17:14
teamcity added a comment to D2964: Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Mon, May 13, 17:12
nakihito updated the diff for D2964: Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead..

Added {}.

Mon, May 13, 17:11
nakihito updated the test plan for D3023: [tests] Remove unused and duplicate imports.
Mon, May 13, 17:03
teamcity added a comment to D3035: New -includeconf argument for including external configuration files.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Mon, May 13, 15:09
markblundeberg accepted D3035: New -includeconf argument for including external configuration files.
Mon, May 13, 14:58
Fabien updated the summary of D3035: New -includeconf argument for including external configuration files.
Mon, May 13, 14:55
teamcity added a comment to D3035: New -includeconf argument for including external configuration files.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Mon, May 13, 14:55
Fabien updated the diff for D3035: New -includeconf argument for including external configuration files.

Update help ordering and add missing newline in release notes.

Mon, May 13, 14:54
Fabien reclaimed D3035: New -includeconf argument for including external configuration files.
Mon, May 13, 14:53
Fabien added a parent task for T541: Backport Core PR10267 to support includeconf: T652: Backport PR13126.
Mon, May 13, 14:51 · Restricted Project
Fabien added a subtask for T652: Backport PR13126: T541: Backport Core PR10267 to support includeconf.
Mon, May 13, 14:51
Fabien removed a subtask for T541: Backport Core PR10267 to support includeconf: T652: Backport PR13126.
Mon, May 13, 14:51 · Restricted Project
Fabien removed a parent task for T652: Backport PR13126: T541: Backport Core PR10267 to support includeconf.
Mon, May 13, 14:51
Fabien added a subtask for T541: Backport Core PR10267 to support includeconf: T652: Backport PR13126.
Mon, May 13, 14:50 · Restricted Project
Fabien added a parent task for T652: Backport PR13126: T541: Backport Core PR10267 to support includeconf.
Mon, May 13, 14:50
Fabien created T652: Backport PR13126.
Mon, May 13, 14:50
markblundeberg added a comment to D3035: New -includeconf argument for including external configuration files.

Ah I see the extra clause is the fix you mention.

Mon, May 13, 14:43
Fabien abandoned D3035: New -includeconf argument for including external configuration files.

You were first to submit, you get the priority

Mon, May 13, 14:38
markblundeberg added a comment to D3035: New -includeconf argument for including external configuration files.

Which one should we do? ( D3026 ) 😂

Mon, May 13, 14:34
teamcity added a comment to D3035: New -includeconf argument for including external configuration files.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Mon, May 13, 14:16
teamcity added a comment to D3035: New -includeconf argument for including external configuration files.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Mon, May 13, 14:02
Herald added a reviewer for D3035: New -includeconf argument for including external configuration files: deadalnix.
Mon, May 13, 14:01
markblundeberg added inline comments to D2964: Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead..
Mon, May 13, 13:52
markblundeberg added a comment to D3013: [rpc] Move tojson.h into blockchain.h.

I think more and more stuff should be better organized. Core doesn't seem to care about separating stuff out much.
However, this is just my opinion. It seems Amaury shared it. I hope we don't prevent ourself from making needed organizational changes indefinitely because of backports.

Mon, May 13, 13:48
Fabien requested changes to D2964: Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead..
Mon, May 13, 12:44
Fabien requested changes to D3023: [tests] Remove unused and duplicate imports.

make check has nothing to do in the test plan

Mon, May 13, 11:30
Fabien accepted D3010: update release notes.
Mon, May 13, 11:19
Fabien accepted D3011: Merge #9833: Trivial: fix comments referencing AppInit2.
Mon, May 13, 11:18
teamcity added a comment to D3034: [CMAKE] Disable OpenGL in Qt static build for OSX.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Mon, May 13, 10:38
teamcity added a comment to D3033: [CMAKE] Add missing files to build bitcoin-qt on OSX.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Mon, May 13, 10:35
teamcity added a comment to D3032: [CMAKE] Fix bitcoind cross build for OSX.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Mon, May 13, 10:30