Page MenuHomePhabricator
Feed All Stories

Tue, Jun 11

teamcity added a comment to D3193: Added update-chainparams.py to fetch and replace assume valid block values from a node using HTTP RPC.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Tue, Jun 11, 23:49
deadalnix added inline comments to D3288: [LINTER] Move phpcs ruleset to a test/lint/phpcs directory.
Tue, Jun 11, 23:47
D3287: [LINTER] Fix some PHP linter rules is now accepted and ready to land.
Tue, Jun 11, 23:46
D3288: [LINTER] Move phpcs ruleset to a test/lint/phpcs directory is now accepted and ready to land.
Tue, Jun 11, 23:46
deadalnix added a comment to D3269: move CheckMinimalPush to script.h.

While mildly useful, I don't think we should be making changes like this until backports are up-to-date.

Tue, Jun 11, 23:46
jasonbcox updated the test plan for D3193: Added update-chainparams.py to fetch and replace assume valid block values from a node using HTTP RPC.
Tue, Jun 11, 23:45
D3270: add CScript::IsMinimalPushOnly now requires changes to proceed.

There is already logic to check if a push is minimal or not, duplicating indicate the approach is wrong.

Tue, Jun 11, 23:43
teamcity added a comment to D3193: Added update-chainparams.py to fetch and replace assume valid block values from a node using HTTP RPC.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Tue, Jun 11, 23:43
jasonbcox added a comment to D3193: Added update-chainparams.py to fetch and replace assume valid block values from a node using HTTP RPC.

Fixes according to feedback

Tue, Jun 11, 23:43
jasonbcox added inline comments to D3193: Added update-chainparams.py to fetch and replace assume valid block values from a node using HTTP RPC.
Tue, Jun 11, 23:42
D3283: Merge #10408, #13291, and partial #13163 now requires changes to proceed.
Tue, Jun 11, 23:40
teamcity added a comment to D3296: Don't create change at the dust limit, even if it means paying more than expected.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Tue, Jun 11, 23:31
teamcity added a comment to D3296: Don't create change at the dust limit, even if it means paying more than expected.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Tue, Jun 11, 23:25
deadalnix created D3296: Don't create change at the dust limit, even if it means paying more than expected.
Tue, Jun 11, 23:24
jasonbcox updated the summary of D3295: Added a script to automate collecting and updating seeds.
Tue, Jun 11, 23:08
teamcity added a comment to D3295: Added a script to automate collecting and updating seeds.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Tue, Jun 11, 23:06
jasonbcox added a comment to D3295: Added a script to automate collecting and updating seeds.

Still need to update docs, but looking for a concept ACK before continuing.

Tue, Jun 11, 23:00
teamcity added a comment to D3295: Added a script to automate collecting and updating seeds.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Tue, Jun 11, 23:00
jasonbcox created D3295: Added a script to automate collecting and updating seeds.
Tue, Jun 11, 22:59
teamcity added a comment to D3294: Merge #13291: test: Don't include torcontrol.cpp into the test file.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Tue, Jun 11, 22:49
nakihito updated the summary of D3283: Merge #10408, #13291, and partial #13163.
Tue, Jun 11, 22:44
nakihito updated the summary of D3293: Merge #13163: Make it clear which functions that are intended to be translation unit local.
Tue, Jun 11, 22:42
teamcity added a comment to D3294: Merge #13291: test: Don't include torcontrol.cpp into the test file.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Tue, Jun 11, 22:41
nakihito planned changes to D3294: Merge #13291: test: Don't include torcontrol.cpp into the test file.
Tue, Jun 11, 22:41
nakihito created D3294: Merge #13291: test: Don't include torcontrol.cpp into the test file.
Tue, Jun 11, 22:41
teamcity added a comment to D3293: Merge #13163: Make it clear which functions that are intended to be translation unit local.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Tue, Jun 11, 22:38
teamcity added a comment to D3285: Merge #10587: Net: Fix resource leak in ReadBinaryFile(...).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Tue, Jun 11, 22:35
teamcity added a comment to D3292: Explicitly call out updating makeseeds.py after major releases.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Tue, Jun 11, 22:30
teamcity added a comment to D3293: Merge #13163: Make it clear which functions that are intended to be translation unit local.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Tue, Jun 11, 22:30
nakihito planned changes to D3293: Merge #13163: Make it clear which functions that are intended to be translation unit local.
Tue, Jun 11, 22:30
nakihito created D3293: Merge #13163: Make it clear which functions that are intended to be translation unit local.
Tue, Jun 11, 22:29
teamcity added a comment to D3285: Merge #10587: Net: Fix resource leak in ReadBinaryFile(...).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Tue, Jun 11, 22:27
nakihito added a comment to D3285: Merge #10587: Net: Fix resource leak in ReadBinaryFile(...).

Rebased.

Tue, Jun 11, 22:27
teamcity added a comment to D3292: Explicitly call out updating makeseeds.py after major releases.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Tue, Jun 11, 22:24
jasonbcox created D3292: Explicitly call out updating makeseeds.py after major releases.
Tue, Jun 11, 22:24
teamcity added a comment to D3283: Merge #10408, #13291, and partial #13163.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Tue, Jun 11, 22:21
teamcity added a comment to D3283: Merge #10408, #13291, and partial #13163.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Tue, Jun 11, 22:14
nakihito added a comment to D3283: Merge #10408, #13291, and partial #13163.

Changed to angled brackets in include statements.

Tue, Jun 11, 22:14
nakihito added a comment to D3283: Merge #10408, #13291, and partial #13163.

In the process of working on the mentioned backports.

Tue, Jun 11, 22:08
teamcity added a comment to D3197: Make Teamcity agent setup easier.

Build Bitcoin-ABC / Master / Nightly Builds / Bitcoin-ABC Gitian Diff Testing passed.

Tue, Jun 11, 19:16
teamcity added a comment to D3197: Make Teamcity agent setup easier.

Build Bitcoin-ABC / Master / Nightly Builds / Bitcoin-ABC Gitian Diff Testing started.

Tue, Jun 11, 19:02
teamcity added a comment to D3197: Make Teamcity agent setup easier.

Build Bitcoin-ABC / Master / Nightly Builds / Bitcoin-ABC Gitian Diff Testing failed.

Tue, Jun 11, 19:01
teamcity added a comment to D3197: Make Teamcity agent setup easier.

Build Bitcoin-ABC / Master / Nightly Builds / Bitcoin-ABC Gitian Diff Testing started.

Tue, Jun 11, 19:01
teamcity added a comment to D3291: Fix rounding errors in calculation of minimum change size.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Tue, Jun 11, 18:25
teamcity added a comment to D3291: Fix rounding errors in calculation of minimum change size.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Tue, Jun 11, 18:18
deadalnix created D3291: Fix rounding errors in calculation of minimum change size.
Tue, Jun 11, 18:18
teamcity added a comment to D3197: Make Teamcity agent setup easier.

Build Bitcoin-ABC / Master / Nightly Builds / Bitcoin-ABC Gitian Diff Testing failed.

Tue, Jun 11, 18:15
teamcity added a comment to D3197: Make Teamcity agent setup easier.

Build Bitcoin-ABC / Master / Nightly Builds / Bitcoin-ABC Gitian Diff Testing started.

Tue, Jun 11, 18:14
teamcity added a comment to D3290: Move original knapsack solver tests to coinselector_tests.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Tue, Jun 11, 17:01
teamcity added a comment to D3290: Move original knapsack solver tests to coinselector_tests.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Tue, Jun 11, 16:54
deadalnix created D3290: Move original knapsack solver tests to coinselector_tests.cpp.
Tue, Jun 11, 16:54
teamcity added a comment to D3289: Move current coin selection algorithm to coinselection.{cpp,h}.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Tue, Jun 11, 16:31
teamcity added a comment to D3289: Move current coin selection algorithm to coinselection.{cpp,h}.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Tue, Jun 11, 16:24
deadalnix created D3289: Move current coin selection algorithm to coinselection.{cpp,h}.
Tue, Jun 11, 16:24
jasonbcox committed rABCacb45f2c4e35: Merge #9350: [Trivial] Adding label for amount inside of tx_valid/tx_invalid. (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #9350: [Trivial] Adding label for amount inside of tx_valid/tx_invalid.
Tue, Jun 11, 16:23
jasonbcox closed D3279: Merge #9350: [Trivial] Adding label for amount inside of tx_valid/tx_invalid.json.
Tue, Jun 11, 16:23
jasonbcox committed rABCe137db475ec6: Merge #10090: Update bitcoin.conf with example for pruning (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #10090: Update bitcoin.conf with example for pruning
Tue, Jun 11, 16:22
jasonbcox closed D3281: Merge #10090: Update bitcoin.conf with example for pruning.
Tue, Jun 11, 16:22
jasonbcox committed rABCc17c0116e853: Merge #10177: Changed "Send" button default status from true to false (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #10177: Changed "Send" button default status from true to false
Tue, Jun 11, 16:21
jasonbcox closed D3282: Merge #10177: Changed "Send" button default status from true to false.
Tue, Jun 11, 16:20
jasonbcox committed rABC504322bef4ed: Merge #10404: doc: Add logging to FinalizeNode() (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #10404: doc: Add logging to FinalizeNode()
Tue, Jun 11, 16:19
jasonbcox closed D3284: Merge #10404: doc: Add logging to FinalizeNode().
Tue, Jun 11, 16:19
jasonbcox committed rABCa9d60a397d35: Merge #10460: Broadcast address every day, not 9 hours (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #10460: Broadcast address every day, not 9 hours
Tue, Jun 11, 16:18
jasonbcox closed D3286: Merge #10460: Broadcast address every day, not 9 hours.
Tue, Jun 11, 16:18
jasonbcox accepted D3256: Fix make distcheck.
Tue, Jun 11, 16:08
D3256: Fix make distcheck is now accepted and ready to land.
Tue, Jun 11, 16:07
teamcity added a comment to D3288: [LINTER] Move phpcs ruleset to a test/lint/phpcs directory.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Tue, Jun 11, 14:18
teamcity added a comment to D3288: [LINTER] Move phpcs ruleset to a test/lint/phpcs directory.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Tue, Jun 11, 14:12
Fabien added a comment to D3288: [LINTER] Move phpcs ruleset to a test/lint/phpcs directory.

Add missing .arclint update

Tue, Jun 11, 14:11
teamcity added a comment to D3288: [LINTER] Move phpcs ruleset to a test/lint/phpcs directory.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Tue, Jun 11, 14:09
teamcity added a comment to D3288: [LINTER] Move phpcs ruleset to a test/lint/phpcs directory.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Tue, Jun 11, 14:03
Harbormaster failed remote builds in B6264: Diff 9312 for D3288: [LINTER] Move phpcs ruleset to a test/lint/phpcs directory!
Tue, Jun 11, 14:01
Fabien created D3288: [LINTER] Move phpcs ruleset to a test/lint/phpcs directory.
Tue, Jun 11, 14:01
teamcity added a comment to D3287: [LINTER] Fix some PHP linter rules.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Tue, Jun 11, 13:55
Fabien created D3287: [LINTER] Fix some PHP linter rules.
Tue, Jun 11, 13:54
markblundeberg accepted D3279: Merge #9350: [Trivial] Adding label for amount inside of tx_valid/tx_invalid.json.
Tue, Jun 11, 13:18
Fabien added a comment to D3285: Merge #10587: Net: Fix resource leak in ReadBinaryFile(...).

Needs rebase

Tue, Jun 11, 06:25
D3283: Merge #10408, #13291, and partial #13163 now requires changes to proceed.
Tue, Jun 11, 06:25
D3279: Merge #9350: [Trivial] Adding label for amount inside of tx_valid/tx_invalid.json is now accepted and ready to land.

Agree with @markblundeberg's comment, but can be a follow up.

Tue, Jun 11, 06:03
D3281: Merge #10090: Update bitcoin.conf with example for pruning is now accepted and ready to land.
Tue, Jun 11, 05:59
D3282: Merge #10177: Changed "Send" button default status from true to false is now accepted and ready to land.
Tue, Jun 11, 05:56
D3284: Merge #10404: doc: Add logging to FinalizeNode() is now accepted and ready to land.
Tue, Jun 11, 05:52
D3286: Merge #10460: Broadcast address every day, not 9 hours is now accepted and ready to land.
Tue, Jun 11, 05:51
Nico Guiton <nico@bitframe.org> committed rABCdfc1e4deffce: Merge #10536: Remove unreachable or otherwise redundant code (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Merge #10536: Remove unreachable or otherwise redundant code
Tue, Jun 11, 01:19
Nico Guiton <nico@bitframe.org> closed D3278: Merge #10536: Remove unreachable or otherwise redundant code.
Tue, Jun 11, 01:19
Harbormaster failed remote builds in B6262: Diff 9309 for D3076: Merge #14409: utils and libraries: Make 'blocksdir' always net specific!
Tue, Jun 11, 00:33
teamcity added a comment to D3076: Merge #14409: utils and libraries: Make 'blocksdir' always net specific.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Tue, Jun 11, 00:33
teamcity added a comment to D3283: Merge #10408, #13291, and partial #13163.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Tue, Jun 11, 00:27
markblundeberg planned changes to D3076: Merge #14409: utils and libraries: Make 'blocksdir' always net specific.
Tue, Jun 11, 00:25
teamcity added a comment to D3076: Merge #14409: utils and libraries: Make 'blocksdir' always net specific.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Tue, Jun 11, 00:25
markblundeberg added a comment to D3076: Merge #14409: utils and libraries: Make 'blocksdir' always net specific.

still awful

Tue, Jun 11, 00:25
teamcity added a comment to D3283: Merge #10408, #13291, and partial #13163.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Tue, Jun 11, 00:21
nakihito added a comment to D3283: Merge #10408, #13291, and partial #13163.

Added CMake change and fixed nits.

Tue, Jun 11, 00:21

Mon, Jun 10

teamcity added a comment to D3286: Merge #10460: Broadcast address every day, not 9 hours.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Mon, Jun 10, 23:26
jasonbcox requested review of D3286: Merge #10460: Broadcast address every day, not 9 hours.
Mon, Jun 10, 23:23
teamcity added a comment to D3286: Merge #10460: Broadcast address every day, not 9 hours.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Mon, Jun 10, 23:19
jasonbcox planned changes to D3286: Merge #10460: Broadcast address every day, not 9 hours.
Mon, Jun 10, 23:18
jasonbcox created D3286: Merge #10460: Broadcast address every day, not 9 hours.
Mon, Jun 10, 23:18
D3285: Merge #10587: Net: Fix resource leak in ReadBinaryFile(...) is now accepted and ready to land.
Mon, Jun 10, 23:03
D3283: Merge #10408, #13291, and partial #13163 now requires changes to proceed.
Mon, Jun 10, 23:03