Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Jul 10 2019
Jul 10 2019
teamcity added a comment to D3638: Merge #12988: Hold cs_main while calling UpdatedBlockTip() signal.
deadalnix committed rABC7efaaeb4c10c: Rename wallet database classes (authored by Russell Yanofsky <russ@yanofsky.org>).
Rename wallet database classes
deadalnix committed rABC94d4e0a15975: wallet: Initialize m_last_block_processed to nullptr. Initialize fields where… (authored by practicalswift <practicalswift@users.noreply.github.com>).
wallet: Initialize m_last_block_processed to nullptr. Initialize fields where…
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
jasonbcox updated the diff for D3502: Added a script to generate chainparams constants header files.
Overhaul of the script based on feedback:
teamcity added a comment to D3634: wallet: Initialize m_last_block_processed to nullptr. Initialize fields where defined..
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
deadalnix updated the diff for D3634: wallet: Initialize m_last_block_processed to nullptr. Initialize fields where defined..
Remove mapRequestCount
deadalnix added inline comments to D3634: wallet: Initialize m_last_block_processed to nullptr. Initialize fields where defined..
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Nico Guiton <nico@bitframe.org> committed rABC2e27620de1be: Merge #10728: fix typo in help text for removeprunedfunds (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
Merge #10728: fix typo in help text for removeprunedfunds
Did a few test runs setting up new VMs and got a passing build with the gitian build on this diff.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Fabien committed rABC251f06465cfa: wallet: Make vpwallets usage thread safe (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
wallet: Make vpwallets usage thread safe
Regenerate timing.json
This code must remain "obviously correct" as much as possible. Systematically doing bound check before accessing an element is absolutely part of that process.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC192db747864c: Merge #14985: test: Remove thread_local from test_bitcoin (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14985: test: Remove thread_local from test_bitcoin
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
iRebase on top of D3618 and fix comments.
teamcity added a comment to D3634: wallet: Initialize m_last_block_processed to nullptr. Initialize fields where defined..
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Harbormaster failed remote builds in B6798: Diff 10195 for D3635: [wallet] Pass error message back from CWallet::Verify()!
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
teamcity added a comment to D3634: wallet: Initialize m_last_block_processed to nullptr. Initialize fields where defined..
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
@deadalnix I've thought over more and I'm not convinced at all about converting to size_t. We can continue to debate but the longer this goes on, the more chance it means that dependent diffs will be delayed, resulting in Schnorr multisig being postponed until May or a later upgrade. That's fine, there's no rush to get these things done, but it seems unfortunate that feature work would be blocked on a nit like this.
deadalnix committed rABC6509f482538a: Rename wallet_accounts.py test (authored by Russell Yanofsky <russ@yanofsky.org>).
Rename wallet_accounts.py test
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
teamcity triaged T672: Build Bitcoin-ABC / Master / Gitian Builds / Nightly - OSX is broken. as Unbreak Now! priority.
teamcity added a comment to D3630: [wallet] setup wallet background flushing in WalletInit directly.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
teamcity added a comment to D3630: [wallet] setup wallet background flushing in WalletInit directly.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Fabien committed rABC6b01c42a8504: [qt] Add support to search the address book (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
[qt] Add support to search the address book
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Don't fail on host key verification when ssh'ing the first time.
Print help before warning for sshpass.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
markblundeberg updated the diff for D3581: Merge #10657: Utils: Improvements to ECDSA key-handling code.
include comment (except part about hashtype byte) into sigencoding.cpp
markblundeberg added a comment to D3581: Merge #10657: Utils: Improvements to ECDSA key-handling code.
In D3581#85393, @teamcity wrote:
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
reupload for unrelated test failure
In D3627#85518, @deadalnix wrote:This makes me a bit worried, to be honest. Isn't it possible to move the nulldummy check near the bound check? This will avoid the spooky action at a distance effect (which is probably why this redundant check survived here in the first place).
This makes me a bit worried, to be honest. Isn't it possible to move the nulldummy check near the bound check? This will avoid the spooky action at a distance effect (which is probably why this redundant check survived here in the first place).
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.
Harbormaster failed remote builds in B6787: Diff 10182 for D3627: [refactor multisig] remove redundant stack check!
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
@deadalnix I'm trying to find style guides and many like this say that we ought to avoid using unsigned types in this kind of situation, for example: https://google.github.io/styleguide/cppguide.html#Integer_Types
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
introduce idxKeyCount and restore redundant stack size check