Page MenuHomePhabricator
Feed All Stories

Jul 16 2019

jasonbcox accepted D3684: Merge #11626: rpc: Make `logging` RPC public.
Jul 16 2019, 23:00
teamcity added a comment to D3684: Merge #11626: rpc: Make `logging` RPC public.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 16 2019, 22:57
teamcity added a comment to D3684: Merge #11626: rpc: Make `logging` RPC public.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 16 2019, 22:51
nakihito created D3684: Merge #11626: rpc: Make `logging` RPC public.
Jul 16 2019, 22:51
teamcity added a comment to D3464: [rpc] Add logging RPC.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 16 2019, 22:44
nakihito updated the summary of D3464: [rpc] Add logging RPC.
Jul 16 2019, 22:35
teamcity added a comment to D3464: [rpc] Add logging RPC.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 16 2019, 22:35
nakihito updated the diff for D3464: [rpc] Add logging RPC.

Removed PR11626. It will be made into its own diff.

Jul 16 2019, 22:35
Nico Guiton <nico@bitframe.org> committed rABCd6b70b4f1583: Merge #10845: Remove unreachable code (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #10845: Remove unreachable code
Jul 16 2019, 22:20
Nico Guiton <nico@bitframe.org> closed D3658: Merge #10845: Remove unreachable code.
Jul 16 2019, 22:20
nakihito planned changes to D3464: [rpc] Add logging RPC.
Jul 16 2019, 22:18
jasonbcox accepted D3350: [script_tests] improve test coverage of minimal push rules.
Jul 16 2019, 22:06
jasonbcox accepted D3636: [wallet] [rpc] Add loadwallet RPC.
Jul 16 2019, 21:55
Nico Guiton <nico@bitframe.org> committed rABCd1cf65ab2e0d: Merge #10793: Changing &var[0] to var.data() (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #10793: Changing &var[0] to var.data()
Jul 16 2019, 21:51
Nico Guiton <nico@bitframe.org> closed D3656: Merge #10793: Changing &var[0] to var.data().
Jul 16 2019, 21:51
jasonbcox accepted D3670: [tests] [qt] Add tests for address book manipulation via EditAddressDialog.
Jul 16 2019, 21:50
jasonbcox accepted D3658: Merge #10845: Remove unreachable code.
Jul 16 2019, 21:49
jasonbcox requested changes to D3589: [5 of 5] Style cleanup..

system.h/cpp needs to be backported first

Jul 16 2019, 21:45
jasonbcox requested changes to D3588: [4 of 5] scripted-diff: Rename CBlockDiskPos to FlatFilePos..

This is clearly missing at least one (if not more) backports. See ReadRawBlockFromDisk in the original PR.

Jul 16 2019, 21:43
jasonbcox accepted D3587: [3 of 5] Move CDiskBlockPos from chain to flatfile..
Jul 16 2019, 21:32
jasonbcox added a comment to D3587: [3 of 5] Move CDiskBlockPos from chain to flatfile..

Note: alternatively we could keep the split and rename diskblockpos.h to flatfilepos.h and put the ToString() implementation in a .cpp file also, or ...?

I'm not totally sure if it's worth splitting up the two, the main thing seems to have been getting it out of chain.h.

For now I'm in favor of merging the two since it would make backports easier. After we've caught up, then it may be worthwhile to reconsider.

Jul 16 2019, 21:28
teamcity added a comment to D3471: Merge #9868: Abstract out the command line options for block assembly.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 16 2019, 21:18
jasonbcox updated the summary of D3471: Merge #9868: Abstract out the command line options for block assembly.
Jul 16 2019, 21:12
teamcity added a comment to D3471: Merge #9868: Abstract out the command line options for block assembly.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 16 2019, 21:12
jasonbcox updated the diff for D3471: Merge #9868: Abstract out the command line options for block assembly.

Rebase on D3683

Jul 16 2019, 21:12
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC149cb12f78f9: [script_tests] improve coverage of minimal number encoding (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).
[script_tests] improve coverage of minimal number encoding
Jul 16 2019, 20:37
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> closed D3347: [script_tests] improve coverage of minimal number encoding.
Jul 16 2019, 20:36
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC30ae54784116: add SCRIPT_ENABLE_SCHNORR_MULTISIG flag for new multisig mode (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).
add SCRIPT_ENABLE_SCHNORR_MULTISIG flag for new multisig mode
Jul 16 2019, 20:32
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> closed D3472: add SCRIPT_ENABLE_SCHNORR_MULTISIG flag for new multisig mode.
Jul 16 2019, 20:32
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC637c25c0bc00: [refactor multisig] remove redundant counters (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).
[refactor multisig] remove redundant counters
Jul 16 2019, 20:22
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> closed D3675: [refactor multisig] remove redundant counters.
Jul 16 2019, 20:22
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC47756d0eea51: [2 of 5] validation: Extract basic block file logic into FlatFileSeq class. (authored by jimpo).
[2 of 5] validation: Extract basic block file logic into FlatFileSeq class.
Jul 16 2019, 20:13
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> closed D3586: [2 of 5] validation: Extract basic block file logic into FlatFileSeq class..
Jul 16 2019, 20:13
teamcity added a comment to D3683: Remove config as a class member of BlockAssembler.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 16 2019, 18:28
teamcity added a comment to D3682: Refactor TestForBlock() to take config as a parameter.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 16 2019, 18:25
teamcity added a comment to D3683: Remove config as a class member of BlockAssembler.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 16 2019, 18:22
jasonbcox created D3683: Remove config as a class member of BlockAssembler.
Jul 16 2019, 18:22
Nico Guiton <nico@bitframe.org> committed rABC876f6f46c534: Error messages in LoadBlockIndexGuts() use __func__ instead of hardcoding… (authored by Nico Guiton <nico@bitframe.org>).
Error messages in LoadBlockIndexGuts() use __func__ instead of hardcoding…
Jul 16 2019, 18:20
Nico Guiton <nico@bitframe.org> closed D3677: Error messages in LoadBlockIndexGuts() use __func__ instead of hardcoding function name..
Jul 16 2019, 18:20
teamcity added a comment to D3681: Refactor addPriorityTxs to take config as a parameter.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 16 2019, 18:17
teamcity added a comment to D3682: Refactor TestForBlock() to take config as a parameter.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 16 2019, 18:16
jasonbcox created D3682: Refactor TestForBlock() to take config as a parameter.
Jul 16 2019, 18:16
teamcity added a comment to D3681: Refactor addPriorityTxs to take config as a parameter.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 16 2019, 18:11
jasonbcox created D3681: Refactor addPriorityTxs to take config as a parameter.
Jul 16 2019, 18:11
teamcity added a comment to D3679: Remove config as a class member of BlockAssembler.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 16 2019, 17:44
teamcity added a comment to D3680: Refactor adding package txs to use config as a parameter.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 16 2019, 17:41
teamcity added a comment to D3679: Remove config as a class member of BlockAssembler.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 16 2019, 17:35
teamcity added a comment to D3680: Refactor adding package txs to use config as a parameter.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 16 2019, 17:35
jasonbcox created D3680: Refactor adding package txs to use config as a parameter.
Jul 16 2019, 17:34
Harbormaster failed remote builds in B6867: Diff 10316 for D3679: Remove config as a class member of BlockAssembler!
Jul 16 2019, 16:45
teamcity added a comment to D3679: Remove config as a class member of BlockAssembler.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Jul 16 2019, 16:44
teamcity added a comment to D3679: Remove config as a class member of BlockAssembler.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 16 2019, 16:38
jasonbcox created D3679: Remove config as a class member of BlockAssembler.
Jul 16 2019, 16:38
jasonbcox requested changes to D3678: Nits in Qt test.
Jul 16 2019, 14:50
jasonbcox accepted D3586: [2 of 5] validation: Extract basic block file logic into FlatFileSeq class..
Jul 16 2019, 14:50
teamcity added a comment to D3678: Nits in Qt test.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 16 2019, 13:28
teamcity added a comment to D3678: Nits in Qt test.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 16 2019, 13:21
deadalnix created D3678: Nits in Qt test.
Jul 16 2019, 13:21
deadalnix requested review of D3670: [tests] [qt] Add tests for address book manipulation via EditAddressDialog.
Jul 16 2019, 13:13
deadalnix committed rABC20dfcce78ef2: [qt] Display more helpful message when adding a send address has failed (authored by James O'Beirne <james.obeirne@gmail.com>).
[qt] Display more helpful message when adding a send address has failed
Jul 16 2019, 13:09
deadalnix closed D3669: [qt] Display more helpful message when adding a send address has failed.
Jul 16 2019, 13:08
deadalnix committed rABCf06e9f7b610b: Add purpose arg to Wallet::getAddress (authored by James O'Beirne <james.obeirne@gmail.com>).
Add purpose arg to Wallet::getAddress
Jul 16 2019, 13:05
deadalnix closed D3668: Add purpose arg to Wallet::getAddress.
Jul 16 2019, 13:05
deadalnix committed rABCaf857482f5aa: [tests] [qt] Introduce qt/test/util with a generalized ConfirmMessage (authored by James O'Beirne <james.obeirne@gmail.com>).
[tests] [qt] Introduce qt/test/util with a generalized ConfirmMessage
Jul 16 2019, 13:01
deadalnix closed D3666: [tests] [qt] Introduce qt/test/util with a generalized ConfirmMessage.
Jul 16 2019, 13:01
deadalnix committed rABCd09a95d5f43d: Merge #9544: [trivial] Add end of namespace comments. Improve consistency. (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #9544: [trivial] Add end of namespace comments. Improve consistency.
Jul 16 2019, 12:59
deadalnix closed D3619: Merge #9544: [trivial] Add end of namespace comments. Improve consistency..
Jul 16 2019, 12:59
teamcity added a comment to D3653: Update chainparams.

Build Bitcoin-ABC / Master / Gitian Builds / Bitcoin-ABC IBD Diff Testing (w/o checkpoints) passed.

Jul 16 2019, 09:06
teamcity added a comment to D3670: [tests] [qt] Add tests for address book manipulation via EditAddressDialog.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 16 2019, 03:20
jasonbcox requested changes to D3670: [tests] [qt] Add tests for address book manipulation via EditAddressDialog.
Jul 16 2019, 03:20
teamcity added a comment to D3670: [tests] [qt] Add tests for address book manipulation via EditAddressDialog.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 16 2019, 03:13
jasonbcox accepted D3669: [qt] Display more helpful message when adding a send address has failed.
Jul 16 2019, 03:13
teamcity added a comment to D3669: [qt] Display more helpful message when adding a send address has failed.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 16 2019, 03:12
jasonbcox accepted D3666: [tests] [qt] Introduce qt/test/util with a generalized ConfirmMessage.
Jul 16 2019, 03:08
jasonbcox accepted D3668: Add purpose arg to Wallet::getAddress.
Jul 16 2019, 03:06
teamcity added a comment to D1972: [Part 5 of 5] Add a CChainState class to clarify internal interfaces.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 16 2019, 03:06
teamcity added a comment to D3669: [qt] Display more helpful message when adding a send address has failed.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 16 2019, 03:04
jasonbcox accepted D3619: Merge #9544: [trivial] Add end of namespace comments. Improve consistency..
Jul 16 2019, 03:01
jasonbcox updated the test plan for D1972: [Part 5 of 5] Add a CChainState class to clarify internal interfaces.
Jul 16 2019, 02:59
teamcity added a comment to D1972: [Part 5 of 5] Add a CChainState class to clarify internal interfaces.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 16 2019, 02:59
jasonbcox updated the diff for D1972: [Part 5 of 5] Add a CChainState class to clarify internal interfaces.
  • Rebase
  • Fix missing portions of the backport
Jul 16 2019, 02:59
jasonbcox commandeered D1972: [Part 5 of 5] Add a CChainState class to clarify internal interfaces.
Jul 16 2019, 02:14
jasonbcox accepted D3677: Error messages in LoadBlockIndexGuts() use __func__ instead of hardcoding function name..
Jul 16 2019, 02:12
jasonbcox committed rABC4e467915935e: Merge #12298: Refactor HaveKeys to early return on false result (authored by jasonbcox).
Merge #12298: Refactor HaveKeys to early return on false result
Jul 16 2019, 02:11
jasonbcox closed D3657: Merge #12298: Refactor HaveKeys to early return on false result.
Jul 16 2019, 02:11
teamcity added a comment to D3653: Update chainparams.

Build Bitcoin-ABC / Master / Gitian Builds / Bitcoin-ABC IBD Diff Testing (w/o checkpoints) started.

Jul 16 2019, 00:06

Jul 15 2019

teamcity added a comment to D3677: Error messages in LoadBlockIndexGuts() use __func__ instead of hardcoding function name..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 15 2019, 23:16
teamcity added a comment to D3677: Error messages in LoadBlockIndexGuts() use __func__ instead of hardcoding function name..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 15 2019, 23:09
nakihito created D3677: Error messages in LoadBlockIndexGuts() use __func__ instead of hardcoding function name..
Jul 15 2019, 23:09
nakihito added inline comments to D3656: Merge #10793: Changing &var[0] to var.data().
Jul 15 2019, 22:58
deadalnix accepted D3656: Merge #10793: Changing &var[0] to var.data().
Jul 15 2019, 22:54
deadalnix committed rABC9a3a34b08c19: Add virtual transaction size to the transaction description in Qt (authored by deadalnix).
Add virtual transaction size to the transaction description in Qt
Jul 15 2019, 22:48
deadalnix closed D3655: Add virtual transaction size to the transaction description in Qt.
Jul 15 2019, 22:48
deadalnix committed rABC4ee17c4e7bd9: wallet: Change output type globals to members (authored by MarcoFalke <falke.marco@gmail.com>).
wallet: Change output type globals to members
Jul 15 2019, 22:41
deadalnix closed D3665: wallet: Change output type globals to members.
Jul 15 2019, 22:41
nakihito accepted D3619: Merge #9544: [trivial] Add end of namespace comments. Improve consistency..
Jul 15 2019, 22:39
nakihito accepted D3655: Add virtual transaction size to the transaction description in Qt.
Jul 15 2019, 22:33
nakihito added a comment to D3671: Merge #10777: [tests] Avoid redundant assignments. Remove unused variables.

What's up with sighash_tests.cpp?

Jul 15 2019, 22:29
teamcity added a comment to D3586: [2 of 5] validation: Extract basic block file logic into FlatFileSeq class..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 15 2019, 22:23
jasonbcox requested changes to D3671: Merge #10777: [tests] Avoid redundant assignments. Remove unused variables.

What's up with sighash_tests.cpp?

Jul 15 2019, 22:18