Feed All Stories

All Stories
Use Results
Edit Query
Hide Query

Sep 9 2019

teamcity added a comment to D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 9 2019, 17:44

teamcity added a comment to D3914: Merge #12853: qa: Match full plain text by default.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 9 2019, 17:39

jasonbcox updated the diff for D3914: Merge #12853: qa: Match full plain text by default.

Fixed import order

Sep 9 2019, 17:39

teamcity added a comment to D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 9 2019, 17:37

jasonbcox updated the diff for D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.

Fixes according to feedback.

Sep 9 2019, 17:36

teamcity added a comment to D3809: Added a script to test seeds.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 9 2019, 17:35

nakihito updated the test plan for D3937: Merge #12928: qt: Initialize non-static class members that were previously neither initialized where defined nor in constructor.

Sep 9 2019, 17:28

teamcity added a comment to D3809: Added a script to test seeds.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 9 2019, 17:28

jasonbcox updated the diff for D3809: Added a script to test seeds.

Fixed braces everywhere.
Rebased
Also fixed up the bash location and added copyright.
Fixed some lint errors.

Sep 9 2019, 17:28

nakihito requested review of D4021: Merge #13149: Handle unsuccessful fseek(...):s.

Sep 9 2019, 17:06

nakihito updated the summary of D4021: Merge #13149: Handle unsuccessful fseek(...):s.

Sep 9 2019, 17:06

teamcity added a comment to D4014: [CI] Make IBD a standard build configuration.

Build Bitcoin-ABC / Resource Intensive Builds / Resource Intensive Diff Testing started.

Sep 9 2019, 17:02

jasonbcox accepted D3992: [CI] Improve error catching and build log verbosity.

Sep 9 2019, 17:01

jasonbcox accepted D3994: [CI] Workaround ubsan failure in functional tests.

Sep 9 2019, 16:35

jasonbcox closed T677: Backport Core PR 13747 as Resolved.

Sep 9 2019, 16:33

jasonbcox committed rABCcb319c1dcdf4: Merge #13747: tests: Skip P2PConnection's is_closing() check when not available (authored by MarcoFalke <falke.marco@gmail.com>).

Merge #13747: tests: Skip P2PConnection's is_closing() check when not available

Sep 9 2019, 16:32

jasonbcox closed D4019: Merge #13747: tests: Skip P2PConnection's is_closing() check when not available.

Sep 9 2019, 16:32

teamcity added a comment to D4019: Merge #13747: tests: Skip P2PConnection's is_closing() check when not available.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 9 2019, 16:30

teamcity added a comment to D4019: Merge #13747: tests: Skip P2PConnection's is_closing() check when not available.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 9 2019, 16:23

jasonbcox updated the diff for D4019: Merge #13747: tests: Skip P2PConnection's is_closing() check when not available.

Rebase + nit

Sep 9 2019, 16:22

jasonbcox closed T684: Backport Core PR13916 as Resolved.

Sep 9 2019, 16:21

jasonbcox closed T684: Backport Core PR13916, a subtask of T685: Backport Core PR13399, as Resolved.

Sep 9 2019, 16:21

jasonbcox committed rABCbb86d8de9a17: Merge #13916: qa: wait_for_verack by default (authored by MarcoFalke <falke.marco@gmail.com>).

Merge #13916: qa: wait_for_verack by default

Sep 9 2019, 16:20

jasonbcox closed D4023: Merge #13916: qa: wait_for_verack by default.

Sep 9 2019, 16:20

jasonbcox added a comment to D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.

What is the use case apart from the IBD script ?

Sep 9 2019, 15:58

teamcity added a comment to D3871: [CMAKE] Add support to build secp256k1 JNI binding and tests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 9 2019, 15:19

Fabien added inline comments to D3871: [CMAKE] Add support to build secp256k1 JNI binding and tests.

Sep 9 2019, 15:16

teamcity added a comment to D3871: [CMAKE] Add support to build secp256k1 JNI binding and tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 9 2019, 15:12

Fabien updated the diff for D3871: [CMAKE] Add support to build secp256k1 JNI binding and tests.

Always build the shared library when JNI is enabled.
This allows for using the CMake built-in BUILD_SHARED_LIBS switch.
No longer depends on D3870 as a consequence.

Sep 9 2019, 15:12

Fabien committed rABCa6371c4a479b: [SECP256K1] JNI tests : remove dependency to obsolete DatatypeConverter (authored by Fabien).

[SECP256K1] JNI tests : remove dependency to obsolete DatatypeConverter

Sep 9 2019, 12:33

Fabien closed D3835: [SECP256K1] JNI tests : remove dependency to obsolete DatatypeConverter.

Sep 9 2019, 12:33

Fabien committed rABC0cc9cba736ea: [TRIVIAL] Cleanup the JNI test file (authored by Fabien).

[TRIVIAL] Cleanup the JNI test file

Sep 9 2019, 12:32

Fabien closed D3834: [TRIVIAL] Cleanup the JNI test file.

Sep 9 2019, 12:32

Fabien accepted D3937: Merge #12928: qt: Initialize non-static class members that were previously neither initialized where defined nor in constructor.

Sep 9 2019, 09:24

Fabien accepted D4023: Merge #13916: qa: wait_for_verack by default.

Sep 9 2019, 09:19

Fabien accepted D3542: Merge #10537: Few Minor per-utxo assert-semantics re-adds and tweak.

Sep 9 2019, 09:16

Fabien committed rABC4da35605e55a: [Linter] Check the log prints are terminated with a newline (authored by Fabien).

[Linter] Check the log prints are terminated with a newline

Sep 9 2019, 09:03

Fabien closed D4001: [Linter] Check the log prints are terminated with a newline.

Sep 9 2019, 09:03

Fabien accepted D4019: Merge #13747: tests: Skip P2PConnection's is_closing() check when not available.

We should migrate to support python >= 3.5 soon, but OK.

Sep 9 2019, 06:46

Fabien requested changes to D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.

Please add braces around the variables everywhere.
What is the use case apart from the IBD script ?

Sep 9 2019, 06:43

Fabien accepted D3694: Update the github issue template to include disclosure policy.

@jasonbcox I updated the summary accordingly.

Sep 9 2019, 06:33

Fabien updated the summary of D3694: Update the github issue template to include disclosure policy.

Sep 9 2019, 06:32

Fabien retitled D3694: Update the github issue template to include disclosure policy from Update the github issue template with more relavant links to Update the github issue template with more relevant links.

Sep 9 2019, 06:32

Fabien requested changes to D3914: Merge #12853: qa: Match full plain text by default.

Sep 9 2019, 06:27

teamcity added a comment to D4001: [Linter] Check the log prints are terminated with a newline.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 9 2019, 06:27

Fabien requested changes to D3809: Added a script to test seeds.

A single nit repeated all over the script.
Otherwise it looks good to me, it proved itself useful at release time to determine from which source to gather the seeds.

Sep 9 2019, 06:26

teamcity added a comment to D4001: [Linter] Check the log prints are terminated with a newline.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 9 2019, 06:16

Fabien updated the diff for D4001: [Linter] Check the log prints are terminated with a newline.

Rebase.

Sep 9 2019, 06:16

Fabien updated the summary of D4001: [Linter] Check the log prints are terminated with a newline.

Sep 9 2019, 06:10

Sep 8 2019

deadalnix accepted D4001: [Linter] Check the log prints are terminated with a newline.

Sep 8 2019, 14:03

deadalnix requested changes to D4021: Merge #13149: Handle unsuccessful fseek(...):s.

Mention PR13149

Sep 8 2019, 12:10

Fabien committed rABC8eb343852006: [LINTER] Enforce using C++ style for void parameters (authored by Fabien).

[LINTER] Enforce using C++ style for void parameters

Sep 8 2019, 10:00

Fabien closed D3984: [LINTER] Enforce using C++ style for void parameters.

Sep 8 2019, 09:59

Fabien committed rABCa62f4554ef1b: Bugfix: NSIS: Exclude Makefile* from docs (authored by Luke Dashjr <luke-jr+git@utopios.org>).

Bugfix: NSIS: Exclude Makefile* from docs

Sep 8 2019, 09:35

Fabien closed D4015: Bugfix: NSIS: Exclude Makefile* from docs.

Sep 8 2019, 09:35

Fabien added a comment to D3994: [CI] Workaround ubsan failure in functional tests.

I'd rather fix it, but so far I failed to do so.
This is most likely not an undefined behavior, because ubsan doesn't catch anything, I rather suspect some kind of timing issue exhibited by running ubsan.

Sep 8 2019, 09:27

deadalnix added a comment to D3994: [CI] Workaround ubsan failure in functional tests.

It would probably be more useful to fix the undefined behavior.

Sep 8 2019, 08:39

Sep 7 2019

teamcity added a comment to D3992: [CI] Improve error catching and build log verbosity.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 7 2019, 06:11

teamcity added a comment to D3992: [CI] Improve error catching and build log verbosity.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 7 2019, 06:04

Fabien updated the diff for D3992: [CI] Improve error catching and build log verbosity.

Disbable the prints during the IBD loop.

Sep 7 2019, 06:04

teamcity added a comment to D3994: [CI] Workaround ubsan failure in functional tests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 7 2019, 06:02

Fabien added a comment to D4014: [CI] Make IBD a standard build configuration.

2 remarks:

The IBD failed due to timeout after 1h, which I think is a good value for all the other tests but not for IBD
The set -x should be removed during the loop, otherwise it prints a sleep every 100ms. I will update D3992.

Sep 7 2019, 05:58

teamcity added a comment to D3994: [CI] Workaround ubsan failure in functional tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 7 2019, 05:54

Fabien updated the diff for D3994: [CI] Workaround ubsan failure in functional tests.

Rebase, improve summary and add a comment asking for removal in the future.

Sep 7 2019, 05:54

Fabien updated the summary of D3994: [CI] Workaround ubsan failure in functional tests.

Sep 7 2019, 05:51

Sep 6 2019

teamcity added a comment to D4014: [CI] Make IBD a standard build configuration.

Build Bitcoin-ABC / Resource Intensive Builds / Resource Intensive Diff Testing failed.

Sep 6 2019, 23:06

Nico Guiton <nico@bitframe.org> committed rABCd0c43baa4437: Merge #12503: [RPC] createmultisig no longer takes addresses (authored by MarcoFalke <falke.marco@gmail.com>).

Merge #12503: [RPC] createmultisig no longer takes addresses

Sep 6 2019, 23:06

Nico Guiton <nico@bitframe.org> closed D4022: Merge #12503: [RPC] createmultisig no longer takes addresses.

Sep 6 2019, 23:06

Nico Guiton <nico@bitframe.org> committed rABCbe3bf6094d7c: Merge #13658: [moveonly] Extract RescanWallet to handle a simple rescan (authored by Wladimir J. van der Laan <laanwj@gmail.com>).

Merge #13658: [moveonly] Extract RescanWallet to handle a simple rescan

Sep 6 2019, 22:58

Nico Guiton <nico@bitframe.org> closed D4020: Merge #13658: [moveonly] Extract RescanWallet to handle a simple rescan.

Sep 6 2019, 22:58

teamcity added a comment to D4023: Merge #13916: qa: wait_for_verack by default.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 6 2019, 22:54

teamcity added a comment to D4023: Merge #13916: qa: wait_for_verack by default.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 6 2019, 22:46

jasonbcox created D4023: Merge #13916: qa: wait_for_verack by default.

Sep 6 2019, 22:46

jasonbcox added a comment to D4014: [CI] Make IBD a standard build configuration.

I created a new configuration for calling resource intensive configs via build-configurations. Running build-ibd-no-assumevalid-checkpoint now for sanity.

Sep 6 2019, 22:07

teamcity added a comment to D4014: [CI] Make IBD a standard build configuration.

Build Bitcoin-ABC / Resource Intensive Builds / Resource Intensive Diff Testing started.

Sep 6 2019, 22:06

teamcity added a comment to D4014: [CI] Make IBD a standard build configuration.

Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC IBD Diff Testing (w/o checkpoints) started.

Sep 6 2019, 22:00

Nico Guiton <nico@bitframe.org> committed rABCcbabd40c5b8f: Merge #11338: qt: Backup former GUI settings on `-resetguisettings` (authored by Wladimir J. van der Laan <laanwj@gmail.com>).

Merge #11338: qt: Backup former GUI settings on `-resetguisettings`

Sep 6 2019, 21:51

Nico Guiton <nico@bitframe.org> closed D3934: Merge #11338: qt: Backup former GUI settings on `-resetguisettings`.

Sep 6 2019, 21:51

jasonbcox accepted D4020: Merge #13658: [moveonly] Extract RescanWallet to handle a simple rescan.

Sep 6 2019, 21:42

jasonbcox accepted D4016: Pull leveldb subtree.

Sep 6 2019, 21:38

jasonbcox requested changes to D3994: [CI] Workaround ubsan failure in functional tests.

A better description/rationale as we discussed earlier.

Sep 6 2019, 21:26

jasonbcox added a comment to D3856: Merge #13439: rpc: Avoid "duplicate" return value for invalid submitblock.

Tracking PR13983 in T686

Sep 6 2019, 21:22

jasonbcox added a parent task for T685: Backport Core PR13399: T686: Backport Core PR13983.

Sep 6 2019, 21:20

jasonbcox added a subtask for T686: Backport Core PR13983: T685: Backport Core PR13399.

Sep 6 2019, 21:20

jasonbcox triaged T686: Backport Core PR13983 as High priority.

Sep 6 2019, 21:20

jasonbcox triaged T685: Backport Core PR13399 as High priority.

Sep 6 2019, 21:19

jasonbcox added a parent task for T684: Backport Core PR13916: T685: Backport Core PR13399.

Sep 6 2019, 21:18

jasonbcox added a subtask for T685: Backport Core PR13399: T684: Backport Core PR13916.

Sep 6 2019, 21:18

jasonbcox created T685: Backport Core PR13399.

Sep 6 2019, 21:18

jasonbcox triaged T684: Backport Core PR13916 as High priority.

Sep 6 2019, 21:17

jasonbcox accepted D3992: [CI] Improve error catching and build log verbosity.

Sep 6 2019, 20:51

jasonbcox accepted D4022: Merge #12503: [RPC] createmultisig no longer takes addresses.

Sep 6 2019, 20:50

jasonbcox accepted D3934: Merge #11338: qt: Backup former GUI settings on `-resetguisettings`.

Sep 6 2019, 20:49

jasonbcox accepted D4014: [CI] Make IBD a standard build configuration.

Sep 6 2019, 20:48

teamcity added a comment to D4022: Merge #12503: [RPC] createmultisig no longer takes addresses.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 6 2019, 18:40

nakihito added a comment to D4022: Merge #12503: [RPC] createmultisig no longer takes addresses.

using addresses in createmultisig was deprecated in D2002 and the deprecated code was removed in D3978.

Sep 6 2019, 18:35

teamcity added a comment to D4022: Merge #12503: [RPC] createmultisig no longer takes addresses.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 6 2019, 18:33

nakihito created D4022: Merge #12503: [RPC] createmultisig no longer takes addresses.

Sep 6 2019, 18:33

teamcity added a comment to D4021: Merge #13149: Handle unsuccessful fseek(...):s.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 6 2019, 18:33

teamcity added a comment to D4021: Merge #13149: Handle unsuccessful fseek(...):s.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 6 2019, 18:26