Page MenuHomePhabricator
Feed All Stories

Mon, Sep 16

Fabien accepted D4088: Move InactivityCheck logic to private method..
Mon, Sep 16, 08:04
deadalnix committed rABCfe55cba91008: Move NotifyNumConnectionsChanged logic to private method. (authored by Patrick Strateman <patrick.strateman@gmail.com>).
Move NotifyNumConnectionsChanged logic to private method.
Mon, Sep 16, 08:03
deadalnix closed D4086: Move NotifyNumConnectionsChanged logic to private method..
Mon, Sep 16, 08:03
Fabien accepted D4087: Move DisconnectNodes logic to private method..
Mon, Sep 16, 07:59
Fabien accepted D4086: Move NotifyNumConnectionsChanged logic to private method..
Mon, Sep 16, 07:54

Sun, Sep 15

teamcity added a comment to D4089: Move SocketHandler logic to private method..

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sun, Sep 15, 19:24
teamcity added a comment to D4088: Move InactivityCheck logic to private method..

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sun, Sep 15, 19:17
teamcity added a comment to D4089: Move SocketHandler logic to private method..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sun, Sep 15, 19:13
deadalnix created D4089: Move SocketHandler logic to private method..
Sun, Sep 15, 19:12
teamcity added a comment to D4088: Move InactivityCheck logic to private method..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sun, Sep 15, 19:07
deadalnix created D4088: Move InactivityCheck logic to private method..
Sun, Sep 15, 19:07
teamcity added a comment to D4087: Move DisconnectNodes logic to private method..

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sun, Sep 15, 18:53
teamcity added a comment to D4087: Move DisconnectNodes logic to private method..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sun, Sep 15, 18:45
teamcity added a comment to D4087: Move DisconnectNodes logic to private method..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sun, Sep 15, 18:45
deadalnix created D4087: Move DisconnectNodes logic to private method..
Sun, Sep 15, 18:45
teamcity added a comment to D4086: Move NotifyNumConnectionsChanged logic to private method..

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sun, Sep 15, 08:33
teamcity added a comment to D4086: Move NotifyNumConnectionsChanged logic to private method..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sun, Sep 15, 08:23
deadalnix created D4086: Move NotifyNumConnectionsChanged logic to private method..
Sun, Sep 15, 08:22

Sep 14 2019

teamcity added a comment to D3871: [CMAKE] Add support to build secp256k1 JNI binding and tests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 14 2019, 19:26
deadalnix accepted D3871: [CMAKE] Add support to build secp256k1 JNI binding and tests.
Sep 14 2019, 19:21
teamcity added a comment to D3871: [CMAKE] Add support to build secp256k1 JNI binding and tests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 14 2019, 19:21
teamcity added a comment to D3871: [CMAKE] Add support to build secp256k1 JNI binding and tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 14 2019, 19:19
Fabien updated the diff for D3871: [CMAKE] Add support to build secp256k1 JNI binding and tests.

Rename the target to be consistent with other tests.

Sep 14 2019, 19:18
teamcity added a comment to D3871: [CMAKE] Add support to build secp256k1 JNI binding and tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 14 2019, 19:11
teamcity added a comment to D3871: [CMAKE] Add support to build secp256k1 JNI binding and tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 14 2019, 19:10
Fabien updated the diff for D3871: [CMAKE] Add support to build secp256k1 JNI binding and tests.

Don't have a test being a duplicate of a target.

Sep 14 2019, 19:10
teamcity added a comment to D3871: [CMAKE] Add support to build secp256k1 JNI binding and tests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 14 2019, 17:44
teamcity added a comment to D3871: [CMAKE] Add support to build secp256k1 JNI binding and tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 14 2019, 17:30
deadalnix committed rABC70b9a1207e4e: tests: remove member connman/peerLogic in TestingSetup (authored by Cory Fields <cory-nospam-@coryfields.com>).
tests: remove member connman/peerLogic in TestingSetup
Sep 14 2019, 17:25
deadalnix closed D4070: tests: remove member connman/peerLogic in TestingSetup.
Sep 14 2019, 17:25
deadalnix requested changes to D3871: [CMAKE] Add support to build secp256k1 JNI binding and tests.
Sep 14 2019, 17:23
Fabien added inline comments to D3871: [CMAKE] Add support to build secp256k1 JNI binding and tests.
Sep 14 2019, 17:20
Fabien updated the diff for D3871: [CMAKE] Add support to build secp256k1 JNI binding and tests.

Add a comment regarding the POSITION_INDEPENDENT_CODE property.

Sep 14 2019, 17:19
Fabien committed rABC9ff97e0fd3fc: [SECP256K1] Create a different library when building with JNI (authored by Fabien).
[SECP256K1] Create a different library when building with JNI
Sep 14 2019, 17:14
Fabien closed D4058: [SECP256K1] Create a different library when building with JNI.
Sep 14 2019, 17:13
deadalnix accepted D4058: [SECP256K1] Create a different library when building with JNI.
Sep 14 2019, 17:07
Fabien accepted D4070: tests: remove member connman/peerLogic in TestingSetup.
Sep 14 2019, 17:07
deadalnix committed rABCb1ac99112da7: Convert comments to thread safety annotations (authored by MarcoFalke <falke.marco@gmail.com>).
Convert comments to thread safety annotations
Sep 14 2019, 17:01
deadalnix closed D4085: Convert comments to thread safety annotations.
Sep 14 2019, 17:01
teamcity added a comment to D4085: Convert comments to thread safety annotations.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 14 2019, 16:59
deadalnix committed rABC487210686b0a: net: Add Clang thread safety annotations for guarded variables in the… (authored by practicalswift <practicalswift@users.noreply.github.com>).
net: Add Clang thread safety annotations for guarded variables in the…
Sep 14 2019, 16:57
deadalnix closed D4084: net: Add Clang thread safety annotations for guarded variables in the networking code.
Sep 14 2019, 16:57
Fabien accepted D4081: Run miner_tests with fixed options.
Sep 14 2019, 16:50
teamcity added a comment to D4085: Convert comments to thread safety annotations.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 14 2019, 16:50
teamcity added a comment to D4085: Convert comments to thread safety annotations.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 14 2019, 16:48
teamcity added a comment to D4085: Convert comments to thread safety annotations.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 14 2019, 16:46
Fabien accepted D4085: Convert comments to thread safety annotations.
Sep 14 2019, 16:45
deadalnix updated the diff for D4085: Convert comments to thread safety annotations.

Remove outdated comment

Sep 14 2019, 16:43
deadalnix committed rABC57c2fde3f33f: Report minfeefilter value in getpeerinfo rpc (authored by Anthony Towns <aj@erisian.com.au>).
Report minfeefilter value in getpeerinfo rpc
Sep 14 2019, 16:38
deadalnix closed D4083: Report minfeefilter value in getpeerinfo rpc.
Sep 14 2019, 16:38
Fabien accepted D4084: net: Add Clang thread safety annotations for guarded variables in the networking code.
Sep 14 2019, 16:37
Fabien requested changes to D4085: Convert comments to thread safety annotations.
Sep 14 2019, 16:36
deadalnix committed rABC16854d62f596: Prefer wait_until over polling with time.sleep (authored by Ben Woosley <ben.woosley@gmail.com>).
Prefer wait_until over polling with time.sleep
Sep 14 2019, 16:35
deadalnix closed D4082: Prefer wait_until over polling with time.sleep.
Sep 14 2019, 16:35
Fabien accepted D4082: Prefer wait_until over polling with time.sleep.
Sep 14 2019, 16:33
teamcity added a comment to D4082: Prefer wait_until over polling with time.sleep.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 14 2019, 16:30
deadalnix accepted D4076: Merge #15239: scripts and tools: Move non-linux build source tarballs to "bitcoin-binaries/version" directory.
Sep 14 2019, 16:28
teamcity added a comment to D4082: Prefer wait_until over polling with time.sleep.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 14 2019, 16:23
deadalnix updated the diff for D4082: Prefer wait_until over polling with time.sleep.

spaces around plus

Sep 14 2019, 16:23
deadalnix retitled D4082: Prefer wait_until over polling with time.sleep from test: Use wait_until in tests where time was used for polling to Prefer wait_until over polling with time.sleep.
Sep 14 2019, 16:22
Fabien accepted D4083: Report minfeefilter value in getpeerinfo rpc.
Sep 14 2019, 16:17
Fabien requested changes to D4082: Prefer wait_until over polling with time.sleep.

You can improve the summary to make it understandable why it doesn't match the title.
Also make check is of no help here.

Sep 14 2019, 16:13
teamcity added a comment to D4058: [SECP256K1] Create a different library when building with JNI.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 14 2019, 16:08
teamcity added a comment to D4058: [SECP256K1] Create a different library when building with JNI.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 14 2019, 16:00
Fabien updated the diff for D4058: [SECP256K1] Create a different library when building with JNI.

Cleanup the obsolete variable.

Sep 14 2019, 16:00
Fabien committed rABCa3cf7aae0c75: [SECP256K1] Build java class files out of tree (authored by Fabien).
[SECP256K1] Build java class files out of tree
Sep 14 2019, 15:55
Fabien closed D4053: [SECP256K1] Build java class files out of tree.
Sep 14 2019, 15:55
teamcity added a comment to D4085: Convert comments to thread safety annotations.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 14 2019, 15:12
teamcity added a comment to D4085: Convert comments to thread safety annotations.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 14 2019, 15:04
deadalnix created D4085: Convert comments to thread safety annotations.
Sep 14 2019, 15:04
teamcity added a comment to D4084: net: Add Clang thread safety annotations for guarded variables in the networking code.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 14 2019, 15:02
teamcity added a comment to D4084: net: Add Clang thread safety annotations for guarded variables in the networking code.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 14 2019, 14:53
deadalnix created D4084: net: Add Clang thread safety annotations for guarded variables in the networking code.
Sep 14 2019, 14:53
teamcity added a comment to D4083: Report minfeefilter value in getpeerinfo rpc.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 14 2019, 14:36
teamcity added a comment to D4083: Report minfeefilter value in getpeerinfo rpc.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 14 2019, 14:28
deadalnix created D4083: Report minfeefilter value in getpeerinfo rpc.
Sep 14 2019, 14:28
teamcity added a comment to D4082: Prefer wait_until over polling with time.sleep.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 14 2019, 14:04
teamcity added a comment to D4082: Prefer wait_until over polling with time.sleep.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 14 2019, 13:57
deadalnix created D4082: Prefer wait_until over polling with time.sleep.
Sep 14 2019, 13:56
teamcity added a comment to D4081: Run miner_tests with fixed options.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 14 2019, 11:19
deadalnix updated the summary of D4081: Run miner_tests with fixed options.
Sep 14 2019, 11:13
teamcity added a comment to D4081: Run miner_tests with fixed options.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 14 2019, 11:12
deadalnix created D4081: Run miner_tests with fixed options.
Sep 14 2019, 11:12
teamcity added a comment to D4072: Abstract out BlockAssembler options.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 14 2019, 09:24
teamcity added a comment to D4072: Abstract out BlockAssembler options.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 14 2019, 09:16
deadalnix updated the diff for D4072: Abstract out BlockAssembler options.

nExcesiveBlockSize -> nExcessiveBlockSize

Sep 14 2019, 09:16
deadalnix accepted D4021: Merge #13149: Handle unsuccessful fseek(...):s.
Sep 14 2019, 08:32
deadalnix requested changes to D4079: debug log number of unknown wallet records on load.

While the code looks correct, it doesn't seems that there is a test case for this behavior, and therefore the test plan don't test for anything useful.

Sep 14 2019, 07:56
deadalnix requested changes to D4077: [qt] Replaces numbered place marker %2 with %1..

Test plan

Sep 14 2019, 07:55
deadalnix requested changes to D4078: [qt] send: Clear All also resets coin control options.

The test plan is not appropriate.

Sep 14 2019, 07:53
deadalnix accepted D4079: debug log number of unknown wallet records on load.
Sep 14 2019, 07:52
deadalnix requested changes to D4075: Integration of property based testing into Bitcoin Core.

The test plan is not appropriate.

Sep 14 2019, 07:51
deadalnix accepted D4080: bench: Use non-throwing ParseDouble(...) instead of throwing boost::lexical_cast<double>(...).
Sep 14 2019, 07:49
Mengerian committed rABC978fae27bb14: Add seed.bchd.cash to seeder lists (authored by Mengerian).
Add seed.bchd.cash to seeder lists
Sep 14 2019, 01:52
Mengerian closed D4073: Add seed.bchd.cash to seeder lists.
Sep 14 2019, 01:52

Sep 13 2019

jasonbcox accepted D4073: Add seed.bchd.cash to seeder lists.
Sep 13 2019, 23:33
teamcity added a comment to D4079: debug log number of unknown wallet records on load.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 13 2019, 22:44
teamcity added a comment to D4080: bench: Use non-throwing ParseDouble(...) instead of throwing boost::lexical_cast<double>(...).

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 13 2019, 22:42
teamcity added a comment to D4078: [qt] send: Clear All also resets coin control options.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 13 2019, 22:38
teamcity added a comment to D4077: [qt] Replaces numbered place marker %2 with %1..

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 13 2019, 22:36