Page MenuHomePhabricator
Feed All Stories

Oct 6 2019

teamcity added a comment to D4206: Allow -upgradewallet to upgradewallets to HD and use a keypool of presplit keys after upgrading to hd chain split.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 6 2019, 19:21
nakihito updated the diff for D4206: Allow -upgradewallet to upgradewallets to HD and use a keypool of presplit keys after upgrading to hd chain split.

Rebased.

Oct 6 2019, 19:21
Nico Guiton <nico@bitframe.org> committed rABC79e9333ccee7: Add 'sethdseed' RPC to initialize or replace HD seed and test (authored by Andrew Chow <achow101-github@achow101.com>).
Add 'sethdseed' RPC to initialize or replace HD seed and test
Oct 6 2019, 18:44
Nico Guiton <nico@bitframe.org> closed D4202: Add 'sethdseed' RPC to initialize or replace HD seed and test.
Oct 6 2019, 18:44
nakihito updated the summary of D4190: Rename master key to seed.
Oct 6 2019, 18:30
deadalnix requested changes to D4195: Added a land bot script.
Oct 6 2019, 18:15
deadalnix added inline comments to D4175: Merge #12924: Fix hdmaster-key / seed-key confusion.
Oct 6 2019, 18:06
deadalnix requested changes to D4190: Rename master key to seed.
Oct 6 2019, 18:05
deadalnix added a comment to D4154: Merge #13158: [Qt]: Improve sendcoinsdialog readability.

The test plan once again doesn't provide anything to check. Ok the window was open, then what? What did change/didn't change? Is that expected?

Oct 6 2019, 18:00
deadalnix accepted D4154: Merge #13158: [Qt]: Improve sendcoinsdialog readability.
Oct 6 2019, 17:58
deadalnix accepted D4189: Remove redundant assignments (dead stores).
Oct 6 2019, 17:56
deadalnix requested changes to D4214: [build-configurations] Resurface the more informative error message when ABC_BUILD_NAME is not set.

This whole approach do not seem to make a lot of sense. The build build_names are not composable in any way, and as it is mandatory, it seems like it should be a parameters rather than an environment variable.

Oct 6 2019, 17:54
deadalnix accepted D4213: [build-configurations] Make BUILD_DIR configurable.
Oct 6 2019, 17:42
deadalnix accepted D4202: Add 'sethdseed' RPC to initialize or replace HD seed and test.
Oct 6 2019, 16:24

Oct 5 2019

teamcity added a comment to D4217: Fix up Seeder file header guards.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 5 2019, 22:41
teamcity added a comment to D4217: Fix up Seeder file header guards.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 5 2019, 22:32
teamcity added a comment to D4216: Update Seeder to use fsbridge::fopen() instead of fopen().

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 5 2019, 22:31
teamcity added a comment to D4217: Fix up Seeder file header guards.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 5 2019, 22:31
nakihito planned changes to D4217: Fix up Seeder file header guards.
Oct 5 2019, 22:30
nakihito created D4217: Fix up Seeder file header guards.
Oct 5 2019, 22:30
nakihito updated the test plan for D4216: Update Seeder to use fsbridge::fopen() instead of fopen().
Oct 5 2019, 22:23
teamcity added a comment to D4216: Update Seeder to use fsbridge::fopen() instead of fopen().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 5 2019, 22:21
nakihito planned changes to D4216: Update Seeder to use fsbridge::fopen() instead of fopen().
Oct 5 2019, 22:21
nakihito created D4216: Update Seeder to use fsbridge::fopen() instead of fopen().
Oct 5 2019, 22:20
teamcity added a comment to D4215: Drop ParseHashUV in favor of calling ParseHashStr.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 5 2019, 19:25
teamcity added a comment to D4215: Drop ParseHashUV in favor of calling ParseHashStr.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 5 2019, 19:09
deadalnix created D4215: Drop ParseHashUV in favor of calling ParseHashStr.
Oct 5 2019, 19:09

Oct 4 2019

nakihito added a comment to D4207: Bump wallet version for pre split keypool.

Considering the error message, I would prefer that this is merged with D4206. Landing immediately after is acceptable as long as the diffs don't cross release boundaries, but why risk it in the first place?

Oct 4 2019, 22:22
deadalnix committed rABC89cf7cfe2363: Remove CombineSignatures and replace tests (authored by Andrew Chow <achow101-github@achow101.com>).
Remove CombineSignatures and replace tests
Oct 4 2019, 21:57
jasonbcox accepted D4207: Bump wallet version for pre split keypool.

Considering the error message, I would prefer that this is merged with D4206. Landing immediately after is acceptable as long as the diffs don't cross release boundaries, but why risk it in the first place?

Oct 4 2019, 21:57
deadalnix closed D4212: Remove CombineSignatures and replace tests.
Oct 4 2019, 21:57
deadalnix committed rABCa7883c3b07ba: Replace CombineSignatures with ProduceSignature (authored by Andrew Chow <achow101-github@achow101.com>).
Replace CombineSignatures with ProduceSignature
Oct 4 2019, 21:54
deadalnix closed D4211: Replace CombineSignatures with ProduceSignature.
Oct 4 2019, 21:54
deadalnix committed rABCae1211c395eb: Make SignatureData able to store signatures and scripts (authored by Andrew Chow <achow101-github@achow101.com>).
Make SignatureData able to store signatures and scripts
Oct 4 2019, 21:51
deadalnix closed D4210: Make SignatureData able to store signatures and scripts.
Oct 4 2019, 21:51
jasonbcox accepted D4206: Allow -upgradewallet to upgradewallets to HD and use a keypool of presplit keys after upgrading to hd chain split.
Oct 4 2019, 21:45
deadalnix committed rABCcc48812a9aa4: Drop UpdateTransaction in favor of UpdateInput (authored by Ben Woosley <ben.woosley@gmail.com>).
Drop UpdateTransaction in favor of UpdateInput
Oct 4 2019, 21:38
deadalnix closed D4203: Drop UpdateTransaction in favor of UpdateInput.
Oct 4 2019, 21:38
jasonbcox added inline comments to D4206: Allow -upgradewallet to upgradewallets to HD and use a keypool of presplit keys after upgrading to hd chain split.
Oct 4 2019, 21:35
deadalnix committed rABC8f425f2d3013: Generic TransactionSignatureCreator works with both CTransaction and… (authored by Martin Ankerl <martin.ankerl@gmail.com>).
Generic TransactionSignatureCreator works with both CTransaction and…
Oct 4 2019, 21:34
deadalnix closed D4200: Generic TransactionSignatureCreator works with both CTransaction and CMutableTransaction.
Oct 4 2019, 21:34
nakihito updated the summary of D4206: Allow -upgradewallet to upgradewallets to HD and use a keypool of presplit keys after upgrading to hd chain split.
Oct 4 2019, 21:30
teamcity added a comment to D4213: [build-configurations] Make BUILD_DIR configurable.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Oct 4 2019, 21:26
Harbormaster failed remote builds in B7693: Diff 13358 for D4213: [build-configurations] Make BUILD_DIR configurable!
Oct 4 2019, 21:26
Harbormaster failed remote builds in B7694: Diff 13359 for D4213: [build-configurations] Make BUILD_DIR configurable!
Oct 4 2019, 21:22
teamcity added a comment to D4213: [build-configurations] Make BUILD_DIR configurable.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Oct 4 2019, 21:22
teamcity added a comment to D4213: [build-configurations] Make BUILD_DIR configurable.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 4 2019, 21:12
jasonbcox updated the diff for D4213: [build-configurations] Make BUILD_DIR configurable.

Simplify build dir creation

Oct 4 2019, 21:12
teamcity added a comment to D4214: [build-configurations] Resurface the more informative error message when ABC_BUILD_NAME is not set.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 4 2019, 21:11
jasonbcox updated the test plan for D4213: [build-configurations] Make BUILD_DIR configurable.
Oct 4 2019, 21:10
teamcity added a comment to D4213: [build-configurations] Make BUILD_DIR configurable.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 4 2019, 21:10
jasonbcox updated the diff for D4213: [build-configurations] Make BUILD_DIR configurable.

Fixed a bug where non-existant build dir would fail

Oct 4 2019, 21:09
teamcity added a comment to D4195: Added a land bot script.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Oct 4 2019, 21:05
Harbormaster failed remote builds in B7692: Diff 13357 for D4195: Added a land bot script!
Oct 4 2019, 21:05
jasonbcox updated the summary of D4195: Added a land bot script.
Oct 4 2019, 21:04
teamcity added a comment to D4195: Added a land bot script.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 4 2019, 21:04
jasonbcox updated the diff for D4195: Added a land bot script.
  • Rebase on D4213 and take advantage of it to make this script more robust.
  • Cleanup the repo state, especially in the case of failures.
Oct 4 2019, 21:04
teamcity added a comment to D4214: [build-configurations] Resurface the more informative error message when ABC_BUILD_NAME is not set.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 4 2019, 21:01
jasonbcox created D4214: [build-configurations] Resurface the more informative error message when ABC_BUILD_NAME is not set.
Oct 4 2019, 21:01
Harbormaster failed remote builds in B7690: Diff 13355 for D4213: [build-configurations] Make BUILD_DIR configurable!
Oct 4 2019, 20:54
teamcity added a comment to D4213: [build-configurations] Make BUILD_DIR configurable.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Oct 4 2019, 20:54
teamcity added a comment to D4213: [build-configurations] Make BUILD_DIR configurable.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 4 2019, 20:53
jasonbcox created D4213: [build-configurations] Make BUILD_DIR configurable.
Oct 4 2019, 20:53
teamcity added a comment to D4189: Remove redundant assignments (dead stores).

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 4 2019, 20:39
fpelliccioni added a comment to D4191: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..

Part of the PR are missing.

It is a partial application of the PR, I forgot to clarify it, sorry. (summary edited).
I didn't apply the rule for built-in types, because it makes no sense:
for (int x : seq)
is preferred over
for (int const& x : seq).
Have I missed anything else?

for (const int x : seq) is even better. There are still some missing, for instance in qt/bitcoingui.cpp .

Oct 4 2019, 20:27
teamcity added a comment to D4189: Remove redundant assignments (dead stores).

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 4 2019, 20:24
fpelliccioni updated the diff for D4189: Remove redundant assignments (dead stores).

test plan fixed.

Oct 4 2019, 20:23
fpelliccioni updated the test plan for D4189: Remove redundant assignments (dead stores).
Oct 4 2019, 20:23
fpelliccioni updated the test plan for D4189: Remove redundant assignments (dead stores).
Oct 4 2019, 20:22
fpelliccioni added a comment to D4189: Remove redundant assignments (dead stores).

The test plan doesn't run.

The test plan is meant to describe the step you took to ensure that this patch is good. Clearly, the step described do not match what you have done, as they simply do not work.

Oct 4 2019, 20:22
jasonbcox added a comment to D4200: Generic TransactionSignatureCreator works with both CTransaction and CMutableTransaction.
  1. Reduced code ownership.
  2. Reduced cognitive load on merge conflicts.
Oct 4 2019, 16:40
jasonbcox accepted D4200: Generic TransactionSignatureCreator works with both CTransaction and CMutableTransaction.
Oct 4 2019, 16:21
Fabien accepted D4200: Generic TransactionSignatureCreator works with both CTransaction and CMutableTransaction.
Oct 4 2019, 15:47
deadalnix added inline comments to D4200: Generic TransactionSignatureCreator works with both CTransaction and CMutableTransaction.
Oct 4 2019, 12:26
deadalnix committed rABC53a7c7e4eef4: Introduce Span type and use it instead of FLATDATA (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Introduce Span type and use it instead of FLATDATA
Oct 4 2019, 12:21
deadalnix closed D4199: Introduce Span type and use it instead of FLATDATA.
Oct 4 2019, 12:21
deadalnix committed rABC314fae5f080b: [cmake] Create a lib specifically for script related components (authored by deadalnix).
[cmake] Create a lib specifically for script related components
Oct 4 2019, 12:13
deadalnix closed D4205: [cmake] Create a lib specifically for script related components.
Oct 4 2019, 12:13
deadalnix committed rABC96d036525db2: Inline Sign1 and SignN (authored by Andrew Chow <achow101-github@achow101.com>).
Inline Sign1 and SignN
Oct 4 2019, 12:06
deadalnix closed D4209: Inline Sign1 and SignN.
Oct 4 2019, 12:06
Fabien accepted D4212: Remove CombineSignatures and replace tests.
Oct 4 2019, 09:22
Fabien accepted D4211: Replace CombineSignatures with ProduceSignature.
Oct 4 2019, 09:11
Fabien accepted D4210: Make SignatureData able to store signatures and scripts.
Oct 4 2019, 08:59
Fabien accepted D4205: [cmake] Create a lib specifically for script related components.
Oct 4 2019, 08:30
Fabien accepted D4209: Inline Sign1 and SignN.
Oct 4 2019, 08:28
Fabien accepted D4199: Introduce Span type and use it instead of FLATDATA.
Oct 4 2019, 06:35
teamcity added a comment to D4211: Replace CombineSignatures with ProduceSignature.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 4 2019, 01:20
teamcity added a comment to D4212: Remove CombineSignatures and replace tests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 4 2019, 01:20
teamcity added a comment to D4212: Remove CombineSignatures and replace tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 4 2019, 01:08
deadalnix created D4212: Remove CombineSignatures and replace tests.
Oct 4 2019, 01:08
teamcity added a comment to D4211: Replace CombineSignatures with ProduceSignature.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 4 2019, 01:04
deadalnix created D4211: Replace CombineSignatures with ProduceSignature.
Oct 4 2019, 01:03
teamcity added a comment to D4210: Make SignatureData able to store signatures and scripts.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 4 2019, 00:57
teamcity added a comment to D4210: Make SignatureData able to store signatures and scripts.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 4 2019, 00:42
deadalnix created D4210: Make SignatureData able to store signatures and scripts.
Oct 4 2019, 00:42

Oct 3 2019

jasonbcox added inline comments to D4200: Generic TransactionSignatureCreator works with both CTransaction and CMutableTransaction.
Oct 3 2019, 23:28
jasonbcox triaged T689: Backport of Core PR13131 as Low priority.
Oct 3 2019, 23:22 · Restricted Project
jasonbcox triaged T688: Backport Core PR13235 as High priority.
Oct 3 2019, 23:15 · Restricted Project
teamcity added a comment to D4209: Inline Sign1 and SignN.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 3 2019, 23:08
teamcity added a comment to D4209: Inline Sign1 and SignN.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 3 2019, 22:52